[INFO] cloning repository https://github.com/Wizdave97/my-redis-client [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Wizdave97/my-redis-client" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWizdave97%2Fmy-redis-client", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWizdave97%2Fmy-redis-client'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6192526147eff265b948c9a34ed47d0f55d11b16 [INFO] checking Wizdave97/my-redis-client against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWizdave97%2Fmy-redis-client" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Wizdave97/my-redis-client [INFO] finished tweaking git repo https://github.com/Wizdave97/my-redis-client [INFO] tweaked toml for git repo https://github.com/Wizdave97/my-redis-client written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Wizdave97/my-redis-client on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Wizdave97/my-redis-client already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] b3a62f20bce1f1eb1a900fca47b87437a4cccad457923c54de6c10c5b5ab8dd9 [INFO] running `Command { std: "docker" "start" "b3a62f20bce1f1eb1a900fca47b87437a4cccad457923c54de6c10c5b5ab8dd9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b3a62f20bce1f1eb1a900fca47b87437a4cccad457923c54de6c10c5b5ab8dd9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "b3a62f20bce1f1eb1a900fca47b87437a4cccad457923c54de6c10c5b5ab8dd9" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b3a62f20bce1f1eb1a900fca47b87437a4cccad457923c54de6c10c5b5ab8dd9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "b3a62f20bce1f1eb1a900fca47b87437a4cccad457923c54de6c10c5b5ab8dd9" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.70 [INFO] [stderr] Compiling libc v0.2.93 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking pin-project-lite v0.2.6 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking regex-syntax v0.6.23 [INFO] [stderr] Checking tracing-core v0.1.17 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking lock_api v0.4.3 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling tokio v1.5.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking futures-core v0.3.14 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking sharded-slab v0.1.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking mio v0.7.11 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking dashmap v4.0.2 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking atoi v0.3.3 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking regex v1.4.6 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking tracing-serde v0.1.2 [INFO] [stderr] Compiling tracing-attributes v0.1.15 [INFO] [stderr] Compiling tokio-macros v1.1.0 [INFO] [stderr] Compiling pin-project-internal v1.0.7 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Compiling async-stream-impl v0.3.1 [INFO] [stderr] Checking async-stream v0.3.1 [INFO] [stderr] Checking tracing v0.1.25 [INFO] [stderr] Checking tracing-subscriber v0.2.17 [INFO] [stderr] Checking pin-project v1.0.7 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking tokio-stream v0.1.5 [INFO] [stderr] Checking mini-redis v0.4.0 [INFO] [stderr] Checking my-redis v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/client.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 43 | let (tx, mut rx) = sync::oneshot::channel(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/client.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 52 | let (tx, mut rx) = sync::oneshot::channel(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/client.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 43 | let (tx, mut rx) = sync::oneshot::channel(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/client.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 52 | let (tx, mut rx) = sync::oneshot::channel(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bin/client.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | resp.send(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _unused = ...` to ignore the resulting value without dropping it immediately [INFO] [stdout] | [INFO] [stdout] 31 | let _unused = resp.send(res); [INFO] [stdout] | +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bin/client.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 36 | resp.send(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _unused = ...` to ignore the resulting value without dropping it immediately [INFO] [stdout] | [INFO] [stdout] 36 | let _unused = resp.send(res); [INFO] [stdout] | +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bin/client.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | tx1.send(Command::Get{key: "hello", resp: tx}).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _unused = ...` to ignore the resulting value without dropping it immediately [INFO] [stdout] | [INFO] [stdout] 44 | let _unused = tx1.send(Command::Get{key: "hello", resp: tx}).await; [INFO] [stdout] | +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bin/client.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | tx2.send(Command::Set{key: "foo", value: "bar".to_string(), resp: tx}).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _unused = ...` to ignore the resulting value without dropping it immediately [INFO] [stdout] | [INFO] [stdout] 53 | let _unused = tx2.send(Command::Set{key: "foo", value: "bar".to_string(), resp: tx}).await; [INFO] [stdout] | +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bin/client.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | resp.send(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _unused = ...` to ignore the resulting value without dropping it immediately [INFO] [stdout] | [INFO] [stdout] 31 | let _unused = resp.send(res); [INFO] [stdout] | +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bin/client.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 36 | resp.send(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _unused = ...` to ignore the resulting value without dropping it immediately [INFO] [stdout] | [INFO] [stdout] 36 | let _unused = resp.send(res); [INFO] [stdout] | +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bin/client.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | tx1.send(Command::Get{key: "hello", resp: tx}).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _unused = ...` to ignore the resulting value without dropping it immediately [INFO] [stdout] | [INFO] [stdout] 44 | let _unused = tx1.send(Command::Get{key: "hello", resp: tx}).await; [INFO] [stdout] | +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bin/client.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | tx2.send(Command::Set{key: "foo", value: "bar".to_string(), resp: tx}).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _unused = ...` to ignore the resulting value without dropping it immediately [INFO] [stdout] | [INFO] [stdout] 53 | let _unused = tx2.send(Command::Set{key: "foo", value: "bar".to_string(), resp: tx}).await; [INFO] [stdout] | +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `bytes::Bytes` [INFO] [stdout] --> src/bin/server.rs:45:41 [INFO] [stdout] | [INFO] [stdout] 45 | ... Frame::Bulk(value.clone().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 45 - Frame::Bulk(value.clone().into()) [INFO] [stdout] 45 + Frame::Bulk(value.clone()) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 45 - Frame::Bulk(value.clone().into()) [INFO] [stdout] 45 + Frame::Bulk(>::into(value.clone())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `my-redis` (bin "server" test) due to 1 previous error [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: useless conversion to the same type: `bytes::Bytes` [INFO] [stdout] --> src/bin/server.rs:45:41 [INFO] [stdout] | [INFO] [stdout] 45 | ... Frame::Bulk(value.clone().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 45 - Frame::Bulk(value.clone().into()) [INFO] [stdout] 45 + Frame::Bulk(value.clone()) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 45 - Frame::Bulk(value.clone().into()) [INFO] [stdout] 45 + Frame::Bulk(>::into(value.clone())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `my-redis` (bin "server") due to 1 previous error [INFO] running `Command { std: "docker" "inspect" "b3a62f20bce1f1eb1a900fca47b87437a4cccad457923c54de6c10c5b5ab8dd9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3a62f20bce1f1eb1a900fca47b87437a4cccad457923c54de6c10c5b5ab8dd9", kill_on_drop: false }` [INFO] [stdout] b3a62f20bce1f1eb1a900fca47b87437a4cccad457923c54de6c10c5b5ab8dd9