[INFO] cloning repository https://github.com/WRTruong/rust-network-project [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/WRTruong/rust-network-project" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWRTruong%2Frust-network-project", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWRTruong%2Frust-network-project'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c11155618a9d05336be1101b46673e07fca94016 [INFO] checking WRTruong/rust-network-project against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWRTruong%2Frust-network-project" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/WRTruong/rust-network-project [INFO] finished tweaking git repo https://github.com/WRTruong/rust-network-project [INFO] tweaked toml for git repo https://github.com/WRTruong/rust-network-project written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/WRTruong/rust-network-project on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/WRTruong/rust-network-project already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] b0b2a488723cd31b2f6912da9e89a134774dc3fd90cc71ebc1d27992ecd1f7b2 [INFO] running `Command { std: "docker" "start" "b0b2a488723cd31b2f6912da9e89a134774dc3fd90cc71ebc1d27992ecd1f7b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b0b2a488723cd31b2f6912da9e89a134774dc3fd90cc71ebc1d27992ecd1f7b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "b0b2a488723cd31b2f6912da9e89a134774dc3fd90cc71ebc1d27992ecd1f7b2" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b0b2a488723cd31b2f6912da9e89a134774dc3fd90cc71ebc1d27992ecd1f7b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "b0b2a488723cd31b2f6912da9e89a134774dc3fd90cc71ebc1d27992ecd1f7b2" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling pkg-config v0.3.33 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling openssl-sys v0.9.114 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking data-encoding v2.10.0 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Compiling openssl v0.10.78 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling native-tls v0.2.18 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking uuid v1.23.1 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking asynchronous-codec v0.6.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking connection-string v0.2.0 [INFO] [stderr] Checking pretty-hex v0.3.0 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking bcrypt v0.15.1 [INFO] [stderr] Checking dotenvy v0.15.7 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking async-native-tls v0.4.0 [INFO] [stderr] Checking tungstenite v0.24.0 [INFO] [stderr] Checking tungstenite v0.23.0 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-tungstenite v0.24.0 [INFO] [stderr] Checking tokio-tungstenite v0.23.1 [INFO] [stderr] Checking tiberius v0.12.3 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking axum v0.7.9 [INFO] [stderr] Checking rust-network-project v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `get_message` and `can_modify_message` are never used [INFO] [stdout] --> src/chat/message_store.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 11 | impl MessageStore { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 78 | pub async fn get_message(&self, message_id: &str) -> Option { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub async fn can_modify_message(&self, message_id: &str, username: &str) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `update_profile` is never used [INFO] [stdout] --> src/auth.rs:113:14 [INFO] [stdout] | [INFO] [stdout] 113 | pub async fn update_profile( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_user_profile` is never used [INFO] [stdout] --> src/auth.rs:135:14 [INFO] [stdout] | [INFO] [stdout] 135 | pub async fn get_user_profile( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/client/client.rs:163:30 [INFO] [stdout] | [INFO] [stdout] 163 | write.send(Message::Text(serde_json::to_string(&msg)?.into())).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 163 - write.send(Message::Text(serde_json::to_string(&msg)?.into())).await?; [INFO] [stdout] 163 + write.send(Message::Text(serde_json::to_string(&msg)?)).await?; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 163 - write.send(Message::Text(serde_json::to_string(&msg)?.into())).await?; [INFO] [stdout] 163 + write.send(Message::Text(>::into(serde_json::to_string(&msg)?))).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/client/client.rs:172:30 [INFO] [stdout] | [INFO] [stdout] 172 | write.send(Message::Text(serde_json::to_string(&join_msg)?.into())).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 172 - write.send(Message::Text(serde_json::to_string(&join_msg)?.into())).await?; [INFO] [stdout] 172 + write.send(Message::Text(serde_json::to_string(&join_msg)?)).await?; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 172 - write.send(Message::Text(serde_json::to_string(&join_msg)?.into())).await?; [INFO] [stdout] 172 + write.send(Message::Text(>::into(serde_json::to_string(&join_msg)?))).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/client/client.rs:181:30 [INFO] [stdout] | [INFO] [stdout] 181 | write.send(Message::Text(serde_json::to_string(&leave_msg)?.into())).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 181 - write.send(Message::Text(serde_json::to_string(&leave_msg)?.into())).await?; [INFO] [stdout] 181 + write.send(Message::Text(serde_json::to_string(&leave_msg)?)).await?; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 181 - write.send(Message::Text(serde_json::to_string(&leave_msg)?.into())).await?; [INFO] [stdout] 181 + write.send(Message::Text(>::into(serde_json::to_string(&leave_msg)?))).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/client/client.rs:191:30 [INFO] [stdout] | [INFO] [stdout] 191 | write.send(Message::Text(serde_json::to_string(&msg)?.into())).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 191 - write.send(Message::Text(serde_json::to_string(&msg)?.into())).await?; [INFO] [stdout] 191 + write.send(Message::Text(serde_json::to_string(&msg)?)).await?; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 191 - write.send(Message::Text(serde_json::to_string(&msg)?.into())).await?; [INFO] [stdout] 191 + write.send(Message::Text(>::into(serde_json::to_string(&msg)?))).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/server/websocket.rs:65:45 [INFO] [stdout] | [INFO] [stdout] 65 | if ws_sender.send(Message::Text(json.into())).await.is_err() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 65 - if ws_sender.send(Message::Text(json.into())).await.is_err() { [INFO] [stdout] 65 + if ws_sender.send(Message::Text(json)).await.is_err() { [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 65 - if ws_sender.send(Message::Text(json.into())).await.is_err() { [INFO] [stdout] 65 + if ws_sender.send(Message::Text(>::into(json))).await.is_err() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-network-project` (bin "rust-network-project" test) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: methods `get_message` and `can_modify_message` are never used [INFO] [stdout] --> src/chat/message_store.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 11 | impl MessageStore { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 78 | pub async fn get_message(&self, message_id: &str) -> Option { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub async fn can_modify_message(&self, message_id: &str, username: &str) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `update_profile` is never used [INFO] [stdout] --> src/auth.rs:113:14 [INFO] [stdout] | [INFO] [stdout] 113 | pub async fn update_profile( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_user_profile` is never used [INFO] [stdout] --> src/auth.rs:135:14 [INFO] [stdout] | [INFO] [stdout] 135 | pub async fn get_user_profile( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/client/client.rs:163:30 [INFO] [stdout] | [INFO] [stdout] 163 | write.send(Message::Text(serde_json::to_string(&msg)?.into())).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 163 - write.send(Message::Text(serde_json::to_string(&msg)?.into())).await?; [INFO] [stdout] 163 + write.send(Message::Text(serde_json::to_string(&msg)?)).await?; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 163 - write.send(Message::Text(serde_json::to_string(&msg)?.into())).await?; [INFO] [stdout] 163 + write.send(Message::Text(>::into(serde_json::to_string(&msg)?))).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/client/client.rs:172:30 [INFO] [stdout] | [INFO] [stdout] 172 | write.send(Message::Text(serde_json::to_string(&join_msg)?.into())).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 172 - write.send(Message::Text(serde_json::to_string(&join_msg)?.into())).await?; [INFO] [stdout] 172 + write.send(Message::Text(serde_json::to_string(&join_msg)?)).await?; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 172 - write.send(Message::Text(serde_json::to_string(&join_msg)?.into())).await?; [INFO] [stdout] 172 + write.send(Message::Text(>::into(serde_json::to_string(&join_msg)?))).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/client/client.rs:181:30 [INFO] [stdout] | [INFO] [stdout] 181 | write.send(Message::Text(serde_json::to_string(&leave_msg)?.into())).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 181 - write.send(Message::Text(serde_json::to_string(&leave_msg)?.into())).await?; [INFO] [stdout] 181 + write.send(Message::Text(serde_json::to_string(&leave_msg)?)).await?; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 181 - write.send(Message::Text(serde_json::to_string(&leave_msg)?.into())).await?; [INFO] [stdout] 181 + write.send(Message::Text(>::into(serde_json::to_string(&leave_msg)?))).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/client/client.rs:191:30 [INFO] [stdout] | [INFO] [stdout] 191 | write.send(Message::Text(serde_json::to_string(&msg)?.into())).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 191 - write.send(Message::Text(serde_json::to_string(&msg)?.into())).await?; [INFO] [stdout] 191 + write.send(Message::Text(serde_json::to_string(&msg)?)).await?; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 191 - write.send(Message::Text(serde_json::to_string(&msg)?.into())).await?; [INFO] [stdout] 191 + write.send(Message::Text(>::into(serde_json::to_string(&msg)?))).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/server/websocket.rs:65:45 [INFO] [stdout] | [INFO] [stdout] 65 | if ws_sender.send(Message::Text(json.into())).await.is_err() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 65 - if ws_sender.send(Message::Text(json.into())).await.is_err() { [INFO] [stdout] 65 + if ws_sender.send(Message::Text(json)).await.is_err() { [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 65 - if ws_sender.send(Message::Text(json.into())).await.is_err() { [INFO] [stdout] 65 + if ws_sender.send(Message::Text(>::into(json))).await.is_err() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-network-project` (bin "rust-network-project") due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b0b2a488723cd31b2f6912da9e89a134774dc3fd90cc71ebc1d27992ecd1f7b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0b2a488723cd31b2f6912da9e89a134774dc3fd90cc71ebc1d27992ecd1f7b2", kill_on_drop: false }` [INFO] [stdout] b0b2a488723cd31b2f6912da9e89a134774dc3fd90cc71ebc1d27992ecd1f7b2