[INFO] cloning repository https://github.com/SBuercklin/AdventOfCode23 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SBuercklin/AdventOfCode23" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSBuercklin%2FAdventOfCode23", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSBuercklin%2FAdventOfCode23'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fd97055aea8f87db4d257d448a3e55777b06f629 [INFO] checking SBuercklin/AdventOfCode23 against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSBuercklin%2FAdventOfCode23" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/SBuercklin/AdventOfCode23 [INFO] finished tweaking git repo https://github.com/SBuercklin/AdventOfCode23 [INFO] tweaked toml for git repo https://github.com/SBuercklin/AdventOfCode23 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/SBuercklin/AdventOfCode23 on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/SBuercklin/AdventOfCode23 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 74a0346ed442567a21be94b3c33151bd4a172a8afc2dc6c1270818b3ff9c313b [INFO] running `Command { std: "docker" "start" "74a0346ed442567a21be94b3c33151bd4a172a8afc2dc6c1270818b3ff9c313b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "74a0346ed442567a21be94b3c33151bd4a172a8afc2dc6c1270818b3ff9c313b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "74a0346ed442567a21be94b3c33151bd4a172a8afc2dc6c1270818b3ff9c313b" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "74a0346ed442567a21be94b3c33151bd4a172a8afc2dc6c1270818b3ff9c313b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "74a0346ed442567a21be94b3c33151bd4a172a8afc2dc6c1270818b3ff9c313b" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking itertools v0.12.0 [INFO] [stderr] Checking clap_builder v4.4.9 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking num-complex v0.4.4 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking num v0.4.1 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking clap v4.4.10 [INFO] [stderr] Checking advent_of_code_23 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: useless assignment of variable of type `bool` to itself [INFO] [stdout] --> src/day10/mod.rs:326:22 [INFO] [stdout] | [INFO] [stdout] 326 | _ => mode = mode, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Vec` [INFO] [stdout] --> src/day15/mod.rs:160:12 [INFO] [stdout] | [INFO] [stdout] 160 | return boxes.into(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 160 - return boxes.into(); [INFO] [stdout] 160 + return boxes; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 160 - return boxes.into(); [INFO] [stdout] 160 + return as Into<_>>::into(boxes); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Vec>` [INFO] [stdout] --> src/day3/mod.rs:140:60 [INFO] [stdout] | [INFO] [stdout] 140 | let mut combined_lines: HashSet = combine_sets(numbers.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 140 - let mut combined_lines: HashSet = combine_sets(numbers.into()); [INFO] [stdout] 140 + let mut combined_lines: HashSet = combine_sets(numbers); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 140 - let mut combined_lines: HashSet = combine_sets(numbers.into()); [INFO] [stdout] 140 + let mut combined_lines: HashSet = combine_sets(> as Into<_>>::into(numbers)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `[Card; 5]` [INFO] [stdout] --> src/day7/mod.rs:220:22 [INFO] [stdout] | [INFO] [stdout] 220 | return Hand::new(hand.into(), bid); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 220 - return Hand::new(hand.into(), bid); [INFO] [stdout] 220 + return Hand::new(hand, bid); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 220 - return Hand::new(hand.into(), bid); [INFO] [stdout] 220 + return Hand::new(<[Card; 5] as Into<_>>::into(hand), bid); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/day15/mod.rs:39:19 [INFO] [stdout] | [INFO] [stdout] 39 | fn new(input: &str) -> Command { [INFO] [stdout] | ^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 39 | fn new(input: &str) -> Command<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless assignment of variable of type `bool` to itself [INFO] [stdout] --> src/day10/mod.rs:326:22 [INFO] [stdout] | [INFO] [stdout] 326 | _ => mode = mode, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent_of_code_23` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stdout] error: useless conversion to the same type: `Vec` [INFO] [stdout] --> src/day15/mod.rs:160:12 [INFO] [stdout] | [INFO] [stdout] 160 | return boxes.into(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 160 - return boxes.into(); [INFO] [stdout] 160 + return boxes; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 160 - return boxes.into(); [INFO] [stdout] 160 + return as Into<_>>::into(boxes); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: useless conversion to the same type: `Vec>` [INFO] [stdout] --> src/day3/mod.rs:140:60 [INFO] [stdout] | [INFO] [stdout] 140 | let mut combined_lines: HashSet = combine_sets(numbers.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 140 - let mut combined_lines: HashSet = combine_sets(numbers.into()); [INFO] [stdout] 140 + let mut combined_lines: HashSet = combine_sets(numbers); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 140 - let mut combined_lines: HashSet = combine_sets(numbers.into()); [INFO] [stdout] 140 + let mut combined_lines: HashSet = combine_sets(> as Into<_>>::into(numbers)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `[Card; 5]` [INFO] [stdout] --> src/day7/mod.rs:220:22 [INFO] [stdout] | [INFO] [stdout] 220 | return Hand::new(hand.into(), bid); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 220 - return Hand::new(hand.into(), bid); [INFO] [stdout] 220 + return Hand::new(hand, bid); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 220 - return Hand::new(hand.into(), bid); [INFO] [stdout] 220 + return Hand::new(<[Card; 5] as Into<_>>::into(hand), bid); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/day15/mod.rs:39:19 [INFO] [stdout] | [INFO] [stdout] 39 | fn new(input: &str) -> Command { [INFO] [stdout] | ^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 39 | fn new(input: &str) -> Command<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent_of_code_23` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "74a0346ed442567a21be94b3c33151bd4a172a8afc2dc6c1270818b3ff9c313b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "74a0346ed442567a21be94b3c33151bd4a172a8afc2dc6c1270818b3ff9c313b", kill_on_drop: false }` [INFO] [stdout] 74a0346ed442567a21be94b3c33151bd4a172a8afc2dc6c1270818b3ff9c313b