[INFO] cloning repository https://github.com/Pumahawk/json_rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Pumahawk/json_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPumahawk%2Fjson_rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPumahawk%2Fjson_rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f62bdc09090771e7118805d7cfeb1f05c9826abe [INFO] checking Pumahawk/json_rust against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPumahawk%2Fjson_rust" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Pumahawk/json_rust [INFO] finished tweaking git repo https://github.com/Pumahawk/json_rust [INFO] tweaked toml for git repo https://github.com/Pumahawk/json_rust written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Pumahawk/json_rust on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Pumahawk/json_rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 4bbc738dabf1647aae906e9ef7f91dfbd845c51b666d63e914ff866f4ab95551 [INFO] running `Command { std: "docker" "start" "4bbc738dabf1647aae906e9ef7f91dfbd845c51b666d63e914ff866f4ab95551", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4bbc738dabf1647aae906e9ef7f91dfbd845c51b666d63e914ff866f4ab95551", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "4bbc738dabf1647aae906e9ef7f91dfbd845c51b666d63e914ff866f4ab95551" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4bbc738dabf1647aae906e9ef7f91dfbd845c51b666d63e914ff866f4ab95551", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "4bbc738dabf1647aae906e9ef7f91dfbd845c51b666d63e914ff866f4ab95551" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Checking automa v0.1.0 (https://github.com/Pumahawk/rust-automa.git#cc0ffe4c) [INFO] [stderr] Checking json v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/automa.rs:1002:66 [INFO] [stdout] | [INFO] [stdout] 1002 | Err(msg) => assert_eq!("Invalid input, default", msg.cause().unwrap().to_string()), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/automa.rs:306:13 [INFO] [stdout] | [INFO] [stdout] 306 | let mut n6: Node = atm::node(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/automa.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 307 | let mut n7: Node = atm::node(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/automa.rs:328:13 [INFO] [stdout] | [INFO] [stdout] 328 | let mut err = atm::node(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n6` [INFO] [stdout] --> src/automa.rs:306:13 [INFO] [stdout] | [INFO] [stdout] 306 | let mut n6: Node = atm::node(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_n6` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n7` [INFO] [stdout] --> src/automa.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 307 | let mut n7: Node = atm::node(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_n7` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `objects::TypeJson` [INFO] [stdout] --> src/objects.rs:83:23 [INFO] [stdout] | [INFO] [stdout] 83 | let mut ret = self.into(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 83 - let mut ret = self.into(); [INFO] [stdout] 83 + let mut ret = self; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 83 - let mut ret = self.into(); [INFO] [stdout] 83 + let mut ret = >::into(self); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/automa.rs:306:13 [INFO] [stdout] | [INFO] [stdout] 306 | let mut n6: Node = atm::node(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/automa.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 307 | let mut n7: Node = atm::node(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/automa.rs:328:13 [INFO] [stdout] | [INFO] [stdout] 328 | let mut err = atm::node(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n6` [INFO] [stdout] --> src/automa.rs:306:13 [INFO] [stdout] | [INFO] [stdout] 306 | let mut n6: Node = atm::node(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_n6` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n7` [INFO] [stdout] --> src/automa.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 307 | let mut n7: Node = atm::node(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_n7` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/objects.rs:464:39 [INFO] [stdout] | [INFO] [stdout] 464 | pub fn new(root: &'a TypeJson) -> ReaderJson { [INFO] [stdout] | -- ^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 464 | pub fn new(root: &'a TypeJson) -> ReaderJson<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/automa.rs:696:22 [INFO] [stdout] | [INFO] [stdout] 696 | pub fn new(iter: &mut T) -> KeyParseQueryAutoma { [INFO] [stdout] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 696 | pub fn new(iter: &mut T) -> KeyParseQueryAutoma<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `json` (lib test) due to 1 previous error; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: useless conversion to the same type: `TypeJson` [INFO] [stdout] --> src/objects.rs:83:23 [INFO] [stdout] | [INFO] [stdout] 83 | let mut ret = self.into(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 83 - let mut ret = self.into(); [INFO] [stdout] 83 + let mut ret = self; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 83 - let mut ret = self.into(); [INFO] [stdout] 83 + let mut ret = >::into(self); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/objects.rs:464:39 [INFO] [stdout] | [INFO] [stdout] 464 | pub fn new(root: &'a TypeJson) -> ReaderJson { [INFO] [stdout] | -- ^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 464 | pub fn new(root: &'a TypeJson) -> ReaderJson<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/automa.rs:696:22 [INFO] [stdout] | [INFO] [stdout] 696 | pub fn new(iter: &mut T) -> KeyParseQueryAutoma { [INFO] [stdout] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 696 | pub fn new(iter: &mut T) -> KeyParseQueryAutoma<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `json` (lib) due to 1 previous error; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4bbc738dabf1647aae906e9ef7f91dfbd845c51b666d63e914ff866f4ab95551", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4bbc738dabf1647aae906e9ef7f91dfbd845c51b666d63e914ff866f4ab95551", kill_on_drop: false }` [INFO] [stdout] 4bbc738dabf1647aae906e9ef7f91dfbd845c51b666d63e914ff866f4ab95551