[INFO] cloning repository https://github.com/Nepich/analysis_proj_refactor [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Nepich/analysis_proj_refactor" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNepich%2Fanalysis_proj_refactor", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNepich%2Fanalysis_proj_refactor'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9b2679cf4094f98346680adc865b5b3feaa01ad5 [INFO] checking Nepich/analysis_proj_refactor against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNepich%2Fanalysis_proj_refactor" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Nepich/analysis_proj_refactor [INFO] finished tweaking git repo https://github.com/Nepich/analysis_proj_refactor [INFO] tweaked toml for git repo https://github.com/Nepich/analysis_proj_refactor written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Nepich/analysis_proj_refactor on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Nepich/analysis_proj_refactor already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] cd81cc5f846124b4e6382802704893b975ef8ea46a20a731a65ea8c010a6b8e9 [INFO] running `Command { std: "docker" "start" "cd81cc5f846124b4e6382802704893b975ef8ea46a20a731a65ea8c010a6b8e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd81cc5f846124b4e6382802704893b975ef8ea46a20a731a65ea8c010a6b8e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "cd81cc5f846124b4e6382802704893b975ef8ea46a20a731a65ea8c010a6b8e9" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd81cc5f846124b4e6382802704893b975ef8ea46a20a731a65ea8c010a6b8e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "cd81cc5f846124b4e6382802704893b975ef8ea46a20a731a65ea8c010a6b8e9" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Checking analysis v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `reader_rc` is never read [INFO] [stdout] --> src/lib.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 33 | struct LogIterator { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 34 | lines: std::iter::Filter>>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LogIterator` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `quote` is never used [INFO] [stdout] --> src/parse.rs:84:4 [INFO] [stdout] | [INFO] [stdout] 84 | fn quote (input: &str) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AsIs` is never constructed [INFO] [stdout] --> src/parse.rs:143:8 [INFO] [stdout] | [INFO] [stdout] 143 | struct AsIs; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `all3` is never used [INFO] [stdout] --> src/parse.rs:315:4 [INFO] [stdout] | [INFO] [stdout] 315 | fn all3(a0: A0, a1: A1, a2: A2) -> All<(A0,A1,A2)> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `all4` is never used [INFO] [stdout] --> src/parse.rs:336:4 [INFO] [stdout] | [INFO] [stdout] 336 | fn all4(a0: A0, a1: A1, a2: A2, a3: A3) -> All<(A0,A1,A2,A3)> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Either` is never used [INFO] [stdout] --> src/parse.rs:633:6 [INFO] [stdout] | [INFO] [stdout] 633 | enum Either { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Status` is never used [INFO] [stdout] --> src/parse.rs:639:6 [INFO] [stdout] | [INFO] [stdout] 639 | enum Status { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `I32` is never constructed [INFO] [stdout] --> src/parse.rs:53:16 [INFO] [stdout] | [INFO] [stdout] 53 | pub struct I32; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `String` [INFO] [stdout] --> src/parse.rs:147:47 [INFO] [stdout] | [INFO] [stdout] 147 | Ok((input[input.len()..].to_string(), input.into())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 147 - Ok((input[input.len()..].to_string(), input.into())) [INFO] [stdout] 147 + Ok((input[input.len()..].to_string(), input)) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 147 - Ok((input[input.len()..].to_string(), input.into())) [INFO] [stdout] 147 + Ok((input[input.len()..].to_string(), >::into(input))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `analysis` (lib) due to 1 previous error; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `reader_rc` is never read [INFO] [stdout] --> src/lib.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 33 | struct LogIterator { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 34 | lines: std::iter::Filter>>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LogIterator` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AsIs` is never constructed [INFO] [stdout] --> src/parse.rs:143:8 [INFO] [stdout] | [INFO] [stdout] 143 | struct AsIs; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `all3` is never used [INFO] [stdout] --> src/parse.rs:315:4 [INFO] [stdout] | [INFO] [stdout] 315 | fn all3(a0: A0, a1: A1, a2: A2) -> All<(A0,A1,A2)> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `all4` is never used [INFO] [stdout] --> src/parse.rs:336:4 [INFO] [stdout] | [INFO] [stdout] 336 | fn all4(a0: A0, a1: A1, a2: A2, a3: A3) -> All<(A0,A1,A2,A3)> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Either` is never used [INFO] [stdout] --> src/parse.rs:633:6 [INFO] [stdout] | [INFO] [stdout] 633 | enum Either { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Status` is never used [INFO] [stdout] --> src/parse.rs:639:6 [INFO] [stdout] | [INFO] [stdout] 639 | enum Status { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `String` [INFO] [stdout] --> src/parse.rs:147:47 [INFO] [stdout] | [INFO] [stdout] 147 | Ok((input[input.len()..].to_string(), input.into())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 147 - Ok((input[input.len()..].to_string(), input.into())) [INFO] [stdout] 147 + Ok((input[input.len()..].to_string(), input)) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 147 - Ok((input[input.len()..].to_string(), input.into())) [INFO] [stdout] 147 + Ok((input[input.len()..].to_string(), >::into(input))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/parse.rs:1219:34 [INFO] [stdout] | [INFO] [stdout] 1219 | assert_eq!(delimited(tag("[".into()), stdp::U32, tag("]".into())).parse("[0x32] nice".into()), Ok((" nice".into(), 0x32))); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 1219 - assert_eq!(delimited(tag("[".into()), stdp::U32, tag("]".into())).parse("[0x32] nice".into()), Ok((" nice".into(), 0x32))); [INFO] [stdout] 1219 + assert_eq!(delimited(tag("["), stdp::U32, tag("]".into())).parse("[0x32] nice".into()), Ok((" nice".into(), 0x32))); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 1219 - assert_eq!(delimited(tag("[".into()), stdp::U32, tag("]".into())).parse("[0x32] nice".into()), Ok((" nice".into(), 0x32))); [INFO] [stdout] 1219 + assert_eq!(delimited(tag(<&str as Into<_>>::into("[")), stdp::U32, tag("]".into())).parse("[0x32] nice".into()), Ok((" nice".into(), 0x32))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/parse.rs:1219:62 [INFO] [stdout] | [INFO] [stdout] 1219 | assert_eq!(delimited(tag("[".into()), stdp::U32, tag("]".into())).parse("[0x32] nice".into()), Ok((" nice".into(), 0x32))); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 1219 - assert_eq!(delimited(tag("[".into()), stdp::U32, tag("]".into())).parse("[0x32] nice".into()), Ok((" nice".into(), 0x32))); [INFO] [stdout] 1219 + assert_eq!(delimited(tag("[".into()), stdp::U32, tag("]")).parse("[0x32] nice".into()), Ok((" nice".into(), 0x32))); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 1219 - assert_eq!(delimited(tag("[".into()), stdp::U32, tag("]".into())).parse("[0x32] nice".into()), Ok((" nice".into(), 0x32))); [INFO] [stdout] 1219 + assert_eq!(delimited(tag("[".into()), stdp::U32, tag(<&str as Into<_>>::into("]"))).parse("[0x32] nice".into()), Ok((" nice".into(), 0x32))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/parse.rs:1220:34 [INFO] [stdout] | [INFO] [stdout] 1220 | assert_eq!(delimited(tag("[".into()), stdp::U32, tag("]")).parse("0x32]".into()), Err(())); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 1220 - assert_eq!(delimited(tag("[".into()), stdp::U32, tag("]")).parse("0x32]".into()), Err(())); [INFO] [stdout] 1220 + assert_eq!(delimited(tag("["), stdp::U32, tag("]")).parse("0x32]".into()), Err(())); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 1220 - assert_eq!(delimited(tag("[".into()), stdp::U32, tag("]")).parse("0x32]".into()), Err(())); [INFO] [stdout] 1220 + assert_eq!(delimited(tag(<&str as Into<_>>::into("[")), stdp::U32, tag("]")).parse("0x32]".into()), Err(())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/parse.rs:1221:34 [INFO] [stdout] | [INFO] [stdout] 1221 | assert_eq!(delimited(tag("[".into()), stdp::U32, tag("]")).parse("[0x32".into()), Err(())); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 1221 - assert_eq!(delimited(tag("[".into()), stdp::U32, tag("]")).parse("[0x32".into()), Err(())); [INFO] [stdout] 1221 + assert_eq!(delimited(tag("["), stdp::U32, tag("]")).parse("[0x32".into()), Err(())); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 1221 - assert_eq!(delimited(tag("[".into()), stdp::U32, tag("]")).parse("[0x32".into()), Err(())); [INFO] [stdout] 1221 + assert_eq!(delimited(tag(<&str as Into<_>>::into("[")), stdp::U32, tag("]")).parse("[0x32".into()), Err(())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `analysis` (lib test) due to 5 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "cd81cc5f846124b4e6382802704893b975ef8ea46a20a731a65ea8c010a6b8e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd81cc5f846124b4e6382802704893b975ef8ea46a20a731a65ea8c010a6b8e9", kill_on_drop: false }` [INFO] [stdout] cd81cc5f846124b4e6382802704893b975ef8ea46a20a731a65ea8c010a6b8e9