[INFO] cloning repository https://github.com/Mereep/advent_of_code_2021_rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Mereep/advent_of_code_2021_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMereep%2Fadvent_of_code_2021_rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMereep%2Fadvent_of_code_2021_rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d1d5348f43517bc2b6d6f9599fd03b2d92112927 [INFO] checking Mereep/advent_of_code_2021_rust against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMereep%2Fadvent_of_code_2021_rust" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Mereep/advent_of_code_2021_rust [INFO] finished tweaking git repo https://github.com/Mereep/advent_of_code_2021_rust [INFO] tweaked toml for git repo https://github.com/Mereep/advent_of_code_2021_rust written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Mereep/advent_of_code_2021_rust on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Mereep/advent_of_code_2021_rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 787337a05c65ba55123a8460c44603b6fb370a35e09fd6189b704a0a8a2e4745 [INFO] running `Command { std: "docker" "start" "787337a05c65ba55123a8460c44603b6fb370a35e09fd6189b704a0a8a2e4745", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "787337a05c65ba55123a8460c44603b6fb370a35e09fd6189b704a0a8a2e4745", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "787337a05c65ba55123a8460c44603b6fb370a35e09fd6189b704a0a8a2e4745" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "787337a05c65ba55123a8460c44603b6fb370a35e09fd6189b704a0a8a2e4745", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "787337a05c65ba55123a8460c44603b6fb370a35e09fd6189b704a0a8a2e4745" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Checking advent_of_code_2021 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/day14/mod.rs:89:14 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn task2(data: &Vec) -> u64 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `HashMap` [INFO] [stdout] --> src/day7/mod.rs:25:24 [INFO] [stdout] | [INFO] [stdout] 25 | positions: vec.into() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 25 - positions: vec.into() [INFO] [stdout] 25 + positions: vec [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 25 - positions: vec.into() [INFO] [stdout] 25 + positions: as Into<_>>::into(vec) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&String` [INFO] [stdout] --> src/day12/mod.rs:57:41 [INFO] [stdout] | [INFO] [stdout] 57 | for neighbour in self.edges.get(from.into()).unwrap() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 57 - for neighbour in self.edges.get(from.into()).unwrap() { [INFO] [stdout] 57 + for neighbour in self.edges.get(from).unwrap() { [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 57 - for neighbour in self.edges.get(from.into()).unwrap() { [INFO] [stdout] 57 + for neighbour in self.edges.get(<&String as Into<_>>::into(from)).unwrap() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&String` [INFO] [stdout] --> src/day12/mod.rs:86:41 [INFO] [stdout] | [INFO] [stdout] 86 | for neighbour in self.edges.get(from.into()).unwrap() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 86 - for neighbour in self.edges.get(from.into()).unwrap() { [INFO] [stdout] 86 + for neighbour in self.edges.get(from).unwrap() { [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 86 - for neighbour in self.edges.get(from.into()).unwrap() { [INFO] [stdout] 86 + for neighbour in self.edges.get(<&String as Into<_>>::into(from)).unwrap() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&char` instead of cloning the inner type [INFO] [stdout] --> src/day8/mod.rs:90:100 [INFO] [stdout] | [INFO] [stdout] 90 | let segment_1 = *seven_chars.difference(&one_char).collect::>().first().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&char` instead of cloning the inner type [INFO] [stdout] --> src/day8/mod.rs:99:118 [INFO] [stdout] | [INFO] [stdout] 99 | let segment_5 = *segments_3_5.difference(&string_to_char_set(&four)).collect::>().first().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&char` instead of cloning the inner type [INFO] [stdout] --> src/day8/mod.rs:101:121 [INFO] [stdout] | [INFO] [stdout] 101 | let segment_3 = *sub_char_from_hashset(&segments_3_5, segment_5).iter().collect::>().first().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&char` instead of cloning the inner type [INFO] [stdout] --> src/day8/mod.rs:107:131 [INFO] [stdout] | [INFO] [stdout] 107 | ..., segment_3).iter().collect::>().first().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&char` instead of cloning the inner type [INFO] [stdout] --> src/day8/mod.rs:117:122 [INFO] [stdout] | [INFO] [stdout] 117 | let segment_4 = *eight_minus_four_minus_segment_1_minus_segment_5.iter().collect::>().first().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&char` instead of cloning the inner type [INFO] [stdout] --> src/day8/mod.rs:132:38 [INFO] [stdout] | [INFO] [stdout] 132 | .first().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&char` instead of cloning the inner type [INFO] [stdout] --> src/day8/mod.rs:137:133 [INFO] [stdout] | [INFO] [stdout] 137 | ..., segment_6).iter().collect::>().first().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent_of_code_2021` (bin "advent_of_code_2021") due to 3 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/day14/mod.rs:89:14 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn task2(data: &Vec) -> u64 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `HashMap` [INFO] [stdout] --> src/day7/mod.rs:25:24 [INFO] [stdout] | [INFO] [stdout] 25 | positions: vec.into() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 25 - positions: vec.into() [INFO] [stdout] 25 + positions: vec [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 25 - positions: vec.into() [INFO] [stdout] 25 + positions: as Into<_>>::into(vec) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&String` [INFO] [stdout] --> src/day12/mod.rs:57:41 [INFO] [stdout] | [INFO] [stdout] 57 | for neighbour in self.edges.get(from.into()).unwrap() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 57 - for neighbour in self.edges.get(from.into()).unwrap() { [INFO] [stdout] 57 + for neighbour in self.edges.get(from).unwrap() { [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 57 - for neighbour in self.edges.get(from.into()).unwrap() { [INFO] [stdout] 57 + for neighbour in self.edges.get(<&String as Into<_>>::into(from)).unwrap() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&String` [INFO] [stdout] --> src/day12/mod.rs:86:41 [INFO] [stdout] | [INFO] [stdout] 86 | for neighbour in self.edges.get(from.into()).unwrap() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 86 - for neighbour in self.edges.get(from.into()).unwrap() { [INFO] [stdout] 86 + for neighbour in self.edges.get(from).unwrap() { [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 86 - for neighbour in self.edges.get(from.into()).unwrap() { [INFO] [stdout] 86 + for neighbour in self.edges.get(<&String as Into<_>>::into(from)).unwrap() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&char` instead of cloning the inner type [INFO] [stdout] --> src/day8/mod.rs:90:100 [INFO] [stdout] | [INFO] [stdout] 90 | let segment_1 = *seven_chars.difference(&one_char).collect::>().first().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&char` instead of cloning the inner type [INFO] [stdout] --> src/day8/mod.rs:99:118 [INFO] [stdout] | [INFO] [stdout] 99 | let segment_5 = *segments_3_5.difference(&string_to_char_set(&four)).collect::>().first().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&char` instead of cloning the inner type [INFO] [stdout] --> src/day8/mod.rs:101:121 [INFO] [stdout] | [INFO] [stdout] 101 | let segment_3 = *sub_char_from_hashset(&segments_3_5, segment_5).iter().collect::>().first().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&char` instead of cloning the inner type [INFO] [stdout] --> src/day8/mod.rs:107:131 [INFO] [stdout] | [INFO] [stdout] 107 | ..., segment_3).iter().collect::>().first().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&char` instead of cloning the inner type [INFO] [stdout] --> src/day8/mod.rs:117:122 [INFO] [stdout] | [INFO] [stdout] 117 | let segment_4 = *eight_minus_four_minus_segment_1_minus_segment_5.iter().collect::>().first().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&char` instead of cloning the inner type [INFO] [stdout] --> src/day8/mod.rs:132:38 [INFO] [stdout] | [INFO] [stdout] 132 | .first().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&char` instead of cloning the inner type [INFO] [stdout] --> src/day8/mod.rs:137:133 [INFO] [stdout] | [INFO] [stdout] 137 | ..., segment_6).iter().collect::>().first().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent_of_code_2021` (bin "advent_of_code_2021" test) due to 3 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "787337a05c65ba55123a8460c44603b6fb370a35e09fd6189b704a0a8a2e4745", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "787337a05c65ba55123a8460c44603b6fb370a35e09fd6189b704a0a8a2e4745", kill_on_drop: false }` [INFO] [stdout] 787337a05c65ba55123a8460c44603b6fb370a35e09fd6189b704a0a8a2e4745