[INFO] cloning repository https://github.com/Mao-jh/Ocli [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Mao-jh/Ocli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMao-jh%2FOcli", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMao-jh%2FOcli'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 42ccd7dade68cdce614b5eb9b50120b120d460b0 [INFO] checking Mao-jh/Ocli against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMao-jh%2FOcli" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Mao-jh/Ocli [INFO] finished tweaking git repo https://github.com/Mao-jh/Ocli [INFO] tweaked toml for git repo https://github.com/Mao-jh/Ocli written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Mao-jh/Ocli on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Mao-jh/Ocli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 00709cd7e38e4a1f3f814c41e2b60ceb5cf317bc2e7e94f11b87afabaa96c62f [INFO] running `Command { std: "docker" "start" "00709cd7e38e4a1f3f814c41e2b60ceb5cf317bc2e7e94f11b87afabaa96c62f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "00709cd7e38e4a1f3f814c41e2b60ceb5cf317bc2e7e94f11b87afabaa96c62f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "00709cd7e38e4a1f3f814c41e2b60ceb5cf317bc2e7e94f11b87afabaa96c62f" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "00709cd7e38e4a1f3f814c41e2b60ceb5cf317bc2e7e94f11b87afabaa96c62f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "00709cd7e38e4a1f3f814c41e2b60ceb5cf317bc2e7e94f11b87afabaa96c62f" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Checking zerofrom v0.1.8 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Compiling cc v1.2.62 [INFO] [stderr] Checking typenum v1.20.0 [INFO] [stderr] Checking tokio v1.52.3 [INFO] [stderr] Compiling rustls v0.23.40 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Checking webpki-roots v1.0.7 [INFO] [stderr] Checking clap_lex v1.1.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Compiling clap_derive v4.6.1 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking yoke v0.8.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap_builder v4.6.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking zerovec v0.11.6 [INFO] [stderr] Checking zerotrie v0.2.4 [INFO] [stderr] Checking rand v0.8.6 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking tinystr v0.8.3 [INFO] [stderr] Checking potential_utf v0.1.5 [INFO] [stderr] Checking icu_collections v2.2.0 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking icu_locale_core v2.2.0 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking icu_provider v2.2.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking icu_normalizer v2.2.0 [INFO] [stderr] Checking icu_properties v2.2.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking clap v4.6.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking tungstenite v0.24.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking tracing-subscriber v0.3.23 [INFO] [stderr] Checking idna_adapter v1.2.2 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking rustls-webpki v0.103.13 [INFO] [stderr] Checking hyper v1.9.0 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-tungstenite v0.24.0 [INFO] [stderr] Checking tower-http v0.6.11 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking hyper-rustls v0.27.9 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking ocli v2.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/sender.rs:237:37 [INFO] [stdout] | [INFO] [stdout] 237 | .send(Message::Text(serde_json::to_string(cmd)?.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 237 - .send(Message::Text(serde_json::to_string(cmd)?.into())) [INFO] [stdout] 237 + .send(Message::Text(serde_json::to_string(cmd)?)) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 237 - .send(Message::Text(serde_json::to_string(cmd)?.into())) [INFO] [stdout] 237 + .send(Message::Text(>::into(serde_json::to_string(cmd)?))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/sender.rs:237:37 [INFO] [stdout] | [INFO] [stdout] 237 | .send(Message::Text(serde_json::to_string(cmd)?.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 237 - .send(Message::Text(serde_json::to_string(cmd)?.into())) [INFO] [stdout] 237 + .send(Message::Text(serde_json::to_string(cmd)?)) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 237 - .send(Message::Text(serde_json::to_string(cmd)?.into())) [INFO] [stdout] 237 + .send(Message::Text(>::into(serde_json::to_string(cmd)?))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ocli` (bin "oc" test) due to 1 previous error [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ocli` (bin "oc") due to 1 previous error [INFO] running `Command { std: "docker" "inspect" "00709cd7e38e4a1f3f814c41e2b60ceb5cf317bc2e7e94f11b87afabaa96c62f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00709cd7e38e4a1f3f814c41e2b60ceb5cf317bc2e7e94f11b87afabaa96c62f", kill_on_drop: false }` [INFO] [stdout] 00709cd7e38e4a1f3f814c41e2b60ceb5cf317bc2e7e94f11b87afabaa96c62f