[INFO] cloning repository https://github.com/LoganLeeTwentyThree/gup [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LoganLeeTwentyThree/gup" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLoganLeeTwentyThree%2Fgup", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLoganLeeTwentyThree%2Fgup'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c10c43ff6a003880d19b839e4769191d7ec3c579 [INFO] checking LoganLeeTwentyThree/gup against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLoganLeeTwentyThree%2Fgup" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/LoganLeeTwentyThree/gup [INFO] finished tweaking git repo https://github.com/LoganLeeTwentyThree/gup [INFO] tweaked toml for git repo https://github.com/LoganLeeTwentyThree/gup written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/LoganLeeTwentyThree/gup on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/LoganLeeTwentyThree/gup already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] e6d919df3b7f9e3f3f37da29f3a5cf5616d1a8e49565be9ecf95e12f0d4ffd08 [INFO] running `Command { std: "docker" "start" "e6d919df3b7f9e3f3f37da29f3a5cf5616d1a8e49565be9ecf95e12f0d4ffd08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e6d919df3b7f9e3f3f37da29f3a5cf5616d1a8e49565be9ecf95e12f0d4ffd08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "e6d919df3b7f9e3f3f37da29f3a5cf5616d1a8e49565be9ecf95e12f0d4ffd08" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e6d919df3b7f9e3f3f37da29f3a5cf5616d1a8e49565be9ecf95e12f0d4ffd08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "e6d919df3b7f9e3f3f37da29f3a5cf5616d1a8e49565be9ecf95e12f0d4ffd08" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling find-msvc-tools v0.1.2 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling object v0.37.3 [INFO] [stderr] Checking cfg-if v1.0.3 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking gimli v0.32.3 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking winnow v0.7.13 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking serde_spanned v1.0.2 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking toml_datetime v0.7.2 [INFO] [stderr] Checking anstream v0.6.20 [INFO] [stderr] Checking toml_writer v1.0.3 [INFO] [stderr] Checking rustc-demangle v0.1.26 [INFO] [stderr] Checking jiff v0.2.15 [INFO] [stderr] Checking copy_dir v0.1.3 [INFO] [stderr] Compiling cc v1.2.39 [INFO] [stderr] Checking colored v3.0.0 [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Checking clap_builder v4.5.48 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling libz-sys v1.1.22 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Compiling libssh2-sys v0.3.1 [INFO] [stderr] Compiling libgit2-sys v0.18.2+1.9.1 [INFO] [stderr] Checking toml_parser v1.0.3 [INFO] [stderr] Checking toml v0.9.7 [INFO] [stderr] Checking regex-automata v0.4.11 [INFO] [stderr] Checking addr2line v0.25.1 [INFO] [stderr] Checking backtrace v0.3.76 [INFO] [stderr] Checking regex v1.11.3 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling clap_derive v4.5.47 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking clap v4.5.48 [INFO] [stderr] Checking clap-verbosity-flag v3.0.4 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking os_info v3.12.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking human-panic v2.0.3 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking git2 v0.20.2 [INFO] [stderr] Checking gup v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/config.rs:143:21 [INFO] [stdout] | [INFO] [stdout] 143 | new_deps.insert(dep.name.into(), toml::Value::Table(new_dep_table)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 143 - new_deps.insert(dep.name.into(), toml::Value::Table(new_dep_table)); [INFO] [stdout] 143 + new_deps.insert(dep.name, toml::Value::Table(new_dep_table)); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 143 - new_deps.insert(dep.name.into(), toml::Value::Table(new_dep_table)); [INFO] [stdout] 143 + new_deps.insert(>::into(dep.name), toml::Value::Table(new_dep_table)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `ColoredString` [INFO] [stdout] --> src/main.rs:86:40 [INFO] [stdout] | [INFO] [stdout] 86 | None => return Err("Invalid or missing filename for module".red().into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 86 - None => return Err("Invalid or missing filename for module".red().into()), [INFO] [stdout] 86 + None => return Err("Invalid or missing filename for module".red()), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 86 - None => return Err("Invalid or missing filename for module".red().into()), [INFO] [stdout] 86 + None => return Err(>::into("Invalid or missing filename for module".red())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/config.rs:143:21 [INFO] [stdout] | [INFO] [stdout] 143 | new_deps.insert(dep.name.into(), toml::Value::Table(new_dep_table)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 143 - new_deps.insert(dep.name.into(), toml::Value::Table(new_dep_table)); [INFO] [stdout] 143 + new_deps.insert(dep.name, toml::Value::Table(new_dep_table)); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 143 - new_deps.insert(dep.name.into(), toml::Value::Table(new_dep_table)); [INFO] [stdout] 143 + new_deps.insert(>::into(dep.name), toml::Value::Table(new_dep_table)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `ColoredString` [INFO] [stdout] --> src/main.rs:86:40 [INFO] [stdout] | [INFO] [stdout] 86 | None => return Err("Invalid or missing filename for module".red().into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 86 - None => return Err("Invalid or missing filename for module".red().into()), [INFO] [stdout] 86 + None => return Err("Invalid or missing filename for module".red()), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 86 - None => return Err("Invalid or missing filename for module".red().into()), [INFO] [stdout] 86 + None => return Err(>::into("Invalid or missing filename for module".red())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gup` (bin "gup" test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `gup` (bin "gup") due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "e6d919df3b7f9e3f3f37da29f3a5cf5616d1a8e49565be9ecf95e12f0d4ffd08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6d919df3b7f9e3f3f37da29f3a5cf5616d1a8e49565be9ecf95e12f0d4ffd08", kill_on_drop: false }` [INFO] [stdout] e6d919df3b7f9e3f3f37da29f3a5cf5616d1a8e49565be9ecf95e12f0d4ffd08