[INFO] cloning repository https://github.com/Katamithetaka/lox.rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Katamithetaka/lox.rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKatamithetaka%2Flox.rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKatamithetaka%2Flox.rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b04973621a86390b30241205afd7afc700645bd2 [INFO] checking Katamithetaka/lox.rs against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKatamithetaka%2Flox.rs" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Katamithetaka/lox.rs [INFO] finished tweaking git repo https://github.com/Katamithetaka/lox.rs [INFO] tweaked toml for git repo https://github.com/Katamithetaka/lox.rs written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Katamithetaka/lox.rs on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Katamithetaka/lox.rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] cd0a9470f4a5bc78c5c5116a6e1ba396ea0591707ad70e4fd2c0708c4ff1f21f [INFO] running `Command { std: "docker" "start" "cd0a9470f4a5bc78c5c5116a6e1ba396ea0591707ad70e4fd2c0708c4ff1f21f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd0a9470f4a5bc78c5c5116a6e1ba396ea0591707ad70e4fd2c0708c4ff1f21f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "cd0a9470f4a5bc78c5c5116a6e1ba396ea0591707ad70e4fd2c0708c4ff1f21f" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd0a9470f4a5bc78c5c5116a6e1ba396ea0591707ad70e4fd2c0708c4ff1f21f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "cd0a9470f4a5bc78c5c5116a6e1ba396ea0591707ad70e4fd2c0708c4ff1f21f" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-segmentation v1.12.0 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking colorchoice v1.0.5 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking anstyle v1.0.14 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking clap_lex v1.1.0 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking anstyle-parse v1.0.0 [INFO] [stderr] Compiling convert_case v0.10.0 [INFO] [stderr] Checking anstream v1.0.0 [INFO] [stderr] Checking clap_builder v4.6.0 [INFO] [stderr] Compiling strum_macros v0.28.0 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Compiling clap_derive v4.6.0 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking clap v4.6.0 [INFO] [stderr] Checking strum v0.28.0 [INFO] [stderr] Checking common v0.1.0 (/opt/rustwide/workdir/common) [INFO] [stderr] Checking optimizer v0.1.0 (/opt/rustwide/workdir/optimizer) [INFO] [stderr] Checking evaluator v0.1.0 (/opt/rustwide/workdir/evaluator) [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking ast_parser v0.1.0 (/opt/rustwide/workdir/ast_parser) [INFO] [stdout] error: useless conversion to the same type: `Expressions<'_>` [INFO] [stdout] --> ast_parser/src/ast_parser.rs:281:12 [INFO] [stdout] | [INFO] [stdout] 281 | Ok(expr.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 281 - Ok(expr.into()) [INFO] [stdout] 281 + Ok(expr) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 281 - Ok(expr.into()) [INFO] [stdout] 281 + Ok( as Into<_>>::into(expr)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `FunctionDeclareStatement<'_>` [INFO] [stdout] --> ast_parser/src/ast_parser.rs:418:19 [INFO] [stdout] | [INFO] [stdout] 418 | return Ok(statement.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 418 - return Ok(statement.into()) [INFO] [stdout] 418 + return Ok(statement) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 418 - return Ok(statement.into()) [INFO] [stdout] 418 + return Ok( as Into<_>>::into(statement)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Statements<'_>` [INFO] [stdout] --> ast_parser/src/ast_parser.rs:457:20 [INFO] [stdout] | [INFO] [stdout] 457 | Ok(self.class_declaration()?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 457 - Ok(self.class_declaration()?.into()) [INFO] [stdout] 457 + Ok(self.class_declaration()?) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 457 - Ok(self.class_declaration()?.into()) [INFO] [stdout] 457 + Ok( as Into<_>>::into(self.class_declaration()?)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Expressions<'_>` [INFO] [stdout] --> ast_parser/src/ast_parser.rs:522:22 [INFO] [stdout] | [INFO] [stdout] 522 | Some(self.expression()?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 522 - Some(self.expression()?.into()) [INFO] [stdout] 522 + Some(self.expression()?) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 522 - Some(self.expression()?.into()) [INFO] [stdout] 522 + Some( as Into<_>>::into(self.expression()?)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Expressions<'_>` [INFO] [stdout] --> ast_parser/src/ast_parser.rs:531:22 [INFO] [stdout] | [INFO] [stdout] 531 | Some(self.expression()?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 531 - Some(self.expression()?.into()) [INFO] [stdout] 531 + Some(self.expression()?) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 531 - Some(self.expression()?.into()) [INFO] [stdout] 531 + Some( as Into<_>>::into(self.expression()?)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Statements<'_>` [INFO] [stdout] --> ast_parser/src/ast_parser.rs:558:20 [INFO] [stdout] | [INFO] [stdout] 558 | Ok(self.while_statement()?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 558 - Ok(self.while_statement()?.into()) [INFO] [stdout] 558 + Ok(self.while_statement()?) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 558 - Ok(self.while_statement()?.into()) [INFO] [stdout] 558 + Ok( as Into<_>>::into(self.while_statement()?)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Statements<'_>` [INFO] [stdout] --> ast_parser/src/ast_parser.rs:562:20 [INFO] [stdout] | [INFO] [stdout] 562 | Ok(self.for_statement()?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 562 - Ok(self.for_statement()?.into()) [INFO] [stdout] 562 + Ok(self.for_statement()?) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 562 - Ok(self.for_statement()?.into()) [INFO] [stdout] 562 + Ok( as Into<_>>::into(self.for_statement()?)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ast_parser` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: useless conversion to the same type: `Expressions<'_>` [INFO] [stdout] --> ast_parser/src/ast_parser.rs:281:12 [INFO] [stdout] | [INFO] [stdout] 281 | Ok(expr.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 281 - Ok(expr.into()) [INFO] [stdout] 281 + Ok(expr) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 281 - Ok(expr.into()) [INFO] [stdout] 281 + Ok( as Into<_>>::into(expr)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `FunctionDeclareStatement<'_>` [INFO] [stdout] --> ast_parser/src/ast_parser.rs:418:19 [INFO] [stdout] | [INFO] [stdout] 418 | return Ok(statement.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 418 - return Ok(statement.into()) [INFO] [stdout] 418 + return Ok(statement) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 418 - return Ok(statement.into()) [INFO] [stdout] 418 + return Ok( as Into<_>>::into(statement)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Statements<'_>` [INFO] [stdout] --> ast_parser/src/ast_parser.rs:457:20 [INFO] [stdout] | [INFO] [stdout] 457 | Ok(self.class_declaration()?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 457 - Ok(self.class_declaration()?.into()) [INFO] [stdout] 457 + Ok(self.class_declaration()?) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 457 - Ok(self.class_declaration()?.into()) [INFO] [stdout] 457 + Ok( as Into<_>>::into(self.class_declaration()?)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Expressions<'_>` [INFO] [stdout] --> ast_parser/src/ast_parser.rs:522:22 [INFO] [stdout] | [INFO] [stdout] 522 | Some(self.expression()?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 522 - Some(self.expression()?.into()) [INFO] [stdout] 522 + Some(self.expression()?) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 522 - Some(self.expression()?.into()) [INFO] [stdout] 522 + Some( as Into<_>>::into(self.expression()?)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Expressions<'_>` [INFO] [stdout] --> ast_parser/src/ast_parser.rs:531:22 [INFO] [stdout] | [INFO] [stdout] 531 | Some(self.expression()?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 531 - Some(self.expression()?.into()) [INFO] [stdout] 531 + Some(self.expression()?) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 531 - Some(self.expression()?.into()) [INFO] [stdout] 531 + Some( as Into<_>>::into(self.expression()?)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Statements<'_>` [INFO] [stdout] --> ast_parser/src/ast_parser.rs:558:20 [INFO] [stdout] | [INFO] [stdout] 558 | Ok(self.while_statement()?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 558 - Ok(self.while_statement()?.into()) [INFO] [stdout] 558 + Ok(self.while_statement()?) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 558 - Ok(self.while_statement()?.into()) [INFO] [stdout] 558 + Ok( as Into<_>>::into(self.while_statement()?)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `Statements<'_>` [INFO] [stdout] --> ast_parser/src/ast_parser.rs:562:20 [INFO] [stdout] | [INFO] [stdout] 562 | Ok(self.for_statement()?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 562 - Ok(self.for_statement()?.into()) [INFO] [stdout] 562 + Ok(self.for_statement()?) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 562 - Ok(self.for_statement()?.into()) [INFO] [stdout] 562 + Ok( as Into<_>>::into(self.for_statement()?)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ast_parser` (lib test) due to 7 previous errors [INFO] [stderr] warning: unused dependency `arrayvec` [INFO] [stderr] --> evaluator/Cargo.toml:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | arrayvec = "0.7.6" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `cargo::unused_dependencies` is set to `warn` by default [INFO] [stderr] help: consider removing the dependency on `arrayvec` [INFO] [stderr] warning: `evaluator` (manifest) generated 1 warning [INFO] running `Command { std: "docker" "inspect" "cd0a9470f4a5bc78c5c5116a6e1ba396ea0591707ad70e4fd2c0708c4ff1f21f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd0a9470f4a5bc78c5c5116a6e1ba396ea0591707ad70e4fd2c0708c4ff1f21f", kill_on_drop: false }` [INFO] [stdout] cd0a9470f4a5bc78c5c5116a6e1ba396ea0591707ad70e4fd2c0708c4ff1f21f