[INFO] cloning repository https://github.com/Jessepan123456/DNS [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Jessepan123456/DNS" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJessepan123456%2FDNS", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJessepan123456%2FDNS'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 99d3ce4e73eb9b8f38f0966126006197f285b46d [INFO] checking Jessepan123456/DNS against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJessepan123456%2FDNS" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Jessepan123456/DNS [INFO] finished tweaking git repo https://github.com/Jessepan123456/DNS [INFO] tweaked toml for git repo https://github.com/Jessepan123456/DNS written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Jessepan123456/DNS on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Jessepan123456/DNS already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 0945c7bd7cb495b478c807d145209ba38372a36e01d920a9d48749e8b7ba595c [INFO] running `Command { std: "docker" "start" "0945c7bd7cb495b478c807d145209ba38372a36e01d920a9d48749e8b7ba595c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0945c7bd7cb495b478c807d145209ba38372a36e01d920a9d48749e8b7ba595c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "0945c7bd7cb495b478c807d145209ba38372a36e01d920a9d48749e8b7ba595c" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0945c7bd7cb495b478c807d145209ba38372a36e01d920a9d48749e8b7ba595c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "0945c7bd7cb495b478c807d145209ba38372a36e01d920a9d48749e8b7ba595c" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Checking DNS v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/DNS/packetbuffer.rs:41:24 [INFO] [stdout] | [INFO] [stdout] 41 | return Err("End of buffer(read)".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 41 - return Err("End of buffer(read)".into()); [INFO] [stdout] 41 + return Err("End of buffer(read)"); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 41 - return Err("End of buffer(read)".into()); [INFO] [stdout] 41 + return Err(<&str as Into<_>>::into("End of buffer(read)")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/DNS/packetbuffer.rs:52:24 [INFO] [stdout] | [INFO] [stdout] 52 | return Err("End of buffer(get)".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 52 - return Err("End of buffer(get)".into()); [INFO] [stdout] 52 + return Err("End of buffer(get)"); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 52 - return Err("End of buffer(get)".into()); [INFO] [stdout] 52 + return Err(<&str as Into<_>>::into("End of buffer(get)")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/DNS/packetbuffer.rs:60:24 [INFO] [stdout] | [INFO] [stdout] 60 | return Err("End of buffer(get_range)".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 60 - return Err("End of buffer(get_range)".into()); [INFO] [stdout] 60 + return Err("End of buffer(get_range)"); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 60 - return Err("End of buffer(get_range)".into()); [INFO] [stdout] 60 + return Err(<&str as Into<_>>::into("End of buffer(get_range)")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `String` [INFO] [stdout] --> src/DNS/packetbuffer.rs:98:28 [INFO] [stdout] | [INFO] [stdout] 98 | return Err(format!("Limit of {} jumps exceeded", max_jumps).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/DNS/Body/dnsrecord.rs:263:17 [INFO] [stdout] | [INFO] [stdout] 263 | buffer.write_u8(text_bytes.len() as u8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 263 | let _ = buffer.write_u8(text_bytes.len() as u8); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `DNS` (lib test) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/DNS/packetbuffer.rs:41:24 [INFO] [stdout] | [INFO] [stdout] 41 | return Err("End of buffer(read)".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 41 - return Err("End of buffer(read)".into()); [INFO] [stdout] 41 + return Err("End of buffer(read)"); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 41 - return Err("End of buffer(read)".into()); [INFO] [stdout] 41 + return Err(<&str as Into<_>>::into("End of buffer(read)")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/DNS/packetbuffer.rs:52:24 [INFO] [stdout] | [INFO] [stdout] 52 | return Err("End of buffer(get)".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 52 - return Err("End of buffer(get)".into()); [INFO] [stdout] 52 + return Err("End of buffer(get)"); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 52 - return Err("End of buffer(get)".into()); [INFO] [stdout] 52 + return Err(<&str as Into<_>>::into("End of buffer(get)")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/DNS/packetbuffer.rs:60:24 [INFO] [stdout] | [INFO] [stdout] 60 | return Err("End of buffer(get_range)".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 60 - return Err("End of buffer(get_range)".into()); [INFO] [stdout] 60 + return Err("End of buffer(get_range)"); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 60 - return Err("End of buffer(get_range)".into()); [INFO] [stdout] 60 + return Err(<&str as Into<_>>::into("End of buffer(get_range)")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `String` [INFO] [stdout] --> src/DNS/packetbuffer.rs:98:28 [INFO] [stdout] | [INFO] [stdout] 98 | return Err(format!("Limit of {} jumps exceeded", max_jumps).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: crate `DNS` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = help: convert the identifier to snake case: `dns` [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/DNS/Body/dnsrecord.rs:263:17 [INFO] [stdout] | [INFO] [stdout] 263 | buffer.write_u8(text_bytes.len() as u8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 263 | let _ = buffer.write_u8(text_bytes.len() as u8); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `DNS` (lib) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0945c7bd7cb495b478c807d145209ba38372a36e01d920a9d48749e8b7ba595c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0945c7bd7cb495b478c807d145209ba38372a36e01d920a9d48749e8b7ba595c", kill_on_drop: false }` [INFO] [stdout] 0945c7bd7cb495b478c807d145209ba38372a36e01d920a9d48749e8b7ba595c