[INFO] cloning repository https://github.com/Jaltaire/pg-connection-string [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Jaltaire/pg-connection-string" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJaltaire%2Fpg-connection-string", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJaltaire%2Fpg-connection-string'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1e9a6c1e8243bb427dcb771c7c5e5ea85c8275be [INFO] checking Jaltaire/pg-connection-string against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJaltaire%2Fpg-connection-string" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Jaltaire/pg-connection-string [INFO] finished tweaking git repo https://github.com/Jaltaire/pg-connection-string [INFO] tweaked toml for git repo https://github.com/Jaltaire/pg-connection-string written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Jaltaire/pg-connection-string on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Jaltaire/pg-connection-string already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 54ebfceadd9a61d5fc77af8dd53ac03abe82d16a622d06f704695640094b3341 [INFO] running `Command { std: "docker" "start" "54ebfceadd9a61d5fc77af8dd53ac03abe82d16a622d06f704695640094b3341", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "54ebfceadd9a61d5fc77af8dd53ac03abe82d16a622d06f704695640094b3341", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "54ebfceadd9a61d5fc77af8dd53ac03abe82d16a622d06f704695640094b3341" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "54ebfceadd9a61d5fc77af8dd53ac03abe82d16a622d06f704695640094b3341", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "54ebfceadd9a61d5fc77af8dd53ac03abe82d16a622d06f704695640094b3341" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling anyhow v1.0.71 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking pg-connection-string v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: useless conversion to the same type: `Host` [INFO] [stdout] --> src/parser/authority/host.rs:80:23 [INFO] [stdout] | [INFO] [stdout] 80 | host: host.map(std::convert::Into::into), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 80 - host: host.map(std::convert::Into::into), [INFO] [stdout] 80 + host: host, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pg-connection-string` (lib) due to 1 previous error [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/parser/authority/host.rs:288:13 [INFO] [stdout] | [INFO] [stdout] 288 | for input in &[",", ",host:123"] {} [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `parser::authority::host::Host` [INFO] [stdout] --> src/parser/authority/host.rs:80:23 [INFO] [stdout] | [INFO] [stdout] 80 | host: host.map(std::convert::Into::into), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 80 - host: host.map(std::convert::Into::into), [INFO] [stdout] 80 + host: host, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/parser/query.rs:91:23 [INFO] [stdout] | [INFO] [stdout] 91 | (rem, expect.into()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 91 - (rem, expect.into()), [INFO] [stdout] 91 + (rem, expect), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 91 - (rem, expect.into()), [INFO] [stdout] 91 + (rem, <&str as Into<_>>::into(expect)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/parser/query.rs:122:25 [INFO] [stdout] | [INFO] [stdout] 122 | ("%20", "", "20".into()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 122 - ("%20", "", "20".into()), [INFO] [stdout] 122 + ("%20", "", "20"), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 122 - ("%20", "", "20".into()), [INFO] [stdout] 122 + ("%20", "", <&str as Into<_>>::into("20")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/parser/query.rs:123:25 [INFO] [stdout] | [INFO] [stdout] 123 | ("%3D", "", "3D".into()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 123 - ("%3D", "", "3D".into()), [INFO] [stdout] 123 + ("%3D", "", "3D"), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 123 - ("%3D", "", "3D".into()), [INFO] [stdout] 123 + ("%3D", "", <&str as Into<_>>::into("3D")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/parser/query.rs:124:25 [INFO] [stdout] | [INFO] [stdout] 124 | ("%3d", "", "3d".into()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 124 - ("%3d", "", "3d".into()), [INFO] [stdout] 124 + ("%3d", "", "3d"), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 124 - ("%3d", "", "3d".into()), [INFO] [stdout] 124 + ("%3d", "", <&str as Into<_>>::into("3d")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/parser/query.rs:125:27 [INFO] [stdout] | [INFO] [stdout] 125 | ("%3D1", "1", "3D".into()), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 125 - ("%3D1", "1", "3D".into()), [INFO] [stdout] 125 + ("%3D1", "1", "3D"), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 125 - ("%3D1", "1", "3D".into()), [INFO] [stdout] 125 + ("%3D1", "1", <&str as Into<_>>::into("3D")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pg-connection-string` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "54ebfceadd9a61d5fc77af8dd53ac03abe82d16a622d06f704695640094b3341", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54ebfceadd9a61d5fc77af8dd53ac03abe82d16a622d06f704695640094b3341", kill_on_drop: false }` [INFO] [stdout] 54ebfceadd9a61d5fc77af8dd53ac03abe82d16a622d06f704695640094b3341