[INFO] cloning repository https://github.com/HimakshP/mini-redis-tokio [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/HimakshP/mini-redis-tokio" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHimakshP%2Fmini-redis-tokio", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHimakshP%2Fmini-redis-tokio'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dca707f96d0020f35e7d70e943ea49c02885d3c9 [INFO] checking HimakshP/mini-redis-tokio against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHimakshP%2Fmini-redis-tokio" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/HimakshP/mini-redis-tokio [INFO] finished tweaking git repo https://github.com/HimakshP/mini-redis-tokio [INFO] tweaked toml for git repo https://github.com/HimakshP/mini-redis-tokio written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/HimakshP/mini-redis-tokio on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/HimakshP/mini-redis-tokio already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 9c40459fa333661b05e98d44f0b5a0e48341979a6a6d46643f24843e780c4273 [INFO] running `Command { std: "docker" "start" "9c40459fa333661b05e98d44f0b5a0e48341979a6a6d46643f24843e780c4273", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9c40459fa333661b05e98d44f0b5a0e48341979a6a6d46643f24843e780c4273", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "9c40459fa333661b05e98d44f0b5a0e48341979a6a6d46643f24843e780c4273" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9c40459fa333661b05e98d44f0b5a0e48341979a6a6d46643f24843e780c4273", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "9c40459fa333661b05e98d44f0b5a0e48341979a6a6d46643f24843e780c4273" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking bytes v1.11.0 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking atoi v0.3.3 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking mini-redis v0.4.1 [INFO] [stderr] Checking redis-tuto v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `frames` [INFO] [stdout] --> src/connection.rs:123:26 [INFO] [stdout] | [INFO] [stdout] 123 | Frame::Array(frames) => todo!(), [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_frames` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/connection.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 16 | impl Connection { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] 17 | fn new(stream: TcpStream) -> Connection { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `frames` [INFO] [stdout] --> src/connection.rs:123:26 [INFO] [stdout] | [INFO] [stdout] 123 | Frame::Array(frames) => todo!(), [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_frames` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/connection.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 16 | impl Connection { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] 17 | fn new(stream: TcpStream) -> Connection { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/connection.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | self.stream.flush().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 125 | let _ = self.stream.flush().await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/connection.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | self.stream.flush().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 125 | let _ = self.stream.flush().await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Command`, `Set`, and `self` [INFO] [stdout] --> src/bin/server.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | Command, Connection, Frame, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 9 | cmd::{self, Set}, [INFO] [stdout] | ^^^^ ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/bin/server.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Command`, `Set`, and `self` [INFO] [stdout] --> src/bin/server.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | Command, Connection, Frame, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 9 | cmd::{self, Set}, [INFO] [stdout] | ^^^^ ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/bin/server.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `bytes::Bytes` [INFO] [stdout] --> src/bin/server.rs:50:33 [INFO] [stdout] | [INFO] [stdout] 50 | Frame::Bulk(value.clone().into()) // getting the value of key via clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 50 - Frame::Bulk(value.clone().into()) // getting the value of key via clone() [INFO] [stdout] 50 + Frame::Bulk(value.clone()) // getting the value of key via clone() [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 50 - Frame::Bulk(value.clone().into()) // getting the value of key via clone() [INFO] [stdout] 50 + Frame::Bulk(>::into(value.clone())) // getting the value of key via clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redis-tuto` (bin "server") due to 1 previous error; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: useless conversion to the same type: `bytes::Bytes` [INFO] [stdout] --> src/bin/server.rs:50:33 [INFO] [stdout] | [INFO] [stdout] 50 | Frame::Bulk(value.clone().into()) // getting the value of key via clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 50 - Frame::Bulk(value.clone().into()) // getting the value of key via clone() [INFO] [stdout] 50 + Frame::Bulk(value.clone()) // getting the value of key via clone() [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 50 - Frame::Bulk(value.clone().into()) // getting the value of key via clone() [INFO] [stdout] 50 + Frame::Bulk(>::into(value.clone())) // getting the value of key via clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redis-tuto` (bin "server" test) due to 1 previous error; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9c40459fa333661b05e98d44f0b5a0e48341979a6a6d46643f24843e780c4273", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c40459fa333661b05e98d44f0b5a0e48341979a6a6d46643f24843e780c4273", kill_on_drop: false }` [INFO] [stdout] 9c40459fa333661b05e98d44f0b5a0e48341979a6a6d46643f24843e780c4273