[INFO] cloning repository https://github.com/Hexorg/rust-planner [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Hexorg/rust-planner" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHexorg%2Frust-planner", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHexorg%2Frust-planner'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5c242d5185095bdc9c447b7ac725fc8e03fb9bc1 [INFO] checking Hexorg/rust-planner against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHexorg%2Frust-planner" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Hexorg/rust-planner [INFO] finished tweaking git repo https://github.com/Hexorg/rust-planner [INFO] tweaked toml for git repo https://github.com/Hexorg/rust-planner written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Hexorg/rust-planner on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Hexorg/rust-planner already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 99da2aa6fbd052843e2ea9140ad118f242adc7d6be45161b8c25f48691483840 [INFO] running `Command { std: "docker" "start" "99da2aa6fbd052843e2ea9140ad118f242adc7d6be45161b8c25f48691483840", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "99da2aa6fbd052843e2ea9140ad118f242adc7d6be45161b8c25f48691483840", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "99da2aa6fbd052843e2ea9140ad118f242adc7d6be45161b8c25f48691483840" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "99da2aa6fbd052843e2ea9140ad118f242adc7d6be45161b8c25f48691483840", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "99da2aa6fbd052843e2ea9140ad118f242adc7d6be45161b8c25f48691483840" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling priority-queue v1.2.2 [INFO] [stderr] Checking hashbrown v0.12.2 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking filename v0.1.1 [INFO] [stderr] Checking htn_planner v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: named argument `depth` is not used by name [INFO] [stdout] --> src/htn/parser/statement.rs:61:49 [INFO] [stdout] | [INFO] [stdout] 61 | write!(self.f, "{:>depth$}task {}", "", depth=self.depth)?; [INFO] [stdout] | -- ^^^^^ this named argument is referred to by position in formatting string [INFO] [stdout] | | [INFO] [stdout] | this formatting argument uses named argument `depth` by position [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(named_arguments_used_positionally)]` on by default [INFO] [stdout] help: use the named argument by name to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 61 | write!(self.f, "{:>depth$}task {depth}", "", depth=self.depth)?; [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TaskBody` [INFO] [stdout] --> src/htn/domain.rs:4:35 [INFO] [stdout] | [INFO] [stdout] 4 | use super::compiler::{Task, self, TaskBody}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `iter::Map` and `slice::Iter` [INFO] [stdout] --> src/htn/compiler/domain.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{collections::HashMap, slice::Iter, iter::Map}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/htn/parser/lexer.rs:197:53 [INFO] [stdout] | [INFO] [stdout] 197 | while let Some(_) = self.it.next_if(|(_,c)| (c.is_alphanumeric() || *c == '_')) { len += 1; } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 197 - while let Some(_) = self.it.next_if(|(_,c)| (c.is_alphanumeric() || *c == '_')) { len += 1; } [INFO] [stdout] 197 + while let Some(_) = self.it.next_if(|(_,c)| c.is_alphanumeric() || *c == '_') { len += 1; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: named argument `depth` is not used by name [INFO] [stdout] --> src/htn/parser/statement.rs:61:49 [INFO] [stdout] | [INFO] [stdout] 61 | write!(self.f, "{:>depth$}task {}", "", depth=self.depth)?; [INFO] [stdout] | -- ^^^^^ this named argument is referred to by position in formatting string [INFO] [stdout] | | [INFO] [stdout] | this formatting argument uses named argument `depth` by position [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(named_arguments_used_positionally)]` on by default [INFO] [stdout] help: use the named argument by name to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 61 | write!(self.f, "{:>depth$}task {depth}", "", depth=self.depth)?; [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TaskBody` [INFO] [stdout] --> src/htn/domain.rs:4:35 [INFO] [stdout] | [INFO] [stdout] 4 | use super::compiler::{Task, self, TaskBody}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `iter::Map` and `slice::Iter` [INFO] [stdout] --> src/htn/compiler/domain.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{collections::HashMap, slice::Iter, iter::Map}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/htn/parser/lexer.rs:197:53 [INFO] [stdout] | [INFO] [stdout] 197 | while let Some(_) = self.it.next_if(|(_,c)| (c.is_alphanumeric() || *c == '_')) { len += 1; } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 197 - while let Some(_) = self.it.next_if(|(_,c)| (c.is_alphanumeric() || *c == '_')) { len += 1; } [INFO] [stdout] 197 + while let Some(_) = self.it.next_if(|(_,c)| c.is_alphanumeric() || *c == '_') { len += 1; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/htn/parser.rs:83:22 [INFO] [stdout] | [INFO] [stdout] 83 | Some(Err(e)) => Err(self.lexer.next().unwrap().unwrap_err()), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `On` [INFO] [stdout] --> src/htn/parser.rs:260:75 [INFO] [stdout] | [INFO] [stdout] 260 | let variable = if self.lexer.next_if(|t| match t { Ok(Token{t:On,..})=>true,_=>false}).is_some() { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] help: you might have meant to pattern match on the similarly named variant `Or` [INFO] [stdout] | [INFO] [stdout] 260 - let variable = if self.lexer.next_if(|t| match t { Ok(Token{t:On,..})=>true,_=>false}).is_some() { [INFO] [stdout] 260 + let variable = if self.lexer.next_if(|t| match t { Ok(Token{t:htn::parser::tokens::TokenData::Or,..})=>true,_=>false}).is_some() { [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 260 | let variable = if self.lexer.next_if(|t| match t { Ok(Token{t:_On,..})=>true,_=>false}).is_some() { [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/htn/search.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 52 | while let Some((mut current, total_plan_cost)) = open_set.pop() { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `i32` [INFO] [stdout] --> src/htn/search.rs:45:63 [INFO] [stdout] | [INFO] [stdout] 45 | cheapest_known_cost_to_state.insert(start.state.clone(), 0.into()); // Cost to reach N [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 45 - cheapest_known_cost_to_state.insert(start.state.clone(), 0.into()); // Cost to reach N [INFO] [stdout] 45 + cheapest_known_cost_to_state.insert(start.state.clone(), 0); // Cost to reach N [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 45 - cheapest_known_cost_to_state.insert(start.state.clone(), 0.into()); // Cost to reach N [INFO] [stdout] 45 + cheapest_known_cost_to_state.insert(start.state.clone(), >::into(0)); // Cost to reach N [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/htn/planner.rs:62:22 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn new_state(&self) -> State { [INFO] [stdout] | ^^^^^ ^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 62 | pub fn new_state(&self) -> State<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `On` should have a snake case name [INFO] [stdout] --> src/htn/parser.rs:260:75 [INFO] [stdout] | [INFO] [stdout] 260 | let variable = if self.lexer.next_if(|t| match t { Ok(Token{t:On,..})=>true,_=>false}).is_some() { [INFO] [stdout] | ^^ help: convert the identifier to snake case (notice the capitalization): `on` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/htn/parser/tokens.rs:148:27 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn unwrap_literal(&self) -> Literal { [INFO] [stdout] | ^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 148 | pub fn unwrap_literal(&self) -> Literal<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `htn_planner` (lib) due to 1 previous error; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/htn/parser.rs:83:22 [INFO] [stdout] | [INFO] [stdout] 83 | Some(Err(e)) => Err(self.lexer.next().unwrap().unwrap_err()), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `On` [INFO] [stdout] --> src/htn/parser.rs:260:75 [INFO] [stdout] | [INFO] [stdout] 260 | let variable = if self.lexer.next_if(|t| match t { Ok(Token{t:On,..})=>true,_=>false}).is_some() { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] help: you might have meant to pattern match on the similarly named variant `Or` [INFO] [stdout] | [INFO] [stdout] 260 - let variable = if self.lexer.next_if(|t| match t { Ok(Token{t:On,..})=>true,_=>false}).is_some() { [INFO] [stdout] 260 + let variable = if self.lexer.next_if(|t| match t { Ok(Token{t:htn::parser::tokens::TokenData::Or,..})=>true,_=>false}).is_some() { [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 260 | let variable = if self.lexer.next_if(|t| match t { Ok(Token{t:_On,..})=>true,_=>false}).is_some() { [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/htn/search.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 52 | while let Some((mut current, total_plan_cost)) = open_set.pop() { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `i32` [INFO] [stdout] --> src/htn/search.rs:45:63 [INFO] [stdout] | [INFO] [stdout] 45 | cheapest_known_cost_to_state.insert(start.state.clone(), 0.into()); // Cost to reach N [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 45 - cheapest_known_cost_to_state.insert(start.state.clone(), 0.into()); // Cost to reach N [INFO] [stdout] 45 + cheapest_known_cost_to_state.insert(start.state.clone(), 0); // Cost to reach N [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 45 - cheapest_known_cost_to_state.insert(start.state.clone(), 0.into()); // Cost to reach N [INFO] [stdout] 45 + cheapest_known_cost_to_state.insert(start.state.clone(), >::into(0)); // Cost to reach N [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/htn/planner.rs:62:22 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn new_state(&self) -> State { [INFO] [stdout] | ^^^^^ ^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 62 | pub fn new_state(&self) -> State<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `On` should have a snake case name [INFO] [stdout] --> src/htn/parser.rs:260:75 [INFO] [stdout] | [INFO] [stdout] 260 | let variable = if self.lexer.next_if(|t| match t { Ok(Token{t:On,..})=>true,_=>false}).is_some() { [INFO] [stdout] | ^^ help: convert the identifier to snake case (notice the capitalization): `on` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/htn/parser/tokens.rs:148:27 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn unwrap_literal(&self) -> Literal { [INFO] [stdout] | ^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 148 | pub fn unwrap_literal(&self) -> Literal<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `htn_planner` (lib test) due to 1 previous error; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "99da2aa6fbd052843e2ea9140ad118f242adc7d6be45161b8c25f48691483840", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "99da2aa6fbd052843e2ea9140ad118f242adc7d6be45161b8c25f48691483840", kill_on_drop: false }` [INFO] [stdout] 99da2aa6fbd052843e2ea9140ad118f242adc7d6be45161b8c25f48691483840