[INFO] cloning repository https://github.com/FreeSamples00/credential_playground [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/FreeSamples00/credential_playground" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFreeSamples00%2Fcredential_playground", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFreeSamples00%2Fcredential_playground'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 224437402fdfd97f9e0a3b2a86330ea1f7261f02 [INFO] checking FreeSamples00/credential_playground against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFreeSamples00%2Fcredential_playground" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/FreeSamples00/credential_playground [INFO] finished tweaking git repo https://github.com/FreeSamples00/credential_playground [INFO] tweaked toml for git repo https://github.com/FreeSamples00/credential_playground written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/FreeSamples00/credential_playground on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/FreeSamples00/credential_playground already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 6c5b2217a69ec3dc37d30a697462bd3914587979a59fc5346bcf2150ef6d1211 [INFO] running `Command { std: "docker" "start" "6c5b2217a69ec3dc37d30a697462bd3914587979a59fc5346bcf2150ef6d1211", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6c5b2217a69ec3dc37d30a697462bd3914587979a59fc5346bcf2150ef6d1211", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "6c5b2217a69ec3dc37d30a697462bd3914587979a59fc5346bcf2150ef6d1211" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6c5b2217a69ec3dc37d30a697462bd3914587979a59fc5346bcf2150ef6d1211", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "6c5b2217a69ec3dc37d30a697462bd3914587979a59fc5346bcf2150ef6d1211" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Compiling zerocopy v0.8.25 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking cfg-if v1.0.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking rtoolbox v0.0.3 [INFO] [stderr] Checking rpassword v7.4.0 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.1 [INFO] [stderr] Checking credential_playground v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/auth_utils.rs:179:40 [INFO] [stdout] | [INFO] [stdout] 179 | self.cred_hashmap.contains_key(username.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 179 - self.cred_hashmap.contains_key(username.into()) [INFO] [stdout] 179 + self.cred_hashmap.contains_key(username) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 179 - self.cred_hashmap.contains_key(username.into()) [INFO] [stdout] 179 + self.cred_hashmap.contains_key(<&str as Into<_>>::into(username)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/auth_utils.rs:188:31 [INFO] [stdout] | [INFO] [stdout] 188 | self.cred_hashmap.get(username.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 188 - self.cred_hashmap.get(username.into()) [INFO] [stdout] 188 + self.cred_hashmap.get(username) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 188 - self.cred_hashmap.get(username.into()) [INFO] [stdout] 188 + self.cred_hashmap.get(<&str as Into<_>>::into(username)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/auth_utils.rs:205:34 [INFO] [stdout] | [INFO] [stdout] 205 | self.cred_hashmap.remove(username.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 205 - self.cred_hashmap.remove(username.into()); [INFO] [stdout] 205 + self.cred_hashmap.remove(username); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 205 - self.cred_hashmap.remove(username.into()); [INFO] [stdout] 205 + self.cred_hashmap.remove(<&str as Into<_>>::into(username)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `credential_playground` (bin "credential_playground" test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/auth_utils.rs:179:40 [INFO] [stdout] | [INFO] [stdout] 179 | self.cred_hashmap.contains_key(username.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 179 - self.cred_hashmap.contains_key(username.into()) [INFO] [stdout] 179 + self.cred_hashmap.contains_key(username) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 179 - self.cred_hashmap.contains_key(username.into()) [INFO] [stdout] 179 + self.cred_hashmap.contains_key(<&str as Into<_>>::into(username)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/auth_utils.rs:188:31 [INFO] [stdout] | [INFO] [stdout] 188 | self.cred_hashmap.get(username.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 188 - self.cred_hashmap.get(username.into()) [INFO] [stdout] 188 + self.cred_hashmap.get(username) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 188 - self.cred_hashmap.get(username.into()) [INFO] [stdout] 188 + self.cred_hashmap.get(<&str as Into<_>>::into(username)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/auth_utils.rs:205:34 [INFO] [stdout] | [INFO] [stdout] 205 | self.cred_hashmap.remove(username.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 205 - self.cred_hashmap.remove(username.into()); [INFO] [stdout] 205 + self.cred_hashmap.remove(username); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 205 - self.cred_hashmap.remove(username.into()); [INFO] [stdout] 205 + self.cred_hashmap.remove(<&str as Into<_>>::into(username)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `credential_playground` (bin "credential_playground") due to 3 previous errors [INFO] [stderr] warning: unused dependency `hex` [INFO] [stderr] --> Cargo.toml:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | hex = "0.4.3" [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `cargo::unused_dependencies` is set to `warn` by default [INFO] [stderr] help: consider removing the dependency on `hex` [INFO] [stderr] warning: unused dependency `rand` [INFO] [stderr] --> Cargo.toml:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | rand = "0.9.1" [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider removing the dependency on `rand` [INFO] [stderr] warning: `credential_playground` (manifest) generated 2 warnings [INFO] running `Command { std: "docker" "inspect" "6c5b2217a69ec3dc37d30a697462bd3914587979a59fc5346bcf2150ef6d1211", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c5b2217a69ec3dc37d30a697462bd3914587979a59fc5346bcf2150ef6d1211", kill_on_drop: false }` [INFO] [stdout] 6c5b2217a69ec3dc37d30a697462bd3914587979a59fc5346bcf2150ef6d1211