[INFO] cloning repository https://github.com/FrankBosman/Advent_Of_Code_2021 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/FrankBosman/Advent_Of_Code_2021" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFrankBosman%2FAdvent_Of_Code_2021", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFrankBosman%2FAdvent_Of_Code_2021'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 76a79a611a26f7be8963fa8c1536e15b7de800da [INFO] checking FrankBosman/Advent_Of_Code_2021 against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFrankBosman%2FAdvent_Of_Code_2021" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/FrankBosman/Advent_Of_Code_2021 [INFO] finished tweaking git repo https://github.com/FrankBosman/Advent_Of_Code_2021 [INFO] tweaked toml for git repo https://github.com/FrankBosman/Advent_Of_Code_2021 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/FrankBosman/Advent_Of_Code_2021 on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/FrankBosman/Advent_Of_Code_2021 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 1e4dfa0cd50d7e9fa583f30a7460de50ffff34a9eb1b2ad4706d10c89e428239 [INFO] running `Command { std: "docker" "start" "1e4dfa0cd50d7e9fa583f30a7460de50ffff34a9eb1b2ad4706d10c89e428239", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1e4dfa0cd50d7e9fa583f30a7460de50ffff34a9eb1b2ad4706d10c89e428239", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "1e4dfa0cd50d7e9fa583f30a7460de50ffff34a9eb1b2ad4706d10c89e428239" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1e4dfa0cd50d7e9fa583f30a7460de50ffff34a9eb1b2ad4706d10c89e428239", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "1e4dfa0cd50d7e9fa583f30a7460de50ffff34a9eb1b2ad4706d10c89e428239" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking Advent_Of_Code_2021 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: crate `Advent_Of_Code_2021` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = help: convert the identifier to snake case: `advent_of_code_2021` [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/day4/day4.rs:77:29 [INFO] [stdout] | [INFO] [stdout] 77 | losing_number = numbers[(number_index - 1)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 77 - losing_number = numbers[(number_index - 1)]; [INFO] [stdout] 77 + losing_number = numbers[number_index - 1]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/day4/day4.rs:77:29 [INFO] [stdout] | [INFO] [stdout] 77 | losing_number = numbers[(number_index - 1)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 77 - losing_number = numbers[(number_index - 1)]; [INFO] [stdout] 77 + losing_number = numbers[number_index - 1]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `losing_number` is never read [INFO] [stdout] --> src/day4/day4.rs:68:29 [INFO] [stdout] | [INFO] [stdout] 68 | let mut losing_number = 0; [INFO] [stdout] | ^ this value is reassigned later and never used [INFO] [stdout] ... [INFO] [stdout] 77 | losing_number = numbers[(number_index - 1)]; [INFO] [stdout] | ------------------------------------------- `losing_number` is overwritten here before the previous value is read [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `losing_number` is never read [INFO] [stdout] --> src/day4/day4.rs:68:29 [INFO] [stdout] | [INFO] [stdout] 68 | let mut losing_number = 0; [INFO] [stdout] | ^ this value is reassigned later and never used [INFO] [stdout] ... [INFO] [stdout] 77 | losing_number = numbers[(number_index - 1)]; [INFO] [stdout] | ------------------------------------------- `losing_number` is overwritten here before the previous value is read [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/day12/day12.rs:39:31 [INFO] [stdout] | [INFO] [stdout] 39 | if !cave.contains_key(name1.into()) {cave.insert(name1.into(), RefCell::new(Node::new(name1.into())));} [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 39 - if !cave.contains_key(name1.into()) {cave.insert(name1.into(), RefCell::new(Node::new(name1.into())));} [INFO] [stdout] 39 + if !cave.contains_key(name1) {cave.insert(name1.into(), RefCell::new(Node::new(name1.into())));} [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 39 - if !cave.contains_key(name1.into()) {cave.insert(name1.into(), RefCell::new(Node::new(name1.into())));} [INFO] [stdout] 39 + if !cave.contains_key(<&str as Into<_>>::into(name1)) {cave.insert(name1.into(), RefCell::new(Node::new(name1.into())));} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/day12/day12.rs:40:31 [INFO] [stdout] | [INFO] [stdout] 40 | if !cave.contains_key(name2.into()) {cave.insert(name2.into(), RefCell::new(Node::new(name2.into())));} [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 40 - if !cave.contains_key(name2.into()) {cave.insert(name2.into(), RefCell::new(Node::new(name2.into())));} [INFO] [stdout] 40 + if !cave.contains_key(name2) {cave.insert(name2.into(), RefCell::new(Node::new(name2.into())));} [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 40 - if !cave.contains_key(name2.into()) {cave.insert(name2.into(), RefCell::new(Node::new(name2.into())));} [INFO] [stdout] 40 + if !cave.contains_key(<&str as Into<_>>::into(name2)) {cave.insert(name2.into(), RefCell::new(Node::new(name2.into())));} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/day12/day12.rs:43:30 [INFO] [stdout] | [INFO] [stdout] 43 | let node1 = cave.get(name1.into()).unwrap().borrow_mut(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 43 - let node1 = cave.get(name1.into()).unwrap().borrow_mut(); [INFO] [stdout] 43 + let node1 = cave.get(name1).unwrap().borrow_mut(); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 43 - let node1 = cave.get(name1.into()).unwrap().borrow_mut(); [INFO] [stdout] 43 + let node1 = cave.get(<&str as Into<_>>::into(name1)).unwrap().borrow_mut(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/day12/day12.rs:44:30 [INFO] [stdout] | [INFO] [stdout] 44 | let node2 = cave.get(name2.into()).unwrap().borrow_mut(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 44 - let node2 = cave.get(name2.into()).unwrap().borrow_mut(); [INFO] [stdout] 44 + let node2 = cave.get(name2).unwrap().borrow_mut(); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 44 - let node2 = cave.get(name2.into()).unwrap().borrow_mut(); [INFO] [stdout] 44 + let node2 = cave.get(<&str as Into<_>>::into(name2)).unwrap().borrow_mut(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&String` [INFO] [stdout] --> src/day12/day12.rs:75:33 [INFO] [stdout] | [INFO] [stdout] 75 | let node = cave.get(connection.into()).unwrap().borrow(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 75 - let node = cave.get(connection.into()).unwrap().borrow(); [INFO] [stdout] 75 + let node = cave.get(connection).unwrap().borrow(); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 75 - let node = cave.get(connection.into()).unwrap().borrow(); [INFO] [stdout] 75 + let node = cave.get(<&String as Into<_>>::into(connection)).unwrap().borrow(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&String` [INFO] [stdout] --> src/day12/day12.rs:94:33 [INFO] [stdout] | [INFO] [stdout] 94 | let node = cave.get(connection.into()).unwrap().borrow(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 94 - let node = cave.get(connection.into()).unwrap().borrow(); [INFO] [stdout] 94 + let node = cave.get(connection).unwrap().borrow(); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 94 - let node = cave.get(connection.into()).unwrap().borrow(); [INFO] [stdout] 94 + let node = cave.get(<&String as Into<_>>::into(connection)).unwrap().borrow(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `Advent_Of_Code_2021` (bin "day12") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "1e4dfa0cd50d7e9fa583f30a7460de50ffff34a9eb1b2ad4706d10c89e428239", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e4dfa0cd50d7e9fa583f30a7460de50ffff34a9eb1b2ad4706d10c89e428239", kill_on_drop: false }` [INFO] [stdout] 1e4dfa0cd50d7e9fa583f30a7460de50ffff34a9eb1b2ad4706d10c89e428239