[INFO] cloning repository https://github.com/FishAndRips/minxp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/FishAndRips/minxp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFishAndRips%2Fminxp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFishAndRips%2Fminxp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 32cb9a0d2e958dd3246093468d0c8a1379a2ba42 [INFO] checking FishAndRips/minxp against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFishAndRips%2Fminxp" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/FishAndRips/minxp [INFO] finished tweaking git repo https://github.com/FishAndRips/minxp [INFO] tweaked toml for git repo https://github.com/FishAndRips/minxp written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/FishAndRips/minxp on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/FishAndRips/minxp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 3aa346cceb835f8332f28e93c8c83273cd6f4e1a2a6b3b9d9fdd2de220f494b9 [INFO] running `Command { std: "docker" "start" "3aa346cceb835f8332f28e93c8c83273cd6f4e1a2a6b3b9d9fdd2de220f494b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3aa346cceb835f8332f28e93c8c83273cd6f4e1a2a6b3b9d9fdd2de220f494b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "3aa346cceb835f8332f28e93c8c83273cd6f4e1a2a6b3b9d9fdd2de220f494b9" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3aa346cceb835f8332f28e93c8c83273cd6f4e1a2a6b3b9d9fdd2de220f494b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "3aa346cceb835f8332f28e93c8c83273cd6f4e1a2a6b3b9d9fdd2de220f494b9" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Compiling windows_x86_64_gnu v0.52.6 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling minxp v0.1.7 (/opt/rustwide/workdir) [INFO] [stderr] Checking windows-targets v0.52.6 [INFO] [stderr] Checking windows-sys v0.59.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking spin v0.10.0 [INFO] [stdout] error: useless conversion to the same type: `String` [INFO] [stdout] --> src/env/vars.rs:146:8 [INFO] [stdout] | [INFO] [stdout] 146 | Ok(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 146 - Ok(v.into()) [INFO] [stdout] 146 + Ok(v) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 146 - Ok(v.into()) [INFO] [stdout] 146 + Ok(>::into(v)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minxp` (lib) due to 1 previous error [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: useless conversion to the same type: `alloc::string::String` [INFO] [stdout] --> src/env/vars.rs:146:8 [INFO] [stdout] | [INFO] [stdout] 146 | Ok(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 146 - Ok(v.into()) [INFO] [stdout] 146 + Ok(v) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 146 - Ok(v.into()) [INFO] [stdout] 146 + Ok(>::into(v)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minxp` (lib test) due to 1 previous error [INFO] running `Command { std: "docker" "inspect" "3aa346cceb835f8332f28e93c8c83273cd6f4e1a2a6b3b9d9fdd2de220f494b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3aa346cceb835f8332f28e93c8c83273cd6f4e1a2a6b3b9d9fdd2de220f494b9", kill_on_drop: false }` [INFO] [stdout] 3aa346cceb835f8332f28e93c8c83273cd6f4e1a2a6b3b9d9fdd2de220f494b9