[INFO] cloning repository https://github.com/Elianagam/blockchain [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Elianagam/blockchain" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FElianagam%2Fblockchain", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FElianagam%2Fblockchain'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 16af333f91d0a37dd8dadccd24e67988e3394ae6 [INFO] checking Elianagam/blockchain against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FElianagam%2Fblockchain" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Elianagam/blockchain [INFO] finished tweaking git repo https://github.com/Elianagam/blockchain [INFO] tweaked toml for git repo https://github.com/Elianagam/blockchain written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Elianagam/blockchain on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Elianagam/blockchain already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] ded546e2ece63d10dd373ccf85e8e98248cc380c1f5059fca2793c21c74b20ae [INFO] running `Command { std: "docker" "start" "ded546e2ece63d10dd373ccf85e8e98248cc380c1f5059fca2793c21c74b20ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ded546e2ece63d10dd373ccf85e8e98248cc380c1f5059fca2793c21c74b20ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "ded546e2ece63d10dd373ccf85e8e98248cc380c1f5059fca2793c21c74b20ae" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ded546e2ece63d10dd373ccf85e8e98248cc380c1f5059fca2793c21c74b20ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "ded546e2ece63d10dd373ccf85e8e98248cc380c1f5059fca2793c21c74b20ae" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking std-semaphore v0.1.0 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking blake2 v0.9.1 [INFO] [stderr] Checking blockchain v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `pending_records` is never read [INFO] [stdout] --> src/blockchain/blockchain.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Blockchain { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pending_records: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Blockchain` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_student_ids`, `get_student_by_id_mut`, and `get_student_by_id` are never used [INFO] [stdout] --> src/blockchain/world_state.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait WorldState { [INFO] [stdout] | ---------- methods in this trait [INFO] [stdout] 6 | /// Returns all registered student ids [INFO] [stdout] 7 | fn get_student_ids(&self) -> Vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 10 | fn get_student_by_id_mut(&mut self, id: &String) -> Option<&mut Student>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 13 | fn get_student_by_id(&self, id: &String) -> Option<&Student>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `String` [INFO] [stdout] --> src/node.rs:419:13 [INFO] [stdout] | [INFO] [stdout] 419 | from.to_string().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 419 - from.to_string().into(), [INFO] [stdout] 419 + from.to_string(), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 419 - from.to_string().into(), [INFO] [stdout] 419 + >::into(from.to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/encoder.rs:7:39 [INFO] [stdout] | [INFO] [stdout] 7 | let mut message = String::from(msg.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blockchain` (bin "app" test) due to 1 previous error; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `pending_records` is never read [INFO] [stdout] --> src/blockchain/blockchain.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Blockchain { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pending_records: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Blockchain` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_student_ids`, `get_student_by_id_mut`, and `get_student_by_id` are never used [INFO] [stdout] --> src/blockchain/world_state.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait WorldState { [INFO] [stdout] | ---------- methods in this trait [INFO] [stdout] 6 | /// Returns all registered student ids [INFO] [stdout] 7 | fn get_student_ids(&self) -> Vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 10 | fn get_student_by_id_mut(&mut self, id: &String) -> Option<&mut Student>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 13 | fn get_student_by_id(&self, id: &String) -> Option<&Student>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `String` [INFO] [stdout] --> src/node.rs:419:13 [INFO] [stdout] | [INFO] [stdout] 419 | from.to_string().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 419 - from.to_string().into(), [INFO] [stdout] 419 + from.to_string(), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 419 - from.to_string().into(), [INFO] [stdout] 419 + >::into(from.to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/encoder.rs:7:39 [INFO] [stdout] | [INFO] [stdout] 7 | let mut message = String::from(msg.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blockchain` (bin "app") due to 1 previous error; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ded546e2ece63d10dd373ccf85e8e98248cc380c1f5059fca2793c21c74b20ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ded546e2ece63d10dd373ccf85e8e98248cc380c1f5059fca2793c21c74b20ae", kill_on_drop: false }` [INFO] [stdout] ded546e2ece63d10dd373ccf85e8e98248cc380c1f5059fca2793c21c74b20ae