[INFO] cloning repository https://github.com/DeSevilla/rlox [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DeSevilla/rlox" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDeSevilla%2Frlox", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDeSevilla%2Frlox'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b3bf30d76a9d5ff5f1dfb75f27135018becc4dda [INFO] checking DeSevilla/rlox against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDeSevilla%2Frlox" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/DeSevilla/rlox [INFO] finished tweaking git repo https://github.com/DeSevilla/rlox [INFO] tweaked toml for git repo https://github.com/DeSevilla/rlox written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/DeSevilla/rlox on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/DeSevilla/rlox already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 0cae1360e82e775af3a15f39fa1ebc9077d4c3efa1ec6141530241a678d2e49d [INFO] running `Command { std: "docker" "start" "0cae1360e82e775af3a15f39fa1ebc9077d4c3efa1ec6141530241a678d2e49d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0cae1360e82e775af3a15f39fa1ebc9077d4c3efa1ec6141530241a678d2e49d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "0cae1360e82e775af3a15f39fa1ebc9077d4c3efa1ec6141530241a678d2e49d" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0cae1360e82e775af3a15f39fa1ebc9077d4c3efa1ec6141530241a678d2e49d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "0cae1360e82e775af3a15f39fa1ebc9077d4c3efa1ec6141530241a678d2e49d" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking lookahead v0.1.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking rlox v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: useless conversion to the same type: `Stmt` [INFO] [stdout] --> src/parser.rs:96:51 [INFO] [stdout] | [INFO] [stdout] 96 | Some(init) => body = Stmt::Block(vec![init.into(), body]), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 96 - Some(init) => body = Stmt::Block(vec![init.into(), body]), [INFO] [stdout] 96 + Some(init) => body = Stmt::Block(vec![init, body]), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 96 - Some(init) => body = Stmt::Block(vec![init.into(), body]), [INFO] [stdout] 96 + Some(init) => body = Stmt::Block(vec![>::into(init), body]), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/parser.rs:329:81 [INFO] [stdout] | [INFO] [stdout] 329 | _ => {let tok = self.lookahead(0).cloned(); Err(self.error(tok, "Unreachable token type mismatch".into())) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 329 - _ => {let tok = self.lookahead(0).cloned(); Err(self.error(tok, "Unreachable token type mismatch".into())) } [INFO] [stdout] 329 + _ => {let tok = self.lookahead(0).cloned(); Err(self.error(tok, "Unreachable token type mismatch")) } [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 329 - _ => {let tok = self.lookahead(0).cloned(); Err(self.error(tok, "Unreachable token type mismatch".into())) } [INFO] [stdout] 329 + _ => {let tok = self.lookahead(0).cloned(); Err(self.error(tok, <&str as Into<_>>::into("Unreachable token type mismatch"))) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/parser.rs:334:33 [INFO] [stdout] | [INFO] [stdout] 334 | Err(self.error(tok, "Expect expression".into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 334 - Err(self.error(tok, "Expect expression".into())) [INFO] [stdout] 334 + Err(self.error(tok, "Expect expression")) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 334 - Err(self.error(tok, "Expect expression".into())) [INFO] [stdout] 334 + Err(self.error(tok, <&str as Into<_>>::into("Expect expression"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `rlox::Literal` [INFO] [stdout] --> src/interpreter.rs:72:34 [INFO] [stdout] | [INFO] [stdout] 72 | Ok(()) => Ok(Literal::None.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 72 - Ok(()) => Ok(Literal::None.into()), [INFO] [stdout] 72 + Ok(()) => Ok(Literal::None), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 72 - Ok(()) => Ok(Literal::None.into()), [INFO] [stdout] 72 + Ok(()) => Ok(>::into(Literal::None)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/scanner.rs:17:24 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(source: &String) -> Scanner { [INFO] [stdout] | ^^^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(source: &String) -> Scanner<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rlox` (bin "rlox") due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: useless conversion to the same type: `Stmt` [INFO] [stdout] --> src/parser.rs:96:51 [INFO] [stdout] | [INFO] [stdout] 96 | Some(init) => body = Stmt::Block(vec![init.into(), body]), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 96 - Some(init) => body = Stmt::Block(vec![init.into(), body]), [INFO] [stdout] 96 + Some(init) => body = Stmt::Block(vec![init, body]), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 96 - Some(init) => body = Stmt::Block(vec![init.into(), body]), [INFO] [stdout] 96 + Some(init) => body = Stmt::Block(vec![>::into(init), body]), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/parser.rs:329:81 [INFO] [stdout] | [INFO] [stdout] 329 | _ => {let tok = self.lookahead(0).cloned(); Err(self.error(tok, "Unreachable token type mismatch".into())) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 329 - _ => {let tok = self.lookahead(0).cloned(); Err(self.error(tok, "Unreachable token type mismatch".into())) } [INFO] [stdout] 329 + _ => {let tok = self.lookahead(0).cloned(); Err(self.error(tok, "Unreachable token type mismatch")) } [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 329 - _ => {let tok = self.lookahead(0).cloned(); Err(self.error(tok, "Unreachable token type mismatch".into())) } [INFO] [stdout] 329 + _ => {let tok = self.lookahead(0).cloned(); Err(self.error(tok, <&str as Into<_>>::into("Unreachable token type mismatch"))) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/parser.rs:334:33 [INFO] [stdout] | [INFO] [stdout] 334 | Err(self.error(tok, "Expect expression".into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 334 - Err(self.error(tok, "Expect expression".into())) [INFO] [stdout] 334 + Err(self.error(tok, "Expect expression")) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 334 - Err(self.error(tok, "Expect expression".into())) [INFO] [stdout] 334 + Err(self.error(tok, <&str as Into<_>>::into("Expect expression"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `rlox::Literal` [INFO] [stdout] --> src/interpreter.rs:72:34 [INFO] [stdout] | [INFO] [stdout] 72 | Ok(()) => Ok(Literal::None.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 72 - Ok(()) => Ok(Literal::None.into()), [INFO] [stdout] 72 + Ok(()) => Ok(Literal::None), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 72 - Ok(()) => Ok(Literal::None.into()), [INFO] [stdout] 72 + Ok(()) => Ok(>::into(Literal::None)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/scanner.rs:17:24 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(source: &String) -> Scanner { [INFO] [stdout] | ^^^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(source: &String) -> Scanner<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rlox` (bin "rlox" test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "0cae1360e82e775af3a15f39fa1ebc9077d4c3efa1ec6141530241a678d2e49d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0cae1360e82e775af3a15f39fa1ebc9077d4c3efa1ec6141530241a678d2e49d", kill_on_drop: false }` [INFO] [stdout] 0cae1360e82e775af3a15f39fa1ebc9077d4c3efa1ec6141530241a678d2e49d