[INFO] cloning repository https://github.com/DanteHerzlos/rust_script [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DanteHerzlos/rust_script" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDanteHerzlos%2Frust_script", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDanteHerzlos%2Frust_script'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e042b1525624023c274ecce46a4a8fd1cf689766 [INFO] checking DanteHerzlos/rust_script against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDanteHerzlos%2Frust_script" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/DanteHerzlos/rust_script [INFO] finished tweaking git repo https://github.com/DanteHerzlos/rust_script [INFO] tweaked toml for git repo https://github.com/DanteHerzlos/rust_script written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/DanteHerzlos/rust_script on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/DanteHerzlos/rust_script already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 5c2f6492b15a4adf28ac290f5b5d5281b7b3404a8427260803d49f11cef3cfb3 [INFO] running `Command { std: "docker" "start" "5c2f6492b15a4adf28ac290f5b5d5281b7b3404a8427260803d49f11cef3cfb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5c2f6492b15a4adf28ac290f5b5d5281b7b3404a8427260803d49f11cef3cfb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "5c2f6492b15a4adf28ac290f5b5d5281b7b3404a8427260803d49f11cef3cfb3" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5c2f6492b15a4adf28ac290f5b5d5281b7b3404a8427260803d49f11cef3cfb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "5c2f6492b15a4adf28ac290f5b5d5281b7b3404a8427260803d49f11cef3cfb3" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Checking rust_script v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: useless conversion to the same type: `std::rc::Rc` [INFO] [stdout] --> src/parser.rs:228:26 [INFO] [stdout] | [INFO] [stdout] 228 | identifiers.push(ident.into()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 228 - identifiers.push(ident.into()); [INFO] [stdout] 228 + identifiers.push(ident); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 228 - identifiers.push(ident.into()); [INFO] [stdout] 228 + identifiers.push( as Into<_>>::into(ident)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::rc::Rc` [INFO] [stdout] --> src/parser.rs:239:30 [INFO] [stdout] | [INFO] [stdout] 239 | identifiers.push(ident.into()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 239 - identifiers.push(ident.into()); [INFO] [stdout] 239 + identifiers.push(ident); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 239 - identifiers.push(ident.into()); [INFO] [stdout] 239 + identifiers.push( as Into<_>>::into(ident)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::rc::Rc` [INFO] [stdout] --> src/evaluator/mod.rs:88:51 [INFO] [stdout] | [INFO] [stdout] 88 | .set(let_stmt.name.value.clone(), value.unwrap().into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 88 - .set(let_stmt.name.value.clone(), value.unwrap().into()); [INFO] [stdout] 88 + .set(let_stmt.name.value.clone(), value.unwrap()); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 88 - .set(let_stmt.name.value.clone(), value.unwrap().into()); [INFO] [stdout] 88 + .set(let_stmt.name.value.clone(), as Into<_>>::into(value.unwrap())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::rc::Rc` [INFO] [stdout] --> src/evaluator/mod.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 93 | return Some(eval_identifier(node.try_into_identifier().unwrap(), env).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 93 - return Some(eval_identifier(node.try_into_identifier().unwrap(), env).into()); [INFO] [stdout] 93 + return Some(eval_identifier(node.try_into_identifier().unwrap(), env)); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 93 - return Some(eval_identifier(node.try_into_identifier().unwrap(), env).into()); [INFO] [stdout] 93 + return Some( as Into<_>>::into(eval_identifier(node.try_into_identifier().unwrap(), env))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::rc::Rc` [INFO] [stdout] --> src/evaluator/mod.rs:245:25 [INFO] [stdout] | [INFO] [stdout] 245 | return vec![evaluated.unwrap().into()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 245 - return vec![evaluated.unwrap().into()]; [INFO] [stdout] 245 + return vec![evaluated.unwrap()]; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 245 - return vec![evaluated.unwrap().into()]; [INFO] [stdout] 245 + return vec![ as Into<_>>::into(evaluated.unwrap())]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::rc::Rc` [INFO] [stdout] --> src/evaluator/mod.rs:248:21 [INFO] [stdout] | [INFO] [stdout] 248 | result.push(evaluated.unwrap().into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 248 - result.push(evaluated.unwrap().into()); [INFO] [stdout] 248 + result.push(evaluated.unwrap()); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 248 - result.push(evaluated.unwrap().into()); [INFO] [stdout] 248 + result.push( as Into<_>>::into(evaluated.unwrap())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::rc::Rc` [INFO] [stdout] --> src/evaluator/mod.rs:288:21 [INFO] [stdout] | [INFO] [stdout] 288 | / result [INFO] [stdout] 289 | | .unwrap() [INFO] [stdout] 290 | | .try_into_return_value() [INFO] [stdout] 291 | | .unwrap() [INFO] [stdout] 292 | | .value [INFO] [stdout] 293 | | .clone() [INFO] [stdout] 294 | | .into(), [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 293 - .clone() [INFO] [stdout] 294 - .into(), [INFO] [stdout] 293 + .clone(), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 288 ~ as Into<_>>::into(result [INFO] [stdout] 289 | .unwrap() [INFO] [stdout] ... [INFO] [stdout] 292 | .value [INFO] [stdout] 293 ~ .clone()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_script` (bin "rust_script") due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: useless conversion to the same type: `std::rc::Rc` [INFO] [stdout] --> src/parser.rs:228:26 [INFO] [stdout] | [INFO] [stdout] 228 | identifiers.push(ident.into()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 228 - identifiers.push(ident.into()); [INFO] [stdout] 228 + identifiers.push(ident); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 228 - identifiers.push(ident.into()); [INFO] [stdout] 228 + identifiers.push( as Into<_>>::into(ident)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::rc::Rc` [INFO] [stdout] --> src/parser.rs:239:30 [INFO] [stdout] | [INFO] [stdout] 239 | identifiers.push(ident.into()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 239 - identifiers.push(ident.into()); [INFO] [stdout] 239 + identifiers.push(ident); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 239 - identifiers.push(ident.into()); [INFO] [stdout] 239 + identifiers.push( as Into<_>>::into(ident)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::rc::Rc` [INFO] [stdout] --> src/evaluator/mod.rs:88:51 [INFO] [stdout] | [INFO] [stdout] 88 | .set(let_stmt.name.value.clone(), value.unwrap().into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 88 - .set(let_stmt.name.value.clone(), value.unwrap().into()); [INFO] [stdout] 88 + .set(let_stmt.name.value.clone(), value.unwrap()); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 88 - .set(let_stmt.name.value.clone(), value.unwrap().into()); [INFO] [stdout] 88 + .set(let_stmt.name.value.clone(), as Into<_>>::into(value.unwrap())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::rc::Rc` [INFO] [stdout] --> src/evaluator/mod.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 93 | return Some(eval_identifier(node.try_into_identifier().unwrap(), env).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 93 - return Some(eval_identifier(node.try_into_identifier().unwrap(), env).into()); [INFO] [stdout] 93 + return Some(eval_identifier(node.try_into_identifier().unwrap(), env)); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 93 - return Some(eval_identifier(node.try_into_identifier().unwrap(), env).into()); [INFO] [stdout] 93 + return Some( as Into<_>>::into(eval_identifier(node.try_into_identifier().unwrap(), env))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::rc::Rc` [INFO] [stdout] --> src/evaluator/mod.rs:245:25 [INFO] [stdout] | [INFO] [stdout] 245 | return vec![evaluated.unwrap().into()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 245 - return vec![evaluated.unwrap().into()]; [INFO] [stdout] 245 + return vec![evaluated.unwrap()]; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 245 - return vec![evaluated.unwrap().into()]; [INFO] [stdout] 245 + return vec![ as Into<_>>::into(evaluated.unwrap())]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::rc::Rc` [INFO] [stdout] --> src/evaluator/mod.rs:248:21 [INFO] [stdout] | [INFO] [stdout] 248 | result.push(evaluated.unwrap().into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 248 - result.push(evaluated.unwrap().into()); [INFO] [stdout] 248 + result.push(evaluated.unwrap()); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 248 - result.push(evaluated.unwrap().into()); [INFO] [stdout] 248 + result.push( as Into<_>>::into(evaluated.unwrap())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `std::rc::Rc` [INFO] [stdout] --> src/evaluator/mod.rs:288:21 [INFO] [stdout] | [INFO] [stdout] 288 | / result [INFO] [stdout] 289 | | .unwrap() [INFO] [stdout] 290 | | .try_into_return_value() [INFO] [stdout] 291 | | .unwrap() [INFO] [stdout] 292 | | .value [INFO] [stdout] 293 | | .clone() [INFO] [stdout] 294 | | .into(), [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 293 - .clone() [INFO] [stdout] 294 - .into(), [INFO] [stdout] 293 + .clone(), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 288 ~ as Into<_>>::into(result [INFO] [stdout] 289 | .unwrap() [INFO] [stdout] ... [INFO] [stdout] 292 | .value [INFO] [stdout] 293 ~ .clone()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_script` (bin "rust_script" test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "5c2f6492b15a4adf28ac290f5b5d5281b7b3404a8427260803d49f11cef3cfb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c2f6492b15a4adf28ac290f5b5d5281b7b3404a8427260803d49f11cef3cfb3", kill_on_drop: false }` [INFO] [stdout] 5c2f6492b15a4adf28ac290f5b5d5281b7b3404a8427260803d49f11cef3cfb3