[INFO] cloning repository https://github.com/DKormann/rubox [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DKormann/rubox" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDKormann%2Frubox", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDKormann%2Frubox'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 41f51d639d807786bcba4ef0b978ff9b1fe3e2b0 [INFO] checking DKormann/rubox against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDKormann%2Frubox" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/DKormann/rubox [INFO] finished tweaking git repo https://github.com/DKormann/rubox [INFO] tweaked toml for git repo https://github.com/DKormann/rubox written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/DKormann/rubox on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/DKormann/rubox already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 7ba539fb91c14180d8265221c1c84dbca10d4a571f603d0237f7436e75ab324a [INFO] running `Command { std: "docker" "start" "7ba539fb91c14180d8265221c1c84dbca10d4a571f603d0237f7436e75ab324a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7ba539fb91c14180d8265221c1c84dbca10d4a571f603d0237f7436e75ab324a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "7ba539fb91c14180d8265221c1c84dbca10d4a571f603d0237f7436e75ab324a" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7ba539fb91c14180d8265221c1c84dbca10d4a571f603d0237f7436e75ab324a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "7ba539fb91c14180d8265221c1c84dbca10d4a571f603d0237f7436e75ab324a" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.96 [INFO] [stderr] Compiling ucd-trie v0.1.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling im v15.1.0 [INFO] [stderr] Checking bitmaps v2.1.0 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking sized-chunks v0.6.5 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Compiling pest v2.8.1 [INFO] [stderr] Compiling pest_meta v2.8.1 [INFO] [stderr] Compiling pest_generator v2.8.1 [INFO] [stderr] Compiling pest_derive v2.8.1 [INFO] [stderr] Checking rubox v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tests.rs:132:47 [INFO] [stdout] | [INFO] [stdout] 132 | test_parse(code, mk_call(mk_access(mk_var("a".into()), "b".into()), vec![mk_int(22)])); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 132 - test_parse(code, mk_call(mk_access(mk_var("a".into()), "b".into()), vec![mk_int(22)])); [INFO] [stdout] 132 + test_parse(code, mk_call(mk_access(mk_var("a"), "b".into()), vec![mk_int(22)])); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 132 - test_parse(code, mk_call(mk_access(mk_var("a".into()), "b".into()), vec![mk_int(22)])); [INFO] [stdout] 132 + test_parse(code, mk_call(mk_access(mk_var(<&str as Into<_>>::into("a")), "b".into()), vec![mk_int(22)])); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tests.rs:138:49 [INFO] [stdout] | [INFO] [stdout] 138 | test_parse(code, mk_access(mk_access(mk_var("a".into()), "b".into()), "c".into())); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 138 - test_parse(code, mk_access(mk_access(mk_var("a".into()), "b".into()), "c".into())); [INFO] [stdout] 138 + test_parse(code, mk_access(mk_access(mk_var("a"), "b".into()), "c".into())); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 138 - test_parse(code, mk_access(mk_access(mk_var("a".into()), "b".into()), "c".into())); [INFO] [stdout] 138 + test_parse(code, mk_access(mk_access(mk_var(<&str as Into<_>>::into("a")), "b".into()), "c".into())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tests.rs:141:76 [INFO] [stdout] | [INFO] [stdout] 141 | test_parse(code, mk_access(mk_index(mk_call(mk_access(mk_access(mk_var("a".into()), "b".into()), "c".into()), vec![mk_int(22)])... [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 141 - test_parse(code, mk_access(mk_index(mk_call(mk_access(mk_access(mk_var("a".into()), "b".into()), "c".into()), vec![mk_int(22)]), mk_int(3)), "d".into())); [INFO] [stdout] 141 + test_parse(code, mk_access(mk_index(mk_call(mk_access(mk_access(mk_var("a"), "b".into()), "c".into()), vec![mk_int(22)]), mk_int(3)), "d".into())); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 141 - test_parse(code, mk_access(mk_index(mk_call(mk_access(mk_access(mk_var("a".into()), "b".into()), "c".into()), vec![mk_int(22)]), mk_int(3)), "d".into())); [INFO] [stdout] 141 + test_parse(code, mk_access(mk_index(mk_call(mk_access(mk_access(mk_var(<&str as Into<_>>::into("a")), "b".into()), "c".into()), vec![mk_int(22)]), mk_int(3)), "d".into())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tests.rs:144:76 [INFO] [stdout] | [INFO] [stdout] 144 | test_parse(code, mk_access(mk_index(mk_call(mk_access(mk_access(mk_var("a".into()), "b".into()), "c".into()), vec![mk_int(22)])... [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 144 - test_parse(code, mk_access(mk_index(mk_call(mk_access(mk_access(mk_var("a".into()), "b".into()), "c".into()), vec![mk_int(22)]), mk_int(3)), "d".into())); [INFO] [stdout] 144 + test_parse(code, mk_access(mk_index(mk_call(mk_access(mk_access(mk_var("a"), "b".into()), "c".into()), vec![mk_int(22)]), mk_int(3)), "d".into())); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 144 - test_parse(code, mk_access(mk_index(mk_call(mk_access(mk_access(mk_var("a".into()), "b".into()), "c".into()), vec![mk_int(22)]), mk_int(3)), "d".into())); [INFO] [stdout] 144 + test_parse(code, mk_access(mk_index(mk_call(mk_access(mk_access(mk_var(<&str as Into<_>>::into("a")), "b".into()), "c".into()), vec![mk_int(22)]), mk_int(3)), "d".into())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `String` [INFO] [stdout] --> src/ast.rs:188:32 [INFO] [stdout] | [INFO] [stdout] 188 | params.into_iter().map(|s| s.into()).collect(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 188 - params.into_iter().map(|s| s.into()).collect(), [INFO] [stdout] 188 + params.into_iter().map(|s| s).collect(), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 188 - params.into_iter().map(|s| s.into()).collect(), [INFO] [stdout] 188 + params.into_iter().map(|s| >::into(s)).collect(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rubox` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: useless conversion to the same type: `String` [INFO] [stdout] --> src/ast.rs:188:32 [INFO] [stdout] | [INFO] [stdout] 188 | params.into_iter().map(|s| s.into()).collect(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 188 - params.into_iter().map(|s| s.into()).collect(), [INFO] [stdout] 188 + params.into_iter().map(|s| s).collect(), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 188 - params.into_iter().map(|s| s.into()).collect(), [INFO] [stdout] 188 + params.into_iter().map(|s| >::into(s)).collect(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rubox` (lib) due to 1 previous error [INFO] running `Command { std: "docker" "inspect" "7ba539fb91c14180d8265221c1c84dbca10d4a571f603d0237f7436e75ab324a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ba539fb91c14180d8265221c1c84dbca10d4a571f603d0237f7436e75ab324a", kill_on_drop: false }` [INFO] [stdout] 7ba539fb91c14180d8265221c1c84dbca10d4a571f603d0237f7436e75ab324a