[INFO] cloning repository https://github.com/AlecGoncharow/crafting-interpreters-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AlecGoncharow/crafting-interpreters-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlecGoncharow%2Fcrafting-interpreters-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlecGoncharow%2Fcrafting-interpreters-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d4abc52ac34abf7f7e64fef9f05614e9750a1f0f [INFO] checking AlecGoncharow/crafting-interpreters-rs against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlecGoncharow%2Fcrafting-interpreters-rs" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/AlecGoncharow/crafting-interpreters-rs [INFO] finished tweaking git repo https://github.com/AlecGoncharow/crafting-interpreters-rs [INFO] tweaked toml for git repo https://github.com/AlecGoncharow/crafting-interpreters-rs written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/AlecGoncharow/crafting-interpreters-rs on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/AlecGoncharow/crafting-interpreters-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] c85defb050bb6b220cc1b005d7206cfc12141be77796fa796da1de5af8595461 [INFO] running `Command { std: "docker" "start" "c85defb050bb6b220cc1b005d7206cfc12141be77796fa796da1de5af8595461", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c85defb050bb6b220cc1b005d7206cfc12141be77796fa796da1de5af8595461", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "c85defb050bb6b220cc1b005d7206cfc12141be77796fa796da1de5af8595461" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c85defb050bb6b220cc1b005d7206cfc12141be77796fa796da1de5af8595461", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "c85defb050bb6b220cc1b005d7206cfc12141be77796fa796da1de5af8595461" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Checking crafting-interpreters-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `or_patterns` has been stable since 1.53.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(or_patterns)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `nll` has been stable since 1.63.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(nll)] [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::u8::MAX`: replaced by the `MAX` associated constant on this type [INFO] [stdout] --> src/compiler/mod.rs:242:32 [INFO] [stdout] | [INFO] [stdout] 242 | if constant > std::u8::MAX { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `or_patterns` has been stable since 1.53.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(or_patterns)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `nll` has been stable since 1.63.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(nll)] [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::u8::MAX`: replaced by the `MAX` associated constant on this type [INFO] [stdout] --> src/compiler/mod.rs:242:32 [INFO] [stdout] | [INFO] [stdout] 242 | if constant > std::u8::MAX { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `f64` [INFO] [stdout] --> src/compiler/value.rs:136:22 [INFO] [stdout] | [INFO] [stdout] 136 | Self::Number(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 136 - Self::Number(v.into()) [INFO] [stdout] 136 + Self::Number(v) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 136 - Self::Number(v.into()) [INFO] [stdout] 136 + Self::Number(>::into(v)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `bool` [INFO] [stdout] --> src/compiler/value.rs:142:20 [INFO] [stdout] | [INFO] [stdout] 142 | Self::Bool(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 142 - Self::Bool(v.into()) [INFO] [stdout] 142 + Self::Bool(v) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 142 - Self::Bool(v.into()) [INFO] [stdout] 142 + Self::Bool(>::into(v)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `interpreter::value::Value` [INFO] [stdout] --> src/interpreter/value.rs:161:25 [INFO] [stdout] | [INFO] [stdout] 161 | args.get(i).unwrap().clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 161 - args.get(i).unwrap().clone().into(), [INFO] [stdout] 161 + args.get(i).unwrap().clone(), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 161 - args.get(i).unwrap().clone().into(), [INFO] [stdout] 161 + >::into(args.get(i).unwrap().clone()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `String` [INFO] [stdout] --> src/interpreter/value.rs:282:19 [INFO] [stdout] | [INFO] [stdout] 282 | Self::Str(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 282 - Self::Str(v.into()) [INFO] [stdout] 282 + Self::Str(v) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 282 - Self::Str(v.into()) [INFO] [stdout] 282 + Self::Str(>::into(v)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `f64` [INFO] [stdout] --> src/interpreter/value.rs:288:22 [INFO] [stdout] | [INFO] [stdout] 288 | Self::Number(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 288 - Self::Number(v.into()) [INFO] [stdout] 288 + Self::Number(v) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 288 - Self::Number(v.into()) [INFO] [stdout] 288 + Self::Number(>::into(v)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `bool` [INFO] [stdout] --> src/interpreter/value.rs:294:20 [INFO] [stdout] | [INFO] [stdout] 294 | Self::Bool(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 294 - Self::Bool(v.into()) [INFO] [stdout] 294 + Self::Bool(v) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 294 - Self::Bool(v.into()) [INFO] [stdout] 294 + Self::Bool(>::into(v)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `interpreter::value::Value` [INFO] [stdout] --> src/interpreter/mod.rs:53:62 [INFO] [stdout] | [INFO] [stdout] 53 | .assign_at(*distance, &token.lexeme, val.into())?; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 53 - .assign_at(*distance, &token.lexeme, val.into())?; [INFO] [stdout] 53 + .assign_at(*distance, &token.lexeme, val)?; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 53 - .assign_at(*distance, &token.lexeme, val.into())?; [INFO] [stdout] 53 + .assign_at(*distance, &token.lexeme, >::into(val))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `interpreter::value::Value` [INFO] [stdout] --> src/interpreter/mod.rs:55:68 [INFO] [stdout] | [INFO] [stdout] 55 | environment.borrow_mut().assign(&token.lexeme, val.into())?; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 55 - environment.borrow_mut().assign(&token.lexeme, val.into())?; [INFO] [stdout] 55 + environment.borrow_mut().assign(&token.lexeme, val)?; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 55 - environment.borrow_mut().assign(&token.lexeme, val.into())?; [INFO] [stdout] 55 + environment.borrow_mut().assign(&token.lexeme, >::into(val))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `interpreter::value::Value` [INFO] [stdout] --> src/interpreter/mod.rs:308:31 [INFO] [stdout] | [INFO] [stdout] 308 | return Ok(left.into()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 308 - return Ok(left.into()); [INFO] [stdout] 308 + return Ok(left); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 308 - return Ok(left.into()); [INFO] [stdout] 308 + return Ok(>::into(left)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `interpreter::value::Value` [INFO] [stdout] --> src/interpreter/mod.rs:314:31 [INFO] [stdout] | [INFO] [stdout] 314 | return Ok(left.into()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 314 - return Ok(left.into()); [INFO] [stdout] 314 + return Ok(left); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 314 - return Ok(left.into()); [INFO] [stdout] 314 + return Ok(>::into(left)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `interpreter::value::Value` [INFO] [stdout] --> src/interpreter/mod.rs:366:64 [INFO] [stdout] | [INFO] [stdout] 366 | environment.borrow_mut().define(&token.lexeme, val.into()); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 366 - environment.borrow_mut().define(&token.lexeme, val.into()); [INFO] [stdout] 366 + environment.borrow_mut().define(&token.lexeme, val); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 366 - environment.borrow_mut().define(&token.lexeme, val.into()); [INFO] [stdout] 366 + environment.borrow_mut().define(&token.lexeme, >::into(val)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crafting-interpreters-rs` (bin "crafting-interpreters-rs") due to 11 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: useless conversion to the same type: `f64` [INFO] [stdout] --> src/compiler/value.rs:136:22 [INFO] [stdout] | [INFO] [stdout] 136 | Self::Number(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 136 - Self::Number(v.into()) [INFO] [stdout] 136 + Self::Number(v) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 136 - Self::Number(v.into()) [INFO] [stdout] 136 + Self::Number(>::into(v)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `bool` [INFO] [stdout] --> src/compiler/value.rs:142:20 [INFO] [stdout] | [INFO] [stdout] 142 | Self::Bool(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 142 - Self::Bool(v.into()) [INFO] [stdout] 142 + Self::Bool(v) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 142 - Self::Bool(v.into()) [INFO] [stdout] 142 + Self::Bool(>::into(v)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `interpreter::value::Value` [INFO] [stdout] --> src/interpreter/value.rs:161:25 [INFO] [stdout] | [INFO] [stdout] 161 | args.get(i).unwrap().clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 161 - args.get(i).unwrap().clone().into(), [INFO] [stdout] 161 + args.get(i).unwrap().clone(), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 161 - args.get(i).unwrap().clone().into(), [INFO] [stdout] 161 + >::into(args.get(i).unwrap().clone()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `String` [INFO] [stdout] --> src/interpreter/value.rs:282:19 [INFO] [stdout] | [INFO] [stdout] 282 | Self::Str(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 282 - Self::Str(v.into()) [INFO] [stdout] 282 + Self::Str(v) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 282 - Self::Str(v.into()) [INFO] [stdout] 282 + Self::Str(>::into(v)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `f64` [INFO] [stdout] --> src/interpreter/value.rs:288:22 [INFO] [stdout] | [INFO] [stdout] 288 | Self::Number(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 288 - Self::Number(v.into()) [INFO] [stdout] 288 + Self::Number(v) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 288 - Self::Number(v.into()) [INFO] [stdout] 288 + Self::Number(>::into(v)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `bool` [INFO] [stdout] --> src/interpreter/value.rs:294:20 [INFO] [stdout] | [INFO] [stdout] 294 | Self::Bool(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 294 - Self::Bool(v.into()) [INFO] [stdout] 294 + Self::Bool(v) [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 294 - Self::Bool(v.into()) [INFO] [stdout] 294 + Self::Bool(>::into(v)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `interpreter::value::Value` [INFO] [stdout] --> src/interpreter/mod.rs:53:62 [INFO] [stdout] | [INFO] [stdout] 53 | .assign_at(*distance, &token.lexeme, val.into())?; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 53 - .assign_at(*distance, &token.lexeme, val.into())?; [INFO] [stdout] 53 + .assign_at(*distance, &token.lexeme, val)?; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 53 - .assign_at(*distance, &token.lexeme, val.into())?; [INFO] [stdout] 53 + .assign_at(*distance, &token.lexeme, >::into(val))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `interpreter::value::Value` [INFO] [stdout] --> src/interpreter/mod.rs:55:68 [INFO] [stdout] | [INFO] [stdout] 55 | environment.borrow_mut().assign(&token.lexeme, val.into())?; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 55 - environment.borrow_mut().assign(&token.lexeme, val.into())?; [INFO] [stdout] 55 + environment.borrow_mut().assign(&token.lexeme, val)?; [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 55 - environment.borrow_mut().assign(&token.lexeme, val.into())?; [INFO] [stdout] 55 + environment.borrow_mut().assign(&token.lexeme, >::into(val))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `interpreter::value::Value` [INFO] [stdout] --> src/interpreter/mod.rs:308:31 [INFO] [stdout] | [INFO] [stdout] 308 | return Ok(left.into()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 308 - return Ok(left.into()); [INFO] [stdout] 308 + return Ok(left); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 308 - return Ok(left.into()); [INFO] [stdout] 308 + return Ok(>::into(left)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `interpreter::value::Value` [INFO] [stdout] --> src/interpreter/mod.rs:314:31 [INFO] [stdout] | [INFO] [stdout] 314 | return Ok(left.into()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 314 - return Ok(left.into()); [INFO] [stdout] 314 + return Ok(left); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 314 - return Ok(left.into()); [INFO] [stdout] 314 + return Ok(>::into(left)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `interpreter::value::Value` [INFO] [stdout] --> src/interpreter/mod.rs:366:64 [INFO] [stdout] | [INFO] [stdout] 366 | environment.borrow_mut().define(&token.lexeme, val.into()); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 366 - environment.borrow_mut().define(&token.lexeme, val.into()); [INFO] [stdout] 366 + environment.borrow_mut().define(&token.lexeme, val); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 366 - environment.borrow_mut().define(&token.lexeme, val.into()); [INFO] [stdout] 366 + environment.borrow_mut().define(&token.lexeme, >::into(val)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crafting-interpreters-rs` (bin "crafting-interpreters-rs" test) due to 11 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c85defb050bb6b220cc1b005d7206cfc12141be77796fa796da1de5af8595461", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c85defb050bb6b220cc1b005d7206cfc12141be77796fa796da1de5af8595461", kill_on_drop: false }` [INFO] [stdout] c85defb050bb6b220cc1b005d7206cfc12141be77796fa796da1de5af8595461