[INFO] cloning repository https://github.com/Alaz-Oz/git-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Alaz-Oz/git-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlaz-Oz%2Fgit-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlaz-Oz%2Fgit-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ef8d46c260a9b93fb28e629aba33c361d5a2f4b9 [INFO] checking Alaz-Oz/git-rs against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlaz-Oz%2Fgit-rs" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Alaz-Oz/git-rs [INFO] finished tweaking git repo https://github.com/Alaz-Oz/git-rs [INFO] tweaked toml for git repo https://github.com/Alaz-Oz/git-rs written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Alaz-Oz/git-rs on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Alaz-Oz/git-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] eac0801d3a276037270101a6f191a4ce82958fdc61acad694e16594c127335fe [INFO] running `Command { std: "docker" "start" "eac0801d3a276037270101a6f191a4ce82958fdc61acad694e16594c127335fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eac0801d3a276037270101a6f191a4ce82958fdc61acad694e16594c127335fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "eac0801d3a276037270101a6f191a4ce82958fdc61acad694e16594c127335fe" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eac0801d3a276037270101a6f191a4ce82958fdc61acad694e16594c127335fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "eac0801d3a276037270101a6f191a4ce82958fdc61acad694e16594c127335fe" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Checking cfg-if v1.0.1 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking configparser v3.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Checking anstream v0.6.20 [INFO] [stderr] Checking clap_builder v4.5.44 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking indexmap v2.11.0 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling clap_derive v4.5.45 [INFO] [stderr] Checking clap v4.5.45 [INFO] [stderr] Checking oz v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `DirEntry`, `HashMap`, `iter::Map`, and `self` [INFO] [stdout] --> src/git_repo.rs:6:29 [INFO] [stdout] | [INFO] [stdout] 6 | collections::{BTreeMap, HashMap, HashSet}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 7 | fs::{self, DirEntry}, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 8 | io::{Read, Write}, [INFO] [stdout] 9 | iter::Map, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 10 | path::{self, PathBuf}, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::commands::repo_find` [INFO] [stdout] --> src/git_repo.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use crate::commands::repo_find; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BTreeMap` and `hash::Hash` [INFO] [stdout] --> src/lib.rs:5:19 [INFO] [stdout] | [INFO] [stdout] 5 | collections::{BTreeMap, HashSet}, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 6 | fs, [INFO] [stdout] 7 | hash::Hash, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DirEntry`, `HashMap`, `iter::Map`, and `self` [INFO] [stdout] --> src/git_repo.rs:6:29 [INFO] [stdout] | [INFO] [stdout] 6 | collections::{BTreeMap, HashMap, HashSet}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 7 | fs::{self, DirEntry}, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 8 | io::{Read, Write}, [INFO] [stdout] 9 | iter::Map, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 10 | path::{self, PathBuf}, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::commands::repo_find` [INFO] [stdout] --> src/git_repo.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use crate::commands::repo_find; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BTreeMap` and `hash::Hash` [INFO] [stdout] --> src/lib.rs:5:19 [INFO] [stdout] | [INFO] [stdout] 5 | collections::{BTreeMap, HashSet}, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 6 | fs, [INFO] [stdout] 7 | hash::Hash, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fmt` [INFO] [stdout] --> src/git_repo.rs:187:52 [INFO] [stdout] | [INFO] [stdout] 187 | pub(crate) fn object_find(&self, name: String, fmt: String) -> String { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_fmt` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fmt` [INFO] [stdout] --> src/git_repo.rs:187:52 [INFO] [stdout] | [INFO] [stdout] 187 | pub(crate) fn object_find(&self, name: String, fmt: String) -> String { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_fmt` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/git_repo.rs:329:31 [INFO] [stdout] | [INFO] [stdout] 329 | fn deserialize(&mut self, data: Vec) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/git_repo.rs:329:31 [INFO] [stdout] | [INFO] [stdout] 329 | fn deserialize(&mut self, data: Vec) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/git_repo.rs:415:31 [INFO] [stdout] | [INFO] [stdout] 415 | fn deserialize(&mut self, data: Vec) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/git_repo.rs:415:31 [INFO] [stdout] | [INFO] [stdout] 415 | fn deserialize(&mut self, data: Vec) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `conf` is never read [INFO] [stdout] --> src/git_repo.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct GitRepository { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 24 | pub(super) conf: Ini, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GitRepository` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `deserialize` is never used [INFO] [stdout] --> src/git_repo.rs:308:8 [INFO] [stdout] | [INFO] [stdout] 304 | pub(crate) trait Serializable { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 308 | fn deserialize(&mut self, data: Vec); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/git_repo.rs:363:19 [INFO] [stdout] | [INFO] [stdout] 357 | impl GitTree { [INFO] [stdout] | ------------ associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 363 | pub(crate) fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `conf` is never read [INFO] [stdout] --> src/git_repo.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct GitRepository { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 24 | pub(super) conf: Ini, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GitRepository` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `deserialize` is never used [INFO] [stdout] --> src/git_repo.rs:308:8 [INFO] [stdout] | [INFO] [stdout] 304 | pub(crate) trait Serializable { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 308 | fn deserialize(&mut self, data: Vec); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/git_repo.rs:363:19 [INFO] [stdout] | [INFO] [stdout] 357 | impl GitTree { [INFO] [stdout] | ------------ associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 363 | pub(crate) fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `PathBuf` [INFO] [stdout] --> src/commands.rs:9:35 [INFO] [stdout] | [INFO] [stdout] 9 | let repo = GitRepository::new(path.into(), true).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 9 - let repo = GitRepository::new(path.into(), true).unwrap(); [INFO] [stdout] 9 + let repo = GitRepository::new(path, true).unwrap(); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 9 - let repo = GitRepository::new(path.into(), true).unwrap(); [INFO] [stdout] 9 + let repo = GitRepository::new(>::into(path), true).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `PathBuf` [INFO] [stdout] --> src/commands.rs:9:35 [INFO] [stdout] | [INFO] [stdout] 9 | let repo = GitRepository::new(path.into(), true).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 9 - let repo = GitRepository::new(path.into(), true).unwrap(); [INFO] [stdout] 9 + let repo = GitRepository::new(path, true).unwrap(); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 9 - let repo = GitRepository::new(path.into(), true).unwrap(); [INFO] [stdout] 9 + let repo = GitRepository::new(>::into(path), true).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oz` (lib) due to 1 previous error; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `oz` (lib test) due to 1 previous error; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "eac0801d3a276037270101a6f191a4ce82958fdc61acad694e16594c127335fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eac0801d3a276037270101a6f191a4ce82958fdc61acad694e16594c127335fe", kill_on_drop: false }` [INFO] [stdout] eac0801d3a276037270101a6f191a4ce82958fdc61acad694e16594c127335fe