[INFO] cloning repository https://github.com/4-0-9/practical-runner [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/4-0-9/practical-runner" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F4-0-9%2Fpractical-runner", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F4-0-9%2Fpractical-runner'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3fb5042e64d52c3bad53fd1845fab14b550812dd [INFO] checking 4-0-9/practical-runner against a5689b034ad287112f709693384a37f1377eb9cc for pr-129249-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F4-0-9%2Fpractical-runner" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/4-0-9/practical-runner [INFO] finished tweaking git repo https://github.com/4-0-9/practical-runner [INFO] tweaked toml for git repo https://github.com/4-0-9/practical-runner written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/4-0-9/practical-runner on toolchain a5689b034ad287112f709693384a37f1377eb9cc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/4-0-9/practical-runner already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.homepage` is redundant with `package.repository` [INFO] [stderr] --> Cargo.toml:18:12 [INFO] [stderr] | [INFO] [stderr] 18 | homepage = "https://github.com/4-0-9/practical-runner" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 22 | repository = "https://github.com/4-0-9/practical-runner" [INFO] [stderr] | ------------------------------------------- [INFO] [stderr] | [INFO] [stderr] = note: `cargo::redundant_homepage` is set to `warn` by default [INFO] [stderr] help: consider removing `package.homepage` [INFO] [stderr] warning: `practicalrunner` (manifest) generated 1 warning [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 22164bf9e55cbf40bd256d8974691fb6f7da41297fb4aee3b1d43899f94fac89 [INFO] running `Command { std: "docker" "start" "22164bf9e55cbf40bd256d8974691fb6f7da41297fb4aee3b1d43899f94fac89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "22164bf9e55cbf40bd256d8974691fb6f7da41297fb4aee3b1d43899f94fac89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "22164bf9e55cbf40bd256d8974691fb6f7da41297fb4aee3b1d43899f94fac89" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "22164bf9e55cbf40bd256d8974691fb6f7da41297fb4aee3b1d43899f94fac89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "22164bf9e55cbf40bd256d8974691fb6f7da41297fb4aee3b1d43899f94fac89" "/opt/rustwide/cargo-home/bin/cargo" "+a5689b034ad287112f709693384a37f1377eb9cc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] warning: `package.homepage` is redundant with `package.repository` [INFO] [stderr] --> Cargo.toml:18:12 [INFO] [stderr] | [INFO] [stderr] 18 | homepage = "https://github.com/4-0-9/practical-runner" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 22 | repository = "https://github.com/4-0-9/practical-runner" [INFO] [stderr] | ------------------------------------------- [INFO] [stderr] | [INFO] [stderr] = note: `cargo::redundant_homepage` is set to `warn` by default [INFO] [stderr] help: consider removing `package.homepage` [INFO] [stderr] warning: `practicalrunner` (manifest) generated 1 warning [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking libloading v0.8.3 [INFO] [stderr] Compiling sdl2 v0.36.0 [INFO] [stderr] Compiling fontconfig v0.8.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling sdl2-sys v0.36.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling yeslogic-fontconfig-sys v5.0.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.65 [INFO] [stderr] Compiling cstr v0.2.12 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking practicalrunner v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: useless conversion to the same type: `i32` [INFO] [stdout] --> src/runner/mod.rs:96:56 [INFO] [stdout] | [INFO] [stdout] 96 | center_on_display(canvas.window_mut(), current_display_index.into(), &video); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 96 - center_on_display(canvas.window_mut(), current_display_index.into(), &video); [INFO] [stdout] 96 + center_on_display(canvas.window_mut(), current_display_index, &video); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 96 - center_on_display(canvas.window_mut(), current_display_index.into(), &video); [INFO] [stdout] 96 + center_on_display(canvas.window_mut(), >::into(current_display_index), &video); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `u16` [INFO] [stdout] --> src/runner/mod.rs:242:41 [INFO] [stdout] | [INFO] [stdout] 242 | let input_position_y: u16 = (PADDING + self.settings.border_size as u16 - 1 [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 243 | | + self.settings.line_spacing.div_ceil(4)) [INFO] [stdout] 244 | | .into(); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 243 - + self.settings.line_spacing.div_ceil(4)) [INFO] [stdout] 244 - .into(); [INFO] [stdout] 243 + + self.settings.line_spacing.div_ceil(4)); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 242 ~ let input_position_y: u16 = >::into((PADDING + self.settings.border_size as u16 - 1 [INFO] [stdout] 243 ~ + self.settings.line_spacing.div_ceil(4))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `u32` [INFO] [stdout] --> src/runner/mod.rs:317:21 [INFO] [stdout] | [INFO] [stdout] 317 | (surface.height() + self.settings.line_spacing as u32).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 317 - (surface.height() + self.settings.line_spacing as u32).into(), [INFO] [stdout] 317 + (surface.height() + self.settings.line_spacing as u32), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 317 - (surface.height() + self.settings.line_spacing as u32).into(), [INFO] [stdout] 317 + >::into((surface.height() + self.settings.line_spacing as u32)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `i32` [INFO] [stdout] --> src/runner/mod.rs:410:43 [INFO] [stdout] | [INFO] [stdout] 410 | let bounds = video.display_bounds(display_index.into()).expect(&format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 410 - let bounds = video.display_bounds(display_index.into()).expect(&format!( [INFO] [stdout] 410 + let bounds = video.display_bounds(display_index).expect(&format!( [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 410 - let bounds = video.display_bounds(display_index.into()).expect(&format!( [INFO] [stdout] 410 + let bounds = video.display_bounds(>::into(display_index)).expect(&format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `practicalrunner` (bin "practicalrunner") due to 4 previous errors [INFO] [stdout] error: useless conversion to the same type: `i32` [INFO] [stdout] --> src/runner/mod.rs:96:56 [INFO] [stdout] | [INFO] [stdout] 96 | center_on_display(canvas.window_mut(), current_display_index.into(), &video); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 96 - center_on_display(canvas.window_mut(), current_display_index.into(), &video); [INFO] [stdout] 96 + center_on_display(canvas.window_mut(), current_display_index, &video); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 96 - center_on_display(canvas.window_mut(), current_display_index.into(), &video); [INFO] [stdout] 96 + center_on_display(canvas.window_mut(), >::into(current_display_index), &video); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: useless conversion to the same type: `u16` [INFO] [stdout] --> src/runner/mod.rs:242:41 [INFO] [stdout] | [INFO] [stdout] 242 | let input_position_y: u16 = (PADDING + self.settings.border_size as u16 - 1 [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 243 | | + self.settings.line_spacing.div_ceil(4)) [INFO] [stdout] 244 | | .into(); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 243 - + self.settings.line_spacing.div_ceil(4)) [INFO] [stdout] 244 - .into(); [INFO] [stdout] 243 + + self.settings.line_spacing.div_ceil(4)); [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 242 ~ let input_position_y: u16 = >::into((PADDING + self.settings.border_size as u16 - 1 [INFO] [stdout] 243 ~ + self.settings.line_spacing.div_ceil(4))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `u32` [INFO] [stdout] --> src/runner/mod.rs:317:21 [INFO] [stdout] | [INFO] [stdout] 317 | (surface.height() + self.settings.line_spacing as u32).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 317 - (surface.height() + self.settings.line_spacing as u32).into(), [INFO] [stdout] 317 + (surface.height() + self.settings.line_spacing as u32), [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 317 - (surface.height() + self.settings.line_spacing as u32).into(), [INFO] [stdout] 317 + >::into((surface.height() + self.settings.line_spacing as u32)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `i32` [INFO] [stdout] --> src/runner/mod.rs:410:43 [INFO] [stdout] | [INFO] [stdout] 410 | let bounds = video.display_bounds(display_index.into()).expect(&format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] help: consider removing the conversion call [INFO] [stdout] | [INFO] [stdout] 410 - let bounds = video.display_bounds(display_index.into()).expect(&format!( [INFO] [stdout] 410 + let bounds = video.display_bounds(display_index).expect(&format!( [INFO] [stdout] | [INFO] [stdout] help: you can use the fully-qualified path to avoid triggering this lint [INFO] [stdout] | [INFO] [stdout] 410 - let bounds = video.display_bounds(display_index.into()).expect(&format!( [INFO] [stdout] 410 + let bounds = video.display_bounds(>::into(display_index)).expect(&format!( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `practicalrunner` (bin "practicalrunner" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "22164bf9e55cbf40bd256d8974691fb6f7da41297fb4aee3b1d43899f94fac89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22164bf9e55cbf40bd256d8974691fb6f7da41297fb4aee3b1d43899f94fac89", kill_on_drop: false }` [INFO] [stdout] 22164bf9e55cbf40bd256d8974691fb6f7da41297fb4aee3b1d43899f94fac89