[INFO] cloning repository https://github.com/thommay/rit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/thommay/rit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthommay%2Frit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthommay%2Frit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0a55975c5f4d68b19f13675547ced1041881d580 [INFO] checking thommay/rit against try#21cad1f647cfd05a566220f933edd88a53e50bcf for pr-129249-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthommay%2Frit" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/thommay/rit [INFO] finished tweaking git repo https://github.com/thommay/rit [INFO] tweaked toml for git repo https://github.com/thommay/rit written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/thommay/rit on toolchain 21cad1f647cfd05a566220f933edd88a53e50bcf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+21cad1f647cfd05a566220f933edd88a53e50bcf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/thommay/rit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+21cad1f647cfd05a566220f933edd88a53e50bcf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3e793bdf10248eb2ddbd6b0faebed8155c11b4589982e2893733958d93e8d540" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] c4b020c430d795b4d97f54a9056baf4bb530c79808e436c294cbf942a406bbea [INFO] running `Command { std: "docker" "start" "c4b020c430d795b4d97f54a9056baf4bb530c79808e436c294cbf942a406bbea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "c4b020c430d795b4d97f54a9056baf4bb530c79808e436c294cbf942a406bbea" "/opt/rustwide/cargo-home/bin/cargo" "+21cad1f647cfd05a566220f933edd88a53e50bcf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c4b020c430d795b4d97f54a9056baf4bb530c79808e436c294cbf942a406bbea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "c4b020c430d795b4d97f54a9056baf4bb530c79808e436c294cbf942a406bbea" "/opt/rustwide/cargo-home/bin/cargo" "+21cad1f647cfd05a566220f933edd88a53e50bcf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.54 [INFO] [stderr] Compiling cc v1.0.36 [INFO] [stderr] Compiling proc-macro2 v0.4.29 [INFO] [stderr] Compiling syn v0.15.33 [INFO] [stderr] Checking cfg-if v0.1.7 [INFO] [stderr] Compiling backtrace v0.3.15 [INFO] [stderr] Compiling bitflags v1.0.5 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rustc-demangle v0.1.14 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking sha1 v0.6.0 [INFO] [stderr] Checking indexmap v1.0.2 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking rand v0.6.5 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Compiling miniz-sys v0.1.11 [INFO] [stderr] Compiling quote v0.6.12 [INFO] [stderr] Checking flate2 v1.0.7 [INFO] [stderr] Checking uuid v0.7.4 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking rit v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:21:35 [INFO] [stdout] | [INFO] [stdout] 21 | type BoxResult = Result>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | type BoxResult = Result>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:21:35 [INFO] [stdout] | [INFO] [stdout] 21 | type BoxResult = Result>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | type BoxResult = Result>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/tree.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Tree { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 10 | pub entries: IndexMap, [INFO] [stdout] 11 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Tree` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `u32` [INFO] [stdout] --> src/utilities.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 35 | let xugo: u32 = (libc::S_IXUSR | libc::S_IXGRP | libc::S_IXOTH).into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: you can instead use the fully-qualified path `::into(val) to avoid triggering this lint [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&[T; N] as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to `<[T; N] as IntoIterator>::into_iter` in Rust 2021 [INFO] [stdout] --> src/workspace.rs:51:20 [INFO] [stdout] | [INFO] [stdout] 51 | if IGNORED.into_iter().any(|&x| p.starts_with(x)) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(array_into_iter)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 51 - if IGNORED.into_iter().any(|&x| p.starts_with(x)) { [INFO] [stdout] 51 + if IGNORED.iter().any(|&x| p.starts_with(x)) { [INFO] [stdout] | [INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value [INFO] [stdout] | [INFO] [stdout] 51 - if IGNORED.into_iter().any(|&x| p.starts_with(x)) { [INFO] [stdout] 51 + if IntoIterator::into_iter(IGNORED).any(|&x| p.starts_with(x)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rit` (bin "rit") due to 1 previous error; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/tree.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Tree { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 10 | pub entries: IndexMap, [INFO] [stdout] 11 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Tree` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: useless conversion to the same type: `u32` [INFO] [stdout] --> src/utilities.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 35 | let xugo: u32 = (libc::S_IXUSR | libc::S_IXGRP | libc::S_IXOTH).into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this method call relies on the `impl Into for T` blanket implementation and type inference, which is a semver hazard as a new `impl Into<_>` that affects your type might be added in the future causing type inference errors [INFO] [stdout] = note: you can instead use the fully-qualified path `::into(val) to avoid triggering this lint [INFO] [stdout] = note: `#[deny(self_type_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&[T; N] as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to `<[T; N] as IntoIterator>::into_iter` in Rust 2021 [INFO] [stdout] --> src/workspace.rs:51:20 [INFO] [stdout] | [INFO] [stdout] 51 | if IGNORED.into_iter().any(|&x| p.starts_with(x)) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(array_into_iter)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 51 - if IGNORED.into_iter().any(|&x| p.starts_with(x)) { [INFO] [stdout] 51 + if IGNORED.iter().any(|&x| p.starts_with(x)) { [INFO] [stdout] | [INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value [INFO] [stdout] | [INFO] [stdout] 51 - if IGNORED.into_iter().any(|&x| p.starts_with(x)) { [INFO] [stdout] 51 + if IntoIterator::into_iter(IGNORED).any(|&x| p.starts_with(x)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rit` (bin "rit" test) due to 1 previous error; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c4b020c430d795b4d97f54a9056baf4bb530c79808e436c294cbf942a406bbea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4b020c430d795b4d97f54a9056baf4bb530c79808e436c294cbf942a406bbea", kill_on_drop: false }` [INFO] [stdout] c4b020c430d795b4d97f54a9056baf4bb530c79808e436c294cbf942a406bbea