[INFO] cloning repository https://github.com/nuclearpesto/rust-binary-tree [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nuclearpesto/rust-binary-tree" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnuclearpesto%2Frust-binary-tree", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnuclearpesto%2Frust-binary-tree'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e03f93f02462e0ed812e0d43f525598f29b072aa [INFO] checking nuclearpesto/rust-binary-tree/e03f93f02462e0ed812e0d43f525598f29b072aa against master#83dcdb3a5dad0ed1e3e1fadc848d3f7727b41aa5 for pr-128425 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnuclearpesto%2Frust-binary-tree" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/nuclearpesto/rust-binary-tree on toolchain 83dcdb3a5dad0ed1e3e1fadc848d3f7727b41aa5 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+83dcdb3a5dad0ed1e3e1fadc848d3f7727b41aa5" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/nuclearpesto/rust-binary-tree [INFO] finished tweaking git repo https://github.com/nuclearpesto/rust-binary-tree [INFO] tweaked toml for git repo https://github.com/nuclearpesto/rust-binary-tree written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/nuclearpesto/rust-binary-tree already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+83dcdb3a5dad0ed1e3e1fadc848d3f7727b41aa5" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+83dcdb3a5dad0ed1e3e1fadc848d3f7727b41aa5" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4cf4f28601c6976684f7523cb19b5b4eb3183ef03181d36d54226c754e3388d3 [INFO] running `Command { std: "docker" "start" "-a" "4cf4f28601c6976684f7523cb19b5b4eb3183ef03181d36d54226c754e3388d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4cf4f28601c6976684f7523cb19b5b4eb3183ef03181d36d54226c754e3388d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4cf4f28601c6976684f7523cb19b5b4eb3183ef03181d36d54226c754e3388d3", kill_on_drop: false }` [INFO] [stdout] 4cf4f28601c6976684f7523cb19b5b4eb3183ef03181d36d54226c754e3388d3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+83dcdb3a5dad0ed1e3e1fadc848d3f7727b41aa5" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 06e05c8dfc79f4ba3f377b8c4475620c996331e6d537eefef4e6c0b48a2e8590 [INFO] running `Command { std: "docker" "start" "-a" "06e05c8dfc79f4ba3f377b8c4475620c996331e6d537eefef4e6c0b48a2e8590", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking binarytree v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:28:62 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn insert(tree: &Option>, key: &str) -> (Option>) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - pub fn insert(tree: &Option>, key: &str) -> (Option>) { [INFO] [stdout] 28 + pub fn insert(tree: &Option>, key: &str) -> Option> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:35:51 [INFO] [stdout] | [INFO] [stdout] 35 | fn clone_node(node: &Option>) -> (Option>) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 35 - fn clone_node(node: &Option>) -> (Option>) { [INFO] [stdout] 35 + fn clone_node(node: &Option>) -> Option> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:41:35 [INFO] [stdout] | [INFO] [stdout] 41 | fn new_leaf(key: &str) -> (Option>) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 41 - fn new_leaf(key: &str) -> (Option>) { [INFO] [stdout] 41 + fn new_leaf(key: &str) -> Option> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:49:55 [INFO] [stdout] | [INFO] [stdout] 49 | fn tree_by_key(tree: &Rc, key: &str) -> (Option>) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 49 - fn tree_by_key(tree: &Rc, key: &str) -> (Option>) { [INFO] [stdout] 49 + fn tree_by_key(tree: &Rc, key: &str) -> Option> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:28:62 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn insert(tree: &Option>, key: &str) -> (Option>) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - pub fn insert(tree: &Option>, key: &str) -> (Option>) { [INFO] [stdout] 28 + pub fn insert(tree: &Option>, key: &str) -> Option> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:35:51 [INFO] [stdout] | [INFO] [stdout] 35 | fn clone_node(node: &Option>) -> (Option>) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 35 - fn clone_node(node: &Option>) -> (Option>) { [INFO] [stdout] 35 + fn clone_node(node: &Option>) -> Option> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:41:35 [INFO] [stdout] | [INFO] [stdout] 41 | fn new_leaf(key: &str) -> (Option>) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 41 - fn new_leaf(key: &str) -> (Option>) { [INFO] [stdout] 41 + fn new_leaf(key: &str) -> Option> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:49:55 [INFO] [stdout] | [INFO] [stdout] 49 | fn tree_by_key(tree: &Rc, key: &str) -> (Option>) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 49 - fn tree_by_key(tree: &Rc, key: &str) -> (Option>) { [INFO] [stdout] 49 + fn tree_by_key(tree: &Rc, key: &str) -> Option> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0170]: pattern binding `Less` is named the same as one of the variants of the type `std::cmp::Ordering` [INFO] [stdout] --> src/main.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | Less => { [INFO] [stdout] | ^^^^ help: to match on the variant, qualify the path: `std::cmp::Ordering::Less` [INFO] [stdout] | [INFO] [stdout] = note: `#[deny(bindings_with_variant_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0170]: pattern binding `Equal` is named the same as one of the variants of the type `std::cmp::Ordering` [INFO] [stdout] --> src/main.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 67 | Equal => { [INFO] [stdout] | ^^^^^ help: to match on the variant, qualify the path: `std::cmp::Ordering::Equal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/main.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 55 | Less => { [INFO] [stdout] | ---- matches any value [INFO] [stdout] ... [INFO] [stdout] 61 | More => { [INFO] [stdout] | ^^^^ unreachable pattern [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/main.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 55 | Less => { [INFO] [stdout] | ---- matches any value [INFO] [stdout] ... [INFO] [stdout] 67 | Equal => { [INFO] [stdout] | ^^^^^ unreachable pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `Less` [INFO] [stdout] --> src/main.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | Less => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_Less` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `More` [INFO] [stdout] --> src/main.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 61 | More => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_More` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `Equal` [INFO] [stdout] --> src/main.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 67 | Equal => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_Equal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Less` should have a snake case name [INFO] [stdout] --> src/main.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | Less => { [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `less` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `More` should have a snake case name [INFO] [stdout] --> src/main.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 61 | More => { [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `more` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Equal` should have a snake case name [INFO] [stdout] --> src/main.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 67 | Equal => { [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `equal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0170]: pattern binding `Less` is named the same as one of the variants of the type `std::cmp::Ordering` [INFO] [stdout] --> src/main.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | Less => { [INFO] [stdout] | ^^^^ help: to match on the variant, qualify the path: `std::cmp::Ordering::Less` [INFO] [stdout] | [INFO] [stdout] = note: `#[deny(bindings_with_variant_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0170]: pattern binding `Equal` is named the same as one of the variants of the type `std::cmp::Ordering` [INFO] [stdout] --> src/main.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 67 | Equal => { [INFO] [stdout] | ^^^^^ help: to match on the variant, qualify the path: `std::cmp::Ordering::Equal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/main.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 55 | Less => { [INFO] [stdout] | ---- matches any value [INFO] [stdout] ... [INFO] [stdout] 61 | More => { [INFO] [stdout] | ^^^^ unreachable pattern [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/main.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 55 | Less => { [INFO] [stdout] | ---- matches any value [INFO] [stdout] ... [INFO] [stdout] 67 | Equal => { [INFO] [stdout] | ^^^^^ unreachable pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `Less` [INFO] [stdout] --> src/main.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | Less => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_Less` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `More` [INFO] [stdout] --> src/main.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 61 | More => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_More` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `Equal` [INFO] [stdout] --> src/main.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 67 | Equal => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_Equal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0170`. [INFO] [stdout] [INFO] [stdout] warning: variable `Less` should have a snake case name [INFO] [stdout] --> src/main.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | Less => { [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `less` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `More` should have a snake case name [INFO] [stdout] --> src/main.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 61 | More => { [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `more` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Equal` should have a snake case name [INFO] [stdout] --> src/main.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 67 | Equal => { [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `equal` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binarytree` (bin "binarytree") due to 3 previous errors; 12 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0170`. [INFO] [stdout] [INFO] [stderr] error: could not compile `binarytree` (bin "binarytree" test) due to 3 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "06e05c8dfc79f4ba3f377b8c4475620c996331e6d537eefef4e6c0b48a2e8590", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06e05c8dfc79f4ba3f377b8c4475620c996331e6d537eefef4e6c0b48a2e8590", kill_on_drop: false }` [INFO] [stdout] 06e05c8dfc79f4ba3f377b8c4475620c996331e6d537eefef4e6c0b48a2e8590