[INFO] cloning repository https://github.com/christopherjmedlin/yalc8emu [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/christopherjmedlin/yalc8emu" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristopherjmedlin%2Fyalc8emu", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristopherjmedlin%2Fyalc8emu'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fa140db9922c8fff32635f89eb72ce5c7183ab59 [INFO] checking christopherjmedlin/yalc8emu against master#05eac57ef6668c9d181b65aceb96b1e7881f60be for pr-127656 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristopherjmedlin%2Fyalc8emu" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/christopherjmedlin/yalc8emu on toolchain 05eac57ef6668c9d181b65aceb96b1e7881f60be [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+05eac57ef6668c9d181b65aceb96b1e7881f60be" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/christopherjmedlin/yalc8emu [INFO] finished tweaking git repo https://github.com/christopherjmedlin/yalc8emu [INFO] tweaked toml for git repo https://github.com/christopherjmedlin/yalc8emu written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/christopherjmedlin/yalc8emu already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+05eac57ef6668c9d181b65aceb96b1e7881f60be" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:dff56e7819e73ed36160586b3445e93eb0be776c16704aeeded9c3fb668b2384" "/opt/rustwide/cargo-home/bin/cargo" "+05eac57ef6668c9d181b65aceb96b1e7881f60be" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eed38388e52a98686032d7bcaebdd31181817214162904b76e2fac5fe71f47c5 [INFO] running `Command { std: "docker" "start" "-a" "eed38388e52a98686032d7bcaebdd31181817214162904b76e2fac5fe71f47c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eed38388e52a98686032d7bcaebdd31181817214162904b76e2fac5fe71f47c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eed38388e52a98686032d7bcaebdd31181817214162904b76e2fac5fe71f47c5", kill_on_drop: false }` [INFO] [stdout] eed38388e52a98686032d7bcaebdd31181817214162904b76e2fac5fe71f47c5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:dff56e7819e73ed36160586b3445e93eb0be776c16704aeeded9c3fb668b2384" "/opt/rustwide/cargo-home/bin/cargo" "+05eac57ef6668c9d181b65aceb96b1e7881f60be" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c9078aa2dd94a9498480a82691b1bf312260fb097be394af68c3a57fd58194c2 [INFO] running `Command { std: "docker" "start" "-a" "c9078aa2dd94a9498480a82691b1bf312260fb097be394af68c3a57fd58194c2", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Compiling cfg-if v0.1.5 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Compiling sdl2-sys v0.31.0 [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking chip8 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Duration` [INFO] [stdout] --> src/cpu/timers.rs:1:26 [INFO] [stdout] | [INFO] [stdout] 1 | use std::time::{Instant, Duration}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/timers.rs:42:37 [INFO] [stdout] | [INFO] [stdout] 42 | fn elapsed_millis(&mut self) -> (u64) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 42 - fn elapsed_millis(&mut self) -> (u64) { [INFO] [stdout] 42 + fn elapsed_millis(&mut self) -> u64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::num::Wrapping` [INFO] [stdout] --> src/cpu/mod.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::num::Wrapping; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:127:30 [INFO] [stdout] | [INFO] [stdout] 127 | fn op_00E0(&mut self) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 127 - fn op_00E0(&mut self) -> (usize) { [INFO] [stdout] 127 + fn op_00E0(&mut self) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:133:30 [INFO] [stdout] | [INFO] [stdout] 133 | fn op_00EE(&mut self) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 133 - fn op_00EE(&mut self) -> (usize) { [INFO] [stdout] 133 + fn op_00EE(&mut self) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:140:42 [INFO] [stdout] | [INFO] [stdout] 140 | fn op_1nnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 140 - fn op_1nnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] 140 + fn op_1nnn(&mut self, nnn: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:146:42 [INFO] [stdout] | [INFO] [stdout] 146 | fn op_2nnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 146 - fn op_2nnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] 146 + fn op_2nnn(&mut self, nnn: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:155:48 [INFO] [stdout] | [INFO] [stdout] 155 | fn op_3xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 155 - fn op_3xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] 155 + fn op_3xkk(&mut self, x: usize, kk: u8) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:163:48 [INFO] [stdout] | [INFO] [stdout] 163 | fn op_4xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 163 - fn op_4xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] 163 + fn op_4xkk(&mut self, x: usize, kk: u8) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:171:50 [INFO] [stdout] | [INFO] [stdout] 171 | fn op_5xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 171 - fn op_5xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 171 + fn op_5xy0(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:179:48 [INFO] [stdout] | [INFO] [stdout] 179 | fn op_6xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 179 - fn op_6xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] 179 + fn op_6xkk(&mut self, x: usize, kk: u8) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:185:48 [INFO] [stdout] | [INFO] [stdout] 185 | fn op_7xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 185 - fn op_7xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] 185 + fn op_7xkk(&mut self, x: usize, kk: u8) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:192:50 [INFO] [stdout] | [INFO] [stdout] 192 | fn op_8xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - fn op_8xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 192 + fn op_8xy0(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:198:50 [INFO] [stdout] | [INFO] [stdout] 198 | fn op_8xy1(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 198 - fn op_8xy1(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 198 + fn op_8xy1(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:204:50 [INFO] [stdout] | [INFO] [stdout] 204 | fn op_8xy2(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 204 - fn op_8xy2(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 204 + fn op_8xy2(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:210:50 [INFO] [stdout] | [INFO] [stdout] 210 | fn op_8xy3(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 210 - fn op_8xy3(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 210 + fn op_8xy3(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:216:50 [INFO] [stdout] | [INFO] [stdout] 216 | fn op_8xy4(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 216 - fn op_8xy4(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 216 + fn op_8xy4(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:230:50 [INFO] [stdout] | [INFO] [stdout] 230 | fn op_8xy5(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 230 - fn op_8xy5(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 230 + fn op_8xy5(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:245:40 [INFO] [stdout] | [INFO] [stdout] 245 | fn op_8xy6(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 245 - fn op_8xy6(&mut self, x: usize) -> (usize) { [INFO] [stdout] 245 + fn op_8xy6(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:253:50 [INFO] [stdout] | [INFO] [stdout] 253 | fn op_8xy7(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 253 - fn op_8xy7(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 253 + fn op_8xy7(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:264:40 [INFO] [stdout] | [INFO] [stdout] 264 | fn op_8xyE(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 264 - fn op_8xyE(&mut self, x: usize) -> (usize) { [INFO] [stdout] 264 + fn op_8xyE(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:271:50 [INFO] [stdout] | [INFO] [stdout] 271 | fn op_9xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 271 - fn op_9xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 271 + fn op_9xy0(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:279:42 [INFO] [stdout] | [INFO] [stdout] 279 | fn op_Annn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 279 - fn op_Annn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] 279 + fn op_Annn(&mut self, nnn: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:285:42 [INFO] [stdout] | [INFO] [stdout] 285 | fn op_Bnnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 285 - fn op_Bnnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] 285 + fn op_Bnnn(&mut self, nnn: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:291:48 [INFO] [stdout] | [INFO] [stdout] 291 | fn op_Cxkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 291 - fn op_Cxkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] 291 + fn op_Cxkk(&mut self, x: usize, kk: u8) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:298:60 [INFO] [stdout] | [INFO] [stdout] 298 | fn op_Dxyn(&mut self, x: usize, y: usize, n: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 298 - fn op_Dxyn(&mut self, x: usize, y: usize, n: usize) -> (usize) { [INFO] [stdout] 298 + fn op_Dxyn(&mut self, x: usize, y: usize, n: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:312:41 [INFO] [stdout] | [INFO] [stdout] 312 | fn op_Ex9E (&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 312 - fn op_Ex9E (&mut self, x: usize) -> (usize) { [INFO] [stdout] 312 + fn op_Ex9E (&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:318:40 [INFO] [stdout] | [INFO] [stdout] 318 | fn op_ExA1(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 318 - fn op_ExA1(&mut self, x: usize) -> (usize) { [INFO] [stdout] 318 + fn op_ExA1(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:324:40 [INFO] [stdout] | [INFO] [stdout] 324 | fn op_Fx07(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 324 - fn op_Fx07(&mut self, x: usize) -> (usize) { [INFO] [stdout] 324 + fn op_Fx07(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:330:40 [INFO] [stdout] | [INFO] [stdout] 330 | fn op_Fx0A(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 330 - fn op_Fx0A(&mut self, x: usize) -> (usize) { [INFO] [stdout] 330 + fn op_Fx0A(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:344:40 [INFO] [stdout] | [INFO] [stdout] 344 | fn op_Fx15(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 344 - fn op_Fx15(&mut self, x: usize) -> (usize) { [INFO] [stdout] 344 + fn op_Fx15(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:350:40 [INFO] [stdout] | [INFO] [stdout] 350 | fn op_Fx18(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 350 - fn op_Fx18(&mut self, x: usize) -> (usize) { [INFO] [stdout] 350 + fn op_Fx18(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:356:40 [INFO] [stdout] | [INFO] [stdout] 356 | fn op_Fx1E(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 356 - fn op_Fx1E(&mut self, x: usize) -> (usize) { [INFO] [stdout] 356 + fn op_Fx1E(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:362:40 [INFO] [stdout] | [INFO] [stdout] 362 | fn op_Fx29(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 362 - fn op_Fx29(&mut self, x: usize) -> (usize) { [INFO] [stdout] 362 + fn op_Fx29(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:368:40 [INFO] [stdout] | [INFO] [stdout] 368 | fn op_Fx33(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 368 - fn op_Fx33(&mut self, x: usize) -> (usize) { [INFO] [stdout] 368 + fn op_Fx33(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:376:40 [INFO] [stdout] | [INFO] [stdout] 376 | fn op_Fx55(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 376 - fn op_Fx55(&mut self, x: usize) -> (usize) { [INFO] [stdout] 376 + fn op_Fx55(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/mod.rs:378:22 [INFO] [stdout] | [INFO] [stdout] 378 | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 378 - let end = if (x > 0xf) {0xf} else {x}; [INFO] [stdout] 378 + let end = if x > 0xf {0xf} else {x}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:387:40 [INFO] [stdout] | [INFO] [stdout] 387 | fn op_Fx65(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 387 - fn op_Fx65(&mut self, x: usize) -> (usize) { [INFO] [stdout] 387 + fn op_Fx65(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/mod.rs:389:22 [INFO] [stdout] | [INFO] [stdout] 389 | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 389 - let end = if (x > 0xf) {0xf} else {x}; [INFO] [stdout] 389 + let end = if x > 0xf {0xf} else {x}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:397:49 [INFO] [stdout] | [INFO] [stdout] 397 | fn unimplemented(&mut self, opcode: u16) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 397 - fn unimplemented(&mut self, opcode: u16) -> (usize) { [INFO] [stdout] 397 + fn unimplemented(&mut self, opcode: u16) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/display.rs:22:76 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn draw(&mut self, x: usize, y: usize, n: usize, sprite: &[u8]) -> (bool) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 - pub fn draw(&mut self, x: usize, y: usize, n: usize, sprite: &[u8]) -> (bool) { [INFO] [stdout] 22 + pub fn draw(&mut self, x: usize, y: usize, n: usize, sprite: &[u8]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/display.rs:68:51 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn get_pixel(self, x: usize, y: usize) -> (bool) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 68 - pub fn get_pixel(self, x: usize, y: usize) -> (bool) { [INFO] [stdout] 68 + pub fn get_pixel(self, x: usize, y: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/timers.rs:42:37 [INFO] [stdout] | [INFO] [stdout] 42 | fn elapsed_millis(&mut self) -> (u64) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 42 - fn elapsed_millis(&mut self) -> (u64) { [INFO] [stdout] 42 + fn elapsed_millis(&mut self) -> u64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::num::Wrapping` [INFO] [stdout] --> src/cpu/mod.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::num::Wrapping; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:127:30 [INFO] [stdout] | [INFO] [stdout] 127 | fn op_00E0(&mut self) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 127 - fn op_00E0(&mut self) -> (usize) { [INFO] [stdout] 127 + fn op_00E0(&mut self) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:133:30 [INFO] [stdout] | [INFO] [stdout] 133 | fn op_00EE(&mut self) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 133 - fn op_00EE(&mut self) -> (usize) { [INFO] [stdout] 133 + fn op_00EE(&mut self) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:140:42 [INFO] [stdout] | [INFO] [stdout] 140 | fn op_1nnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 140 - fn op_1nnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] 140 + fn op_1nnn(&mut self, nnn: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:146:42 [INFO] [stdout] | [INFO] [stdout] 146 | fn op_2nnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 146 - fn op_2nnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] 146 + fn op_2nnn(&mut self, nnn: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:155:48 [INFO] [stdout] | [INFO] [stdout] 155 | fn op_3xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 155 - fn op_3xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] 155 + fn op_3xkk(&mut self, x: usize, kk: u8) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:163:48 [INFO] [stdout] | [INFO] [stdout] 163 | fn op_4xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 163 - fn op_4xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] 163 + fn op_4xkk(&mut self, x: usize, kk: u8) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:171:50 [INFO] [stdout] | [INFO] [stdout] 171 | fn op_5xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 171 - fn op_5xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 171 + fn op_5xy0(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:179:48 [INFO] [stdout] | [INFO] [stdout] 179 | fn op_6xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 179 - fn op_6xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] 179 + fn op_6xkk(&mut self, x: usize, kk: u8) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:185:48 [INFO] [stdout] | [INFO] [stdout] 185 | fn op_7xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 185 - fn op_7xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] 185 + fn op_7xkk(&mut self, x: usize, kk: u8) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:192:50 [INFO] [stdout] | [INFO] [stdout] 192 | fn op_8xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - fn op_8xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 192 + fn op_8xy0(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:198:50 [INFO] [stdout] | [INFO] [stdout] 198 | fn op_8xy1(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 198 - fn op_8xy1(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 198 + fn op_8xy1(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:204:50 [INFO] [stdout] | [INFO] [stdout] 204 | fn op_8xy2(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 204 - fn op_8xy2(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 204 + fn op_8xy2(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:210:50 [INFO] [stdout] | [INFO] [stdout] 210 | fn op_8xy3(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 210 - fn op_8xy3(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 210 + fn op_8xy3(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:216:50 [INFO] [stdout] | [INFO] [stdout] 216 | fn op_8xy4(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 216 - fn op_8xy4(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 216 + fn op_8xy4(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:230:50 [INFO] [stdout] | [INFO] [stdout] 230 | fn op_8xy5(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 230 - fn op_8xy5(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 230 + fn op_8xy5(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:245:40 [INFO] [stdout] | [INFO] [stdout] 245 | fn op_8xy6(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 245 - fn op_8xy6(&mut self, x: usize) -> (usize) { [INFO] [stdout] 245 + fn op_8xy6(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:253:50 [INFO] [stdout] | [INFO] [stdout] 253 | fn op_8xy7(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 253 - fn op_8xy7(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 253 + fn op_8xy7(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:264:40 [INFO] [stdout] | [INFO] [stdout] 264 | fn op_8xyE(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 264 - fn op_8xyE(&mut self, x: usize) -> (usize) { [INFO] [stdout] 264 + fn op_8xyE(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:271:50 [INFO] [stdout] | [INFO] [stdout] 271 | fn op_9xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 271 - fn op_9xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] 271 + fn op_9xy0(&mut self, x: usize, y: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:279:42 [INFO] [stdout] | [INFO] [stdout] 279 | fn op_Annn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 279 - fn op_Annn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] 279 + fn op_Annn(&mut self, nnn: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:285:42 [INFO] [stdout] | [INFO] [stdout] 285 | fn op_Bnnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 285 - fn op_Bnnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] 285 + fn op_Bnnn(&mut self, nnn: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:291:48 [INFO] [stdout] | [INFO] [stdout] 291 | fn op_Cxkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 291 - fn op_Cxkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] 291 + fn op_Cxkk(&mut self, x: usize, kk: u8) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:298:60 [INFO] [stdout] | [INFO] [stdout] 298 | fn op_Dxyn(&mut self, x: usize, y: usize, n: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 298 - fn op_Dxyn(&mut self, x: usize, y: usize, n: usize) -> (usize) { [INFO] [stdout] 298 + fn op_Dxyn(&mut self, x: usize, y: usize, n: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:312:41 [INFO] [stdout] | [INFO] [stdout] 312 | fn op_Ex9E (&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 312 - fn op_Ex9E (&mut self, x: usize) -> (usize) { [INFO] [stdout] 312 + fn op_Ex9E (&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:318:40 [INFO] [stdout] | [INFO] [stdout] 318 | fn op_ExA1(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 318 - fn op_ExA1(&mut self, x: usize) -> (usize) { [INFO] [stdout] 318 + fn op_ExA1(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:324:40 [INFO] [stdout] | [INFO] [stdout] 324 | fn op_Fx07(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 324 - fn op_Fx07(&mut self, x: usize) -> (usize) { [INFO] [stdout] 324 + fn op_Fx07(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:330:40 [INFO] [stdout] | [INFO] [stdout] 330 | fn op_Fx0A(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 330 - fn op_Fx0A(&mut self, x: usize) -> (usize) { [INFO] [stdout] 330 + fn op_Fx0A(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:344:40 [INFO] [stdout] | [INFO] [stdout] 344 | fn op_Fx15(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 344 - fn op_Fx15(&mut self, x: usize) -> (usize) { [INFO] [stdout] 344 + fn op_Fx15(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:350:40 [INFO] [stdout] | [INFO] [stdout] 350 | fn op_Fx18(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 350 - fn op_Fx18(&mut self, x: usize) -> (usize) { [INFO] [stdout] 350 + fn op_Fx18(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:356:40 [INFO] [stdout] | [INFO] [stdout] 356 | fn op_Fx1E(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 356 - fn op_Fx1E(&mut self, x: usize) -> (usize) { [INFO] [stdout] 356 + fn op_Fx1E(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:362:40 [INFO] [stdout] | [INFO] [stdout] 362 | fn op_Fx29(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 362 - fn op_Fx29(&mut self, x: usize) -> (usize) { [INFO] [stdout] 362 + fn op_Fx29(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:368:40 [INFO] [stdout] | [INFO] [stdout] 368 | fn op_Fx33(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 368 - fn op_Fx33(&mut self, x: usize) -> (usize) { [INFO] [stdout] 368 + fn op_Fx33(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:376:40 [INFO] [stdout] | [INFO] [stdout] 376 | fn op_Fx55(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 376 - fn op_Fx55(&mut self, x: usize) -> (usize) { [INFO] [stdout] 376 + fn op_Fx55(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/mod.rs:378:22 [INFO] [stdout] | [INFO] [stdout] 378 | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 378 - let end = if (x > 0xf) {0xf} else {x}; [INFO] [stdout] 378 + let end = if x > 0xf {0xf} else {x}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:387:40 [INFO] [stdout] | [INFO] [stdout] 387 | fn op_Fx65(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 387 - fn op_Fx65(&mut self, x: usize) -> (usize) { [INFO] [stdout] 387 + fn op_Fx65(&mut self, x: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/mod.rs:389:22 [INFO] [stdout] | [INFO] [stdout] 389 | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 389 - let end = if (x > 0xf) {0xf} else {x}; [INFO] [stdout] 389 + let end = if x > 0xf {0xf} else {x}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:397:49 [INFO] [stdout] | [INFO] [stdout] 397 | fn unimplemented(&mut self, opcode: u16) -> (usize) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 397 - fn unimplemented(&mut self, opcode: u16) -> (usize) { [INFO] [stdout] 397 + fn unimplemented(&mut self, opcode: u16) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/display.rs:22:76 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn draw(&mut self, x: usize, y: usize, n: usize, sprite: &[u8]) -> (bool) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 - pub fn draw(&mut self, x: usize, y: usize, n: usize, sprite: &[u8]) -> (bool) { [INFO] [stdout] 22 + pub fn draw(&mut self, x: usize, y: usize, n: usize, sprite: &[u8]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/display.rs:68:51 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn get_pixel(self, x: usize, y: usize) -> (bool) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 68 - pub fn get_pixel(self, x: usize, y: usize) -> (bool) { [INFO] [stdout] 68 + pub fn get_pixel(self, x: usize, y: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/timers.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let mut timers = TimerSubsystem { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> src/cpu/mod.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | for (i, &b) in rom.iter().enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `why` [INFO] [stdout] --> src/rom.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | Err(why) => panic!("Couldn't open ROM"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/display.rs:57:25 [INFO] [stdout] | [INFO] [stdout] 57 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 10, 10)); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_keycode` [INFO] [stdout] --> src/keypad.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | let event_keycode: Keycode; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_keycode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_00E0` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 127 | fn op_00E0(&mut self) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_00_e0` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_00EE` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 133 | fn op_00EE(&mut self) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_00_ee` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_8xyE` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:264:8 [INFO] [stdout] | [INFO] [stdout] 264 | fn op_8xyE(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_8xy_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Annn` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:279:8 [INFO] [stdout] | [INFO] [stdout] 279 | fn op_Annn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_annn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Bnnn` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:285:8 [INFO] [stdout] | [INFO] [stdout] 285 | fn op_Bnnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_bnnn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Cxkk` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:291:8 [INFO] [stdout] | [INFO] [stdout] 291 | fn op_Cxkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_cxkk` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Dxyn` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:298:8 [INFO] [stdout] | [INFO] [stdout] 298 | fn op_Dxyn(&mut self, x: usize, y: usize, n: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_dxyn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Ex9E` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:312:8 [INFO] [stdout] | [INFO] [stdout] 312 | fn op_Ex9E (&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_ex9_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_ExA1` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:318:8 [INFO] [stdout] | [INFO] [stdout] 318 | fn op_ExA1(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_ex_a1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx07` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:324:8 [INFO] [stdout] | [INFO] [stdout] 324 | fn op_Fx07(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx07` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx0A` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:330:8 [INFO] [stdout] | [INFO] [stdout] 330 | fn op_Fx0A(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_fx0_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx15` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:344:8 [INFO] [stdout] | [INFO] [stdout] 344 | fn op_Fx15(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx15` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx18` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:350:8 [INFO] [stdout] | [INFO] [stdout] 350 | fn op_Fx18(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx18` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx1E` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:356:8 [INFO] [stdout] | [INFO] [stdout] 356 | fn op_Fx1E(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_fx1_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx29` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:362:8 [INFO] [stdout] | [INFO] [stdout] 362 | fn op_Fx29(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx29` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx33` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:368:8 [INFO] [stdout] | [INFO] [stdout] 368 | fn op_Fx33(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx33` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx55` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:376:8 [INFO] [stdout] | [INFO] [stdout] 376 | fn op_Fx55(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx55` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx65` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:387:8 [INFO] [stdout] | [INFO] [stdout] 387 | fn op_Fx65(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx65` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/rom.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | file.read(buf); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 13 | let _ = file.read(buf); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 66 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/timers.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let mut timers = TimerSubsystem { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> src/cpu/mod.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | for (i, &b) in rom.iter().enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `why` [INFO] [stdout] --> src/rom.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | Err(why) => panic!("Couldn't open ROM"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/display.rs:57:25 [INFO] [stdout] | [INFO] [stdout] 57 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 10, 10)); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pixels_cleared` [INFO] [stdout] --> src/display.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | let pixels_cleared = display.draw(63, 31, 5, &sprite); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pixels_cleared` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_keycode` [INFO] [stdout] --> src/keypad.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | let event_keycode: Keycode; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_keycode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_00E0` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 127 | fn op_00E0(&mut self) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_00_e0` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_00EE` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 133 | fn op_00EE(&mut self) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_00_ee` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_8xyE` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:264:8 [INFO] [stdout] | [INFO] [stdout] 264 | fn op_8xyE(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_8xy_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Annn` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:279:8 [INFO] [stdout] | [INFO] [stdout] 279 | fn op_Annn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_annn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Bnnn` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:285:8 [INFO] [stdout] | [INFO] [stdout] 285 | fn op_Bnnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_bnnn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Cxkk` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:291:8 [INFO] [stdout] | [INFO] [stdout] 291 | fn op_Cxkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_cxkk` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Dxyn` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:298:8 [INFO] [stdout] | [INFO] [stdout] 298 | fn op_Dxyn(&mut self, x: usize, y: usize, n: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_dxyn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Ex9E` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:312:8 [INFO] [stdout] | [INFO] [stdout] 312 | fn op_Ex9E (&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_ex9_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_ExA1` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:318:8 [INFO] [stdout] | [INFO] [stdout] 318 | fn op_ExA1(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_ex_a1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx07` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:324:8 [INFO] [stdout] | [INFO] [stdout] 324 | fn op_Fx07(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx07` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx0A` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:330:8 [INFO] [stdout] | [INFO] [stdout] 330 | fn op_Fx0A(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_fx0_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx15` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:344:8 [INFO] [stdout] | [INFO] [stdout] 344 | fn op_Fx15(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx15` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx18` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:350:8 [INFO] [stdout] | [INFO] [stdout] 350 | fn op_Fx18(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx18` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx1E` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:356:8 [INFO] [stdout] | [INFO] [stdout] 356 | fn op_Fx1E(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_fx1_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx29` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:362:8 [INFO] [stdout] | [INFO] [stdout] 362 | fn op_Fx29(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx29` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx33` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:368:8 [INFO] [stdout] | [INFO] [stdout] 368 | fn op_Fx33(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx33` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx55` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:376:8 [INFO] [stdout] | [INFO] [stdout] 376 | fn op_Fx55(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx55` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx65` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:387:8 [INFO] [stdout] | [INFO] [stdout] 387 | fn op_Fx65(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx65` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_2nnn_and_00EE` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:68:4 [INFO] [stdout] | [INFO] [stdout] 68 | fn test_2nnn_and_00EE() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `test_2nnn_and_00_ee` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_8xyE` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:170:19 [INFO] [stdout] | [INFO] [stdout] 170 | test_register_op!(test_8xyE, 0x821E, 123, 20, 40, 0); [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `test_8xy_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_8xyE_odd` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:171:19 [INFO] [stdout] | [INFO] [stdout] 171 | test_register_op!(test_8xyE_odd, 0x821E, 123, 21, 42, 1); [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `test_8xy_e_odd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Annn` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:187:4 [INFO] [stdout] | [INFO] [stdout] 187 | fn test_Annn() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `test_annn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Bnnn` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:195:4 [INFO] [stdout] | [INFO] [stdout] 195 | fn test_Bnnn() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `test_bnnn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Dxyn` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:204:4 [INFO] [stdout] | [INFO] [stdout] 204 | fn test_Dxyn() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `test_dxyn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Cnnn` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:214:4 [INFO] [stdout] | [INFO] [stdout] 214 | fn test_Cnnn() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_cnnn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Fx1E` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:222:4 [INFO] [stdout] | [INFO] [stdout] 222 | fn test_Fx1E() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `test_fx1_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Fx29` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:232:4 [INFO] [stdout] | [INFO] [stdout] 232 | fn test_Fx29() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx29` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Fx33` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:248:4 [INFO] [stdout] | [INFO] [stdout] 248 | fn test_Fx33() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx33` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Fx55` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:260:4 [INFO] [stdout] | [INFO] [stdout] 260 | fn test_Fx55() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx55` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Fx65` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:277:4 [INFO] [stdout] | [INFO] [stdout] 277 | fn test_Fx65() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx65` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Fx07` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:292:4 [INFO] [stdout] | [INFO] [stdout] 292 | fn test_Fx07() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx07` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Fx15_and_Fx18` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:301:4 [INFO] [stdout] | [INFO] [stdout] 301 | fn test_Fx15_and_Fx18() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx15_and_fx18` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/rom.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | file.read(buf); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 13 | let _ = file.read(buf); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 80 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.86s [INFO] running `Command { std: "docker" "inspect" "c9078aa2dd94a9498480a82691b1bf312260fb097be394af68c3a57fd58194c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9078aa2dd94a9498480a82691b1bf312260fb097be394af68c3a57fd58194c2", kill_on_drop: false }` [INFO] [stdout] c9078aa2dd94a9498480a82691b1bf312260fb097be394af68c3a57fd58194c2 [INFO] checking christopherjmedlin/yalc8emu against try#0c9c19b42881b7ee3d3f268d2369726c7f8dddfd for pr-127656 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristopherjmedlin%2Fyalc8emu" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/christopherjmedlin/yalc8emu on toolchain 0c9c19b42881b7ee3d3f268d2369726c7f8dddfd [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+0c9c19b42881b7ee3d3f268d2369726c7f8dddfd" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/christopherjmedlin/yalc8emu [INFO] finished tweaking git repo https://github.com/christopherjmedlin/yalc8emu [INFO] tweaked toml for git repo https://github.com/christopherjmedlin/yalc8emu written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/christopherjmedlin/yalc8emu already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+0c9c19b42881b7ee3d3f268d2369726c7f8dddfd" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:dff56e7819e73ed36160586b3445e93eb0be776c16704aeeded9c3fb668b2384" "/opt/rustwide/cargo-home/bin/cargo" "+0c9c19b42881b7ee3d3f268d2369726c7f8dddfd" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ef89d431a2f1bc32db11f264244c224761c27e4e1754ac29cb377b45db908eb9 [INFO] running `Command { std: "docker" "start" "-a" "ef89d431a2f1bc32db11f264244c224761c27e4e1754ac29cb377b45db908eb9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ef89d431a2f1bc32db11f264244c224761c27e4e1754ac29cb377b45db908eb9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef89d431a2f1bc32db11f264244c224761c27e4e1754ac29cb377b45db908eb9", kill_on_drop: false }` [INFO] [stdout] ef89d431a2f1bc32db11f264244c224761c27e4e1754ac29cb377b45db908eb9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:dff56e7819e73ed36160586b3445e93eb0be776c16704aeeded9c3fb668b2384" "/opt/rustwide/cargo-home/bin/cargo" "+0c9c19b42881b7ee3d3f268d2369726c7f8dddfd" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 001c0214a478008c3a62c69bf968b963946993b2ccb5ee5b61af8dcc922cc4c4 [INFO] running `Command { std: "docker" "start" "-a" "001c0214a478008c3a62c69bf968b963946993b2ccb5ee5b61af8dcc922cc4c4", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling cfg-if v0.1.5 [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stdout] error[E0365]: extern crate `core` is private and cannot be re-exported [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bitflags-0.7.0/src/lib.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub use core as __core; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: consider making the `extern crate` item publicly accessible [INFO] [stdout] | [INFO] [stdout] 1 | pub // Copyright 2014 The Rust Project Developers. See the COPYRIGHT [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling sdl2-sys v0.31.0 [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0365`. [INFO] [stdout] [INFO] [stderr] error: could not compile `bitflags` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "001c0214a478008c3a62c69bf968b963946993b2ccb5ee5b61af8dcc922cc4c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "001c0214a478008c3a62c69bf968b963946993b2ccb5ee5b61af8dcc922cc4c4", kill_on_drop: false }` [INFO] [stdout] 001c0214a478008c3a62c69bf968b963946993b2ccb5ee5b61af8dcc922cc4c4