[INFO] cloning repository https://github.com/christopherjmedlin/hackman [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/christopherjmedlin/hackman" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristopherjmedlin%2Fhackman", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristopherjmedlin%2Fhackman'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 116a625552d35f2f8a7bd06f69005ef7283238b0 [INFO] checking christopherjmedlin/hackman against master#05eac57ef6668c9d181b65aceb96b1e7881f60be for pr-127656 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristopherjmedlin%2Fhackman" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/christopherjmedlin/hackman on toolchain 05eac57ef6668c9d181b65aceb96b1e7881f60be [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+05eac57ef6668c9d181b65aceb96b1e7881f60be" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/christopherjmedlin/hackman [INFO] finished tweaking git repo https://github.com/christopherjmedlin/hackman [INFO] tweaked toml for git repo https://github.com/christopherjmedlin/hackman written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/christopherjmedlin/hackman already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+05eac57ef6668c9d181b65aceb96b1e7881f60be" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:dff56e7819e73ed36160586b3445e93eb0be776c16704aeeded9c3fb668b2384" "/opt/rustwide/cargo-home/bin/cargo" "+05eac57ef6668c9d181b65aceb96b1e7881f60be" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7671dd11cf79eeafd520d6a8f47982210c4c505427e3f390a7cab94189fb21f1 [INFO] running `Command { std: "docker" "start" "-a" "7671dd11cf79eeafd520d6a8f47982210c4c505427e3f390a7cab94189fb21f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7671dd11cf79eeafd520d6a8f47982210c4c505427e3f390a7cab94189fb21f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7671dd11cf79eeafd520d6a8f47982210c4c505427e3f390a7cab94189fb21f1", kill_on_drop: false }` [INFO] [stdout] 7671dd11cf79eeafd520d6a8f47982210c4c505427e3f390a7cab94189fb21f1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:dff56e7819e73ed36160586b3445e93eb0be776c16704aeeded9c3fb668b2384" "/opt/rustwide/cargo-home/bin/cargo" "+05eac57ef6668c9d181b65aceb96b1e7881f60be" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 197ae0984365812a9d7308063f63c7e14a6648ee96ae0474e00831e0de8446e7 [INFO] running `Command { std: "docker" "start" "-a" "197ae0984365812a9d7308063f63c7e14a6648ee96ae0474e00831e0de8446e7", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling cfg-if v0.1.6 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling sdl2-sys v0.31.0 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking pacman v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/cpu/mod.rs:134:18 [INFO] [stdout] | [INFO] [stdout] 134 | (0, 4...7, 0) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/cpu/mod.rs:782:21 [INFO] [stdout] | [INFO] [stdout] 782 | (2, _, 0...3) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:74:24 [INFO] [stdout] | [INFO] [stdout] 74 | (GAME_ROM_START...GAME_ROM_END, false) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:78:24 [INFO] [stdout] | [INFO] [stdout] 78 | (GAME_ROM_START...GAME_ROM_END, true) => Err("Cannot write to ROM."), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:80:26 [INFO] [stdout] | [INFO] [stdout] 80 | (VRAM_TILES_START...VRAM_TILES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:84:29 [INFO] [stdout] | [INFO] [stdout] 84 | (VRAM_PALETTES_START...VRAM_PALETTES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:88:19 [INFO] [stdout] | [INFO] [stdout] 88 | (RAM_START...RAM_END, _) => Ok(Address::Ram((addr - RAM_START) as usize)), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:90:28 [INFO] [stdout] | [INFO] [stdout] 90 | (VRAM_SPRITES_START...VRAM_SPRITES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:94:28 [INFO] [stdout] | [INFO] [stdout] 94 | (IN0_REGISTER_START...IN0_REGISTER_END, false) => Ok(Address::IN0Register), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:105:28 [INFO] [stdout] | [INFO] [stdout] 105 | (IN1_REGISTER_START...IN1_REGISTER_END, false) => Ok(Address::IN1Register), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | (SOUND_START...SOUND_END, true) => Ok(Address::Sound((addr - SOUND_START) as usize)), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 109 | (SPRITE_XY_START...SPRITE_XY_END, true) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:113:26 [INFO] [stdout] | [INFO] [stdout] 113 | (DIP_SWITCH_START...DIP_SWITCH_END, _) => Ok(Address::DipSwitchRegister), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:115:24 [INFO] [stdout] | [INFO] [stdout] 115 | (WATCHDOG_START...WATCHDOG_END, _) => Ok(Address::WatchdogTimerReset), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/memory_mapper.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::boxed::Box` [INFO] [stdout] --> src/memory_mapper.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | use std::boxed::Box; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/pacman.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/main.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | #[macro_use(matches)] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/cpu/mod.rs:134:18 [INFO] [stdout] | [INFO] [stdout] 134 | (0, 4...7, 0) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/cpu/mod.rs:782:21 [INFO] [stdout] | [INFO] [stdout] 782 | (2, _, 0...3) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/cpu/tests.rs:258:22 [INFO] [stdout] | [INFO] [stdout] 258 | cpu.reg.sp = 100;; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:74:24 [INFO] [stdout] | [INFO] [stdout] 74 | (GAME_ROM_START...GAME_ROM_END, false) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:78:24 [INFO] [stdout] | [INFO] [stdout] 78 | (GAME_ROM_START...GAME_ROM_END, true) => Err("Cannot write to ROM."), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:80:26 [INFO] [stdout] | [INFO] [stdout] 80 | (VRAM_TILES_START...VRAM_TILES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:84:29 [INFO] [stdout] | [INFO] [stdout] 84 | (VRAM_PALETTES_START...VRAM_PALETTES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:88:19 [INFO] [stdout] | [INFO] [stdout] 88 | (RAM_START...RAM_END, _) => Ok(Address::Ram((addr - RAM_START) as usize)), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:90:28 [INFO] [stdout] | [INFO] [stdout] 90 | (VRAM_SPRITES_START...VRAM_SPRITES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:94:28 [INFO] [stdout] | [INFO] [stdout] 94 | (IN0_REGISTER_START...IN0_REGISTER_END, false) => Ok(Address::IN0Register), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:105:28 [INFO] [stdout] | [INFO] [stdout] 105 | (IN1_REGISTER_START...IN1_REGISTER_END, false) => Ok(Address::IN1Register), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | (SOUND_START...SOUND_END, true) => Ok(Address::Sound((addr - SOUND_START) as usize)), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 109 | (SPRITE_XY_START...SPRITE_XY_END, true) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:113:26 [INFO] [stdout] | [INFO] [stdout] 113 | (DIP_SWITCH_START...DIP_SWITCH_END, _) => Ok(Address::DipSwitchRegister), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 49 | memory: &mut Memory, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 49 | memory: &mut dyn Memory, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:115:24 [INFO] [stdout] | [INFO] [stdout] 115 | (WATCHDOG_START...WATCHDOG_END, _) => Ok(Address::WatchdogTimerReset), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | io: &mut InputOutput, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 50 | io: &mut dyn InputOutput, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/pacman.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | memory: &mut Memory, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 73 | memory: &mut dyn Memory, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | io: &mut InputOutput, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 74 | io: &mut dyn InputOutput, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:539:46 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut dyn Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:539:63 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut dyn InputOutput, ext: bool) -> usize { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:626:58 [INFO] [stdout] | [INFO] [stdout] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut dyn Memory, io: &mut InputOutput) -> usize { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:626:75 [INFO] [stdout] | [INFO] [stdout] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut dyn InputOutput) -> usize { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:792:42 [INFO] [stdout] | [INFO] [stdout] 792 | fn r(&mut self, index: u8, mem: &mut Memory) -> u8 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 792 | fn r(&mut self, index: u8, mem: &mut dyn Memory) -> u8 { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:800:58 [INFO] [stdout] | [INFO] [stdout] 800 | fn write_r(&mut self, index: u8, byte: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 800 | fn write_r(&mut self, index: u8, byte: u8, mem: &mut dyn Memory) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:808:47 [INFO] [stdout] | [INFO] [stdout] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut dyn Memory, io: &mut InputOutput) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:808:64 [INFO] [stdout] | [INFO] [stdout] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut dyn InputOutput) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:952:42 [INFO] [stdout] | [INFO] [stdout] 952 | fn load_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 952 | fn load_inc_dec(&mut self, mem: &mut dyn Memory, inc: bool) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:974:42 [INFO] [stdout] | [INFO] [stdout] 974 | fn comp_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 974 | fn comp_inc_dec(&mut self, mem: &mut dyn Memory, inc: bool) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1274:42 [INFO] [stdout] | [INFO] [stdout] 1274 | fn dec_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1274 | fn dec_8(&mut self, y: u8, mem: &mut dyn Memory) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1288:42 [INFO] [stdout] | [INFO] [stdout] 1288 | fn inc_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1288 | fn inc_8(&mut self, y: u8, mem: &mut dyn Memory) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1303:34 [INFO] [stdout] | [INFO] [stdout] 1303 | fn call(&mut self, mem: &mut Memory, addr: u16) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1303 | fn call(&mut self, mem: &mut dyn Memory, addr: u16) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1310:33 [INFO] [stdout] | [INFO] [stdout] 1310 | fn ret(&mut self, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1310 | fn ret(&mut self, mem: &mut dyn Memory) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1316:39 [INFO] [stdout] | [INFO] [stdout] 1316 | fn pop_stack(&mut self, mem: &mut Memory) -> u8 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1316 | fn pop_stack(&mut self, mem: &mut dyn Memory) -> u8 { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1324:40 [INFO] [stdout] | [INFO] [stdout] 1324 | fn push_stack(&mut self, mem: &mut Memory, byte: u8) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1324 | fn push_stack(&mut self, mem: &mut dyn Memory, byte: u8) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1333:43 [INFO] [stdout] | [INFO] [stdout] 1333 | fn push_stack_16(&mut self, mem: &mut Memory, word: u16) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1333 | fn push_stack_16(&mut self, mem: &mut dyn Memory, word: u16) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1338:42 [INFO] [stdout] | [INFO] [stdout] 1338 | fn pop_stack_16(&mut self, mem: &mut Memory) -> u16 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1338 | fn pop_stack_16(&mut self, mem: &mut dyn Memory) -> u16 { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 49 | memory: &mut Memory, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 49 | memory: &mut dyn Memory, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | io: &mut InputOutput, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 50 | io: &mut dyn InputOutput, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | memory: &mut Memory, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 73 | memory: &mut dyn Memory, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | io: &mut InputOutput, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 74 | io: &mut dyn InputOutput, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:539:46 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut dyn Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:539:63 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut dyn InputOutput, ext: bool) -> usize { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:626:58 [INFO] [stdout] | [INFO] [stdout] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut dyn Memory, io: &mut InputOutput) -> usize { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:626:75 [INFO] [stdout] | [INFO] [stdout] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut dyn InputOutput) -> usize { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:792:42 [INFO] [stdout] | [INFO] [stdout] 792 | fn r(&mut self, index: u8, mem: &mut Memory) -> u8 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 792 | fn r(&mut self, index: u8, mem: &mut dyn Memory) -> u8 { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:800:58 [INFO] [stdout] | [INFO] [stdout] 800 | fn write_r(&mut self, index: u8, byte: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 800 | fn write_r(&mut self, index: u8, byte: u8, mem: &mut dyn Memory) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:808:47 [INFO] [stdout] | [INFO] [stdout] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut dyn Memory, io: &mut InputOutput) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:808:64 [INFO] [stdout] | [INFO] [stdout] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut dyn InputOutput) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:952:42 [INFO] [stdout] | [INFO] [stdout] 952 | fn load_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 952 | fn load_inc_dec(&mut self, mem: &mut dyn Memory, inc: bool) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:974:42 [INFO] [stdout] | [INFO] [stdout] 974 | fn comp_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 974 | fn comp_inc_dec(&mut self, mem: &mut dyn Memory, inc: bool) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1274:42 [INFO] [stdout] | [INFO] [stdout] 1274 | fn dec_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1274 | fn dec_8(&mut self, y: u8, mem: &mut dyn Memory) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1288:42 [INFO] [stdout] | [INFO] [stdout] 1288 | fn inc_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1288 | fn inc_8(&mut self, y: u8, mem: &mut dyn Memory) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1303:34 [INFO] [stdout] | [INFO] [stdout] 1303 | fn call(&mut self, mem: &mut Memory, addr: u16) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1303 | fn call(&mut self, mem: &mut dyn Memory, addr: u16) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1310:33 [INFO] [stdout] | [INFO] [stdout] 1310 | fn ret(&mut self, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1310 | fn ret(&mut self, mem: &mut dyn Memory) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1316:39 [INFO] [stdout] | [INFO] [stdout] 1316 | fn pop_stack(&mut self, mem: &mut Memory) -> u8 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1316 | fn pop_stack(&mut self, mem: &mut dyn Memory) -> u8 { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1324:40 [INFO] [stdout] | [INFO] [stdout] 1324 | fn push_stack(&mut self, mem: &mut Memory, byte: u8) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1324 | fn push_stack(&mut self, mem: &mut dyn Memory, byte: u8) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1333:43 [INFO] [stdout] | [INFO] [stdout] 1333 | fn push_stack_16(&mut self, mem: &mut Memory, word: u16) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1333 | fn push_stack_16(&mut self, mem: &mut dyn Memory, word: u16) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1338:42 [INFO] [stdout] | [INFO] [stdout] 1338 | fn pop_stack_16(&mut self, mem: &mut Memory) -> u16 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1338 | fn pop_stack_16(&mut self, mem: &mut dyn Memory) -> u16 { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/cpu/io.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | fn input(&self, port: u8) -> u8 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/cpu/io.rs:25:26 [INFO] [stdout] | [INFO] [stdout] 25 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/cpu/mod.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | for i in 0..iters { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `io` [INFO] [stdout] --> src/cpu/mod.rs:539:54 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_io` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:912:13 [INFO] [stdout] | [INFO] [stdout] 912 | (5, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:919:13 [INFO] [stdout] | [INFO] [stdout] 919 | (6, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:933:13 [INFO] [stdout] | [INFO] [stdout] 933 | (7, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1145:13 [INFO] [stdout] | [INFO] [stdout] 1145 | let mut result = left.wrapping_sub(right); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1347:13 [INFO] [stdout] | [INFO] [stdout] 1347 | let mut left = left + (carry as u8); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1354:13 [INFO] [stdout] | [INFO] [stdout] 1354 | let mut left = left - (carry as u8); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `number_of_ones` is assigned to, but never used [INFO] [stdout] --> src/cpu/mod.rs:1381:17 [INFO] [stdout] | [INFO] [stdout] 1381 | let mut number_of_ones = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_number_of_ones` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/display.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 2, 2)); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x_flip` [INFO] [stdout] --> src/display.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | x_flip: bool, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_x_flip` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y_flip` [INFO] [stdout] --> src/display.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | y_flip: bool, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_y_flip` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/interrupt_vector.rs:14:21 [INFO] [stdout] | [INFO] [stdout] 14 | fn input(&self, port: u8) -> u8 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/interrupt_vector.rs:18:26 [INFO] [stdout] | [INFO] [stdout] 18 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rom.rs:70:17 [INFO] [stdout] | [INFO] [stdout] 70 | let mut color = &mut self.color_rom[i]; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color` [INFO] [stdout] --> src/rom.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | let color = self.color_rom[*byte as usize]; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `why` [INFO] [stdout] --> src/rom.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | Err(why) => panic!("Missing ROMs"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `why` [INFO] [stdout] --> src/rom.rs:142:17 [INFO] [stdout] | [INFO] [stdout] 142 | Err(why) => panic!("Error reading ROM"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/memory_map.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | VramSprites(usize), [INFO] [stdout] | ----------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 48 | VramSprites(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/memory_map.rs:59:11 [INFO] [stdout] | [INFO] [stdout] 59 | Sound(usize), [INFO] [stdout] | ----- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 59 | Sound(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/memory_map.rs:60:22 [INFO] [stdout] | [INFO] [stdout] 60 | SpriteXYRegister(usize), [INFO] [stdout] | ---------------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 60 | SpriteXYRegister(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `VramPalettes` is never constructed [INFO] [stdout] --> src/memory_map.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 43 | pub enum Address { [INFO] [stdout] | ------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 46 | VramPalettes(usize), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `roms` is never read [INFO] [stdout] --> src/pacman.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct PacmanSystem<'a> { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 13 | roms: &'a Box, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `sound_roms` is never read [INFO] [stdout] --> src/rom.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Roms { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | pub sound_roms: [[u8; 256]; 2], [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/cpu/io.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | fn input(&self, port: u8) -> u8 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/cpu/io.rs:25:26 [INFO] [stdout] | [INFO] [stdout] 25 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 66 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/cpu/mod.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | for i in 0..iters { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `io` [INFO] [stdout] --> src/cpu/mod.rs:539:54 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_io` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:912:13 [INFO] [stdout] | [INFO] [stdout] 912 | (5, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:919:13 [INFO] [stdout] | [INFO] [stdout] 919 | (6, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:933:13 [INFO] [stdout] | [INFO] [stdout] 933 | (7, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1145:13 [INFO] [stdout] | [INFO] [stdout] 1145 | let mut result = left.wrapping_sub(right); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1347:13 [INFO] [stdout] | [INFO] [stdout] 1347 | let mut left = left + (carry as u8); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1354:13 [INFO] [stdout] | [INFO] [stdout] 1354 | let mut left = left - (carry as u8); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `number_of_ones` is assigned to, but never used [INFO] [stdout] --> src/cpu/mod.rs:1381:17 [INFO] [stdout] | [INFO] [stdout] 1381 | let mut number_of_ones = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_number_of_ones` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mem` [INFO] [stdout] --> src/cpu/tests.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | let mut mem = &mut TestMemory::new(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_mem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/tests.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | let mut mem = &mut TestMemory::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/display.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 2, 2)); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x_flip` [INFO] [stdout] --> src/display.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | x_flip: bool, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_x_flip` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y_flip` [INFO] [stdout] --> src/display.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | y_flip: bool, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_y_flip` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/interrupt_vector.rs:14:21 [INFO] [stdout] | [INFO] [stdout] 14 | fn input(&self, port: u8) -> u8 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/interrupt_vector.rs:18:26 [INFO] [stdout] | [INFO] [stdout] 18 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rom.rs:70:17 [INFO] [stdout] | [INFO] [stdout] 70 | let mut color = &mut self.color_rom[i]; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color` [INFO] [stdout] --> src/rom.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | let color = self.color_rom[*byte as usize]; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `why` [INFO] [stdout] --> src/rom.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | Err(why) => panic!("Missing ROMs"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `why` [INFO] [stdout] --> src/rom.rs:142:17 [INFO] [stdout] | [INFO] [stdout] 142 | Err(why) => panic!("Error reading ROM"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/memory_map.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | VramSprites(usize), [INFO] [stdout] | ----------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 48 | VramSprites(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/memory_map.rs:59:11 [INFO] [stdout] | [INFO] [stdout] 59 | Sound(usize), [INFO] [stdout] | ----- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 59 | Sound(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/memory_map.rs:60:22 [INFO] [stdout] | [INFO] [stdout] 60 | SpriteXYRegister(usize), [INFO] [stdout] | ---------------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 60 | SpriteXYRegister(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `VramPalettes` is never constructed [INFO] [stdout] --> src/memory_map.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 43 | pub enum Address { [INFO] [stdout] | ------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 46 | VramPalettes(usize), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `roms` is never read [INFO] [stdout] --> src/pacman.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct PacmanSystem<'a> { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 13 | roms: &'a Box, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `sound_roms` is never read [INFO] [stdout] --> src/rom.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Roms { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | pub sound_roms: [[u8; 256]; 2], [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 66 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.66s [INFO] running `Command { std: "docker" "inspect" "197ae0984365812a9d7308063f63c7e14a6648ee96ae0474e00831e0de8446e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "197ae0984365812a9d7308063f63c7e14a6648ee96ae0474e00831e0de8446e7", kill_on_drop: false }` [INFO] [stdout] 197ae0984365812a9d7308063f63c7e14a6648ee96ae0474e00831e0de8446e7 [INFO] checking christopherjmedlin/hackman against try#0c9c19b42881b7ee3d3f268d2369726c7f8dddfd for pr-127656 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristopherjmedlin%2Fhackman" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/christopherjmedlin/hackman on toolchain 0c9c19b42881b7ee3d3f268d2369726c7f8dddfd [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+0c9c19b42881b7ee3d3f268d2369726c7f8dddfd" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/christopherjmedlin/hackman [INFO] finished tweaking git repo https://github.com/christopherjmedlin/hackman [INFO] tweaked toml for git repo https://github.com/christopherjmedlin/hackman written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/christopherjmedlin/hackman already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+0c9c19b42881b7ee3d3f268d2369726c7f8dddfd" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:dff56e7819e73ed36160586b3445e93eb0be776c16704aeeded9c3fb668b2384" "/opt/rustwide/cargo-home/bin/cargo" "+0c9c19b42881b7ee3d3f268d2369726c7f8dddfd" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 893b8e5c8c3c31e69aca4bd9ae5a11765d9701521a2f5704b01f171b1e76cab4 [INFO] running `Command { std: "docker" "start" "-a" "893b8e5c8c3c31e69aca4bd9ae5a11765d9701521a2f5704b01f171b1e76cab4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "893b8e5c8c3c31e69aca4bd9ae5a11765d9701521a2f5704b01f171b1e76cab4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "893b8e5c8c3c31e69aca4bd9ae5a11765d9701521a2f5704b01f171b1e76cab4", kill_on_drop: false }` [INFO] [stdout] 893b8e5c8c3c31e69aca4bd9ae5a11765d9701521a2f5704b01f171b1e76cab4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:dff56e7819e73ed36160586b3445e93eb0be776c16704aeeded9c3fb668b2384" "/opt/rustwide/cargo-home/bin/cargo" "+0c9c19b42881b7ee3d3f268d2369726c7f8dddfd" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 54912e37a20e10a9f15482fd52424644ecd5bd2b16225f728235e247b26c6c10 [INFO] running `Command { std: "docker" "start" "-a" "54912e37a20e10a9f15482fd52424644ecd5bd2b16225f728235e247b26c6c10", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling cfg-if v0.1.6 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stdout] error[E0365]: extern crate `core` is private and cannot be re-exported [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/bitflags-0.7.0/src/lib.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub use core as __core; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: consider making the `extern crate` item publicly accessible [INFO] [stdout] | [INFO] [stdout] 1 | pub // Copyright 2014 The Rust Project Developers. See the COPYRIGHT [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0365`. [INFO] [stdout] [INFO] [stderr] Compiling sdl2-sys v0.31.0 [INFO] [stderr] error: could not compile `bitflags` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "54912e37a20e10a9f15482fd52424644ecd5bd2b16225f728235e247b26c6c10", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54912e37a20e10a9f15482fd52424644ecd5bd2b16225f728235e247b26c6c10", kill_on_drop: false }` [INFO] [stdout] 54912e37a20e10a9f15482fd52424644ecd5bd2b16225f728235e247b26c6c10