[INFO] cloning repository https://github.com/wzhd/kseqi [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/wzhd/kseqi" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwzhd%2Fkseqi", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwzhd%2Fkseqi'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8cf7804ed7ee5f57884b9d6d4a101a7563f9ec6a [INFO] checking wzhd/kseqi against master#22572d0994593197593e2a1b7b18d720a9a349a7 for pr-126452-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwzhd%2Fkseqi" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/wzhd/kseqi on toolchain 22572d0994593197593e2a1b7b18d720a9a349a7 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+22572d0994593197593e2a1b7b18d720a9a349a7" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/wzhd/kseqi [INFO] finished tweaking git repo https://github.com/wzhd/kseqi [INFO] tweaked toml for git repo https://github.com/wzhd/kseqi written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/wzhd/kseqi already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+22572d0994593197593e2a1b7b18d720a9a349a7" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded x11-dl v2.20.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+22572d0994593197593e2a1b7b18d720a9a349a7" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1cea84d7e0bea39224dcde5d8821600c5b29bf4332921d27f8e60c2d0339ec59 [INFO] running `Command { std: "docker" "start" "-a" "1cea84d7e0bea39224dcde5d8821600c5b29bf4332921d27f8e60c2d0339ec59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1cea84d7e0bea39224dcde5d8821600c5b29bf4332921d27f8e60c2d0339ec59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1cea84d7e0bea39224dcde5d8821600c5b29bf4332921d27f8e60c2d0339ec59", kill_on_drop: false }` [INFO] [stdout] 1cea84d7e0bea39224dcde5d8821600c5b29bf4332921d27f8e60c2d0339ec59 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+22572d0994593197593e2a1b7b18d720a9a349a7" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aad248ca444b76f80f359b49681038b8acd9bfaa1dabb42b1a81bd7051a5d109 [INFO] running `Command { std: "docker" "start" "-a" "aad248ca444b76f80f359b49681038b8acd9bfaa1dabb42b1a81bd7051a5d109", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling pkg-config v0.3.26 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling x11-dl v2.20.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking mio v0.8.5 [INFO] [stderr] Checking kseqi-desktop v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/xdl/xinput2.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | Ok((xip2)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - Ok((xip2)) [INFO] [stdout] 28 + Ok(xip2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/xinput2.rs:294:22 [INFO] [stdout] | [INFO] [stdout] 294 | let attach = (self.xidi.attachment ); [INFO] [stdout] | ^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 294 - let attach = (self.xidi.attachment ); [INFO] [stdout] 294 + let attach = self.xidi.attachment; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/mod.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | let event = (&*event); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 115 - let event = (&*event); [INFO] [stdout] 115 + let event = &*event; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/mod.rs:527:20 [INFO] [stdout] | [INFO] [stdout] 527 | kbs ^= (1 << b1p); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 527 - kbs ^= (1 << b1p); [INFO] [stdout] 527 + kbs ^= 1 << b1p; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/conf/mod.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | for (a) in self.acts.iter() { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 118 - for (a) in self.acts.iter() { [INFO] [stdout] 118 + for a in self.acts.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/conf/mod.rs:173:24 [INFO] [stdout] | [INFO] [stdout] 173 | let a = if (&self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0) { "↘"}else {"↗"}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 173 - let a = if (&self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0) { "↘"}else {"↗"}; [INFO] [stdout] 173 + let a = if &self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0 { "↘"}else {"↗"}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/conf/mod.rs:213:43 [INFO] [stdout] | [INFO] [stdout] 213 | Ok((input, a)) => if let Some((sqa)) = a { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 213 - Ok((input, a)) => if let Some((sqa)) = a { [INFO] [stdout] 213 + Ok((input, a)) => if let Some(sqa) = a { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/conf/mod.rs:378:36 [INFO] [stdout] | [INFO] [stdout] 378 | let sv = SmoVec::from_iter((0..10)).unwrap(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 378 - let sv = SmoVec::from_iter((0..10)).unwrap(); [INFO] [stdout] 378 + let sv = SmoVec::from_iter(0..10).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/conf/mod.rs:380:36 [INFO] [stdout] | [INFO] [stdout] 380 | let sv = SmoVec::from_iter((0..6)).unwrap(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 380 - let sv = SmoVec::from_iter((0..6)).unwrap(); [INFO] [stdout] 380 + let sv = SmoVec::from_iter(0..6).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/conf/mod.rs:382:36 [INFO] [stdout] | [INFO] [stdout] 382 | let sv = SmoVec::from_iter((0..8)).unwrap(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 382 - let sv = SmoVec::from_iter((0..8)).unwrap(); [INFO] [stdout] 382 + let sv = SmoVec::from_iter(0..8).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/conf/mod.rs:384:36 [INFO] [stdout] | [INFO] [stdout] 384 | let sv = SmoVec::from_iter((0..7)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 384 - let sv = SmoVec::from_iter((0..7)); [INFO] [stdout] 384 + let sv = SmoVec::from_iter(0..7); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/signal.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | Ok((r)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - Ok((r)) [INFO] [stdout] 32 + Ok(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/lib.rs:192:22 [INFO] [stdout] | [INFO] [stdout] 192 | Some((de)) => { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - Some((de)) => { [INFO] [stdout] 192 + Some(de) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/xdl/xinput2.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | Ok((xip2)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - Ok((xip2)) [INFO] [stdout] 28 + Ok(xip2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/xinput2.rs:294:22 [INFO] [stdout] | [INFO] [stdout] 294 | let attach = (self.xidi.attachment ); [INFO] [stdout] | ^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 294 - let attach = (self.xidi.attachment ); [INFO] [stdout] 294 + let attach = self.xidi.attachment; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/mod.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | let event = (&*event); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 115 - let event = (&*event); [INFO] [stdout] 115 + let event = &*event; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/mod.rs:527:20 [INFO] [stdout] | [INFO] [stdout] 527 | kbs ^= (1 << b1p); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 527 - kbs ^= (1 << b1p); [INFO] [stdout] 527 + kbs ^= 1 << b1p; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/conf/mod.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | for (a) in self.acts.iter() { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 118 - for (a) in self.acts.iter() { [INFO] [stdout] 118 + for a in self.acts.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/conf/mod.rs:173:24 [INFO] [stdout] | [INFO] [stdout] 173 | let a = if (&self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0) { "↘"}else {"↗"}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 173 - let a = if (&self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0) { "↘"}else {"↗"}; [INFO] [stdout] 173 + let a = if &self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0 { "↘"}else {"↗"}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/conf/mod.rs:213:43 [INFO] [stdout] | [INFO] [stdout] 213 | Ok((input, a)) => if let Some((sqa)) = a { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 213 - Ok((input, a)) => if let Some((sqa)) = a { [INFO] [stdout] 213 + Ok((input, a)) => if let Some(sqa) = a { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/signal.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | Ok((r)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - Ok((r)) [INFO] [stdout] 32 + Ok(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/lib.rs:192:22 [INFO] [stdout] | [INFO] [stdout] 192 | Some((de)) => { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - Some((de)) => { [INFO] [stdout] 192 + Some(de) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `XFreer` is never constructed [INFO] [stdout] --> src/xdl/util.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 85 | pub(crate) struct XFreer<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `HierarchyInfo` is never used [INFO] [stdout] --> src/xdl/data.rs:71:7 [INFO] [stdout] | [INFO] [stdout] 71 | trait HierarchyInfo { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_HierarchyChanged` should have an upper case name [INFO] [stdout] --> src/xdl/mod.rs:288:17 [INFO] [stdout] | [INFO] [stdout] 288 | XI_HierarchyChanged => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_HIERARCHY_CHANGED` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_DeviceChanged` should have an upper case name [INFO] [stdout] --> src/xdl/mod.rs:295:17 [INFO] [stdout] | [INFO] [stdout] 295 | XI_DeviceChanged => Some(Event::XIDeviceChange(*(xcookie.data as *mut _))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_DEVICE_CHANGED` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadAccess` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | BadAccess => XlibErr::Access, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper case: `BAD_ACCESS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadValue` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | BadValue => XlibErr::Value, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper case: `BAD_VALUE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadWindow` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | BadWindow => XlibErr::Window, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper case: `BAD_WINDOW` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIKeyClass` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:236:17 [INFO] [stdout] | [INFO] [stdout] 236 | XIKeyClass => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper case: `XIKEY_CLASS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIMasterPointer` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:338:13 [INFO] [stdout] | [INFO] [stdout] 338 | XIMasterPointer => Self::MasterPointer, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIMASTER_POINTER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIMasterKeyboard` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:339:13 [INFO] [stdout] | [INFO] [stdout] 339 | XIMasterKeyboard => Self::MasterKeyboard, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIMASTER_KEYBOARD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XISlavePointer` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:340:13 [INFO] [stdout] | [INFO] [stdout] 340 | XISlavePointer => Self::SlavePointer, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XISLAVE_POINTER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XISlaveKeyboard` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:341:13 [INFO] [stdout] | [INFO] [stdout] 341 | XISlaveKeyboard => Self::SlaveKeyboard, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XISLAVE_KEYBOARD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIFloatingSlave` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:342:13 [INFO] [stdout] | [INFO] [stdout] 342 | XIFloatingSlave => Self::FloatingSlave, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIFLOATING_SLAVE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_KeyPress` should have an upper case name [INFO] [stdout] --> src/xdl/data.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | XI_KeyPress => { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper case: `XI_KEY_PRESS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_KeyRelease` should have an upper case name [INFO] [stdout] --> src/xdl/data.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | XI_KeyRelease => { [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_KEY_RELEASE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/bin/keyv.rs:22:23 [INFO] [stdout] | [INFO] [stdout] 22 | let Some(e) = ( x.recv_timeout(None)) else { [INFO] [stdout] | ^^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 - let Some(e) = ( x.recv_timeout(None)) else { [INFO] [stdout] 22 + let Some(e) = x.recv_timeout(None) else { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/bin/keyv.rs:22:23 [INFO] [stdout] | [INFO] [stdout] 22 | let Some(e) = ( x.recv_timeout(None)) else { [INFO] [stdout] | ^^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 - let Some(e) = ( x.recv_timeout(None)) else { [INFO] [stdout] 22 + let Some(e) = x.recv_timeout(None) else { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `XFreer` is never constructed [INFO] [stdout] --> src/xdl/util.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 85 | pub(crate) struct XFreer<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `HierarchyInfo` is never used [INFO] [stdout] --> src/xdl/data.rs:71:7 [INFO] [stdout] | [INFO] [stdout] 71 | trait HierarchyInfo { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_HierarchyChanged` should have an upper case name [INFO] [stdout] --> src/xdl/mod.rs:288:17 [INFO] [stdout] | [INFO] [stdout] 288 | XI_HierarchyChanged => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_HIERARCHY_CHANGED` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_DeviceChanged` should have an upper case name [INFO] [stdout] --> src/xdl/mod.rs:295:17 [INFO] [stdout] | [INFO] [stdout] 295 | XI_DeviceChanged => Some(Event::XIDeviceChange(*(xcookie.data as *mut _))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_DEVICE_CHANGED` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadAccess` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | BadAccess => XlibErr::Access, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper case: `BAD_ACCESS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadValue` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | BadValue => XlibErr::Value, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper case: `BAD_VALUE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadWindow` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | BadWindow => XlibErr::Window, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper case: `BAD_WINDOW` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIKeyClass` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:236:17 [INFO] [stdout] | [INFO] [stdout] 236 | XIKeyClass => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper case: `XIKEY_CLASS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIMasterPointer` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:338:13 [INFO] [stdout] | [INFO] [stdout] 338 | XIMasterPointer => Self::MasterPointer, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIMASTER_POINTER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIMasterKeyboard` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:339:13 [INFO] [stdout] | [INFO] [stdout] 339 | XIMasterKeyboard => Self::MasterKeyboard, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIMASTER_KEYBOARD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XISlavePointer` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:340:13 [INFO] [stdout] | [INFO] [stdout] 340 | XISlavePointer => Self::SlavePointer, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XISLAVE_POINTER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XISlaveKeyboard` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:341:13 [INFO] [stdout] | [INFO] [stdout] 341 | XISlaveKeyboard => Self::SlaveKeyboard, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XISLAVE_KEYBOARD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIFloatingSlave` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:342:13 [INFO] [stdout] | [INFO] [stdout] 342 | XIFloatingSlave => Self::FloatingSlave, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIFLOATING_SLAVE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_KeyPress` should have an upper case name [INFO] [stdout] --> src/xdl/data.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | XI_KeyPress => { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper case: `XI_KEY_PRESS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_KeyRelease` should have an upper case name [INFO] [stdout] --> src/xdl/data.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | XI_KeyRelease => { [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_KEY_RELEASE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 28 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.77s [INFO] running `Command { std: "docker" "inspect" "aad248ca444b76f80f359b49681038b8acd9bfaa1dabb42b1a81bd7051a5d109", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aad248ca444b76f80f359b49681038b8acd9bfaa1dabb42b1a81bd7051a5d109", kill_on_drop: false }` [INFO] [stdout] aad248ca444b76f80f359b49681038b8acd9bfaa1dabb42b1a81bd7051a5d109 [INFO] checking wzhd/kseqi against try#6289438dbad80b1a0029c66dd3f6abf57c2c51be for pr-126452-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fwzhd%2Fkseqi" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/wzhd/kseqi on toolchain 6289438dbad80b1a0029c66dd3f6abf57c2c51be [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+6289438dbad80b1a0029c66dd3f6abf57c2c51be" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/wzhd/kseqi [INFO] finished tweaking git repo https://github.com/wzhd/kseqi [INFO] tweaked toml for git repo https://github.com/wzhd/kseqi written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/wzhd/kseqi already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+6289438dbad80b1a0029c66dd3f6abf57c2c51be" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+6289438dbad80b1a0029c66dd3f6abf57c2c51be" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f1616f20876605a2076d45fcb477940277115259150406f5f7a35e593afa7774 [INFO] running `Command { std: "docker" "start" "-a" "f1616f20876605a2076d45fcb477940277115259150406f5f7a35e593afa7774", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f1616f20876605a2076d45fcb477940277115259150406f5f7a35e593afa7774", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1616f20876605a2076d45fcb477940277115259150406f5f7a35e593afa7774", kill_on_drop: false }` [INFO] [stdout] f1616f20876605a2076d45fcb477940277115259150406f5f7a35e593afa7774 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+6289438dbad80b1a0029c66dd3f6abf57c2c51be" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7cbb68287c6b81af147c2aa240f584261c89aaa3bfd70f94b2822fe795d0bbc7 [INFO] running `Command { std: "docker" "start" "-a" "7cbb68287c6b81af147c2aa240f584261c89aaa3bfd70f94b2822fe795d0bbc7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling pkg-config v0.3.26 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling x11-dl v2.20.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking mio v0.8.5 [INFO] [stderr] Checking kseqi-desktop v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/xdl/xinput2.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | Ok((xip2)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - Ok((xip2)) [INFO] [stdout] 28 + Ok(xip2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/xinput2.rs:294:22 [INFO] [stdout] | [INFO] [stdout] 294 | let attach = (self.xidi.attachment ); [INFO] [stdout] | ^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 294 - let attach = (self.xidi.attachment ); [INFO] [stdout] 294 + let attach = self.xidi.attachment; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/mod.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | let event = (&*event); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 115 - let event = (&*event); [INFO] [stdout] 115 + let event = &*event; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/mod.rs:527:20 [INFO] [stdout] | [INFO] [stdout] 527 | kbs ^= (1 << b1p); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 527 - kbs ^= (1 << b1p); [INFO] [stdout] 527 + kbs ^= 1 << b1p; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/conf/mod.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | for (a) in self.acts.iter() { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 118 - for (a) in self.acts.iter() { [INFO] [stdout] 118 + for a in self.acts.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/conf/mod.rs:173:24 [INFO] [stdout] | [INFO] [stdout] 173 | let a = if (&self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0) { "↘"}else {"↗"}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 173 - let a = if (&self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0) { "↘"}else {"↗"}; [INFO] [stdout] 173 + let a = if &self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0 { "↘"}else {"↗"}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/conf/mod.rs:213:43 [INFO] [stdout] | [INFO] [stdout] 213 | Ok((input, a)) => if let Some((sqa)) = a { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 213 - Ok((input, a)) => if let Some((sqa)) = a { [INFO] [stdout] 213 + Ok((input, a)) => if let Some(sqa) = a { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/signal.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | Ok((r)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - Ok((r)) [INFO] [stdout] 32 + Ok(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/lib.rs:192:22 [INFO] [stdout] | [INFO] [stdout] 192 | Some((de)) => { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - Some((de)) => { [INFO] [stdout] 192 + Some(de) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/xdl/xinput2.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | Ok((xip2)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - Ok((xip2)) [INFO] [stdout] 28 + Ok(xip2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/xinput2.rs:294:22 [INFO] [stdout] | [INFO] [stdout] 294 | let attach = (self.xidi.attachment ); [INFO] [stdout] | ^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 294 - let attach = (self.xidi.attachment ); [INFO] [stdout] 294 + let attach = self.xidi.attachment; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/mod.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | let event = (&*event); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 115 - let event = (&*event); [INFO] [stdout] 115 + let event = &*event; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/xdl/mod.rs:527:20 [INFO] [stdout] | [INFO] [stdout] 527 | kbs ^= (1 << b1p); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 527 - kbs ^= (1 << b1p); [INFO] [stdout] 527 + kbs ^= 1 << b1p; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/conf/mod.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | for (a) in self.acts.iter() { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 118 - for (a) in self.acts.iter() { [INFO] [stdout] 118 + for a in self.acts.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/conf/mod.rs:173:24 [INFO] [stdout] | [INFO] [stdout] 173 | let a = if (&self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0) { "↘"}else {"↗"}; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 173 - let a = if (&self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0) { "↘"}else {"↗"}; [INFO] [stdout] 173 + let a = if &self.sq[..i].iter().filter(|&a| a == k).count() %2 ==0 { "↘"}else {"↗"}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/conf/mod.rs:213:43 [INFO] [stdout] | [INFO] [stdout] 213 | Ok((input, a)) => if let Some((sqa)) = a { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 213 - Ok((input, a)) => if let Some((sqa)) = a { [INFO] [stdout] 213 + Ok((input, a)) => if let Some(sqa) = a { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/conf/mod.rs:378:36 [INFO] [stdout] | [INFO] [stdout] 378 | let sv = SmoVec::from_iter((0..10)).unwrap(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 378 - let sv = SmoVec::from_iter((0..10)).unwrap(); [INFO] [stdout] 378 + let sv = SmoVec::from_iter(0..10).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/conf/mod.rs:380:36 [INFO] [stdout] | [INFO] [stdout] 380 | let sv = SmoVec::from_iter((0..6)).unwrap(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 380 - let sv = SmoVec::from_iter((0..6)).unwrap(); [INFO] [stdout] 380 + let sv = SmoVec::from_iter(0..6).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/conf/mod.rs:382:36 [INFO] [stdout] | [INFO] [stdout] 382 | let sv = SmoVec::from_iter((0..8)).unwrap(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 382 - let sv = SmoVec::from_iter((0..8)).unwrap(); [INFO] [stdout] 382 + let sv = SmoVec::from_iter(0..8).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/conf/mod.rs:384:36 [INFO] [stdout] | [INFO] [stdout] 384 | let sv = SmoVec::from_iter((0..7)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 384 - let sv = SmoVec::from_iter((0..7)); [INFO] [stdout] 384 + let sv = SmoVec::from_iter(0..7); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/signal.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | Ok((r)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - Ok((r)) [INFO] [stdout] 32 + Ok(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/lib.rs:192:22 [INFO] [stdout] | [INFO] [stdout] 192 | Some((de)) => { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - Some((de)) => { [INFO] [stdout] 192 + Some(de) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `XFreer` is never constructed [INFO] [stdout] --> src/xdl/util.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 85 | pub(crate) struct XFreer<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `HierarchyInfo` is never used [INFO] [stdout] --> src/xdl/data.rs:71:7 [INFO] [stdout] | [INFO] [stdout] 71 | trait HierarchyInfo { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_HierarchyChanged` should have an upper case name [INFO] [stdout] --> src/xdl/mod.rs:288:17 [INFO] [stdout] | [INFO] [stdout] 288 | XI_HierarchyChanged => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_HIERARCHY_CHANGED` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_DeviceChanged` should have an upper case name [INFO] [stdout] --> src/xdl/mod.rs:295:17 [INFO] [stdout] | [INFO] [stdout] 295 | XI_DeviceChanged => Some(Event::XIDeviceChange(*(xcookie.data as *mut _))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_DEVICE_CHANGED` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadAccess` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | BadAccess => XlibErr::Access, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper case: `BAD_ACCESS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadValue` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | BadValue => XlibErr::Value, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper case: `BAD_VALUE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadWindow` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | BadWindow => XlibErr::Window, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper case: `BAD_WINDOW` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIKeyClass` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:236:17 [INFO] [stdout] | [INFO] [stdout] 236 | XIKeyClass => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper case: `XIKEY_CLASS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIMasterPointer` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:338:13 [INFO] [stdout] | [INFO] [stdout] 338 | XIMasterPointer => Self::MasterPointer, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIMASTER_POINTER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIMasterKeyboard` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:339:13 [INFO] [stdout] | [INFO] [stdout] 339 | XIMasterKeyboard => Self::MasterKeyboard, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIMASTER_KEYBOARD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XISlavePointer` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:340:13 [INFO] [stdout] | [INFO] [stdout] 340 | XISlavePointer => Self::SlavePointer, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XISLAVE_POINTER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XISlaveKeyboard` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:341:13 [INFO] [stdout] | [INFO] [stdout] 341 | XISlaveKeyboard => Self::SlaveKeyboard, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XISLAVE_KEYBOARD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIFloatingSlave` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:342:13 [INFO] [stdout] | [INFO] [stdout] 342 | XIFloatingSlave => Self::FloatingSlave, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIFLOATING_SLAVE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_KeyPress` should have an upper case name [INFO] [stdout] --> src/xdl/data.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | XI_KeyPress => { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper case: `XI_KEY_PRESS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_KeyRelease` should have an upper case name [INFO] [stdout] --> src/xdl/data.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | XI_KeyRelease => { [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_KEY_RELEASE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/bin/keyv.rs:22:23 [INFO] [stdout] | [INFO] [stdout] 22 | let Some(e) = ( x.recv_timeout(None)) else { [INFO] [stdout] | ^^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 - let Some(e) = ( x.recv_timeout(None)) else { [INFO] [stdout] 22 + let Some(e) = x.recv_timeout(None) else { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/bin/keyv.rs:22:23 [INFO] [stdout] | [INFO] [stdout] 22 | let Some(e) = ( x.recv_timeout(None)) else { [INFO] [stdout] | ^^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 - let Some(e) = ( x.recv_timeout(None)) else { [INFO] [stdout] 22 + let Some(e) = x.recv_timeout(None) else { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `XFreer` is never constructed [INFO] [stdout] --> src/xdl/util.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 85 | pub(crate) struct XFreer<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `HierarchyInfo` is never used [INFO] [stdout] --> src/xdl/data.rs:71:7 [INFO] [stdout] | [INFO] [stdout] 71 | trait HierarchyInfo { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_HierarchyChanged` should have an upper case name [INFO] [stdout] --> src/xdl/mod.rs:288:17 [INFO] [stdout] | [INFO] [stdout] 288 | XI_HierarchyChanged => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_HIERARCHY_CHANGED` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_DeviceChanged` should have an upper case name [INFO] [stdout] --> src/xdl/mod.rs:295:17 [INFO] [stdout] | [INFO] [stdout] 295 | XI_DeviceChanged => Some(Event::XIDeviceChange(*(xcookie.data as *mut _))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_DEVICE_CHANGED` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadAccess` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | BadAccess => XlibErr::Access, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper case: `BAD_ACCESS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadValue` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | BadValue => XlibErr::Value, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper case: `BAD_VALUE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `BadWindow` should have an upper case name [INFO] [stdout] --> src/xdl/err.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | BadWindow => XlibErr::Window, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper case: `BAD_WINDOW` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIKeyClass` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:236:17 [INFO] [stdout] | [INFO] [stdout] 236 | XIKeyClass => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper case: `XIKEY_CLASS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIMasterPointer` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:338:13 [INFO] [stdout] | [INFO] [stdout] 338 | XIMasterPointer => Self::MasterPointer, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIMASTER_POINTER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIMasterKeyboard` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:339:13 [INFO] [stdout] | [INFO] [stdout] 339 | XIMasterKeyboard => Self::MasterKeyboard, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIMASTER_KEYBOARD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XISlavePointer` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:340:13 [INFO] [stdout] | [INFO] [stdout] 340 | XISlavePointer => Self::SlavePointer, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XISLAVE_POINTER` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XISlaveKeyboard` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:341:13 [INFO] [stdout] | [INFO] [stdout] 341 | XISlaveKeyboard => Self::SlaveKeyboard, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XISLAVE_KEYBOARD` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XIFloatingSlave` should have an upper case name [INFO] [stdout] --> src/xdl/xinput2.rs:342:13 [INFO] [stdout] | [INFO] [stdout] 342 | XIFloatingSlave => Self::FloatingSlave, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `XIFLOATING_SLAVE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_KeyPress` should have an upper case name [INFO] [stdout] --> src/xdl/data.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | XI_KeyPress => { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper case: `XI_KEY_PRESS` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant in pattern `XI_KeyRelease` should have an upper case name [INFO] [stdout] --> src/xdl/data.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | XI_KeyRelease => { [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper case: `XI_KEY_RELEASE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 28 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.90s [INFO] running `Command { std: "docker" "inspect" "7cbb68287c6b81af147c2aa240f584261c89aaa3bfd70f94b2822fe795d0bbc7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7cbb68287c6b81af147c2aa240f584261c89aaa3bfd70f94b2822fe795d0bbc7", kill_on_drop: false }` [INFO] [stdout] 7cbb68287c6b81af147c2aa240f584261c89aaa3bfd70f94b2822fe795d0bbc7