[INFO] fetching crate embedded-flight-control 0.2.1... [INFO] checking embedded-flight-control-0.2.1 against master#506512391b1a75ae450d36c9420978402a91abcc for pr-125107-1 [INFO] extracting crate embedded-flight-control 0.2.1 into /workspace/builds/worker-7-tc1/source [INFO] validating manifest of crates.io crate embedded-flight-control 0.2.1 on toolchain 506512391b1a75ae450d36c9420978402a91abcc [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+506512391b1a75ae450d36c9420978402a91abcc" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate embedded-flight-control 0.2.1 [INFO] finished tweaking crates.io crate embedded-flight-control 0.2.1 [INFO] tweaked toml for crates.io crate embedded-flight-control 0.2.1 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+506512391b1a75ae450d36c9420978402a91abcc" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 18 packages to latest compatible versions [INFO] [stderr] Adding nalgebra v0.31.4 (latest: v0.32.5) [INFO] [stderr] Adding num v0.3.1 (latest: v0.4.3) [INFO] [stderr] Adding num-complex v0.3.1 (latest: v0.4.6) [INFO] [stderr] Adding num-rational v0.3.2 (latest: v0.4.2) [INFO] [stderr] Adding simba v0.7.3 (latest: v0.8.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+506512391b1a75ae450d36c9420978402a91abcc" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded simba v0.7.3 [INFO] [stderr] Downloaded embedded-flight-core v0.1.1 [INFO] [stderr] Downloaded num-rational v0.4.2 [INFO] [stderr] Downloaded paste v1.0.15 [INFO] [stderr] Downloaded approx v0.5.1 [INFO] [stderr] Downloaded nalgebra v0.31.4 [INFO] [stderr] Downloaded num-complex v0.4.6 [INFO] [stderr] Downloaded typenum v1.17.0 [INFO] [stderr] Downloaded libm v0.2.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:59a85a07ab18ca8720692f8e61effa1c651d9e2ca591e072c2b212bb91a6b8b5" "/opt/rustwide/cargo-home/bin/cargo" "+506512391b1a75ae450d36c9420978402a91abcc" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 15ab0b3ecc3afac11a660af38817b14b0a8a03fef0b0749d812608567f8403d1 [INFO] running `Command { std: "docker" "start" "-a" "15ab0b3ecc3afac11a660af38817b14b0a8a03fef0b0749d812608567f8403d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "15ab0b3ecc3afac11a660af38817b14b0a8a03fef0b0749d812608567f8403d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "15ab0b3ecc3afac11a660af38817b14b0a8a03fef0b0749d812608567f8403d1", kill_on_drop: false }` [INFO] [stdout] 15ab0b3ecc3afac11a660af38817b14b0a8a03fef0b0749d812608567f8403d1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:59a85a07ab18ca8720692f8e61effa1c651d9e2ca591e072c2b212bb91a6b8b5" "/opt/rustwide/cargo-home/bin/cargo" "+506512391b1a75ae450d36c9420978402a91abcc" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 18762907fd41fa7780aec2e1dbdf86ed12a440c7ef9fae6560aaa57a8676127a [INFO] running `Command { std: "docker" "start" "-a" "18762907fd41fa7780aec2e1dbdf86ed12a440c7ef9fae6560aaa57a8676127a", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-complex v0.3.1 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking simba v0.7.3 [INFO] [stderr] Checking num v0.3.1 [INFO] [stderr] Checking embedded-time v0.12.1 [INFO] [stderr] Checking nalgebra v0.31.4 [INFO] [stderr] Checking embedded-flight-core v0.1.1 [INFO] [stderr] Checking embedded-flight-control v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/attitude/mod.rs:239:12 [INFO] [stdout] | [INFO] [stdout] 239 | if (self.p_angle_yaw.kp != 0. [INFO] [stdout] | ^ [INFO] [stdout] 240 | && attitude_error.z.abs() [INFO] [stdout] 241 | > ac_attitude_accel_y_controller_max_radss / self.p_angle_yaw.kp) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 239 ~ if self.p_angle_yaw.kp != 0. [INFO] [stdout] 240 | && attitude_error.z.abs() [INFO] [stdout] 241 ~ > ac_attitude_accel_y_controller_max_radss / self.p_angle_yaw.kp [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/attitude/mod.rs:542:12 [INFO] [stdout] | [INFO] [stdout] 542 | if (error > linear_dist) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 542 - if (error > linear_dist) { [INFO] [stdout] 542 + if error > linear_dist { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/attitude/mod.rs:544:19 [INFO] [stdout] | [INFO] [stdout] 544 | } else if (error < -linear_dist) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 544 - } else if (error < -linear_dist) { [INFO] [stdout] 544 + } else if error < -linear_dist { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Quaternion`, `Vector3` [INFO] [stdout] --> src/attitude/multi_copter.rs:169:20 [INFO] [stdout] | [INFO] [stdout] 169 | use nalgebra::{Quaternion, Vector3}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::MultiCopterAttitudeController` [INFO] [stdout] --> src/attitude/multi_copter.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | use super::MultiCopterAttitudeController; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/attitude/mod.rs:239:12 [INFO] [stdout] | [INFO] [stdout] 239 | if (self.p_angle_yaw.kp != 0. [INFO] [stdout] | ^ [INFO] [stdout] 240 | && attitude_error.z.abs() [INFO] [stdout] 241 | > ac_attitude_accel_y_controller_max_radss / self.p_angle_yaw.kp) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 239 ~ if self.p_angle_yaw.kp != 0. [INFO] [stdout] 240 | && attitude_error.z.abs() [INFO] [stdout] 241 ~ > ac_attitude_accel_y_controller_max_radss / self.p_angle_yaw.kp [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/attitude/mod.rs:542:12 [INFO] [stdout] | [INFO] [stdout] 542 | if (error > linear_dist) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 542 - if (error > linear_dist) { [INFO] [stdout] 542 + if error > linear_dist { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/attitude/mod.rs:544:19 [INFO] [stdout] | [INFO] [stdout] 544 | } else if (error < -linear_dist) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 544 - } else if (error < -linear_dist) { [INFO] [stdout] 544 + } else if error < -linear_dist { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `thrust_angle` [INFO] [stdout] --> src/attitude/mod.rs:230:14 [INFO] [stdout] | [INFO] [stdout] 230 | let (thrust_angle, thrust_vector_correction, mut attitude_error, thrust_error_angle) = [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_thrust_angle` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `thrust_error_angle` [INFO] [stdout] --> src/attitude/mod.rs:230:74 [INFO] [stdout] | [INFO] [stdout] 230 | let (thrust_angle, thrust_vector_correction, mut attitude_error, thrust_error_angle) = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_thrust_error_angle` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `initial_filt_T_hz` should have a snake case name [INFO] [stdout] --> src/pid/mod.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | initial_filt_T_hz: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `initial_filt_t_hz` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `initial_filt_E_hz` should have a snake case name [INFO] [stdout] --> src/pid/mod.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | initial_filt_E_hz: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `initial_filt_e_hz` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `initial_filt_D_hz` should have a snake case name [INFO] [stdout] --> src/pid/mod.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | initial_filt_D_hz: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `initial_filt_d_hz` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `initial_filt_T_hz` should have a snake case name [INFO] [stdout] --> src/pid/mod.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | initial_filt_T_hz: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `initial_filt_t_hz` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `initial_filt_E_hz` should have a snake case name [INFO] [stdout] --> src/pid/mod.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | initial_filt_E_hz: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `initial_filt_e_hz` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `initial_filt_D_hz` should have a snake case name [INFO] [stdout] --> src/pid/mod.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | initial_filt_D_hz: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `initial_filt_d_hz` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `wrap_PI` should have a snake case name [INFO] [stdout] --> src/attitude/mod.rs:637:4 [INFO] [stdout] | [INFO] [stdout] 637 | fn wrap_PI(radian: f32) -> f32 { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `wrap_pi` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `wrap_2PI` should have a snake case name [INFO] [stdout] --> src/attitude/mod.rs:646:4 [INFO] [stdout] | [INFO] [stdout] 646 | fn wrap_2PI(radian: f32) -> f32 { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `wrap_2_pi` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num_traits::Float` [INFO] [stdout] --> src/pid/slew_limiter.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use num_traits::Float; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num_traits::Float` [INFO] [stdout] --> src/attitude/mod.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use num_traits::Float; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `thrust_angle` [INFO] [stdout] --> src/attitude/mod.rs:230:14 [INFO] [stdout] | [INFO] [stdout] 230 | let (thrust_angle, thrust_vector_correction, mut attitude_error, thrust_error_angle) = [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_thrust_angle` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `thrust_error_angle` [INFO] [stdout] --> src/attitude/mod.rs:230:74 [INFO] [stdout] | [INFO] [stdout] 230 | let (thrust_angle, thrust_vector_correction, mut attitude_error, thrust_error_angle) = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_thrust_error_angle` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `initial_filt_T_hz` should have a snake case name [INFO] [stdout] --> src/pid/mod.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | initial_filt_T_hz: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `initial_filt_t_hz` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `initial_filt_E_hz` should have a snake case name [INFO] [stdout] --> src/pid/mod.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | initial_filt_E_hz: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `initial_filt_e_hz` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `initial_filt_D_hz` should have a snake case name [INFO] [stdout] --> src/pid/mod.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | initial_filt_D_hz: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `initial_filt_d_hz` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `initial_filt_T_hz` should have a snake case name [INFO] [stdout] --> src/pid/mod.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | initial_filt_T_hz: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `initial_filt_t_hz` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `initial_filt_E_hz` should have a snake case name [INFO] [stdout] --> src/pid/mod.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | initial_filt_E_hz: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `initial_filt_e_hz` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `initial_filt_D_hz` should have a snake case name [INFO] [stdout] --> src/pid/mod.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | initial_filt_D_hz: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `initial_filt_d_hz` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `wrap_PI` should have a snake case name [INFO] [stdout] --> src/attitude/mod.rs:637:4 [INFO] [stdout] | [INFO] [stdout] 637 | fn wrap_PI(radian: f32) -> f32 { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `wrap_pi` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `wrap_2PI` should have a snake case name [INFO] [stdout] --> src/attitude/mod.rs:646:4 [INFO] [stdout] | [INFO] [stdout] 646 | fn wrap_2PI(radian: f32) -> f32 { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `wrap_2_pi` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.58s [INFO] running `Command { std: "docker" "inspect" "18762907fd41fa7780aec2e1dbdf86ed12a440c7ef9fae6560aaa57a8676127a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18762907fd41fa7780aec2e1dbdf86ed12a440c7ef9fae6560aaa57a8676127a", kill_on_drop: false }` [INFO] [stdout] 18762907fd41fa7780aec2e1dbdf86ed12a440c7ef9fae6560aaa57a8676127a