[INFO] cloning repository https://github.com/tzAcee/rs_chip8 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tzAcee/rs_chip8" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FtzAcee%2Frs_chip8", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FtzAcee%2Frs_chip8'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c4007ff5ee94e1ee0127843e609db1cefe809355 [INFO] checking tzAcee/rs_chip8 against master#c2239bca5b89a8d3573cc0fc0f2fa65c50edb79c for pr-123737 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FtzAcee%2Frs_chip8" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/tzAcee/rs_chip8 on toolchain c2239bca5b89a8d3573cc0fc0f2fa65c50edb79c [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c2239bca5b89a8d3573cc0fc0f2fa65c50edb79c" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/tzAcee/rs_chip8 [INFO] finished tweaking git repo https://github.com/tzAcee/rs_chip8 [INFO] tweaked toml for git repo https://github.com/tzAcee/rs_chip8 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/tzAcee/rs_chip8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c2239bca5b89a8d3573cc0fc0f2fa65c50edb79c" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pulldown-cmark v0.9.2 [INFO] [stderr] Downloaded proc-macro-crate v1.2.0 [INFO] [stderr] Downloaded owned_ttf_parser v0.15.1 [INFO] [stderr] Downloaded camino v1.0.9 [INFO] [stderr] Downloaded bytemuck v1.11.0 [INFO] [stderr] Downloaded glyph_brush v0.7.4 [INFO] [stderr] Downloaded glam v0.20.5 [INFO] [stderr] Downloaded ggez v0.7.0 [INFO] [stderr] Downloaded libc v0.2.127 [INFO] [stderr] Downloaded serde_json v1.0.83 [INFO] [stderr] Downloaded euclid v0.22.7 [INFO] [stderr] Downloaded serde_derive v1.0.142 [INFO] [stderr] Downloaded serde v1.0.142 [INFO] [stderr] Downloaded semver v1.0.13 [INFO] [stderr] Downloaded ab_glyph v0.2.15 [INFO] [stderr] Downloaded ordered-float v3.0.0 [INFO] [stderr] Downloaded bytecount v0.6.3 [INFO] [stderr] Downloaded crossbeam-queue v0.3.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+c2239bca5b89a8d3573cc0fc0f2fa65c50edb79c" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2c21c0f3b421af5cbf3d134fc55d701b44d964dd6f75bcd204d28f3f5a18130b [INFO] running `Command { std: "docker" "start" "-a" "2c21c0f3b421af5cbf3d134fc55d701b44d964dd6f75bcd204d28f3f5a18130b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2c21c0f3b421af5cbf3d134fc55d701b44d964dd6f75bcd204d28f3f5a18130b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c21c0f3b421af5cbf3d134fc55d701b44d964dd6f75bcd204d28f3f5a18130b", kill_on_drop: false }` [INFO] [stdout] 2c21c0f3b421af5cbf3d134fc55d701b44d964dd6f75bcd204d28f3f5a18130b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+c2239bca5b89a8d3573cc0fc0f2fa65c50edb79c" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cb1ef52fe998032bb9159aff3256564569c801982f88570d093b72ccbc1b6201 [INFO] running `Command { std: "docker" "start" "-a" "cb1ef52fe998032bb9159aff3256564569c801982f88570d093b72ccbc1b6201", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.127 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling xml-rs v0.8.4 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling crossbeam-epoch v0.9.10 [INFO] [stderr] Compiling wayland-sys v0.28.6 [INFO] [stderr] Checking libloading v0.7.3 [INFO] [stderr] Compiling serde_derive v1.0.142 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.5 [INFO] [stderr] Compiling serde v1.0.142 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Checking dlib v0.5.0 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Checking crossbeam-utils v0.8.11 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking ttf-parser v0.6.2 [INFO] [stderr] Compiling crossbeam-queue v0.3.6 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling x11-dl v2.19.1 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Compiling camino v1.0.9 [INFO] [stderr] Compiling serde_json v1.0.83 [INFO] [stderr] Compiling semver v1.0.13 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Checking crossbeam-deque v0.8.2 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Compiling pulldown-cmark v0.9.2 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking owned_ttf_parser v0.15.1 [INFO] [stderr] Compiling wayland-scanner v0.28.6 [INFO] [stderr] Checking crossbeam v0.8.2 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling minimp3-sys v0.3.2 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking euclid v0.22.7 [INFO] [stderr] Compiling fastrand v1.8.0 [INFO] [stderr] Compiling remove_dir_all v0.5.3 [INFO] [stderr] Checking gfx_core v0.9.2 [INFO] [stderr] Checking num-integer v0.1.45 [INFO] [stderr] Checking ab_glyph v0.2.15 [INFO] [stderr] Checking owned_ttf_parser v0.6.0 [INFO] [stderr] Checking rusttype v0.9.2 [INFO] [stderr] Compiling tempfile v3.3.0 [INFO] [stderr] Compiling gfx_gl v0.6.1 [INFO] [stderr] Compiling glutin_egl_sys v0.1.6 [INFO] [stderr] Checking nix v0.20.0 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking nix v0.18.0 [INFO] [stderr] Checking xdg v2.4.1 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking memmap2 v0.1.0 [INFO] [stderr] Checking andrew v0.3.1 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking lyon_geom v0.17.7 [INFO] [stderr] Checking xcursor v0.3.4 [INFO] [stderr] Compiling glutin_glx_sys v0.1.8 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking raw-window-handle v0.3.4 [INFO] [stderr] Checking mio-misc v1.2.2 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Compiling cpal v0.13.5 [INFO] [stderr] Checking either v1.7.0 [INFO] [stderr] Compiling bytecount v0.6.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling wayland-client v0.28.6 [INFO] [stderr] Compiling wayland-protocols v0.28.6 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking lyon_path v0.17.7 [INFO] [stderr] Checking slice-deque v0.3.0 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking float_next_after v0.1.5 [INFO] [stderr] Checking sid v0.6.1 [INFO] [stderr] Checking ogg v0.8.0 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking lyon_tessellation v0.17.10 [INFO] [stderr] Checking lyon_algorithms v0.17.7 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking glyph_brush_layout v0.2.3 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking num-iter v0.1.43 [INFO] [stderr] Checking num-rational v0.3.2 [INFO] [stderr] Checking bzip2 v0.4.3 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking ordered-float v3.0.0 [INFO] [stderr] Checking mint v0.5.9 [INFO] [stderr] Checking hound v3.4.0 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Checking bytemuck v1.11.0 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Checking lyon v0.17.10 [INFO] [stderr] Checking gfx v0.18.2 [INFO] [stderr] Checking directories v3.0.2 [INFO] [stderr] Checking glam v0.21.3 [INFO] [stderr] Checking glam v0.20.5 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking gfx_device_gl v0.16.2 [INFO] [stderr] Compiling thiserror-impl v1.0.32 [INFO] [stderr] Compiling smart-default v0.6.0 [INFO] [stderr] Checking glyph_brush_draw_cache v0.1.5 [INFO] [stderr] Checking wayland-commons v0.28.6 [INFO] [stderr] Checking calloop v0.6.5 [INFO] [stderr] Checking alsa v0.6.0 [INFO] [stderr] Checking gilrs-core v0.3.2 [INFO] [stderr] Checking glyph_brush v0.7.4 [INFO] [stderr] Checking gilrs v0.8.2 [INFO] [stderr] Checking thiserror v1.0.32 [INFO] [stderr] Checking minimp3 v0.5.1 [INFO] [stderr] Checking zip v0.5.13 [INFO] [stderr] Checking wayland-cursor v0.28.6 [INFO] [stderr] Checking wayland-egl v0.28.6 [INFO] [stderr] Checking rodio v0.14.0 [INFO] [stderr] Checking toml v0.5.9 [INFO] [stderr] Compiling cargo-platform v0.1.2 [INFO] [stderr] Checking smithay-client-toolkit v0.12.3 [INFO] [stderr] Compiling cargo_metadata v0.14.2 [INFO] [stderr] Checking winit v0.25.0 [INFO] [stderr] Compiling skeptic v0.13.7 [INFO] [stderr] Compiling ggez v0.7.0 [INFO] [stderr] Checking glutin v0.27.0 [INFO] [stderr] Checking old_school_gfx_glutin_ext v0.27.0 [INFO] [stderr] Checking rs_chip8 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::fs::File` [INFO] [stdout] --> src/chip8/chip8_mods/memory.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fs::File; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::chip8::chip8_mods::memory` [INFO] [stdout] --> src/chip8/chip8_mods/program_counter.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::chip8::chip8_mods::memory; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::VecDeque` [INFO] [stdout] --> src/chip8/chip8_mods/stack.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::VecDeque; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/chip8/chip8_mods/delay_timer.rs:11:11 [INFO] [stdout] | [INFO] [stdout] 11 | if(self.value>=0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 11 - if(self.value>=0) { [INFO] [stdout] 11 + if self.value>=0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/chip8/chip8_mods/sound_timer.rs:11:11 [INFO] [stdout] | [INFO] [stdout] 11 | if(self.value>=0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 11 - if(self.value>=0) { [INFO] [stdout] 11 + if self.value>=0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Color` [INFO] [stdout] --> src/chip8.rs:4:28 [INFO] [stdout] | [INFO] [stdout] 4 | use ggez::graphics::{self, Color}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `current`, `self`, `time` [INFO] [stdout] --> src/chip8.rs:10:14 [INFO] [stdout] | [INFO] [stdout] 10 | thread::{self, current}, [INFO] [stdout] | ^^^^ ^^^^^^^ [INFO] [stdout] 11 | time, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/chip8.rs:58:36 [INFO] [stdout] | [INFO] [stdout] 58 | let last_bit = ((*this).current_instruction & 0x000F); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - let last_bit = ((*this).current_instruction & 0x000F); [INFO] [stdout] 58 + let last_bit = (*this).current_instruction & 0x000F; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/chip8.rs:196:23 [INFO] [stdout] | [INFO] [stdout] 196 | if(minuend > subtrahend) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 196 - if(minuend > subtrahend) { [INFO] [stdout] 196 + if minuend > subtrahend { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/chip8.rs:217:23 [INFO] [stdout] | [INFO] [stdout] 217 | if(minuend > subtrahend) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 217 - if(minuend > subtrahend) { [INFO] [stdout] 217 + if minuend > subtrahend { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/chip8.rs:290:29 [INFO] [stdout] | [INFO] [stdout] 290 | let N = ((*this).current_instruction & 0x000F); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 290 - let N = ((*this).current_instruction & 0x000F); [INFO] [stdout] 290 + let N = (*this).current_instruction & 0x000F; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/chip8.rs:296:42 [INFO] [stdout] | [INFO] [stdout] 296 | ... let is_set = (nth_byte >> (7 - i) & 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 296 - let is_set = (nth_byte >> (7 - i) & 1); [INFO] [stdout] 296 + let is_set = nth_byte >> (7 - i) & 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs::File` [INFO] [stdout] --> src/chip8/chip8_mods/memory.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fs::File; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::chip8::chip8_mods::memory` [INFO] [stdout] --> src/chip8/chip8_mods/program_counter.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::chip8::chip8_mods::memory; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::VecDeque` [INFO] [stdout] --> src/chip8/chip8_mods/stack.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::VecDeque; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/chip8/chip8_mods/delay_timer.rs:11:11 [INFO] [stdout] | [INFO] [stdout] 11 | if(self.value>=0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 11 - if(self.value>=0) { [INFO] [stdout] 11 + if self.value>=0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/chip8/chip8_mods/sound_timer.rs:11:11 [INFO] [stdout] | [INFO] [stdout] 11 | if(self.value>=0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 11 - if(self.value>=0) { [INFO] [stdout] 11 + if self.value>=0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Color` [INFO] [stdout] --> src/chip8.rs:4:28 [INFO] [stdout] | [INFO] [stdout] 4 | use ggez::graphics::{self, Color}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `current`, `self`, `time` [INFO] [stdout] --> src/chip8.rs:10:14 [INFO] [stdout] | [INFO] [stdout] 10 | thread::{self, current}, [INFO] [stdout] | ^^^^ ^^^^^^^ [INFO] [stdout] 11 | time, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/chip8.rs:58:36 [INFO] [stdout] | [INFO] [stdout] 58 | let last_bit = ((*this).current_instruction & 0x000F); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - let last_bit = ((*this).current_instruction & 0x000F); [INFO] [stdout] 58 + let last_bit = (*this).current_instruction & 0x000F; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/chip8.rs:196:23 [INFO] [stdout] | [INFO] [stdout] 196 | if(minuend > subtrahend) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 196 - if(minuend > subtrahend) { [INFO] [stdout] 196 + if minuend > subtrahend { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/chip8.rs:217:23 [INFO] [stdout] | [INFO] [stdout] 217 | if(minuend > subtrahend) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 217 - if(minuend > subtrahend) { [INFO] [stdout] 217 + if minuend > subtrahend { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/chip8.rs:290:29 [INFO] [stdout] | [INFO] [stdout] 290 | let N = ((*this).current_instruction & 0x000F); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 290 - let N = ((*this).current_instruction & 0x000F); [INFO] [stdout] 290 + let N = (*this).current_instruction & 0x000F; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/chip8.rs:296:42 [INFO] [stdout] | [INFO] [stdout] 296 | ... let is_set = (nth_byte >> (7 - i) & 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 296 - let is_set = (nth_byte >> (7 - i) & 1); [INFO] [stdout] 296 + let is_set = nth_byte >> (7 - i) & 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude` [INFO] [stdout] --> src/chip8/chip8_mods/memory.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `abc` [INFO] [stdout] --> src/chip8/chip8_mods/memory.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | let abc: u8 = 0xf0; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_abc` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `this` [INFO] [stdout] --> src/chip8.rs:39:34 [INFO] [stdout] | [INFO] [stdout] 39 | current_function: { |this| () }, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_this` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `current_vx` is never read [INFO] [stdout] --> src/chip8.rs:282:29 [INFO] [stdout] | [INFO] [stdout] 282 | let mut current_vx = (*this).variable_registers[X as usize].get() % 64; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude` [INFO] [stdout] --> src/chip8/chip8_mods/memory.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `abc` [INFO] [stdout] --> src/chip8/chip8_mods/memory.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | let abc: u8 = 0xf0; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_abc` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/chip8.rs:363:25 [INFO] [stdout] | [INFO] [stdout] 363 | let mut color = graphics::Color::WHITE; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `delay_timer` and `sound_timer` are never read [INFO] [stdout] --> src/chip8.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Chip8 { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 20 | delay_timer: delay_timer::DelayTimer, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 21 | sound_timer: sound_timer::SoundTimer, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `memory_size` is never used [INFO] [stdout] --> src/chip8/chip8_mods/program_counter.rs:17:15 [INFO] [stdout] | [INFO] [stdout] 17 | const memory_size: u32 = 4096; // KB [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `pop` is never used [INFO] [stdout] --> src/chip8/chip8_mods/stack.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 8 | impl Stack { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn pop(&mut self) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `value` is never read [INFO] [stdout] --> src/chip8/chip8_mods/delay_timer.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct DelayTimer { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 2 | value: u8 [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `tick` and `get_value` are never used [INFO] [stdout] --> src/chip8/chip8_mods/delay_timer.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 5 | impl DelayTimer { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 10 | pub fn tick(&mut self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 18 | pub fn get_value(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `value` is never read [INFO] [stdout] --> src/chip8/chip8_mods/sound_timer.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct SoundTimer { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 2 | value: u8 [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `tick` and `get_value` are never used [INFO] [stdout] --> src/chip8/chip8_mods/sound_timer.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 5 | impl SoundTimer { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 10 | pub fn tick(&mut self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | pub fn get_value(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NNN` should have a snake case name [INFO] [stdout] --> src/chip8.rs:84:25 [INFO] [stdout] | [INFO] [stdout] 84 | let NNN = ((*this).current_instruction & 0x0FFF) as u8; [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `nnn` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:94:25 [INFO] [stdout] | [INFO] [stdout] 94 | let X = ((*this).current_instruction & 0x0F00) >> 8; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NN` should have a snake case name [INFO] [stdout] --> src/chip8.rs:96:25 [INFO] [stdout] | [INFO] [stdout] 96 | let NN = ((*this).current_instruction & 0x00FF) as u8; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `nn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:108:25 [INFO] [stdout] | [INFO] [stdout] 108 | let X = ((*this).current_instruction & 0x0F00) >> 8; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NN` should have a snake case name [INFO] [stdout] --> src/chip8.rs:110:25 [INFO] [stdout] | [INFO] [stdout] 110 | let NN = ((*this).current_instruction & 0x00FF) as u8; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `nn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:122:25 [INFO] [stdout] | [INFO] [stdout] 122 | let X = ((*this).current_instruction & 0x0F00) >> 8; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Y` should have a snake case name [INFO] [stdout] --> src/chip8.rs:124:25 [INFO] [stdout] | [INFO] [stdout] 124 | let Y = ((*this).current_instruction & 0x00F0) >> 4; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NN` should have a snake case name [INFO] [stdout] --> src/chip8.rs:137:25 [INFO] [stdout] | [INFO] [stdout] 137 | let NN = ((*this).current_instruction & 0x00FF) as u8; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `nn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:138:25 [INFO] [stdout] | [INFO] [stdout] 138 | let X = ((*this).current_instruction & 0x0F00) >> 8; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NN` should have a snake case name [INFO] [stdout] --> src/chip8.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | let NN = ((*this).current_instruction & 0x00FF) as u8; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `nn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `this` [INFO] [stdout] --> src/chip8.rs:39:34 [INFO] [stdout] | [INFO] [stdout] 39 | current_function: { |this| () }, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_this` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:146:25 [INFO] [stdout] | [INFO] [stdout] 146 | let X = ((*this).current_instruction & 0x0F00) >> 8; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:156:21 [INFO] [stdout] | [INFO] [stdout] 156 | let X = (((*this).current_instruction & 0x0F00) >> 8) as usize; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Y` should have a snake case name [INFO] [stdout] --> src/chip8.rs:157:21 [INFO] [stdout] | [INFO] [stdout] 157 | let Y = (((*this).current_instruction & 0x00F0) >> 4) as usize; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:242:25 [INFO] [stdout] | [INFO] [stdout] 242 | let X = ((*this).current_instruction & 0x0F00) >> 8; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Y` should have a snake case name [INFO] [stdout] --> src/chip8.rs:244:25 [INFO] [stdout] | [INFO] [stdout] 244 | let Y = ((*this).current_instruction & 0x00F0) >> 4; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NN` should have a snake case name [INFO] [stdout] --> src/chip8.rs:257:25 [INFO] [stdout] | [INFO] [stdout] 257 | let NN = ((*this).current_instruction & 0x0FFF) as u16; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `nn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NNN` should have a snake case name [INFO] [stdout] --> src/chip8.rs:264:21 [INFO] [stdout] | [INFO] [stdout] 264 | let NNN = ((*this).current_instruction & 0x0FFF) as u32; [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `nnn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:271:25 [INFO] [stdout] | [INFO] [stdout] 271 | let X = ((*this).current_instruction & 0x0F00) >> 8; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NN` should have a snake case name [INFO] [stdout] --> src/chip8.rs:272:25 [INFO] [stdout] | [INFO] [stdout] 272 | let NN = ((*this).current_instruction & 0x00FF) as u8; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `nn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:281:25 [INFO] [stdout] | [INFO] [stdout] 281 | let X = ((*this).current_instruction & 0x0F00) >> 8; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Y` should have a snake case name [INFO] [stdout] --> src/chip8.rs:283:25 [INFO] [stdout] | [INFO] [stdout] 283 | let Y = ((*this).current_instruction & 0x00F0) >> 4; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/chip8.rs:290:25 [INFO] [stdout] | [INFO] [stdout] 290 | let N = ((*this).current_instruction & 0x000F); [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `I` should have a snake case name [INFO] [stdout] --> src/chip8.rs:291:25 [INFO] [stdout] | [INFO] [stdout] 291 | let I = (*this).i.get(); [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `YArr` should have a snake case name [INFO] [stdout] --> src/chip8.rs:354:19 [INFO] [stdout] | [INFO] [stdout] 354 | for (y_i, YArr) in self.display.get_pixels().iter().enumerate() { [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `yarr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `current_vx` is never read [INFO] [stdout] --> src/chip8.rs:282:29 [INFO] [stdout] | [INFO] [stdout] 282 | let mut current_vx = (*this).variable_registers[X as usize].get() % 64; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/chip8.rs:372:21 [INFO] [stdout] | [INFO] [stdout] 372 | graphics::draw(ctx, &rect, graphics::DrawParam::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 372 | let _ = graphics::draw(ctx, &rect, graphics::DrawParam::default()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `RAM` should have a snake case name [INFO] [stdout] --> src/chip8/chip8_mods/memory.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | RAM: [u8; 4096], [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `ram` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Y` should have a snake case name [INFO] [stdout] --> src/chip8/chip8_mods/display.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | for Y in self.pixels.iter_mut() { [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `memory_size` should have an upper case name [INFO] [stdout] --> src/chip8/chip8_mods/program_counter.rs:17:15 [INFO] [stdout] | [INFO] [stdout] 17 | const memory_size: u32 = 4096; // KB [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper case: `MEMORY_SIZE` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/chip8/chip8_mods/delay_timer.rs:11:11 [INFO] [stdout] | [INFO] [stdout] 11 | if(self.value>=0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/chip8/chip8_mods/sound_timer.rs:11:11 [INFO] [stdout] | [INFO] [stdout] 11 | if(self.value>=0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/chip8.rs:363:25 [INFO] [stdout] | [INFO] [stdout] 363 | let mut color = graphics::Color::WHITE; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `delay_timer` and `sound_timer` are never read [INFO] [stdout] --> src/chip8.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Chip8 { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 20 | delay_timer: delay_timer::DelayTimer, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 21 | sound_timer: sound_timer::SoundTimer, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `memory_size` is never used [INFO] [stdout] --> src/chip8/chip8_mods/program_counter.rs:17:15 [INFO] [stdout] | [INFO] [stdout] 17 | const memory_size: u32 = 4096; // KB [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `pop` is never used [INFO] [stdout] --> src/chip8/chip8_mods/stack.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 8 | impl Stack { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn pop(&mut self) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `value` is never read [INFO] [stdout] --> src/chip8/chip8_mods/delay_timer.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct DelayTimer { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 2 | value: u8 [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `tick` and `get_value` are never used [INFO] [stdout] --> src/chip8/chip8_mods/delay_timer.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 5 | impl DelayTimer { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 10 | pub fn tick(&mut self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 18 | pub fn get_value(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `value` is never read [INFO] [stdout] --> src/chip8/chip8_mods/sound_timer.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct SoundTimer { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 2 | value: u8 [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `tick` and `get_value` are never used [INFO] [stdout] --> src/chip8/chip8_mods/sound_timer.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 5 | impl SoundTimer { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 10 | pub fn tick(&mut self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | pub fn get_value(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NNN` should have a snake case name [INFO] [stdout] --> src/chip8.rs:84:25 [INFO] [stdout] | [INFO] [stdout] 84 | let NNN = ((*this).current_instruction & 0x0FFF) as u8; [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `nnn` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:94:25 [INFO] [stdout] | [INFO] [stdout] 94 | let X = ((*this).current_instruction & 0x0F00) >> 8; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NN` should have a snake case name [INFO] [stdout] --> src/chip8.rs:96:25 [INFO] [stdout] | [INFO] [stdout] 96 | let NN = ((*this).current_instruction & 0x00FF) as u8; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `nn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:108:25 [INFO] [stdout] | [INFO] [stdout] 108 | let X = ((*this).current_instruction & 0x0F00) >> 8; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NN` should have a snake case name [INFO] [stdout] --> src/chip8.rs:110:25 [INFO] [stdout] | [INFO] [stdout] 110 | let NN = ((*this).current_instruction & 0x00FF) as u8; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `nn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:122:25 [INFO] [stdout] | [INFO] [stdout] 122 | let X = ((*this).current_instruction & 0x0F00) >> 8; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Y` should have a snake case name [INFO] [stdout] --> src/chip8.rs:124:25 [INFO] [stdout] | [INFO] [stdout] 124 | let Y = ((*this).current_instruction & 0x00F0) >> 4; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 54 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NN` should have a snake case name [INFO] [stdout] --> src/chip8.rs:137:25 [INFO] [stdout] | [INFO] [stdout] 137 | let NN = ((*this).current_instruction & 0x00FF) as u8; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `nn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:138:25 [INFO] [stdout] | [INFO] [stdout] 138 | let X = ((*this).current_instruction & 0x0F00) >> 8; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NN` should have a snake case name [INFO] [stdout] --> src/chip8.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | let NN = ((*this).current_instruction & 0x00FF) as u8; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `nn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:146:25 [INFO] [stdout] | [INFO] [stdout] 146 | let X = ((*this).current_instruction & 0x0F00) >> 8; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:156:21 [INFO] [stdout] | [INFO] [stdout] 156 | let X = (((*this).current_instruction & 0x0F00) >> 8) as usize; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Y` should have a snake case name [INFO] [stdout] --> src/chip8.rs:157:21 [INFO] [stdout] | [INFO] [stdout] 157 | let Y = (((*this).current_instruction & 0x00F0) >> 4) as usize; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:242:25 [INFO] [stdout] | [INFO] [stdout] 242 | let X = ((*this).current_instruction & 0x0F00) >> 8; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Y` should have a snake case name [INFO] [stdout] --> src/chip8.rs:244:25 [INFO] [stdout] | [INFO] [stdout] 244 | let Y = ((*this).current_instruction & 0x00F0) >> 4; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NN` should have a snake case name [INFO] [stdout] --> src/chip8.rs:257:25 [INFO] [stdout] | [INFO] [stdout] 257 | let NN = ((*this).current_instruction & 0x0FFF) as u16; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `nn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NNN` should have a snake case name [INFO] [stdout] --> src/chip8.rs:264:21 [INFO] [stdout] | [INFO] [stdout] 264 | let NNN = ((*this).current_instruction & 0x0FFF) as u32; [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `nnn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:271:25 [INFO] [stdout] | [INFO] [stdout] 271 | let X = ((*this).current_instruction & 0x0F00) >> 8; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NN` should have a snake case name [INFO] [stdout] --> src/chip8.rs:272:25 [INFO] [stdout] | [INFO] [stdout] 272 | let NN = ((*this).current_instruction & 0x00FF) as u8; [INFO] [stdout] | ^^ help: convert the identifier to snake case: `nn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/chip8.rs:281:25 [INFO] [stdout] | [INFO] [stdout] 281 | let X = ((*this).current_instruction & 0x0F00) >> 8; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Y` should have a snake case name [INFO] [stdout] --> src/chip8.rs:283:25 [INFO] [stdout] | [INFO] [stdout] 283 | let Y = ((*this).current_instruction & 0x00F0) >> 4; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/chip8.rs:290:25 [INFO] [stdout] | [INFO] [stdout] 290 | let N = ((*this).current_instruction & 0x000F); [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `I` should have a snake case name [INFO] [stdout] --> src/chip8.rs:291:25 [INFO] [stdout] | [INFO] [stdout] 291 | let I = (*this).i.get(); [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `YArr` should have a snake case name [INFO] [stdout] --> src/chip8.rs:354:19 [INFO] [stdout] | [INFO] [stdout] 354 | for (y_i, YArr) in self.display.get_pixels().iter().enumerate() { [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `yarr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/chip8.rs:372:21 [INFO] [stdout] | [INFO] [stdout] 372 | graphics::draw(ctx, &rect, graphics::DrawParam::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 372 | let _ = graphics::draw(ctx, &rect, graphics::DrawParam::default()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `RAM` should have a snake case name [INFO] [stdout] --> src/chip8/chip8_mods/memory.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | RAM: [u8; 4096], [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `ram` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Y` should have a snake case name [INFO] [stdout] --> src/chip8/chip8_mods/display.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | for Y in self.pixels.iter_mut() { [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `memory_size` should have an upper case name [INFO] [stdout] --> src/chip8/chip8_mods/program_counter.rs:17:15 [INFO] [stdout] | [INFO] [stdout] 17 | const memory_size: u32 = 4096; // KB [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper case: `MEMORY_SIZE` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/chip8/chip8_mods/delay_timer.rs:11:11 [INFO] [stdout] | [INFO] [stdout] 11 | if(self.value>=0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/chip8/chip8_mods/sound_timer.rs:11:11 [INFO] [stdout] | [INFO] [stdout] 11 | if(self.value>=0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 54 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 57.83s [INFO] running `Command { std: "docker" "inspect" "cb1ef52fe998032bb9159aff3256564569c801982f88570d093b72ccbc1b6201", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb1ef52fe998032bb9159aff3256564569c801982f88570d093b72ccbc1b6201", kill_on_drop: false }` [INFO] [stdout] cb1ef52fe998032bb9159aff3256564569c801982f88570d093b72ccbc1b6201