[INFO] cloning repository https://github.com/jfrikker/arbiter [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jfrikker/arbiter" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjfrikker%2Farbiter", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjfrikker%2Farbiter'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b8fbe0b7dfe90154994c1ce1e4eaaf33cc50b42c [INFO] checking jfrikker/arbiter against master#af4a5a13a15fa0c60e06321077ef452f769b42fd for pr-122960-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjfrikker%2Farbiter" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/jfrikker/arbiter on toolchain af4a5a13a15fa0c60e06321077ef452f769b42fd [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+af4a5a13a15fa0c60e06321077ef452f769b42fd" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/jfrikker/arbiter [INFO] finished tweaking git repo https://github.com/jfrikker/arbiter [INFO] tweaked toml for git repo https://github.com/jfrikker/arbiter written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/jfrikker/arbiter already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+af4a5a13a15fa0c60e06321077ef452f769b42fd" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tokio-fs v0.1.6 [INFO] [stderr] Downloaded num_cpus v1.10.0 [INFO] [stderr] Downloaded stderrlog v0.4.1 [INFO] [stderr] Downloaded tokio-threadpool v0.1.13 [INFO] [stderr] Downloaded multimap v0.4.0 [INFO] [stderr] Downloaded which v2.0.1 [INFO] [stderr] Downloaded prost-derive v0.5.0 [INFO] [stderr] Downloaded futures v0.1.26 [INFO] [stderr] Downloaded prost v0.5.0 [INFO] [stderr] Downloaded syn v0.15.30 [INFO] [stderr] Downloaded cc v1.0.35 [INFO] [stderr] Downloaded tokio-sync v0.1.4 [INFO] [stderr] Downloaded tokio v0.1.18 [INFO] [stderr] Downloaded tokio-trace-core v0.1.0 [INFO] [stderr] Downloaded prost-types v0.5.0 [INFO] [stderr] Downloaded prost-build v0.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+af4a5a13a15fa0c60e06321077ef452f769b42fd" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 64e77f01089d8d49b452ca712f3d64bf7d586574c52e22101a442a2e81911834 [INFO] running `Command { std: "docker" "start" "-a" "64e77f01089d8d49b452ca712f3d64bf7d586574c52e22101a442a2e81911834", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "64e77f01089d8d49b452ca712f3d64bf7d586574c52e22101a442a2e81911834", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64e77f01089d8d49b452ca712f3d64bf7d586574c52e22101a442a2e81911834", kill_on_drop: false }` [INFO] [stdout] 64e77f01089d8d49b452ca712f3d64bf7d586574c52e22101a442a2e81911834 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+af4a5a13a15fa0c60e06321077ef452f769b42fd" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 60194a76136bae39a80208faa491d5f55dd5905af1a75c1580625c1c28e3c2b8 [INFO] running `Command { std: "docker" "start" "-a" "60194a76136bae39a80208faa491d5f55dd5905af1a75c1580625c1c28e3c2b8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.51 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Checking cfg-if v0.1.7 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling cc v1.0.35 [INFO] [stderr] Checking futures v0.1.26 [INFO] [stderr] Compiling rustc-demangle v0.1.13 [INFO] [stderr] Compiling proc-macro2 v0.4.27 [INFO] [stderr] Compiling syn v0.15.30 [INFO] [stderr] Compiling either v1.5.2 [INFO] [stderr] Compiling parking_lot_core v0.4.0 [INFO] [stderr] Checking smallvec v0.6.9 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Checking crossbeam-utils v0.6.5 [INFO] [stderr] Compiling itertools v0.8.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_jitter v0.1.3 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling backtrace v0.3.15 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Compiling fixedbitset v0.1.9 [INFO] [stderr] Compiling remove_dir_all v0.5.1 [INFO] [stderr] Compiling unicode-segmentation v1.2.1 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Compiling petgraph v0.4.13 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Compiling multimap v0.4.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking tokio-trace-core v0.1.0 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking num_cpus v1.10.0 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Compiling quote v0.6.12 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking termcolor v0.3.6 [INFO] [stderr] Checking linked-hash-map v0.5.2 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Checking tokio-executor v0.1.7 [INFO] [stderr] Checking tokio-io v0.1.12 [INFO] [stderr] Checking tokio-sync v0.1.4 [INFO] [stderr] Checking tokio-current-thread v0.1.6 [INFO] [stderr] Checking tokio-timer v0.2.10 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking tokio-threadpool v0.1.13 [INFO] [stderr] Compiling tempfile v3.0.7 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking tokio-fs v0.1.6 [INFO] [stderr] Checking tokio-reactor v0.1.9 [INFO] [stderr] Compiling failure v0.1.5 [INFO] [stderr] Checking stderrlog v0.4.1 [INFO] [stderr] Compiling which v2.0.1 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Compiling prost-build v0.5.0 [INFO] [stderr] Checking tokio v0.1.18 [INFO] [stderr] Compiling prost-derive v0.5.0 [INFO] [stderr] Compiling prost v0.5.0 [INFO] [stderr] Compiling prost-types v0.5.0 [INFO] [stderr] Compiling arbiter v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `error`, `info` [INFO] [stdout] --> src/main.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | use log::{error, info}; [INFO] [stdout] | ^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::rc::Rc` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::rc::Rc; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::prelude::*` [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use tokio::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::codec::Framed` [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use tokio::codec::Framed; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::codec::length_delimited::Builder` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use tokio::codec::length_delimited::Builder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::net::TcpListener` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use tokio::net::TcpListener; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `run`, `spawn` [INFO] [stdout] --> src/main.rs:12:38 [INFO] [stdout] | [INFO] [stdout] 12 | use tokio::runtime::current_thread::{run, spawn}; [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::sync::mpsc::unbounded_channel` [INFO] [stdout] --> src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use tokio::sync::mpsc::unbounded_channel; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `error`, `info` [INFO] [stdout] --> src/main.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | use log::{error, info}; [INFO] [stdout] | ^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::rc::Rc` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::rc::Rc; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::prelude::*` [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use tokio::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::codec::Framed` [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use tokio::codec::Framed; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::codec::length_delimited::Builder` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use tokio::codec::length_delimited::Builder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::net::TcpListener` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use tokio::net::TcpListener; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `run`, `spawn` [INFO] [stdout] --> src/main.rs:12:38 [INFO] [stdout] | [INFO] [stdout] 12 | use tokio::runtime::current_thread::{run, spawn}; [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::sync::mpsc::unbounded_channel` [INFO] [stdout] --> src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use tokio::sync::mpsc::unbounded_channel; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0601]: `main` function not found in crate `arbiter` [INFO] [stdout] --> src/main.rs:13:42 [INFO] [stdout] | [INFO] [stdout] 13 | use tokio::sync::mpsc::unbounded_channel; [INFO] [stdout] | ^ consider adding a `main` function to `src/main.rs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0601`. [INFO] [stdout] [INFO] [stderr] error: could not compile `arbiter` (bin "arbiter") due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: methods `get_state`, `transaction_progress_many`, and `with_transaction` are never used [INFO] [stdout] --> src/arbiter.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 15 | / impl Arbiter [INFO] [stdout] 16 | | where TID: Eq + Hash + Clone + Debug, [INFO] [stdout] 17 | | RID: Eq + Hash + Clone + Debug { [INFO] [stdout] | |________________________________________- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 27 | pub fn get_state(&self, id: &TID) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub fn transaction_progress_many(&mut self, id: &TID, read: R, written: W) -> Result> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 135 | fn with_transaction(&self, id: &TID, f: F) -> Result [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `transaction_progress_many` and `commit_completed` are never used [INFO] [stdout] --> src/arbiter.rs:164:8 [INFO] [stdout] | [INFO] [stdout] 153 | / impl Transaction [INFO] [stdout] 154 | | where RID: Eq + Hash + Clone { [INFO] [stdout] | |________________________________- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 164 | fn transaction_progress_many (&mut self, read: R, written: W) -> Result<()> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 218 | fn commit_completed(&mut self) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_can_commit` and `get_failed` are never used [INFO] [stdout] --> src/arbiter.rs:289:12 [INFO] [stdout] | [INFO] [stdout] 256 | impl TransactionUpdate { [INFO] [stdout] | --------------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 289 | pub fn get_can_commit(&self) -> &Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 293 | pub fn get_failed(&self) -> &Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ArbiterFut` is never constructed [INFO] [stdout] --> src/arbiter_fut.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct ArbiterFut { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/arbiter_fut.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 15 | / impl ArbiterFut [INFO] [stdout] 16 | | where TID: Eq + Hash + Clone + Debug, [INFO] [stdout] 17 | | RID: Eq + Hash + Clone + Debug { [INFO] [stdout] | |________________________________________- associated items in this implementation [INFO] [stdout] 18 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 25 | pub fn start_transaction(&mut self, id: TID) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 29 | pub fn transaction_progress_many(&mut self, id: &TID, read: R, written: W) -> Result [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 40 | pub fn start_commit(&mut self, id: &TID) -> impl Future { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn commit_completed(&mut self, id: &TID) -> Result<(), Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 73 | fn handle_update(&mut self, update: &TransactionUpdate) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | fn check_cancelled(&self, id: &TID) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `CommitResult` is never used [INFO] [stdout] --> src/arbiter_fut.rs:98:10 [INFO] [stdout] | [INFO] [stdout] 98 | pub enum CommitResult { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CommitResult` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/arbiter.rs:126:29 [INFO] [stdout] | [INFO] [stdout] 126 | for min_relevant in self.txns.values() [INFO] [stdout] | _____________________________^ [INFO] [stdout] 127 | | .map(|t| t.created_commit) [INFO] [stdout] 128 | | .min() { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 126 | while let Some(min_relevant) = self.txns.values() [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 126 | if let Some(min_relevant) = self.txns.values() [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "60194a76136bae39a80208faa491d5f55dd5905af1a75c1580625c1c28e3c2b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60194a76136bae39a80208faa491d5f55dd5905af1a75c1580625c1c28e3c2b8", kill_on_drop: false }` [INFO] [stdout] 60194a76136bae39a80208faa491d5f55dd5905af1a75c1580625c1c28e3c2b8 [INFO] checking jfrikker/arbiter against try#36dbcaee1a55543dfc181be52a69d99ff46ff62f for pr-122960-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjfrikker%2Farbiter" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/jfrikker/arbiter on toolchain 36dbcaee1a55543dfc181be52a69d99ff46ff62f [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+36dbcaee1a55543dfc181be52a69d99ff46ff62f" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/jfrikker/arbiter [INFO] finished tweaking git repo https://github.com/jfrikker/arbiter [INFO] tweaked toml for git repo https://github.com/jfrikker/arbiter written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/jfrikker/arbiter already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+36dbcaee1a55543dfc181be52a69d99ff46ff62f" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+36dbcaee1a55543dfc181be52a69d99ff46ff62f" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e0e5631eb6f42734d04df2d952063a133dc14c40d9e7f35162a21a833147aa5 [INFO] running `Command { std: "docker" "start" "-a" "5e0e5631eb6f42734d04df2d952063a133dc14c40d9e7f35162a21a833147aa5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e0e5631eb6f42734d04df2d952063a133dc14c40d9e7f35162a21a833147aa5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e0e5631eb6f42734d04df2d952063a133dc14c40d9e7f35162a21a833147aa5", kill_on_drop: false }` [INFO] [stdout] 5e0e5631eb6f42734d04df2d952063a133dc14c40d9e7f35162a21a833147aa5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+36dbcaee1a55543dfc181be52a69d99ff46ff62f" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b57b78bff7d479958d08f87c6d384ee0ccb15cf2f75326718cb0a61d7a126c9b [INFO] running `Command { std: "docker" "start" "-a" "b57b78bff7d479958d08f87c6d384ee0ccb15cf2f75326718cb0a61d7a126c9b", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] skipping non-2021 edition `2018` [INFO] running `Command { std: "docker" "inspect" "b57b78bff7d479958d08f87c6d384ee0ccb15cf2f75326718cb0a61d7a126c9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b57b78bff7d479958d08f87c6d384ee0ccb15cf2f75326718cb0a61d7a126c9b", kill_on_drop: false }` [INFO] [stdout] b57b78bff7d479958d08f87c6d384ee0ccb15cf2f75326718cb0a61d7a126c9b