[INFO] cloning repository https://github.com/romanb/hexkit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/romanb/hexkit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fromanb%2Fhexkit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fromanb%2Fhexkit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e42b6b8c2a6db91622ec5001a818b32af27cc87a [INFO] checking romanb/hexkit against master#b56aaec52bc0fa35591a872fb4aac81f606e265c for pr-122661-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fromanb%2Fhexkit" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/romanb/hexkit [INFO] finished tweaking git repo https://github.com/romanb/hexkit [INFO] tweaked toml for git repo https://github.com/romanb/hexkit written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/romanb/hexkit on toolchain b56aaec52bc0fa35591a872fb4aac81f606e265c [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b56aaec52bc0fa35591a872fb4aac81f606e265c" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/romanb/hexkit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b56aaec52bc0fa35591a872fb4aac81f606e265c" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zip v0.5.6 [INFO] [stderr] Downloaded podio v0.1.7 [INFO] [stderr] Downloaded cpal v0.10.0 [INFO] [stderr] Downloaded rodio v0.10.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:cf8efcab8866f2cf4285301c7418e2f4f2a9b088c91ba69c40d5b659f81557f7" "/opt/rustwide/cargo-home/bin/cargo" "+b56aaec52bc0fa35591a872fb4aac81f606e265c" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4e80eb91680e9ea9c64c9af4654ddb891b7c73491fa80f0b1eca863383593404 [INFO] running `Command { std: "docker" "start" "-a" "4e80eb91680e9ea9c64c9af4654ddb891b7c73491fa80f0b1eca863383593404", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4e80eb91680e9ea9c64c9af4654ddb891b7c73491fa80f0b1eca863383593404", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e80eb91680e9ea9c64c9af4654ddb891b7c73491fa80f0b1eca863383593404", kill_on_drop: false }` [INFO] [stdout] 4e80eb91680e9ea9c64c9af4654ddb891b7c73491fa80f0b1eca863383593404 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:cf8efcab8866f2cf4285301c7418e2f4f2a9b088c91ba69c40d5b659f81557f7" "/opt/rustwide/cargo-home/bin/cargo" "+b56aaec52bc0fa35591a872fb4aac81f606e265c" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5411a62965b5d01e05eb93c654c6751b4e56a218c7c7128f2ab893f993fea930 [INFO] running `Command { std: "docker" "start" "-a" "5411a62965b5d01e05eb93c654c6751b4e56a218c7c7128f2ab893f993fea930", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.72 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling libm v0.2.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling xml-rs v0.8.3 [INFO] [stderr] Compiling pkg-config v0.3.18 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling serde v1.0.114 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.34 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling cc v1.0.58 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.5 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Compiling libloading v0.6.2 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Compiling wayland-scanner v0.21.13 [INFO] [stderr] Checking ordered-float v1.1.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking stb_truetype v0.3.1 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking linked-hash-map v0.5.3 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Checking dlib v0.4.2 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling gl_generator v0.13.1 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Checking rusttype v0.8.3 [INFO] [stderr] Checking wayland-sys v0.21.13 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling gimli v0.22.0 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling adler v0.2.3 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Compiling error-chain v0.12.2 [INFO] [stderr] Compiling miniz_oxide v0.4.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling wayland-client v0.21.13 [INFO] [stderr] Checking wayland-commons v0.21.13 [INFO] [stderr] Compiling wayland-protocols v0.21.13 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling x11-dl v2.18.5 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling typenum v1.12.0 [INFO] [stderr] Compiling rustc-demangle v0.1.16 [INFO] [stderr] Compiling serde_json v1.0.56 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Compiling addr2line v0.13.0 [INFO] [stderr] Compiling serde_derive v1.0.114 [INFO] [stderr] Compiling object v0.20.0 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking rusttype v0.7.9 [INFO] [stderr] Checking line_drawing v0.7.0 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking euclid v0.20.14 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling alsa-sys v0.1.2 [INFO] [stderr] Compiling pulldown-cmark v0.2.0 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling itoa v0.4.6 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking lyon_geom v0.14.1 [INFO] [stderr] Checking andrew v0.2.1 [INFO] [stderr] Compiling gfx_gl v0.6.1 [INFO] [stderr] Compiling synstructure v0.12.4 [INFO] [stderr] Compiling backtrace v0.3.50 [INFO] [stderr] Compiling rand v0.4.6 [INFO] [stderr] Compiling glutin_egl_sys v0.1.4 [INFO] [stderr] Compiling glutin_glx_sys v0.1.6 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Compiling bzip2-sys v0.1.9+1.0.8 [INFO] [stderr] Compiling minimp3-sys v0.3.2 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Checking adler32 v1.1.0 [INFO] [stderr] Compiling nix v0.15.0 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Compiling remove_dir_all v0.5.3 [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Checking gfx_core v0.9.2 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Checking generic-array v0.12.3 [INFO] [stderr] Checking alga v0.9.3 [INFO] [stderr] Checking lyon_path v0.14.0 [INFO] [stderr] Checking sid v0.5.2 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Compiling num-iter v0.1.41 [INFO] [stderr] Checking mint v0.5.5 [INFO] [stderr] Compiling cpal v0.10.0 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling bytecount v0.4.0 [INFO] [stderr] Compiling glob v0.2.11 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking nalgebra v0.18.1 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking slice-deque v0.3.0 [INFO] [stderr] Checking ogg v0.7.0 [INFO] [stderr] Compiling cargo_metadata v0.6.4 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking xi-unicode v0.2.1 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking uuid v0.8.1 [INFO] [stderr] Checking glyph_brush_layout v0.1.9 [INFO] [stderr] Compiling skeptic v0.13.4 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking gfx_device_gl v0.16.2 [INFO] [stderr] Checking twox-hash v1.5.0 [INFO] [stderr] Checking lewton v0.9.4 [INFO] [stderr] Checking minimp3 v0.3.5 [INFO] [stderr] Checking png v0.15.3 [INFO] [stderr] Compiling ggez v0.5.1 (https://github.com/ggez/ggez?branch=devel#b728d961) [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking lyon_tessellation v0.14.2 [INFO] [stderr] Checking lyon_algorithms v0.14.0 [INFO] [stderr] Compiling num-derive v0.3.0 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking tiff v0.3.1 [INFO] [stderr] Checking jpeg-decoder v0.1.20 [INFO] [stderr] Checking gilrs-core v0.2.6 [INFO] [stderr] Checking claxon v0.4.2 [INFO] [stderr] Checking hound v3.4.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking podio v0.1.7 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking zip v0.5.6 [INFO] [stderr] Checking gilrs v0.7.4 [INFO] [stderr] Checking image v0.22.5 [INFO] [stderr] Checking rodio v0.10.0 [INFO] [stderr] Checking lyon v0.14.2 [INFO] [stderr] Checking directories v2.0.2 [INFO] [stderr] Checking glyph_brush v0.6.3 [INFO] [stderr] Compiling smart-default v0.5.2 [INFO] [stderr] Checking gfx v0.18.2 [INFO] [stderr] Checking aho-corasick v0.7.13 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking toml v0.5.6 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking quickcheck v0.9.2 [INFO] [stderr] Checking hexacore v0.1.0 (/opt/rustwide/workdir/hexacore) [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> hexacore/src/grid/coords/cube.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | use std::ops::{ Add, Sub }; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `Add` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> hexacore/src/grid/coords/cube.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use vec::*; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> hexacore/src/grid/coords/cube.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | use std::ops::{ Add, Sub }; [INFO] [stdout] | ^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> hexacore/src/grid/coords/cube.rs:10:22 [INFO] [stdout] | [INFO] [stdout] 10 | use std::ops::{ Add, Sub }; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `Sub` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> hexacore/src/grid/coords/cube.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use vec::*; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> hexacore/src/grid/coords/cube.rs:10:22 [INFO] [stdout] | [INFO] [stdout] 10 | use std::ops::{ Add, Sub }; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> hexacore/src/grid.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use coords::*; [INFO] [stdout] | ^^^^^^^^^ the name `lerp` in the value namespace is first re-exported here [INFO] [stdout] 5 | [INFO] [stdout] 6 | use crate::geo::*; [INFO] [stdout] | ------------- but the name `lerp` in the value namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> hexacore/src/grid/coords/cube.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | use std::ops::{ Add, Sub }; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `Add` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> hexacore/src/grid/coords/cube.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use vec::*; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> hexacore/src/grid/coords/cube.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | use std::ops::{ Add, Sub }; [INFO] [stdout] | ^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> hexacore/src/grid/coords/cube.rs:10:22 [INFO] [stdout] | [INFO] [stdout] 10 | use std::ops::{ Add, Sub }; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `Sub` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> hexacore/src/grid/coords/cube.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use vec::*; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> hexacore/src/grid/coords/cube.rs:10:22 [INFO] [stdout] | [INFO] [stdout] 10 | use std::ops::{ Add, Sub }; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> hexacore/src/grid.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use coords::*; [INFO] [stdout] | ^^^^^^^^^ the name `lerp` in the value namespace is first re-exported here [INFO] [stdout] 5 | [INFO] [stdout] 6 | use crate::geo::*; [INFO] [stdout] | ------------- but the name `lerp` in the value namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> hexacore/src/geo.rs:344:10 [INFO] [stdout] | [INFO] [stdout] 344 | #[derive(FromPrimitive, ToPrimitive, Debug)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_Z6` [INFO] [stdout] 345 | pub enum Z6 { [INFO] [stdout] | -- `Z6` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> hexacore/src/geo.rs:344:25 [INFO] [stdout] | [INFO] [stdout] 344 | #[derive(FromPrimitive, ToPrimitive, Debug)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `ToPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_ToPrimitive_FOR_Z6` [INFO] [stdout] 345 | pub enum Z6 { [INFO] [stdout] | -- `Z6` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `ToPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `ToPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `ToPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> hexacore/src/grid.rs:96:29 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn iter_within<'a>(&'a self, b: &'a Bounds) [INFO] [stdout] | ^^ ^^ the lifetime is named here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] 97 | -> impl Iterator + 'a [INFO] [stdout] | -- -------- -- the same lifetime is named here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the same lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 97 | -> impl Iterator + 'a [INFO] [stdout] | ++ ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> hexacore/src/grid/coords/cube/vec.rs:151:10 [INFO] [stdout] | [INFO] [stdout] 151 | #[derive(FromPrimitive, Debug)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_FlatTopDirection` [INFO] [stdout] 152 | pub enum FlatTopDirection { [INFO] [stdout] | ---------------- `FlatTopDirection` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> hexacore/src/grid/coords/cube/vec.rs:173:10 [INFO] [stdout] | [INFO] [stdout] 173 | #[derive(FromPrimitive, Debug)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_FlatTopDiagonal` [INFO] [stdout] 174 | pub enum FlatTopDiagonal { [INFO] [stdout] | --------------- `FlatTopDiagonal` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> hexacore/src/grid/coords/cube/vec.rs:192:17 [INFO] [stdout] | [INFO] [stdout] 192 | #[derive(Debug, FromPrimitive)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_PointyTopDirection` [INFO] [stdout] 193 | pub enum PointyTopDirection { [INFO] [stdout] | ------------------ `PointyTopDirection` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> hexacore/src/grid/coords/cube/vec.rs:214:17 [INFO] [stdout] | [INFO] [stdout] 214 | #[derive(Debug, FromPrimitive)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_PointyTopDiagonal` [INFO] [stdout] 215 | pub enum PointyTopDiagonal { [INFO] [stdout] | ----------------- `PointyTopDiagonal` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> hexacore/src/geo.rs:344:10 [INFO] [stdout] | [INFO] [stdout] 344 | #[derive(FromPrimitive, ToPrimitive, Debug)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_Z6` [INFO] [stdout] 345 | pub enum Z6 { [INFO] [stdout] | -- `Z6` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> hexacore/src/geo.rs:344:25 [INFO] [stdout] | [INFO] [stdout] 344 | #[derive(FromPrimitive, ToPrimitive, Debug)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `ToPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_ToPrimitive_FOR_Z6` [INFO] [stdout] 345 | pub enum Z6 { [INFO] [stdout] | -- `Z6` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `ToPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `ToPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `ToPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> hexacore/src/grid.rs:96:29 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn iter_within<'a>(&'a self, b: &'a Bounds) [INFO] [stdout] | ^^ ^^ the lifetime is named here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] 97 | -> impl Iterator + 'a [INFO] [stdout] | -- -------- -- the same lifetime is named here [INFO] [stdout] | | | [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the same lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 97 | -> impl Iterator + 'a [INFO] [stdout] | ++ ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> hexacore/src/grid/coords/cube/vec.rs:151:10 [INFO] [stdout] | [INFO] [stdout] 151 | #[derive(FromPrimitive, Debug)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_FlatTopDirection` [INFO] [stdout] 152 | pub enum FlatTopDirection { [INFO] [stdout] | ---------------- `FlatTopDirection` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> hexacore/src/grid/coords/cube/vec.rs:173:10 [INFO] [stdout] | [INFO] [stdout] 173 | #[derive(FromPrimitive, Debug)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_FlatTopDiagonal` [INFO] [stdout] 174 | pub enum FlatTopDiagonal { [INFO] [stdout] | --------------- `FlatTopDiagonal` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> hexacore/src/grid/coords/cube/vec.rs:192:17 [INFO] [stdout] | [INFO] [stdout] 192 | #[derive(Debug, FromPrimitive)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_PointyTopDirection` [INFO] [stdout] 193 | pub enum PointyTopDirection { [INFO] [stdout] | ------------------ `PointyTopDirection` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> hexacore/src/grid/coords/cube/vec.rs:214:17 [INFO] [stdout] | [INFO] [stdout] 214 | #[derive(Debug, FromPrimitive)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_PointyTopDiagonal` [INFO] [stdout] 215 | pub enum PointyTopDiagonal { [INFO] [stdout] | ----------------- `PointyTopDiagonal` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking smithay-client-toolkit v0.4.6 [INFO] [stderr] Checking winit v0.19.5 [INFO] [stderr] Checking glutin v0.20.1 [INFO] [stderr] Checking gfx_window_glutin v0.30.0 [INFO] [stderr] Checking hexggez v0.1.0 (/opt/rustwide/workdir/hexggez) [INFO] [stderr] Checking hexspace v0.1.0 (/opt/rustwide/workdir/hexspace) [INFO] [stdout] warning: field `start` is never read [INFO] [stdout] --> hexspace/src/world.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 159 | pub struct Movement { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 160 | pub entity: Entity, [INFO] [stdout] 161 | pub start: Coords, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> hexspace/src/ui.rs:213:54 [INFO] [stdout] | [INFO] [stdout] 213 | Button::IncreaseCost => for s in &self.selected { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 213 - Button::IncreaseCost => for s in &self.selected { [INFO] [stdout] 213 + Button::IncreaseCost => while let Some(s) = &self.selected { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 213 - Button::IncreaseCost => for s in &self.selected { [INFO] [stdout] 213 + Button::IncreaseCost => if let Some(s) = &self.selected { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> hexspace/src/ui.rs:216:54 [INFO] [stdout] | [INFO] [stdout] 216 | Button::DecreaseCost => for s in &self.selected { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 216 - Button::DecreaseCost => for s in &self.selected { [INFO] [stdout] 216 + Button::DecreaseCost => while let Some(s) = &self.selected { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 216 - Button::DecreaseCost => for s in &self.selected { [INFO] [stdout] 216 + Button::DecreaseCost => if let Some(s) = &self.selected { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> hexspace/src/ui.rs:314:24 [INFO] [stdout] | [INFO] [stdout] 314 | for hex in self.view.grid().get(*pos) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 314 - for hex in self.view.grid().get(*pos) { [INFO] [stdout] 314 + while let Some(hex) = self.view.grid().get(*pos) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 314 - for hex in self.view.grid().get(*pos) { [INFO] [stdout] 314 + if let Some(hex) = self.view.grid().get(*pos) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> hexspace/src/world.rs:191:17 [INFO] [stdout] | [INFO] [stdout] 191 | pub fn name(&self) -> Cow { [INFO] [stdout] | ^^^^^ -------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 191 | pub fn name(&self) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `start` is never read [INFO] [stdout] --> hexspace/src/world.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 159 | pub struct Movement { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 160 | pub entity: Entity, [INFO] [stdout] 161 | pub start: Coords, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> hexspace/src/ui.rs:213:54 [INFO] [stdout] | [INFO] [stdout] 213 | Button::IncreaseCost => for s in &self.selected { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 213 - Button::IncreaseCost => for s in &self.selected { [INFO] [stdout] 213 + Button::IncreaseCost => while let Some(s) = &self.selected { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 213 - Button::IncreaseCost => for s in &self.selected { [INFO] [stdout] 213 + Button::IncreaseCost => if let Some(s) = &self.selected { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> hexspace/src/ui.rs:216:54 [INFO] [stdout] | [INFO] [stdout] 216 | Button::DecreaseCost => for s in &self.selected { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 216 - Button::DecreaseCost => for s in &self.selected { [INFO] [stdout] 216 + Button::DecreaseCost => while let Some(s) = &self.selected { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 216 - Button::DecreaseCost => for s in &self.selected { [INFO] [stdout] 216 + Button::DecreaseCost => if let Some(s) = &self.selected { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> hexspace/src/ui.rs:314:24 [INFO] [stdout] | [INFO] [stdout] 314 | for hex in self.view.grid().get(*pos) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 314 - for hex in self.view.grid().get(*pos) { [INFO] [stdout] 314 + while let Some(hex) = self.view.grid().get(*pos) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 314 - for hex in self.view.grid().get(*pos) { [INFO] [stdout] 314 + if let Some(hex) = self.view.grid().get(*pos) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> hexspace/src/world.rs:191:17 [INFO] [stdout] | [INFO] [stdout] 191 | pub fn name(&self) -> Cow { [INFO] [stdout] | ^^^^^ -------- the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 191 | pub fn name(&self) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 09s [INFO] running `Command { std: "docker" "inspect" "5411a62965b5d01e05eb93c654c6751b4e56a218c7c7128f2ab893f993fea930", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5411a62965b5d01e05eb93c654c6751b4e56a218c7c7128f2ab893f993fea930", kill_on_drop: false }` [INFO] [stdout] 5411a62965b5d01e05eb93c654c6751b4e56a218c7c7128f2ab893f993fea930