[INFO] fetching crate c5store 0.2.3...
[INFO] checking c5store-0.2.3 against master#b0696a5160711c068cb1f01b7437db7990d15750 for pr-121848
[INFO] extracting crate c5store 0.2.3 into /workspace/builds/worker-7-tc1/source
[INFO] validating manifest of crates.io crate c5store 0.2.3 on toolchain b0696a5160711c068cb1f01b7437db7990d15750
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b0696a5160711c068cb1f01b7437db7990d15750" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] started tweaking crates.io crate c5store 0.2.3
[INFO] finished tweaking crates.io crate c5store 0.2.3
[INFO] tweaked toml for crates.io crate c5store 0.2.3 written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b0696a5160711c068cb1f01b7437db7990d15750" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b0696a5160711c068cb1f01b7437db7990d15750" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded ecies_25519 v0.1.2
[INFO] [stderr]   Downloaded universal-hash v0.5.1
[INFO] [stderr]   Downloaded shellexpand v2.1.2
[INFO] [stderr]   Downloaded curve25519-parser v0.2.0
[INFO] [stderr]   Downloaded natord v1.0.9
[INFO] [stderr]   Downloaded scheduled-thread-pool v0.2.7
[INFO] [stderr]   Downloaded curve25519-parser v0.4.0
[INFO] [stderr]   Downloaded curve25519-dalek-derive v0.1.1
[INFO] [stderr]   Downloaded polyval v0.6.2
[INFO] [stderr]   Downloaded rusticata-macros v2.1.0
[INFO] [stderr]   Downloaded pem v3.0.3
[INFO] [stderr]   Downloaded aead v0.5.2
[INFO] [stderr]   Downloaded der-parser v4.1.1
[INFO] [stderr]   Downloaded base64 v0.22.0
[INFO] [stderr]   Downloaded skiplist v0.4.0
[INFO] [stderr]   Downloaded curve25519-dalek v4.1.2
[INFO] [stderr]   Downloaded fiat-crypto v0.2.6
[INFO] [stderr]   Downloaded x25519-dalek v2.0.1
[INFO] [stderr]   Downloaded platforms v3.3.0
[INFO] [stderr]   Downloaded serde_test v1.0.176
[INFO] [stderr]   Downloaded der-oid-macro v0.2.0
[INFO] [stderr]   Downloaded aes-gcm v0.10.3
[INFO] [stderr]   Downloaded ghash v0.5.1
[INFO] [stderr]   Downloaded pem v0.8.3
[INFO] [stderr]   Downloaded ctr v0.9.2
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+b0696a5160711c068cb1f01b7437db7990d15750" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 3407e778b2c551be741f3a61c34a207215762d8a6454c27160d3c5cdb831edd7
[INFO] running `Command { std: "docker" "start" "-a" "3407e778b2c551be741f3a61c34a207215762d8a6454c27160d3c5cdb831edd7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "3407e778b2c551be741f3a61c34a207215762d8a6454c27160d3c5cdb831edd7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "3407e778b2c551be741f3a61c34a207215762d8a6454c27160d3c5cdb831edd7", kill_on_drop: false }`
[INFO] [stdout] 3407e778b2c551be741f3a61c34a207215762d8a6454c27160d3c5cdb831edd7
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+b0696a5160711c068cb1f01b7437db7990d15750" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 8c1825e7c0f60134d21ef9e56e3db7a7d923493a03ff435c0ec55033929e2608
[INFO] running `Command { std: "docker" "start" "-a" "8c1825e7c0f60134d21ef9e56e3db7a7d923493a03ff435c0ec55033929e2608", kill_on_drop: false }`
[INFO] [stderr]    Compiling syn v1.0.109
[INFO] [stderr]    Compiling num-traits v0.2.18
[INFO] [stderr]    Compiling platforms v3.3.0
[INFO] [stderr]    Compiling num-bigint v0.3.3
[INFO] [stderr]     Checking nom v7.1.3
[INFO] [stderr]    Compiling arrayvec v0.5.2
[INFO] [stderr]     Checking crypto-common v0.1.6
[INFO] [stderr]     Checking inout v0.1.3
[INFO] [stderr]    Compiling zeroize_derive v1.4.2
[INFO] [stderr]    Compiling curve25519-dalek-derive v0.1.1
[INFO] [stderr]    Compiling displaydoc v0.2.4
[INFO] [stderr]     Checking serde v1.0.197
[INFO] [stderr]     Checking regex-automata v0.4.6
[INFO] [stderr]     Checking base64 v0.21.7
[INFO] [stderr]     Checking rusticata-macros v2.1.0
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]     Checking parking_lot_core v0.9.9
[INFO] [stderr]     Checking digest v0.10.7
[INFO] [stderr]     Checking universal-hash v0.5.1
[INFO] [stderr]     Checking cipher v0.4.4
[INFO] [stderr]     Checking polyval v0.6.2
[INFO] [stderr]     Checking pem v3.0.3
[INFO] [stderr]     Checking sha2 v0.10.8
[INFO] [stderr]    Compiling curve25519-dalek v4.1.2
[INFO] [stderr]    Compiling lexical-core v0.7.6
[INFO] [stderr]     Checking hmac v0.12.1
[INFO] [stderr]     Checking ghash v0.5.1
[INFO] [stderr]     Checking ctr v0.9.2
[INFO] [stderr]     Checking aes v0.8.4
[INFO] [stderr]     Checking aead v0.5.2
[INFO] [stderr]     Checking dirs-sys v0.3.7
[INFO] [stderr]    Compiling num-rational v0.4.1
[INFO] [stderr]     Checking linked-hash-map v0.5.6
[INFO] [stderr]     Checking parking_lot_core v0.8.6
[INFO] [stderr]     Checking dirs v4.0.0
[INFO] [stderr]     Checking hkdf v0.12.4
[INFO] [stderr]     Checking parking_lot v0.12.1
[INFO] [stderr]     Checking yaml-rust v0.4.5
[INFO] [stderr]     Checking base64 v0.22.0
[INFO] [stderr]     Checking sha2 v0.9.9
[INFO] [stderr]     Checking scheduled-thread-pool v0.2.7
[INFO] [stderr]     Checking parking_lot v0.11.2
[INFO] [stderr]     Checking skiplist v0.4.0
[INFO] [stderr]     Checking aes-gcm v0.10.3
[INFO] [stderr]     Checking shellexpand v2.1.2
[INFO] [stderr]     Checking natord v1.0.9
[INFO] [stderr]     Checking zeroize v1.3.0
[INFO] [stderr]     Checking curve25519-dalek v3.2.1
[INFO] [stderr]     Checking num-integer v0.1.46
[INFO] [stderr]     Checking regex v1.10.3
[INFO] [stderr]     Checking num-bigint v0.4.4
[INFO] [stderr]    Compiling nom v5.1.3
[INFO] [stderr]     Checking rusticata-macros v4.1.0
[INFO] [stderr]     Checking x25519-dalek v1.2.0
[INFO] [stderr]     Checking pem v0.8.3
[INFO] [stderr]     Checking x25519-dalek v2.0.1
[INFO] [stderr]     Checking multimap v0.8.3
[INFO] [stderr]     Checking serde_json v1.0.114
[INFO] [stderr]     Checking serde_yaml v0.8.26
[INFO] [stderr]     Checking serde_test v1.0.176
[INFO] [stderr]    Compiling der-oid-macro v0.2.0
[INFO] [stderr]     Checking der-parser v4.1.1
[INFO] [stderr]    Compiling synstructure v0.12.6
[INFO] [stderr]     Checking curve25519-parser v0.2.0
[INFO] [stderr]    Compiling asn1-rs-derive v0.4.0
[INFO] [stderr]    Compiling asn1-rs-impl v0.1.0
[INFO] [stderr]     Checking asn1-rs v0.5.2
[INFO] [stderr]     Checking der-parser v8.2.0
[INFO] [stderr]     Checking curve25519-parser v0.4.0
[INFO] [stderr]     Checking ecies_25519 v0.1.2
[INFO] [stderr]     Checking c5store v0.2.3 (/opt/rustwide/workdir)
[INFO] [stdout] warning: the item `FromIterator` is imported redundantly
[INFO] [stdout]  --> src/data.rs:8:17
[INFO] [stdout]   |
[INFO] [stdout] 8 | use std::iter::{FromIterator, IntoIterator, Iterator};
[INFO] [stdout]   |                 ^^^^^^^^^^^^
[INFO] [stdout]  --> /rustc/b0696a5160711c068cb1f01b7437db7990d15750/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `FromIterator` is already defined here
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `IntoIterator` is imported redundantly
[INFO] [stdout]  --> src/data.rs:8:31
[INFO] [stdout]   |
[INFO] [stdout] 8 | use std::iter::{FromIterator, IntoIterator, Iterator};
[INFO] [stdout]   |                               ^^^^^^^^^^^^
[INFO] [stdout]  --> /rustc/b0696a5160711c068cb1f01b7437db7990d15750/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `IntoIterator` is already defined here
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `Iterator` is imported redundantly
[INFO] [stdout]  --> src/data.rs:8:45
[INFO] [stdout]   |
[INFO] [stdout] 8 | use std::iter::{FromIterator, IntoIterator, Iterator};
[INFO] [stdout]   |                                             ^^^^^^^^
[INFO] [stdout]  --> /rustc/b0696a5160711c068cb1f01b7437db7990d15750/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `Iterator` is already defined here
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `FromIterator` is imported redundantly
[INFO] [stdout]  --> src/providers.rs:3:5
[INFO] [stdout]   |
[INFO] [stdout] 3 | use std::iter::FromIterator;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]  --> /rustc/b0696a5160711c068cb1f01b7437db7990d15750/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `FromIterator` is already defined here
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `TryInto` is imported redundantly
[INFO] [stdout]  --> src/value.rs:2:5
[INFO] [stdout]   |
[INFO] [stdout] 2 | use std::convert::TryInto;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]  --> /rustc/b0696a5160711c068cb1f01b7437db7990d15750/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `TryInto` is already defined here
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `FromIterator` is imported redundantly
[INFO] [stdout]  --> src/data.rs:8:17
[INFO] [stdout]   |
[INFO] [stdout] 8 | use std::iter::{FromIterator, IntoIterator, Iterator};
[INFO] [stdout]   |                 ^^^^^^^^^^^^
[INFO] [stdout]  --> /rustc/b0696a5160711c068cb1f01b7437db7990d15750/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `FromIterator` is already defined here
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `IntoIterator` is imported redundantly
[INFO] [stdout]  --> src/data.rs:8:31
[INFO] [stdout]   |
[INFO] [stdout] 8 | use std::iter::{FromIterator, IntoIterator, Iterator};
[INFO] [stdout]   |                               ^^^^^^^^^^^^
[INFO] [stdout]  --> /rustc/b0696a5160711c068cb1f01b7437db7990d15750/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `IntoIterator` is already defined here
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `Iterator` is imported redundantly
[INFO] [stdout]  --> src/data.rs:8:45
[INFO] [stdout]   |
[INFO] [stdout] 8 | use std::iter::{FromIterator, IntoIterator, Iterator};
[INFO] [stdout]   |                                             ^^^^^^^^
[INFO] [stdout]  --> /rustc/b0696a5160711c068cb1f01b7437db7990d15750/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `Iterator` is already defined here
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `FromIterator` is imported redundantly
[INFO] [stdout]  --> src/providers.rs:3:5
[INFO] [stdout]   |
[INFO] [stdout] 3 | use std::iter::FromIterator;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]  --> /rustc/b0696a5160711c068cb1f01b7437db7990d15750/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `FromIterator` is already defined here
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `TryInto` is imported redundantly
[INFO] [stdout]  --> src/value.rs:2:5
[INFO] [stdout]   |
[INFO] [stdout] 2 | use std::convert::TryInto;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]  --> /rustc/b0696a5160711c068cb1f01b7437db7990d15750/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `TryInto` is already defined here
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated associated function `scheduled_thread_pool::ScheduledThreadPool::with_name`: use ScheduledThreadPool::builder
[INFO] [stdout]    --> src/lib.rs:115:50
[INFO] [stdout]     |
[INFO] [stdout] 115 |       thread_pool: Arc::new(ScheduledThreadPool::with_name("c5Store_change_notifier", 1)),
[INFO] [stdout]     |                                                  ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(deprecated)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated associated function `scheduled_thread_pool::ScheduledThreadPool::with_name`: use ScheduledThreadPool::builder
[INFO] [stdout]    --> src/lib.rs:115:50
[INFO] [stdout]     |
[INFO] [stdout] 115 |       thread_pool: Arc::new(ScheduledThreadPool::with_name("c5Store_change_notifier", 1)),
[INFO] [stdout]     |                                                  ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(deprecated)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated associated function `scheduled_thread_pool::ScheduledThreadPool::with_name`: use ScheduledThreadPool::builder
[INFO] [stdout]    --> src/lib.rs:356:52
[INFO] [stdout]     |
[INFO] [stdout] 356 |       _scheduled_thread_pool: ScheduledThreadPool::with_name("c5store_mgr", 8),
[INFO] [stdout]     |                                                    ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated associated function `scheduled_thread_pool::ScheduledThreadPool::with_name`: use ScheduledThreadPool::builder
[INFO] [stdout]    --> src/lib.rs:356:52
[INFO] [stdout]     |
[INFO] [stdout] 356 |       _scheduled_thread_pool: ScheduledThreadPool::with_name("c5store_mgr", 8),
[INFO] [stdout]     |                                                    ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `with_subscribers` is never used
[INFO] [stdout]    --> src/internal.rs:309:10
[INFO] [stdout]     |
[INFO] [stdout] 303 | impl C5StoreSubscriptions {
[INFO] [stdout]     | ------------------------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 309 |   pub fn with_subscribers<SubscriberFn>(&self, key_path: &str, subscriber_fn: SubscriberFn)
[INFO] [stdout]     |          ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `as_bytes` is never used
[INFO] [stdout]    --> src/value.rs:279:17
[INFO] [stdout]     |
[INFO] [stdout] 277 | impl C5DataValue {
[INFO] [stdout]     | ---------------- method in this implementation
[INFO] [stdout] 278 |
[INFO] [stdout] 279 |   pub(crate) fn as_bytes(&self) -> Option<Vec<u8>> {
[INFO] [stdout]     |                 ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/lib.rs:396:55
[INFO] [stdout]     |
[INFO] [stdout] 396 |     self._value_providers.lock().insert(Box::from(name.clone()), Box::from(value_provider));
[INFO] [stdout]     |                                                       ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed
[INFO] [stdout]     = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/internal.rs:325:28
[INFO] [stdout]     |
[INFO] [stdout] 325 |     for change_listener in rwlock.get(notify_key_path) {
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 325 |     while let Some(change_listener) = rwlock.get(notify_key_path) {
[INFO] [stdout]     |     ~~~~~~~~~~~~~~~               ~~~
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 325 |     if let Some(change_listener) = rwlock.get(notify_key_path) {
[INFO] [stdout]     |     ~~~~~~~~~~~~               ~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `with_subscribers` is never used
[INFO] [stdout]    --> src/internal.rs:309:10
[INFO] [stdout]     |
[INFO] [stdout] 303 | impl C5StoreSubscriptions {
[INFO] [stdout]     | ------------------------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 309 |   pub fn with_subscribers<SubscriberFn>(&self, key_path: &str, subscriber_fn: SubscriberFn)
[INFO] [stdout]     |          ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `as_bytes` is never used
[INFO] [stdout]    --> src/value.rs:279:17
[INFO] [stdout]     |
[INFO] [stdout] 277 | impl C5DataValue {
[INFO] [stdout]     | ---------------- method in this implementation
[INFO] [stdout] 278 |
[INFO] [stdout] 279 |   pub(crate) fn as_bytes(&self) -> Option<Vec<u8>> {
[INFO] [stdout]     |                 ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/lib.rs:396:55
[INFO] [stdout]     |
[INFO] [stdout] 396 |     self._value_providers.lock().insert(Box::from(name.clone()), Box::from(value_provider));
[INFO] [stdout]     |                                                       ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed
[INFO] [stdout]     = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/internal.rs:325:28
[INFO] [stdout]     |
[INFO] [stdout] 325 |     for change_listener in rwlock.get(notify_key_path) {
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 325 |     while let Some(change_listener) = rwlock.get(notify_key_path) {
[INFO] [stdout]     |     ~~~~~~~~~~~~~~~               ~~~
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 325 |     if let Some(change_listener) = rwlock.get(notify_key_path) {
[INFO] [stdout]     |     ~~~~~~~~~~~~               ~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 11 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 11 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.01s
[INFO] running `Command { std: "docker" "inspect" "8c1825e7c0f60134d21ef9e56e3db7a7d923493a03ff435c0ec55033929e2608", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "8c1825e7c0f60134d21ef9e56e3db7a7d923493a03ff435c0ec55033929e2608", kill_on_drop: false }`
[INFO] [stdout] 8c1825e7c0f60134d21ef9e56e3db7a7d923493a03ff435c0ec55033929e2608
[INFO] checking c5store-0.2.3 against try#bfe97fcae016881ad333f0ff8cea2cadb9cf136c for pr-121848
[INFO] extracting crate c5store 0.2.3 into /workspace/builds/worker-7-tc2/source
[INFO] validating manifest of crates.io crate c5store 0.2.3 on toolchain bfe97fcae016881ad333f0ff8cea2cadb9cf136c
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+bfe97fcae016881ad333f0ff8cea2cadb9cf136c" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] started tweaking crates.io crate c5store 0.2.3
[INFO] finished tweaking crates.io crate c5store 0.2.3
[INFO] tweaked toml for crates.io crate c5store 0.2.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+bfe97fcae016881ad333f0ff8cea2cadb9cf136c" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+bfe97fcae016881ad333f0ff8cea2cadb9cf136c" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+bfe97fcae016881ad333f0ff8cea2cadb9cf136c" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 94bdde45660ee19f00ff21995eabffc72632f233cd4f86d914c032d80172c9ff
[INFO] running `Command { std: "docker" "start" "-a" "94bdde45660ee19f00ff21995eabffc72632f233cd4f86d914c032d80172c9ff", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "94bdde45660ee19f00ff21995eabffc72632f233cd4f86d914c032d80172c9ff", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "94bdde45660ee19f00ff21995eabffc72632f233cd4f86d914c032d80172c9ff", kill_on_drop: false }`
[INFO] [stdout] 94bdde45660ee19f00ff21995eabffc72632f233cd4f86d914c032d80172c9ff
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+bfe97fcae016881ad333f0ff8cea2cadb9cf136c" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 61afaaa26cbce3e01b9c301d0e1b40a628d0e3334dc8183d58a95e6547902312
[INFO] running `Command { std: "docker" "start" "-a" "61afaaa26cbce3e01b9c301d0e1b40a628d0e3334dc8183d58a95e6547902312", kill_on_drop: false }`
[INFO] [stderr]    Compiling num-traits v0.2.18
[INFO] [stderr]    Compiling syn v1.0.109
[INFO] [stderr]    Compiling platforms v3.3.0
[INFO] [stderr]     Checking nom v7.1.3
[INFO] [stderr]    Compiling num-bigint v0.3.3
[INFO] [stderr]    Compiling arrayvec v0.5.2
[INFO] [stderr]     Checking inout v0.1.3
[INFO] [stderr]     Checking crypto-common v0.1.6
[INFO] [stderr]    Compiling zeroize_derive v1.4.2
[INFO] [stderr]    Compiling displaydoc v0.2.4
[INFO] [stderr]    Compiling curve25519-dalek-derive v0.1.1
[INFO] [stderr]     Checking serde v1.0.197
[INFO] [stderr]     Checking regex-automata v0.4.6
[INFO] [stderr]     Checking base64 v0.21.7
[INFO] [stderr]     Checking rusticata-macros v2.1.0
[INFO] [stderr]     Checking parking_lot_core v0.9.9
[INFO] [stderr]     Checking digest v0.10.7
[INFO] [stderr]     Checking cipher v0.4.4
[INFO] [stderr]     Checking universal-hash v0.5.1
[INFO] [stderr]     Checking aead v0.5.2
[INFO] [stderr]     Checking pem v3.0.3
[INFO] [stderr]     Checking polyval v0.6.2
[INFO] [stderr]     Checking sha2 v0.10.8
[INFO] [stderr]    Compiling curve25519-dalek v4.1.2
[INFO] [stderr]     Checking ctr v0.9.2
[INFO] [stderr]    Compiling lexical-core v0.7.6
[INFO] [stderr]     Checking aes v0.8.4
[INFO] [stderr]     Checking hmac v0.12.1
[INFO] [stderr]     Checking ghash v0.5.1
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]     Checking dirs-sys v0.3.7
[INFO] [stderr]    Compiling num-rational v0.4.1
[INFO] [stderr]     Checking linked-hash-map v0.5.6
[INFO] [stderr]     Checking parking_lot_core v0.8.6
[INFO] [stderr]     Checking dirs v4.0.0
[INFO] [stderr]     Checking hkdf v0.12.4
[INFO] [stderr]     Checking parking_lot v0.12.1
[INFO] [stderr]     Checking yaml-rust v0.4.5
[INFO] [stderr]     Checking base64 v0.22.0
[INFO] [stderr]     Checking aes-gcm v0.10.3
[INFO] [stderr]     Checking scheduled-thread-pool v0.2.7
[INFO] [stderr]     Checking sha2 v0.9.9
[INFO] [stderr]     Checking parking_lot v0.11.2
[INFO] [stderr]     Checking shellexpand v2.1.2
[INFO] [stderr]     Checking natord v1.0.9
[INFO] [stderr]     Checking skiplist v0.4.0
[INFO] [stderr]     Checking zeroize v1.3.0
[INFO] [stderr]     Checking curve25519-dalek v3.2.1
[INFO] [stderr]     Checking num-integer v0.1.46
[INFO] [stderr]     Checking regex v1.10.3
[INFO] [stderr]     Checking num-bigint v0.4.4
[INFO] [stderr]     Checking rusticata-macros v4.1.0
[INFO] [stderr]    Compiling nom v5.1.3
[INFO] [stderr]     Checking pem v0.8.3
[INFO] [stderr]     Checking x25519-dalek v1.2.0
[INFO] [stderr]     Checking x25519-dalek v2.0.1
[INFO] [stderr]     Checking serde_json v1.0.114
[INFO] [stderr]     Checking multimap v0.8.3
[INFO] [stderr]     Checking serde_yaml v0.8.26
[INFO] [stderr]     Checking serde_test v1.0.176
[INFO] [stderr]    Compiling der-oid-macro v0.2.0
[INFO] [stderr]    Compiling synstructure v0.12.6
[INFO] [stderr]     Checking der-parser v4.1.1
[INFO] [stderr]     Checking curve25519-parser v0.2.0
[INFO] [stderr]    Compiling asn1-rs-derive v0.4.0
[INFO] [stderr]    Compiling asn1-rs-impl v0.1.0
[INFO] [stderr]     Checking asn1-rs v0.5.2
[INFO] [stderr]     Checking der-parser v8.2.0
[INFO] [stderr]     Checking curve25519-parser v0.4.0
[INFO] [stderr]     Checking ecies_25519 v0.1.2
[INFO] [stderr]     Checking c5store v0.2.3 (/opt/rustwide/workdir)
[INFO] [stdout] warning: the item `FromIterator` is imported redundantly
[INFO] [stdout]  --> src/data.rs:8:17
[INFO] [stdout]   |
[INFO] [stdout] 8 | use std::iter::{FromIterator, IntoIterator, Iterator};
[INFO] [stdout]   |                 ^^^^^^^^^^^^
[INFO] [stdout]  --> /rustc/bfe97fcae016881ad333f0ff8cea2cadb9cf136c/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `FromIterator` is already defined here
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `IntoIterator` is imported redundantly
[INFO] [stdout]  --> src/data.rs:8:31
[INFO] [stdout]   |
[INFO] [stdout] 8 | use std::iter::{FromIterator, IntoIterator, Iterator};
[INFO] [stdout]   |                               ^^^^^^^^^^^^
[INFO] [stdout]  --> /rustc/bfe97fcae016881ad333f0ff8cea2cadb9cf136c/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `IntoIterator` is already defined here
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `FromIterator` is imported redundantly
[INFO] [stdout]  --> src/data.rs:8:17
[INFO] [stdout]   |
[INFO] [stdout] 8 | use std::iter::{FromIterator, IntoIterator, Iterator};
[INFO] [stdout]   |                 ^^^^^^^^^^^^
[INFO] [stdout]  --> /rustc/bfe97fcae016881ad333f0ff8cea2cadb9cf136c/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `FromIterator` is already defined here
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `Iterator` is imported redundantly
[INFO] [stdout]  --> src/data.rs:8:45
[INFO] [stdout]   |
[INFO] [stdout] 8 | use std::iter::{FromIterator, IntoIterator, Iterator};
[INFO] [stdout]   |                                             ^^^^^^^^
[INFO] [stdout]  --> /rustc/bfe97fcae016881ad333f0ff8cea2cadb9cf136c/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `Iterator` is already defined here
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `FromIterator` is imported redundantly
[INFO] [stdout]  --> src/providers.rs:3:5
[INFO] [stdout]   |
[INFO] [stdout] 3 | use std::iter::FromIterator;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]  --> /rustc/bfe97fcae016881ad333f0ff8cea2cadb9cf136c/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `FromIterator` is already defined here
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `TryInto` is imported redundantly
[INFO] [stdout]  --> src/value.rs:2:5
[INFO] [stdout]   |
[INFO] [stdout] 2 | use std::convert::TryInto;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]  --> /rustc/bfe97fcae016881ad333f0ff8cea2cadb9cf136c/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `TryInto` is already defined here
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `IntoIterator` is imported redundantly
[INFO] [stdout]  --> src/data.rs:8:31
[INFO] [stdout]   |
[INFO] [stdout] 8 | use std::iter::{FromIterator, IntoIterator, Iterator};
[INFO] [stdout]   |                               ^^^^^^^^^^^^
[INFO] [stdout]  --> /rustc/bfe97fcae016881ad333f0ff8cea2cadb9cf136c/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `IntoIterator` is already defined here
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `Iterator` is imported redundantly
[INFO] [stdout]  --> src/data.rs:8:45
[INFO] [stdout]   |
[INFO] [stdout] 8 | use std::iter::{FromIterator, IntoIterator, Iterator};
[INFO] [stdout]   |                                             ^^^^^^^^
[INFO] [stdout]  --> /rustc/bfe97fcae016881ad333f0ff8cea2cadb9cf136c/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `Iterator` is already defined here
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `FromIterator` is imported redundantly
[INFO] [stdout]  --> src/providers.rs:3:5
[INFO] [stdout]   |
[INFO] [stdout] 3 | use std::iter::FromIterator;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]  --> /rustc/bfe97fcae016881ad333f0ff8cea2cadb9cf136c/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `FromIterator` is already defined here
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the item `TryInto` is imported redundantly
[INFO] [stdout]  --> src/value.rs:2:5
[INFO] [stdout]   |
[INFO] [stdout] 2 | use std::convert::TryInto;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]  --> /rustc/bfe97fcae016881ad333f0ff8cea2cadb9cf136c/library/std/src/prelude/mod.rs:129:13
[INFO] [stdout]   |
[INFO] [stdout]   = note: the item `TryInto` is already defined here
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated associated function `scheduled_thread_pool::ScheduledThreadPool::with_name`: use ScheduledThreadPool::builder
[INFO] [stdout]    --> src/lib.rs:115:50
[INFO] [stdout]     |
[INFO] [stdout] 115 |       thread_pool: Arc::new(ScheduledThreadPool::with_name("c5Store_change_notifier", 1)),
[INFO] [stdout]     |                                                  ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(deprecated)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated associated function `scheduled_thread_pool::ScheduledThreadPool::with_name`: use ScheduledThreadPool::builder
[INFO] [stdout]    --> src/lib.rs:115:50
[INFO] [stdout]     |
[INFO] [stdout] 115 |       thread_pool: Arc::new(ScheduledThreadPool::with_name("c5Store_change_notifier", 1)),
[INFO] [stdout]     |                                                  ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(deprecated)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated associated function `scheduled_thread_pool::ScheduledThreadPool::with_name`: use ScheduledThreadPool::builder
[INFO] [stdout]    --> src/lib.rs:356:52
[INFO] [stdout]     |
[INFO] [stdout] 356 |       _scheduled_thread_pool: ScheduledThreadPool::with_name("c5store_mgr", 8),
[INFO] [stdout]     |                                                    ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated associated function `scheduled_thread_pool::ScheduledThreadPool::with_name`: use ScheduledThreadPool::builder
[INFO] [stdout]    --> src/lib.rs:356:52
[INFO] [stdout]     |
[INFO] [stdout] 356 |       _scheduled_thread_pool: ScheduledThreadPool::with_name("c5store_mgr", 8),
[INFO] [stdout]     |                                                    ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `with_subscribers` is never used
[INFO] [stdout]    --> src/internal.rs:309:10
[INFO] [stdout]     |
[INFO] [stdout] 303 | impl C5StoreSubscriptions {
[INFO] [stdout]     | ------------------------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 309 |   pub fn with_subscribers<SubscriberFn>(&self, key_path: &str, subscriber_fn: SubscriberFn)
[INFO] [stdout]     |          ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `with_subscribers` is never used
[INFO] [stdout]    --> src/internal.rs:309:10
[INFO] [stdout]     |
[INFO] [stdout] 303 | impl C5StoreSubscriptions {
[INFO] [stdout]     | ------------------------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 309 |   pub fn with_subscribers<SubscriberFn>(&self, key_path: &str, subscriber_fn: SubscriberFn)
[INFO] [stdout]     |          ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `as_bytes` is never used
[INFO] [stdout]    --> src/value.rs:279:17
[INFO] [stdout]     |
[INFO] [stdout] 277 | impl C5DataValue {
[INFO] [stdout]     | ---------------- method in this implementation
[INFO] [stdout] 278 |
[INFO] [stdout] 279 |   pub(crate) fn as_bytes(&self) -> Option<Vec<u8>> {
[INFO] [stdout]     |                 ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `as_bytes` is never used
[INFO] [stdout]    --> src/value.rs:279:17
[INFO] [stdout]     |
[INFO] [stdout] 277 | impl C5DataValue {
[INFO] [stdout]     | ---------------- method in this implementation
[INFO] [stdout] 278 |
[INFO] [stdout] 279 |   pub(crate) fn as_bytes(&self) -> Option<Vec<u8>> {
[INFO] [stdout]     |                 ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/lib.rs:396:55
[INFO] [stdout]     |
[INFO] [stdout] 396 |     self._value_providers.lock().insert(Box::from(name.clone()), Box::from(value_provider));
[INFO] [stdout]     |                                                       ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed
[INFO] [stdout]     = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/lib.rs:396:55
[INFO] [stdout]     |
[INFO] [stdout] 396 |     self._value_providers.lock().insert(Box::from(name.clone()), Box::from(value_provider));
[INFO] [stdout]     |                                                       ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed
[INFO] [stdout]     = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/internal.rs:325:28
[INFO] [stdout]     |
[INFO] [stdout] 325 |     for change_listener in rwlock.get(notify_key_path) {
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 325 |     while let Some(change_listener) = rwlock.get(notify_key_path) {
[INFO] [stdout]     |     ~~~~~~~~~~~~~~~               ~~~
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 325 |     if let Some(change_listener) = rwlock.get(notify_key_path) {
[INFO] [stdout]     |     ~~~~~~~~~~~~               ~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/internal.rs:325:28
[INFO] [stdout]     |
[INFO] [stdout] 325 |     for change_listener in rwlock.get(notify_key_path) {
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 325 |     while let Some(change_listener) = rwlock.get(notify_key_path) {
[INFO] [stdout]     |     ~~~~~~~~~~~~~~~               ~~~
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 325 |     if let Some(change_listener) = rwlock.get(notify_key_path) {
[INFO] [stdout]     |     ~~~~~~~~~~~~               ~~~
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 11 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: 11 warnings emitted
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.37s
[INFO] running `Command { std: "docker" "inspect" "61afaaa26cbce3e01b9c301d0e1b40a628d0e3334dc8183d58a95e6547902312", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "61afaaa26cbce3e01b9c301d0e1b40a628d0e3334dc8183d58a95e6547902312", kill_on_drop: false }`
[INFO] [stdout] 61afaaa26cbce3e01b9c301d0e1b40a628d0e3334dc8183d58a95e6547902312
