[INFO] cloning repository https://github.com/frohman04/advent-2019 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/frohman04/advent-2019" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffrohman04%2Fadvent-2019", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffrohman04%2Fadvent-2019'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e38fb023f03139177433ab97d21ef6828f0a341d [INFO] checking frohman04/advent-2019 against master#5518eaa946291f00471af8b254b2a1715f234882 for pr-120393 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffrohman04%2Fadvent-2019" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/frohman04/advent-2019 on toolchain 5518eaa946291f00471af8b254b2a1715f234882 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5518eaa946291f00471af8b254b2a1715f234882" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/frohman04/advent-2019 [INFO] finished tweaking git repo https://github.com/frohman04/advent-2019 [INFO] tweaked toml for git repo https://github.com/frohman04/advent-2019 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/frohman04/advent-2019 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5518eaa946291f00471af8b254b2a1715f234882" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded proc-macro2 v1.0.8 [INFO] [stderr] Downloaded num-rational v0.2.3 [INFO] [stderr] Downloaded syn v1.0.14 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+5518eaa946291f00471af8b254b2a1715f234882" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 26d882254b596ece161006ba7844139b9c56b9d602dbd93e54ad2e47001dc5e0 [INFO] running `Command { std: "docker" "start" "-a" "26d882254b596ece161006ba7844139b9c56b9d602dbd93e54ad2e47001dc5e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "26d882254b596ece161006ba7844139b9c56b9d602dbd93e54ad2e47001dc5e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26d882254b596ece161006ba7844139b9c56b9d602dbd93e54ad2e47001dc5e0", kill_on_drop: false }` [INFO] [stdout] 26d882254b596ece161006ba7844139b9c56b9d602dbd93e54ad2e47001dc5e0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+5518eaa946291f00471af8b254b2a1715f234882" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a352141e1ee8a1b164f8a7c1c5e6ed18d740174dde3550e294af306611d544ee [INFO] running `Command { std: "docker" "start" "-a" "a352141e1ee8a1b164f8a7c1c5e6ed18d740174dde3550e294af306611d544ee", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling num-rational v0.2.3 [INFO] [stderr] Compiling num-iter v0.1.40 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Compiling num-derive v0.3.0 [INFO] [stderr] Checking advent-2019 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day11-prob01.rs:325:9 [INFO] [stdout] | [INFO] [stdout] 325 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 325 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 325 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day11-prob01.rs:330:9 [INFO] [stdout] | [INFO] [stdout] 330 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 330 - (self.code[param1_addr]) [INFO] [stdout] 330 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day09-prob02.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 240 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 240 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day09-prob02.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 245 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 245 - (self.code[param1_addr]) [INFO] [stdout] 245 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day13-prob01.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 301 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 301 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day13-prob01.rs:306:9 [INFO] [stdout] | [INFO] [stdout] 306 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 306 - (self.code[param1_addr]) [INFO] [stdout] 306 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day09-prob01.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 240 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 240 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day09-prob01.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 245 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 245 - (self.code[param1_addr]) [INFO] [stdout] 245 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day09-prob01.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 240 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 240 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day09-prob01.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 245 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 245 - (self.code[param1_addr]) [INFO] [stdout] 245 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/day11-prob01.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | _ => panic!(format!("Received invalid direction: {}", turn)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 90 - _ => panic!(format!("Received invalid direction: {}", turn)), [INFO] [stdout] 90 + _ => panic!("Received invalid direction: {}", turn), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/bin/day06-prob02.rs:64:29 [INFO] [stdout] | [INFO] [stdout] 64 | let mut curr = satellite.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/day03-prob02.rs:153:25 [INFO] [stdout] | [INFO] [stdout] 153 | _ => panic!(format!("Unknown direction: {}", dir)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 153 - _ => panic!(format!("Unknown direction: {}", dir)), [INFO] [stdout] 153 + _ => panic!("Unknown direction: {}", dir), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/day03-prob01.rs:150:25 [INFO] [stdout] | [INFO] [stdout] 150 | _ => panic!(format!("Unknown direction: {}", dir)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 150 - _ => panic!(format!("Unknown direction: {}", dir)), [INFO] [stdout] 150 + _ => panic!("Unknown direction: {}", dir), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day11-prob01.rs:325:9 [INFO] [stdout] | [INFO] [stdout] 325 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 325 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 325 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day11-prob01.rs:330:9 [INFO] [stdout] | [INFO] [stdout] 330 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 330 - (self.code[param1_addr]) [INFO] [stdout] 330 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/day03-prob02.rs:153:25 [INFO] [stdout] | [INFO] [stdout] 153 | _ => panic!(format!("Unknown direction: {}", dir)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 153 - _ => panic!(format!("Unknown direction: {}", dir)), [INFO] [stdout] 153 + _ => panic!("Unknown direction: {}", dir), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/day03-prob01.rs:150:25 [INFO] [stdout] | [INFO] [stdout] 150 | _ => panic!(format!("Unknown direction: {}", dir)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 150 - _ => panic!(format!("Unknown direction: {}", dir)), [INFO] [stdout] 150 + _ => panic!("Unknown direction: {}", dir), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/day11-prob01.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | _ => panic!(format!("Received invalid direction: {}", turn)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 90 - _ => panic!(format!("Received invalid direction: {}", turn)), [INFO] [stdout] 90 + _ => panic!("Received invalid direction: {}", turn), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day09-prob02.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 240 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 240 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day09-prob02.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 245 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 245 - (self.code[param1_addr]) [INFO] [stdout] 245 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/bin/day06-prob01.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 55 | let mut curr = satellite.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/bin/day06-prob01.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 55 | let mut curr = satellite.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day11-prob02.rs:353:9 [INFO] [stdout] | [INFO] [stdout] 353 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 353 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 353 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day11-prob02.rs:358:9 [INFO] [stdout] | [INFO] [stdout] 358 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 358 - (self.code[param1_addr]) [INFO] [stdout] 358 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day11-prob02.rs:353:9 [INFO] [stdout] | [INFO] [stdout] 353 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 353 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 353 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day11-prob02.rs:358:9 [INFO] [stdout] | [INFO] [stdout] 358 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 358 - (self.code[param1_addr]) [INFO] [stdout] 358 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day13-prob02.rs:386:9 [INFO] [stdout] | [INFO] [stdout] 386 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 386 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 386 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day13-prob02.rs:391:9 [INFO] [stdout] | [INFO] [stdout] 391 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 391 - (self.code[param1_addr]) [INFO] [stdout] 391 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day13-prob02.rs:386:9 [INFO] [stdout] | [INFO] [stdout] 386 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 386 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 386 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day13-prob02.rs:391:9 [INFO] [stdout] | [INFO] [stdout] 391 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 391 - (self.code[param1_addr]) [INFO] [stdout] 391 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/bin/day06-prob02.rs:64:29 [INFO] [stdout] | [INFO] [stdout] 64 | let mut curr = satellite.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/day11-prob02.rs:84:29 [INFO] [stdout] | [INFO] [stdout] 84 | _ => panic!(format!("Unexpected color {} at {:?}", color, (x, y))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 84 - _ => panic!(format!("Unexpected color {} at {:?}", color, (x, y))), [INFO] [stdout] 84 + _ => panic!("Unexpected color {} at {:?}", color, (x, y)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/day11-prob02.rs:118:25 [INFO] [stdout] | [INFO] [stdout] 118 | _ => panic!(format!("Received invalid direction: {}", turn)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 118 - _ => panic!(format!("Received invalid direction: {}", turn)), [INFO] [stdout] 118 + _ => panic!("Received invalid direction: {}", turn), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day13-prob01.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 301 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 301 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day13-prob01.rs:306:9 [INFO] [stdout] | [INFO] [stdout] 306 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 306 - (self.code[param1_addr]) [INFO] [stdout] 306 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/day11-prob02.rs:84:29 [INFO] [stdout] | [INFO] [stdout] 84 | _ => panic!(format!("Unexpected color {} at {:?}", color, (x, y))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 84 - _ => panic!(format!("Unexpected color {} at {:?}", color, (x, y))), [INFO] [stdout] 84 + _ => panic!("Unexpected color {} at {:?}", color, (x, y)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/day11-prob02.rs:118:25 [INFO] [stdout] | [INFO] [stdout] 118 | _ => panic!(format!("Received invalid direction: {}", turn)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 118 - _ => panic!(format!("Received invalid direction: {}", turn)), [INFO] [stdout] 118 + _ => panic!("Received invalid direction: {}", turn), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.55s [INFO] running `Command { std: "docker" "inspect" "a352141e1ee8a1b164f8a7c1c5e6ed18d740174dde3550e294af306611d544ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a352141e1ee8a1b164f8a7c1c5e6ed18d740174dde3550e294af306611d544ee", kill_on_drop: false }` [INFO] [stdout] a352141e1ee8a1b164f8a7c1c5e6ed18d740174dde3550e294af306611d544ee [INFO] checking frohman04/advent-2019 against try#7622c0f807a4e13c4db886a1681bf343795692df+rustflags=-Dnon_local_definitions for pr-120393 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffrohman04%2Fadvent-2019" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/frohman04/advent-2019 on toolchain 7622c0f807a4e13c4db886a1681bf343795692df [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7622c0f807a4e13c4db886a1681bf343795692df" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/frohman04/advent-2019 [INFO] finished tweaking git repo https://github.com/frohman04/advent-2019 [INFO] tweaked toml for git repo https://github.com/frohman04/advent-2019 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/frohman04/advent-2019 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7622c0f807a4e13c4db886a1681bf343795692df" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+7622c0f807a4e13c4db886a1681bf343795692df" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3a9030b72f9317de014dd92e120a1bd7adf27bd957541170d9a27c3e920e1b64 [INFO] running `Command { std: "docker" "start" "-a" "3a9030b72f9317de014dd92e120a1bd7adf27bd957541170d9a27c3e920e1b64", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3a9030b72f9317de014dd92e120a1bd7adf27bd957541170d9a27c3e920e1b64", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a9030b72f9317de014dd92e120a1bd7adf27bd957541170d9a27c3e920e1b64", kill_on_drop: false }` [INFO] [stdout] 3a9030b72f9317de014dd92e120a1bd7adf27bd957541170d9a27c3e920e1b64 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dnon_local_definitions" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+7622c0f807a4e13c4db886a1681bf343795692df" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 00d1c734b1a6a5e3d13a18c3bd5cf3c41bb69abb8e8ebc14c50da99ef5b273b5 [INFO] running `Command { std: "docker" "start" "-a" "00d1c734b1a6a5e3d13a18c3bd5cf3c41bb69abb8e8ebc14c50da99ef5b273b5", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling num-iter v0.1.40 [INFO] [stderr] Compiling num-rational v0.2.3 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Compiling num-derive v0.3.0 [INFO] [stderr] Checking advent-2019 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day11-prob01.rs:325:9 [INFO] [stdout] | [INFO] [stdout] 325 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 325 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 325 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day11-prob02.rs:353:9 [INFO] [stdout] | [INFO] [stdout] 353 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 353 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 353 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day11-prob01.rs:330:9 [INFO] [stdout] | [INFO] [stdout] 330 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 330 - (self.code[param1_addr]) [INFO] [stdout] 330 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day11-prob02.rs:358:9 [INFO] [stdout] | [INFO] [stdout] 358 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 358 - (self.code[param1_addr]) [INFO] [stdout] 358 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day09-prob02.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 240 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 240 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day09-prob02.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 245 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 245 - (self.code[param1_addr]) [INFO] [stdout] 245 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day13-prob01.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 301 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 301 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day13-prob01.rs:306:9 [INFO] [stdout] | [INFO] [stdout] 306 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 306 - (self.code[param1_addr]) [INFO] [stdout] 306 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day13-prob01.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 301 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 301 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day13-prob01.rs:306:9 [INFO] [stdout] | [INFO] [stdout] 306 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 306 - (self.code[param1_addr]) [INFO] [stdout] 306 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/day03-prob02.rs:153:25 [INFO] [stdout] | [INFO] [stdout] 153 | _ => panic!(format!("Unknown direction: {}", dir)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 153 - _ => panic!(format!("Unknown direction: {}", dir)), [INFO] [stdout] 153 + _ => panic!("Unknown direction: {}", dir), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/day11-prob01.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | _ => panic!(format!("Received invalid direction: {}", turn)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 90 - _ => panic!(format!("Received invalid direction: {}", turn)), [INFO] [stdout] 90 + _ => panic!("Received invalid direction: {}", turn), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/day11-prob02.rs:84:29 [INFO] [stdout] | [INFO] [stdout] 84 | _ => panic!(format!("Unexpected color {} at {:?}", color, (x, y))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 84 - _ => panic!(format!("Unexpected color {} at {:?}", color, (x, y))), [INFO] [stdout] 84 + _ => panic!("Unexpected color {} at {:?}", color, (x, y)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/day11-prob02.rs:118:25 [INFO] [stdout] | [INFO] [stdout] 118 | _ => panic!(format!("Received invalid direction: {}", turn)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 118 - _ => panic!(format!("Received invalid direction: {}", turn)), [INFO] [stdout] 118 + _ => panic!("Received invalid direction: {}", turn), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/day03-prob01.rs:150:25 [INFO] [stdout] | [INFO] [stdout] 150 | _ => panic!(format!("Unknown direction: {}", dir)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 150 - _ => panic!(format!("Unknown direction: {}", dir)), [INFO] [stdout] 150 + _ => panic!("Unknown direction: {}", dir), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: non-local `impl` definition, they should be avoided as they go against expectation [INFO] [stdout] --> src/bin/day13-prob01.rs:96:56 [INFO] [stdout] | [INFO] [stdout] 96 | #[derive(Debug, Clone, Ord, PartialOrd, PartialEq, Eq, FromPrimitive)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: move this `impl` block outside the of the current constant `_IMPL_NUM_FromPrimitive_FOR_Tile` [INFO] [stdout] = note: an `impl` definition is non-local if it is nested inside an item and neither the type nor the trait are at the same nesting level as the `impl` block [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: requested on the command line with `-D non-local-definitions` [INFO] [stdout] = note: this error originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent-2019` (bin "day13-prob01") due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/bin/day06-prob01.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 55 | let mut curr = satellite.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: non-local `impl` definition, they should be avoided as they go against expectation [INFO] [stdout] --> src/bin/day13-prob01.rs:96:56 [INFO] [stdout] | [INFO] [stdout] 96 | #[derive(Debug, Clone, Ord, PartialOrd, PartialEq, Eq, FromPrimitive)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: move this `impl` block outside the of the current constant `_IMPL_NUM_FromPrimitive_FOR_Tile` [INFO] [stdout] = note: an `impl` definition is non-local if it is nested inside an item and neither the type nor the trait are at the same nesting level as the `impl` block [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: requested on the command line with `-D non-local-definitions` [INFO] [stdout] = note: this error originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day11-prob01.rs:325:9 [INFO] [stdout] | [INFO] [stdout] 325 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 325 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 325 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day11-prob01.rs:330:9 [INFO] [stdout] | [INFO] [stdout] 330 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 330 - (self.code[param1_addr]) [INFO] [stdout] 330 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day09-prob01.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | (self.get_addr(1, param1_mode)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 240 - (self.get_addr(1, param1_mode)) [INFO] [stdout] 240 + self.get_addr(1, param1_mode) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/bin/day09-prob01.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 245 | (self.code[param1_addr]) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 245 - (self.code[param1_addr]) [INFO] [stdout] 245 + self.code[param1_addr] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent-2019` (bin "day13-prob01" test) due to 2 previous errors; 2 warnings emitted [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/bin/day11-prob01.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | _ => panic!(format!("Received invalid direction: {}", turn)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 90 - _ => panic!(format!("Received invalid direction: {}", turn)), [INFO] [stdout] 90 + _ => panic!("Received invalid direction: {}", turn), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "00d1c734b1a6a5e3d13a18c3bd5cf3c41bb69abb8e8ebc14c50da99ef5b273b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00d1c734b1a6a5e3d13a18c3bd5cf3c41bb69abb8e8ebc14c50da99ef5b273b5", kill_on_drop: false }` [INFO] [stdout] 00d1c734b1a6a5e3d13a18c3bd5cf3c41bb69abb8e8ebc14c50da99ef5b273b5