[INFO] fetching crate kumitateru 0.4.0... [INFO] checking kumitateru-0.4.0 against master#5518eaa946291f00471af8b254b2a1715f234882 for pr-120393-1 [INFO] extracting crate kumitateru 0.4.0 into /workspace/builds/worker-5-tc1/source [INFO] validating manifest of crates.io crate kumitateru 0.4.0 on toolchain 5518eaa946291f00471af8b254b2a1715f234882 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5518eaa946291f00471af8b254b2a1715f234882" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kumitateru 0.4.0 [INFO] finished tweaking crates.io crate kumitateru 0.4.0 [INFO] tweaked toml for crates.io crate kumitateru 0.4.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate crates.io crate kumitateru 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5518eaa946291f00471af8b254b2a1715f234882" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded signal-hook-mio v0.2.1 [INFO] [stderr] Downloaded unicode-xid v0.2.2 [INFO] [stderr] Downloaded toml v0.5.8 [INFO] [stderr] Downloaded mio v0.7.14 [INFO] [stderr] Downloaded home v0.5.3 [INFO] [stderr] Downloaded unicode-width v0.1.9 [INFO] [stderr] Downloaded yaserde v0.6.0 [INFO] [stderr] Downloaded redox_syscall v0.2.10 [INFO] [stderr] Downloaded lock_api v0.4.5 [INFO] [stderr] Downloaded signal-hook v0.3.10 [INFO] [stderr] Downloaded crossterm v0.20.0 [INFO] [stderr] Downloaded regex v1.5.4 [INFO] [stderr] Downloaded clap v2.33.3 [INFO] [stderr] Downloaded regex-syntax v0.6.25 [INFO] [stderr] Downloaded aho-corasick v0.7.18 [INFO] [stderr] Downloaded libc v0.2.107 [INFO] [stderr] Downloaded syn v1.0.81 [INFO] [stderr] Downloaded quick-xml v0.20.0 [INFO] [stderr] Downloaded serde v1.0.130 [INFO] [stderr] Downloaded memchr v2.4.1 [INFO] [stderr] Downloaded unicode-segmentation v1.8.0 [INFO] [stderr] Downloaded ntapi v0.3.6 [INFO] [stderr] Downloaded parking_lot v0.11.2 [INFO] [stderr] Downloaded minidom v0.13.0 [INFO] [stderr] Downloaded serde_derive v1.0.130 [INFO] [stderr] Downloaded log v0.4.14 [INFO] [stderr] Downloaded yaserde_derive v0.5.1 [INFO] [stderr] Downloaded proc-macro2 v1.0.32 [INFO] [stderr] Downloaded getrandom v0.2.3 [INFO] [stderr] Downloaded quote v1.0.10 [INFO] [stderr] Downloaded wasi v0.10.2+wasi-snapshot-preview1 [INFO] [stderr] Downloaded xml-rs v0.8.4 [INFO] [stderr] Downloaded ansi_term v0.11.0 [INFO] [stderr] Downloaded colored v2.0.0 [INFO] [stderr] Downloaded crossterm_winapi v0.8.0 [INFO] [stderr] Downloaded scopeguard v1.1.0 [INFO] [stderr] Downloaded smallvec v1.7.0 [INFO] [stderr] Downloaded parking_lot_core v0.8.5 [INFO] [stderr] Downloaded anyhow v1.0.45 [INFO] [stderr] Downloaded uuid v0.8.2 [INFO] [stderr] Downloaded miow v0.3.7 [INFO] [stderr] Downloaded signal-hook-registry v1.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+5518eaa946291f00471af8b254b2a1715f234882" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f5ee42cfaa2279e869945f1bd31dce7e2d5a2166ede8d8e8167735f07db100b9 [INFO] running `Command { std: "docker" "start" "-a" "f5ee42cfaa2279e869945f1bd31dce7e2d5a2166ede8d8e8167735f07db100b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f5ee42cfaa2279e869945f1bd31dce7e2d5a2166ede8d8e8167735f07db100b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5ee42cfaa2279e869945f1bd31dce7e2d5a2166ede8d8e8167735f07db100b9", kill_on_drop: false }` [INFO] [stdout] f5ee42cfaa2279e869945f1bd31dce7e2d5a2166ede8d8e8167735f07db100b9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+5518eaa946291f00471af8b254b2a1715f234882" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 627c4d197fcd70764cff1d3ede33fe0f9a83116274aa74fa6bbfca453eefc03c [INFO] running `Command { std: "docker" "start" "-a" "627c4d197fcd70764cff1d3ede33fe0f9a83116274aa74fa6bbfca453eefc03c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.107 [INFO] [stderr] Compiling proc-macro2 v1.0.32 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling syn v1.0.81 [INFO] [stderr] Compiling signal-hook v0.3.10 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling anyhow v1.0.45 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking quick-xml v0.20.0 [INFO] [stderr] Checking xml-rs v0.8.4 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking signal-hook-mio v0.2.1 [INFO] [stderr] Checking minidom v0.13.0 [INFO] [stderr] Checking crossterm v0.20.0 [INFO] [stderr] Checking home v0.5.3 [INFO] [stderr] Checking yaserde v0.6.0 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Compiling yaserde_derive v0.5.1 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking kumitateru v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `construct_selection` is never used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:8:4 [INFO] [stdout] | [INFO] [stdout] 8 | fn construct_selection(header: &str, items: Vec<&str>, highlighted: i64, selected: bool) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `display_cli_multiple_selection` is never used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn display_cli_multiple_selection(header: &str, items: Vec<&str>) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `reset_selection` is never used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:105:4 [INFO] [stdout] | [INFO] [stdout] 105 | fn reset_selection(len: i64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:161:21 [INFO] [stdout] | [INFO] [stdout] 161 | io::stdin().read_line(&mut proj_name); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 161 | let _ = io::stdin().read_line(&mut proj_name); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:260:5 [INFO] [stdout] | [INFO] [stdout] 260 | io::stdin().read_line(&mut version); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 260 | let _ = io::stdin().read_line(&mut version); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | fs::create_dir("build"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 16 | let _ = fs::create_dir("build"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | fs::create_dir("build/tmp"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 17 | let _ = fs::create_dir("build/tmp"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | fs::create_dir("build/tmp/source"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 18 | let _ = fs::create_dir("build/tmp/source"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | fs::create_dir("build/tmp/resources"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 19 | let _ = fs::create_dir("build/tmp/resources"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/prepare_build.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 32 | for entry in fs::read_dir(PathBuf::from(resource)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 32 | while let Ok(entry) = fs::read_dir(PathBuf::from(resource)) { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 32 | for entry in fs::read_dir(PathBuf::from(resource))? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 32 | if let Ok(entry) = fs::read_dir(PathBuf::from(resource)) { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 119 | fs::copy(entry.path(), end_dir.clone()).with_context(|| format!("Failed to copy {:?} to {:?}", entry.path(), end_dir)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 119 | let _ = fs::copy(entry.path(), end_dir.clone()).with_context(|| format!("Failed to copy {:?} to {:?}", entry.path(), end_dir)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/tui/item_selection.rs:20:78 [INFO] [stdout] | [INFO] [stdout] 20 | result.push_str(&*format!("{}", format!("{}) {}", i + 1, items[i].clone()).bold())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/tui/item_selection.rs:22:64 [INFO] [stdout] | [INFO] [stdout] 22 | result.push_str(&*format!("{}) {}", i + 1, items[i].clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/utils/tui/item_selection.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 107 | let _ = io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/utils/tui/item_selection.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | io::stdout().execute(cursor::MoveUp(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 108 | let _ = io::stdout().execute(cursor::MoveUp(1)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:20:78 [INFO] [stdout] | [INFO] [stdout] 20 | result.push_str(&*format!("{}", format!("{}) {}", i + 1, items[i].clone()).bold())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:22:64 [INFO] [stdout] | [INFO] [stdout] 22 | result.push_str(&*format!("{}) {}", i + 1, items[i].clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 107 | let _ = io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | io::stdout().execute(cursor::MoveUp(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 108 | let _ = io::stdout().execute(cursor::MoveUp(1)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/verify_project.rs:90:18 [INFO] [stdout] | [INFO] [stdout] 90 | for entry in fs::read_dir("resources") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 90 | while let Ok(entry) = fs::read_dir("resources") { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 90 | for entry in fs::read_dir("resources")? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 90 | if let Ok(entry) = fs::read_dir("resources") { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/verify_project.rs:100:26 [INFO] [stdout] | [INFO] [stdout] 100 | for entry in fs::read_dir(entry.path()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 100 | while let Ok(entry) = fs::read_dir(entry.path()) { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 100 | for entry in fs::read_dir(entry.path())? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 100 | if let Ok(entry) = fs::read_dir(entry.path()) { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 21 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `construct_selection` is never used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:8:4 [INFO] [stdout] | [INFO] [stdout] 8 | fn construct_selection(header: &str, items: Vec<&str>, highlighted: i64, selected: bool) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `display_cli_multiple_selection` is never used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn display_cli_multiple_selection(header: &str, items: Vec<&str>) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `reset_selection` is never used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:105:4 [INFO] [stdout] | [INFO] [stdout] 105 | fn reset_selection(len: i64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:161:21 [INFO] [stdout] | [INFO] [stdout] 161 | io::stdin().read_line(&mut proj_name); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 161 | let _ = io::stdin().read_line(&mut proj_name); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:260:5 [INFO] [stdout] | [INFO] [stdout] 260 | io::stdin().read_line(&mut version); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 260 | let _ = io::stdin().read_line(&mut version); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | fs::create_dir("build"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 16 | let _ = fs::create_dir("build"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | fs::create_dir("build/tmp"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 17 | let _ = fs::create_dir("build/tmp"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | fs::create_dir("build/tmp/source"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 18 | let _ = fs::create_dir("build/tmp/source"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | fs::create_dir("build/tmp/resources"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 19 | let _ = fs::create_dir("build/tmp/resources"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/prepare_build.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 32 | for entry in fs::read_dir(PathBuf::from(resource)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 32 | while let Ok(entry) = fs::read_dir(PathBuf::from(resource)) { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 32 | for entry in fs::read_dir(PathBuf::from(resource))? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 32 | if let Ok(entry) = fs::read_dir(PathBuf::from(resource)) { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 119 | fs::copy(entry.path(), end_dir.clone()).with_context(|| format!("Failed to copy {:?} to {:?}", entry.path(), end_dir)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 119 | let _ = fs::copy(entry.path(), end_dir.clone()).with_context(|| format!("Failed to copy {:?} to {:?}", entry.path(), end_dir)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/tui/item_selection.rs:20:78 [INFO] [stdout] | [INFO] [stdout] 20 | result.push_str(&*format!("{}", format!("{}) {}", i + 1, items[i].clone()).bold())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/tui/item_selection.rs:22:64 [INFO] [stdout] | [INFO] [stdout] 22 | result.push_str(&*format!("{}) {}", i + 1, items[i].clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/utils/tui/item_selection.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 107 | let _ = io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/utils/tui/item_selection.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | io::stdout().execute(cursor::MoveUp(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 108 | let _ = io::stdout().execute(cursor::MoveUp(1)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:20:78 [INFO] [stdout] | [INFO] [stdout] 20 | result.push_str(&*format!("{}", format!("{}) {}", i + 1, items[i].clone()).bold())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:22:64 [INFO] [stdout] | [INFO] [stdout] 22 | result.push_str(&*format!("{}) {}", i + 1, items[i].clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 107 | let _ = io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | io::stdout().execute(cursor::MoveUp(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 108 | let _ = io::stdout().execute(cursor::MoveUp(1)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/verify_project.rs:90:18 [INFO] [stdout] | [INFO] [stdout] 90 | for entry in fs::read_dir("resources") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 90 | while let Ok(entry) = fs::read_dir("resources") { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 90 | for entry in fs::read_dir("resources")? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 90 | if let Ok(entry) = fs::read_dir("resources") { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/verify_project.rs:100:26 [INFO] [stdout] | [INFO] [stdout] 100 | for entry in fs::read_dir(entry.path()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 100 | while let Ok(entry) = fs::read_dir(entry.path()) { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 100 | for entry in fs::read_dir(entry.path())? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 100 | if let Ok(entry) = fs::read_dir(entry.path()) { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 21 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.75s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: quick-xml v0.20.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "627c4d197fcd70764cff1d3ede33fe0f9a83116274aa74fa6bbfca453eefc03c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "627c4d197fcd70764cff1d3ede33fe0f9a83116274aa74fa6bbfca453eefc03c", kill_on_drop: false }` [INFO] [stdout] 627c4d197fcd70764cff1d3ede33fe0f9a83116274aa74fa6bbfca453eefc03c