[INFO] fetching crate quick-csv 0.1.6... [INFO] checking quick-csv-0.1.6 against master#00bfd6b2734d9c28a147bf237490995731781fdd for pr-117984 [INFO] extracting crate quick-csv 0.1.6 into /workspace/builds/worker-5-tc1/source [INFO] validating manifest of crates.io crate quick-csv 0.1.6 on toolchain 00bfd6b2734d9c28a147bf237490995731781fdd [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate quick-csv 0.1.6 [INFO] finished tweaking crates.io crate quick-csv 0.1.6 [INFO] tweaked toml for crates.io crate quick-csv 0.1.6 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 43a72923412cdc2c09cefce9c9e7956bff881b4736c29c7a0ed112c434a14900 [INFO] running `Command { std: "docker" "start" "-a" "43a72923412cdc2c09cefce9c9e7956bff881b4736c29c7a0ed112c434a14900", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "43a72923412cdc2c09cefce9c9e7956bff881b4736c29c7a0ed112c434a14900", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43a72923412cdc2c09cefce9c9e7956bff881b4736c29c7a0ed112c434a14900", kill_on_drop: false }` [INFO] [stdout] 43a72923412cdc2c09cefce9c9e7956bff881b4736c29c7a0ed112c434a14900 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] de50aeee3be088d1473756f076e6bfee6c117d64af02759d7e530820021cfd3d [INFO] running `Command { std: "docker" "start" "-a" "de50aeee3be088d1473756f076e6bfee6c117d64af02759d7e530820021cfd3d", kill_on_drop: false }` [INFO] [stderr] Checking rustc-serialize v0.3.24 [INFO] [stderr] Checking quick-csv v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/columns.rs:140:19 [INFO] [stdout] | [INFO] [stdout] 140 | let col = try!(self.next().ok_or(Error::EOL)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/columns.rs:155:17 [INFO] [stdout] | [INFO] [stdout] 155 | let i = try!(self [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/columns.rs:204:19 [INFO] [stdout] | [INFO] [stdout] 204 | let col = try!(self.peek().ok_or(Error::EOL)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:190:37 [INFO] [stdout] | [INFO] [stdout] 190 | let reader = BufReader::new(try!(File::open(path))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:265:27 [INFO] [stdout] | [INFO] [stdout] 265 | let mut columns = try!(self.columns()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:377:8 [INFO] [stdout] | [INFO] [stdout] 377 | if try!(reader.fill_buf()).starts_with(UTF8_BOM) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/error.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 58 | fn cause(&self) -> Option<&::std::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 58 | fn cause(&self) -> Option<&dyn (::std::error::Error)> { [INFO] [stdout] | +++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/columns.rs:140:19 [INFO] [stdout] | [INFO] [stdout] 140 | let col = try!(self.next().ok_or(Error::EOL)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/columns.rs:155:17 [INFO] [stdout] | [INFO] [stdout] 155 | let i = try!(self [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/columns.rs:204:19 [INFO] [stdout] | [INFO] [stdout] 204 | let col = try!(self.peek().ok_or(Error::EOL)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `RustcDecodable`: rustc-serialize is deprecated and no longer supported [INFO] [stdout] --> src/test.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | #[derive(Debug, RustcDecodable, RustcEncodable, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `RustcEncodable`: rustc-serialize is deprecated and no longer supported [INFO] [stdout] --> src/test.rs:156:33 [INFO] [stdout] | [INFO] [stdout] 156 | #[derive(Debug, RustcDecodable, RustcEncodable, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `RustcDecodable`: rustc-serialize is deprecated and no longer supported [INFO] [stdout] --> src/test.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 178 | #[derive(Debug, RustcDecodable, RustcEncodable, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `RustcEncodable`: rustc-serialize is deprecated and no longer supported [INFO] [stdout] --> src/test.rs:178:33 [INFO] [stdout] | [INFO] [stdout] 178 | #[derive(Debug, RustcDecodable, RustcEncodable, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/test.rs:163:31 [INFO] [stdout] | [INFO] [stdout] 163 | decodes_to!(decode_char, "a", (char), vec![('a')]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 163 - decodes_to!(decode_char, "a", (char), vec![('a')]); [INFO] [stdout] 163 + decodes_to!(decode_char, "a", char, vec![('a')]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:190:37 [INFO] [stdout] | [INFO] [stdout] 190 | let reader = BufReader::new(try!(File::open(path))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:265:27 [INFO] [stdout] | [INFO] [stdout] 265 | let mut columns = try!(self.columns()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:377:8 [INFO] [stdout] | [INFO] [stdout] 377 | if try!(reader.fill_buf()).starts_with(UTF8_BOM) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/error.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 58 | fn cause(&self) -> Option<&::std::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 58 | fn cause(&self) -> Option<&dyn (::std::error::Error)> { [INFO] [stdout] | +++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `RustcDecodable`: rustc-serialize is deprecated and no longer supported [INFO] [stdout] --> benches/bench.rs:75:10 [INFO] [stdout] | [INFO] [stdout] 75 | #[derive(RustcDecodable)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> benches/bench.rs:16:47 [INFO] [stdout] | [INFO] [stdout] 16 | r.or_else(|e: E| -> Result { panic!(format!("{:?}", e)) }).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 16 - r.or_else(|e: E| -> Result { panic!(format!("{:?}", e)) }).unwrap() [INFO] [stdout] 16 + r.or_else(|e: E| -> Result { panic!("{:?}", e) }).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> benches/bench.rs:33:22 [INFO] [stdout] | [INFO] [stdout] 33 | for c in row.unwrap().columns() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 33 | while let Ok(c) = row.unwrap().columns() { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 33 | if let Ok(c) = row.unwrap().columns() { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.96s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: rustc-serialize v0.3.24 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "de50aeee3be088d1473756f076e6bfee6c117d64af02759d7e530820021cfd3d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de50aeee3be088d1473756f076e6bfee6c117d64af02759d7e530820021cfd3d", kill_on_drop: false }` [INFO] [stdout] de50aeee3be088d1473756f076e6bfee6c117d64af02759d7e530820021cfd3d