[INFO] fetching crate astrup 0.0.9... [INFO] checking astrup-0.0.9 against master#00bfd6b2734d9c28a147bf237490995731781fdd for pr-117984 [INFO] extracting crate astrup 0.0.9 into /workspace/builds/worker-7-tc1/source [INFO] validating manifest of crates.io crate astrup 0.0.9 on toolchain 00bfd6b2734d9c28a147bf237490995731781fdd [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate astrup 0.0.9 [INFO] finished tweaking crates.io crate astrup 0.0.9 [INFO] tweaked toml for crates.io crate astrup 0.0.9 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded siphasher v0.2.3 [INFO] [stderr] Downloaded phf_shared v0.7.24 [INFO] [stderr] Downloaded phf_generator v0.7.24 [INFO] [stderr] Downloaded num-rational v0.1.42 [INFO] [stderr] Downloaded gdk-sys v0.5.0 [INFO] [stderr] Downloaded matrixmultiply v0.1.15 [INFO] [stderr] Downloaded phf_codegen v0.7.24 [INFO] [stderr] Downloaded num v0.1.42 [INFO] [stderr] Downloaded gobject-sys v0.5.0 [INFO] [stderr] Downloaded gdk-pixbuf-sys v0.5.0 [INFO] [stderr] Downloaded rawpointer v0.1.0 [INFO] [stderr] Downloaded phf v0.7.24 [INFO] [stderr] Downloaded c_vec v1.2.1 [INFO] [stderr] Downloaded cairo-rs v0.3.0 [INFO] [stderr] Downloaded gio v0.3.0 [INFO] [stderr] Downloaded palette v0.2.1 [INFO] [stderr] Downloaded csv v1.3.0 [INFO] [stderr] Downloaded glib v0.4.1 [INFO] [stderr] Downloaded glib-sys v0.5.0 [INFO] [stderr] Downloaded gtk-sys v0.5.0 [INFO] [stderr] Downloaded itertools v0.7.11 [INFO] [stderr] Downloaded gdk v0.7.0 [INFO] [stderr] Downloaded ndarray v0.11.2 [INFO] [stderr] Downloaded gtk v0.3.0 [INFO] [stderr] Downloaded gio-sys v0.5.0 [INFO] [stderr] Downloaded csv-core v0.1.11 [INFO] [stderr] Downloaded num-bigint v0.1.44 [INFO] [stderr] Downloaded pango v0.3.0 [INFO] [stderr] Downloaded cairo-sys-rs v0.5.0 [INFO] [stderr] Downloaded num-complex v0.1.43 [INFO] [stderr] Downloaded gdk-pixbuf v0.3.0 [INFO] [stderr] Downloaded atk-sys v0.5.0 [INFO] [stderr] Downloaded approx v0.1.1 [INFO] [stderr] Downloaded pango-sys v0.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 62abef2565ffbf0d3fd25f38662f30289fa146792ef7a53405e24d10c465ec18 [INFO] running `Command { std: "docker" "start" "-a" "62abef2565ffbf0d3fd25f38662f30289fa146792ef7a53405e24d10c465ec18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "62abef2565ffbf0d3fd25f38662f30289fa146792ef7a53405e24d10c465ec18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62abef2565ffbf0d3fd25f38662f30289fa146792ef7a53405e24d10c465ec18", kill_on_drop: false }` [INFO] [stdout] 62abef2565ffbf0d3fd25f38662f30289fa146792ef7a53405e24d10c465ec18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ed64916e558eae5d586ca31e6f569e4dfbe99339c55cadc0077aef1df92d266d [INFO] running `Command { std: "docker" "start" "-a" "ed64916e558eae5d586ca31e6f569e4dfbe99339c55cadc0077aef1df92d266d", kill_on_drop: false }` [INFO] [stderr] Compiling glib-sys v0.5.0 [INFO] [stderr] Compiling gobject-sys v0.5.0 [INFO] [stderr] Compiling gio-sys v0.5.0 [INFO] [stderr] Compiling rand_core v0.4.2 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.5.0 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling cairo-sys-rs v0.5.0 [INFO] [stderr] Compiling pango-sys v0.5.0 [INFO] [stderr] Compiling rand_core v0.3.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling gdk-sys v0.5.0 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling rand_hc v0.1.0 [INFO] [stderr] Compiling rand_xorshift v0.1.1 [INFO] [stderr] Compiling rand_isaac v0.1.1 [INFO] [stderr] Compiling rand_jitter v0.1.4 [INFO] [stderr] Compiling rand_os v0.1.3 [INFO] [stderr] Compiling atk-sys v0.5.0 [INFO] [stderr] Checking rustc-serialize v0.3.24 [INFO] [stderr] Compiling siphasher v0.2.3 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling phf_shared v0.7.24 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Checking glib v0.4.1 [INFO] [stderr] Compiling gtk-sys v0.5.0 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Compiling gio v0.3.0 [INFO] [stderr] Compiling cairo-rs v0.3.0 [INFO] [stderr] Compiling gdk-pixbuf v0.3.0 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Compiling matrixmultiply v0.1.15 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking c_vec v1.2.1 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Compiling gdk v0.7.0 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking pango v0.3.0 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Compiling palette v0.2.1 [INFO] [stderr] Checking object v0.32.1 [INFO] [stderr] Compiling ndarray v0.11.2 [INFO] [stderr] Checking rawpointer v0.1.0 [INFO] [stderr] Compiling gtk v0.3.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking phf v0.7.24 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking iana-time-zone v0.1.58 [INFO] [stderr] Checking approx v0.1.1 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Checking astrup v0.0.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/view.rs:65:56 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn add(mut self, mut figure: Figure) -> Result<(Self), Error> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 65 - pub fn add(mut self, mut figure: Figure) -> Result<(Self), Error> { [INFO] [stdout] 65 + pub fn add(mut self, mut figure: Figure) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/view.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 69 | Ok((self)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 69 - Ok((self)) [INFO] [stdout] 69 + Ok(self) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/figure.rs:138:49 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn save(self, filename: &str) -> Result<(Self), Error> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 138 - pub fn save(self, filename: &str) -> Result<(Self), Error> { [INFO] [stdout] 138 + pub fn save(self, filename: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/figure.rs:156:12 [INFO] [stdout] | [INFO] [stdout] 156 | Ok((self)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 156 - Ok((self)) [INFO] [stdout] 156 + Ok(self) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/utils.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | ((old_number - old_min) / (old_max - old_min) * new_max + [INFO] [stdout] | ^ [INFO] [stdout] 240 | (old_max - old_number) / (old_max - old_min) * new_min) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 239 ~ (old_number - old_min) / (old_max - old_min) * new_max + [INFO] [stdout] 240 ~ (old_max - old_number) / (old_max - old_min) * new_min [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/view.rs:65:56 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn add(mut self, mut figure: Figure) -> Result<(Self), Error> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 65 - pub fn add(mut self, mut figure: Figure) -> Result<(Self), Error> { [INFO] [stdout] 65 + pub fn add(mut self, mut figure: Figure) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/view.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 69 | Ok((self)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 69 - Ok((self)) [INFO] [stdout] 69 + Ok(self) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/figure.rs:138:49 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn save(self, filename: &str) -> Result<(Self), Error> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 138 - pub fn save(self, filename: &str) -> Result<(Self), Error> { [INFO] [stdout] 138 + pub fn save(self, filename: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/figure.rs:156:12 [INFO] [stdout] | [INFO] [stdout] 156 | Ok((self)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 156 - Ok((self)) [INFO] [stdout] 156 + Ok(self) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/utils.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | ((old_number - old_min) / (old_max - old_min) * new_max + [INFO] [stdout] | ^ [INFO] [stdout] 240 | (old_max - old_number) / (old_max - old_min) * new_min) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 239 ~ (old_number - old_min) / (old_max - old_min) * new_max + [INFO] [stdout] 240 ~ (old_max - old_number) / (old_max - old_min) * new_min [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `hor_marks` and `ver_marks` are never read [INFO] [stdout] --> src/canvas.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct Canvas { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 30 | hor_marks: Vec, // TODO: Use these in stead of axis [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 31 | ver_marks: Vec, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Canvas` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `font_matrix` is never read [INFO] [stdout] --> src/text.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Text { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 15 | font_matrix: Matrix, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Text` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary allocation, use `&` instead [INFO] [stdout] --> src/view.rs:78:36 [INFO] [stdout] | [INFO] [stdout] 78 | let drawing_area = Box::new(DrawingArea::new)(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_allocation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `hor_marks` and `ver_marks` are never read [INFO] [stdout] --> src/canvas.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct Canvas { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 30 | hor_marks: Vec, // TODO: Use these in stead of axis [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 31 | ver_marks: Vec, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Canvas` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `font_matrix` is never read [INFO] [stdout] --> src/text.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Text { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 15 | font_matrix: Matrix, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Text` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary allocation, use `&` instead [INFO] [stdout] --> src/view.rs:78:36 [INFO] [stdout] | [INFO] [stdout] 78 | let drawing_area = Box::new(DrawingArea::new)(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_allocation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.52s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: rustc-serialize v0.3.24 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "ed64916e558eae5d586ca31e6f569e4dfbe99339c55cadc0077aef1df92d266d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed64916e558eae5d586ca31e6f569e4dfbe99339c55cadc0077aef1df92d266d", kill_on_drop: false }` [INFO] [stdout] ed64916e558eae5d586ca31e6f569e4dfbe99339c55cadc0077aef1df92d266d