[INFO] cloning repository https://github.com/natelust/reups [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/natelust/reups" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnatelust%2Freups", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnatelust%2Freups'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cfe327ebd7b8961ef55db153d1c7b9d8b5b58541 [INFO] checking natelust/reups against master#00bfd6b2734d9c28a147bf237490995731781fdd for pr-117984 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnatelust%2Freups" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/natelust/reups on toolchain 00bfd6b2734d9c28a147bf237490995731781fdd [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/natelust/reups [INFO] finished tweaking git repo https://github.com/natelust/reups [INFO] tweaked toml for git repo https://github.com/natelust/reups written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/natelust/reups already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded preferences v1.1.0 [INFO] [stderr] Downloaded ole32-sys v0.2.0 [INFO] [stderr] Downloaded failure_derive v0.1.3 [INFO] [stderr] Downloaded itoa v0.4.3 [INFO] [stderr] Downloaded shell32-sys v0.1.2 [INFO] [stderr] Downloaded rustc-demangle v0.1.11 [INFO] [stderr] Downloaded users v0.8.1 [INFO] [stderr] Downloaded app_dirs v1.2.1 [INFO] [stderr] Downloaded atty v0.2.8 [INFO] [stderr] Downloaded backtrace v0.3.12 [INFO] [stderr] Downloaded ryu v0.2.7 [INFO] [stderr] Downloaded syn v0.15.23 [INFO] [stderr] Downloaded regex v0.2.10 [INFO] [stderr] Downloaded winapi v0.3.4 [INFO] [stderr] Downloaded regex-syntax v0.5.5 [INFO] [stderr] Downloaded libc v0.2.45 [INFO] [stderr] Downloaded serde_json v0.9.10 [INFO] [stderr] Downloaded failure v0.1.3 [INFO] [stderr] Downloaded ordermap v0.3.5 [INFO] [stderr] Downloaded serde_json v1.0.39 [INFO] [stderr] Downloaded serde_derive v1.0.90 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 209916c90eaab4e30af5cf567da30d27482ce5062d8a7d72b5448b77fc7675f9 [INFO] running `Command { std: "docker" "start" "-a" "209916c90eaab4e30af5cf567da30d27482ce5062d8a7d72b5448b77fc7675f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "209916c90eaab4e30af5cf567da30d27482ce5062d8a7d72b5448b77fc7675f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "209916c90eaab4e30af5cf567da30d27482ce5062d8a7d72b5448b77fc7675f9", kill_on_drop: false }` [INFO] [stdout] 209916c90eaab4e30af5cf567da30d27482ce5062d8a7d72b5448b77fc7675f9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8395b5448fb3befd9fad94c4532970de21c8806ec8388dc2e37f5ad6112ec7d7 [INFO] running `Command { std: "docker" "start" "-a" "8395b5448fb3befd9fad94c4532970de21c8806ec8388dc2e37f5ad6112ec7d7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.45 [INFO] [stderr] Compiling proc-macro2 v0.4.24 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling serde v1.0.79 [INFO] [stderr] Compiling ryu v0.2.7 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Checking serde v0.9.15 [INFO] [stderr] Checking dtoa v0.4.3 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Checking unicode-width v0.1.4 [INFO] [stderr] Checking ucd-util v0.1.1 [INFO] [stderr] Compiling regex v0.2.10 [INFO] [stderr] Checking itoa v0.3.4 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking bitflags v1.0.1 [INFO] [stderr] Checking utf8-ranges v1.0.0 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking regex-syntax v0.5.5 [INFO] [stderr] Checking itoa v0.4.3 [INFO] [stderr] Checking vec_map v0.8.0 [INFO] [stderr] Checking fixedbitset v0.1.9 [INFO] [stderr] Checking app_dirs v1.2.1 [INFO] [stderr] Checking cfg-if v0.1.5 [INFO] [stderr] Checking rustc-serialize v0.3.24 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking ordermap v0.3.5 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking petgraph v0.4.13 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking atty v0.2.8 [INFO] [stderr] Checking dirs v1.0.4 [INFO] [stderr] Checking users v0.8.1 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Compiling syn v0.15.23 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking preferences v1.1.0 [INFO] [stderr] Checking log v0.4.5 [INFO] [stderr] Checking serde_json v1.0.39 [INFO] [stderr] Compiling serde_derive v1.0.90 [INFO] [stderr] Checking reups v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cogs.rs:142:8 [INFO] [stdout] | [INFO] [stdout] 142 | if (user_path.exists()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 142 - if (user_path.exists()) { [INFO] [stdout] 142 + if user_path.exists() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cogs.rs:142:8 [INFO] [stdout] | [INFO] [stdout] 142 | if (user_path.exists()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 142 - if (user_path.exists()) { [INFO] [stdout] 142 + if user_path.exists() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/db/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use self::db_impl::DBImplDeclare; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `DBImplDeclare` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/db/mod.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub use self::db_impl::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/db/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use self::db_impl::DBImplDeclare; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/db/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use self::db_impl::DBImplDeclare; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `DBImplDeclare` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/db/mod.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub use self::db_impl::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/db/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use self::db_impl::DBImplDeclare; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/db/mod.rs:304:31 [INFO] [stdout] | [INFO] [stdout] 304 | let extra_db: Box = [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 304 | let extra_db: Box = [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/db/mod.rs:195:52 [INFO] [stdout] | [INFO] [stdout] 195 | let mut db_dict = FnvHashMap::>::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 195 | let mut db_dict = FnvHashMap::>::default(); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/db/mod.rs:304:31 [INFO] [stdout] | [INFO] [stdout] 304 | let extra_db: Box = [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 304 | let extra_db: Box = [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/db/mod.rs:195:52 [INFO] [stdout] | [INFO] [stdout] 195 | let mut db_dict = FnvHashMap::>::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 195 | let mut db_dict = FnvHashMap::>::default(); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/db/db_impl/posix_db_impl.rs:302:55 [INFO] [stdout] | [INFO] [stdout] 302 | let base = self.location.parent().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&std::string::String` instead of cloning the inner type [INFO] [stdout] --> src/setup.rs:431:73 [INFO] [stdout] | [INFO] [stdout] 431 | let mut largest_version = versions.iter().max().unwrap().clone().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/db/db_impl/posix_db_impl.rs:302:55 [INFO] [stdout] | [INFO] [stdout] 302 | let base = self.location.parent().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&std::string::String` instead of cloning the inner type [INFO] [stdout] --> src/setup.rs:431:73 [INFO] [stdout] | [INFO] [stdout] 431 | let mut largest_version = versions.iter().max().unwrap().clone().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.17s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: rustc-serialize v0.3.24 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "8395b5448fb3befd9fad94c4532970de21c8806ec8388dc2e37f5ad6112ec7d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8395b5448fb3befd9fad94c4532970de21c8806ec8388dc2e37f5ad6112ec7d7", kill_on_drop: false }` [INFO] [stdout] 8395b5448fb3befd9fad94c4532970de21c8806ec8388dc2e37f5ad6112ec7d7