[INFO] cloning repository https://github.com/jakequade/rust-chat-websockets [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jakequade/rust-chat-websockets" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjakequade%2Frust-chat-websockets", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjakequade%2Frust-chat-websockets'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 957741583d75d54f89b8076588df7f252c9f2194 [INFO] checking jakequade/rust-chat-websockets against master#00bfd6b2734d9c28a147bf237490995731781fdd for pr-117984 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjakequade%2Frust-chat-websockets" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/jakequade/rust-chat-websockets on toolchain 00bfd6b2734d9c28a147bf237490995731781fdd [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/jakequade/rust-chat-websockets [INFO] finished tweaking git repo https://github.com/jakequade/rust-chat-websockets [INFO] tweaked toml for git repo https://github.com/jakequade/rust-chat-websockets written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/jakequade/rust-chat-websockets already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7bf1f8b8132b91fb5356e99f5eb0c153d6d719ecbac333d7637e896253f3829d [INFO] running `Command { std: "docker" "start" "-a" "7bf1f8b8132b91fb5356e99f5eb0c153d6d719ecbac333d7637e896253f3829d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7bf1f8b8132b91fb5356e99f5eb0c153d6d719ecbac333d7637e896253f3829d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7bf1f8b8132b91fb5356e99f5eb0c153d6d719ecbac333d7637e896253f3829d", kill_on_drop: false }` [INFO] [stdout] 7bf1f8b8132b91fb5356e99f5eb0c153d6d719ecbac333d7637e896253f3829d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 59573ab80b4ad083e3cf7a211e43a3cdb0048238fd1156f5a299a683e35d8ce9 [INFO] running `Command { std: "docker" "start" "-a" "59573ab80b4ad083e3cf7a211e43a3cdb0048238fd1156f5a299a683e35d8ce9", kill_on_drop: false }` [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Compiling libc v0.2.109 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking bitflags v0.4.0 [INFO] [stderr] Checking bytes v0.3.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking slab v0.1.3 [INFO] [stderr] Checking rustc-serialize v0.3.24 [INFO] [stderr] Compiling ws2_32-sys v0.2.1 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking sha1 v0.1.1 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Compiling http-muncher v0.2.5 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking chat v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/client.rs:117:20 [INFO] [stdout] | [INFO] [stdout] 117 | if (self.outgoing.len() > 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 117 - if (self.outgoing.len() > 0) { [INFO] [stdout] 117 + if self.outgoing.len() > 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/frame.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/client.rs:117:20 [INFO] [stdout] | [INFO] [stdout] 117 | if (self.outgoing.len() > 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 117 - if (self.outgoing.len() > 0) { [INFO] [stdout] 117 + if self.outgoing.len() > 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/frame.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `len` [INFO] [stdout] --> src/client.rs:82:25 [INFO] [stdout] | [INFO] [stdout] 82 | Ok(Some(len)) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_len` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `len` [INFO] [stdout] --> src/client.rs:82:25 [INFO] [stdout] | [INFO] [stdout] 82 | Ok(Some(len)) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_len` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | let mut client = self.clients.get_mut(&token).unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | let mut client = self.clients.get_mut(&token).unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HandshakeResponse` is never constructed [INFO] [stdout] --> src/client.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 51 | pub enum ClientState { [INFO] [stdout] | ----------- variant in this enum [INFO] [stdout] 52 | AwaitingHandshake(RefCell>), [INFO] [stdout] 53 | HandshakeResponse, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `read_handshake` is never used [INFO] [stdout] --> src/client.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 69 | impl WebSocketClient { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] 70 | pub fn read_handshake(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | let mut client = self.clients.get_mut(&token).unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `mask` is never read [INFO] [stdout] --> src/frame.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 79 | pub struct WebSocketFrame { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 80 | header: WebSocketFrameHeader, [INFO] [stdout] 81 | mask: Option<[u8; 4]>, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `WebSocketFrame` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/server.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | let mut client = self.clients.get_mut(&token).unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_opcode` is never used [INFO] [stdout] --> src/frame.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 85 | impl WebSocketFrame { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 129 | pub fn get_opcode(&self) -> OpCode { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HandshakeResponse` is never constructed [INFO] [stdout] --> src/client.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 51 | pub enum ClientState { [INFO] [stdout] | ----------- variant in this enum [INFO] [stdout] 52 | AwaitingHandshake(RefCell>), [INFO] [stdout] 53 | HandshakeResponse, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `read_handshake` is never used [INFO] [stdout] --> src/client.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 69 | impl WebSocketClient { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] 70 | pub fn read_handshake(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `mask` is never read [INFO] [stdout] --> src/frame.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 79 | pub struct WebSocketFrame { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 80 | header: WebSocketFrameHeader, [INFO] [stdout] 81 | mask: Option<[u8; 4]>, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `WebSocketFrame` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_opcode` is never used [INFO] [stdout] --> src/frame.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 85 | impl WebSocketFrame { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 129 | pub fn get_opcode(&self) -> OpCode { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.43s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: rustc-serialize v0.3.24 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "59573ab80b4ad083e3cf7a211e43a3cdb0048238fd1156f5a299a683e35d8ce9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59573ab80b4ad083e3cf7a211e43a3cdb0048238fd1156f5a299a683e35d8ce9", kill_on_drop: false }` [INFO] [stdout] 59573ab80b4ad083e3cf7a211e43a3cdb0048238fd1156f5a299a683e35d8ce9