[INFO] cloning repository https://github.com/MartinBG/MiniGit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MartinBG/MiniGit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMartinBG%2FMiniGit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMartinBG%2FMiniGit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 18295be714a76d6d63b93027831f898f6d122c3d [INFO] checking MartinBG/MiniGit against master#00bfd6b2734d9c28a147bf237490995731781fdd for pr-117984 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMartinBG%2FMiniGit" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MartinBG/MiniGit on toolchain 00bfd6b2734d9c28a147bf237490995731781fdd [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MartinBG/MiniGit [INFO] finished tweaking git repo https://github.com/MartinBG/MiniGit [INFO] tweaked toml for git repo https://github.com/MartinBG/MiniGit written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/MartinBG/MiniGit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded same-file v1.0.1 [INFO] [stderr] Downloaded num v0.1.41 [INFO] [stderr] Downloaded walkdir v2.0.1 [INFO] [stderr] Downloaded libc v0.2.35 [INFO] [stderr] Downloaded winapi v0.3.3 [INFO] [stderr] Downloaded winapi-i686-pc-windows-gnu v0.3.2 [INFO] [stderr] Downloaded winapi-x86_64-pc-windows-gnu v0.3.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b17f513266c1a3b979d17f8482540646197cbd88e91689e0ef056ff00ce39be4 [INFO] running `Command { std: "docker" "start" "-a" "b17f513266c1a3b979d17f8482540646197cbd88e91689e0ef056ff00ce39be4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b17f513266c1a3b979d17f8482540646197cbd88e91689e0ef056ff00ce39be4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b17f513266c1a3b979d17f8482540646197cbd88e91689e0ef056ff00ce39be4", kill_on_drop: false }` [INFO] [stdout] b17f513266c1a3b979d17f8482540646197cbd88e91689e0ef056ff00ce39be4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+00bfd6b2734d9c28a147bf237490995731781fdd" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eca4be121270a4c8b460a5fbc32c4e87f15cb83f1c355daa63ccdd9660c69b43 [INFO] running `Command { std: "docker" "start" "-a" "eca4be121270a4c8b460a5fbc32c4e87f15cb83f1c355daa63ccdd9660c69b43", kill_on_drop: false }` [INFO] [stderr] Checking num-traits v0.1.41 [INFO] [stderr] Checking libc v0.2.35 [INFO] [stderr] Compiling gcc v0.3.54 [INFO] [stderr] Checking rustc-serialize v0.3.24 [INFO] [stderr] Checking itoa v0.3.4 [INFO] [stderr] Checking same-file v1.0.1 [INFO] [stderr] Checking serde v1.0.27 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking dtoa v0.4.2 [INFO] [stderr] Checking walkdir v2.0.1 [INFO] [stderr] Checking num-integer v0.1.35 [INFO] [stderr] Checking time v0.1.39 [INFO] [stderr] Checking rand v0.3.20 [INFO] [stderr] Checking num-iter v0.1.34 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking num v0.1.41 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Compiling serde_derive_internals v0.19.0 [INFO] [stderr] Compiling serde_derive v1.0.27 [INFO] [stderr] Checking serde_json v1.0.9 [INFO] [stderr] Checking MiniGit v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/init.rs:22:62 [INFO] [stdout] | [INFO] [stdout] 22 | create_dir(&path_buf).expect("could not create directory");; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/init.rs:22:62 [INFO] [stdout] | [INFO] [stdout] 22 | create_dir(&path_buf).expect("could not create directory");; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/commit_node.rs:54:39 [INFO] [stdout] | [INFO] [stdout] 54 | Err(err) => panic!(String::from(err.description())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/commit_node.rs:54:39 [INFO] [stdout] | [INFO] [stdout] 54 | Err(err) => panic!(String::from(err.description())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/command_parsing.rs:113:3 [INFO] [stdout] | [INFO] [stdout] 113 | _ => panic!("Wrong command passed in run_command") [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/command_parsing.rs:113:3 [INFO] [stdout] | [INFO] [stdout] 113 | _ => panic!("Wrong command passed in run_command") [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: crate `MiniGit` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = help: convert the identifier to snake case: `mini_git` [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/log.rs:22:23 [INFO] [stdout] | [INFO] [stdout] 22 | Err(err) => panic!(err) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 22 | Err(err) => panic!("{}", err) [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 22 | Err(err) => std::panic::panic_any(err) [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/dir_structs.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 93 | Err(err) => panic!(err) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 93 | Err(err) => panic!("{}", err) [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 93 | Err(err) => std::panic::panic_any(err) [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: crate `MiniGit` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = help: convert the identifier to snake case: `mini_git` [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/log.rs:22:23 [INFO] [stdout] | [INFO] [stdout] 22 | Err(err) => panic!(err) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 22 | Err(err) => panic!("{}", err) [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 22 | Err(err) => std::panic::panic_any(err) [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/dir_structs.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 93 | Err(err) => panic!(err) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 93 | Err(err) => panic!("{}", err) [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 93 | Err(err) => std::panic::panic_any(err) [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/dir_structs.rs:149:38 [INFO] [stdout] | [INFO] [stdout] 149 | diff.added_items.push(other_it_el.deref().clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `dir_structs::DirItem` does not implement `Deref`, so calling `deref` on `&dir_structs::DirItem` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/dir_structs.rs:164:39 [INFO] [stdout] | [INFO] [stdout] 164 | diff.added_items.push(other_it_el.deref().clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `dir_structs::DirItem` does not implement `Deref`, so calling `deref` on `&dir_structs::DirItem` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/dir_structs.rs:165:35 [INFO] [stdout] | [INFO] [stdout] 165 | diff.removed_items.push(it_el.deref().clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `dir_structs::DirItem` does not implement `Deref`, so calling `deref` on `&dir_structs::DirItem` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/dir_structs.rs:149:38 [INFO] [stdout] | [INFO] [stdout] 149 | diff.added_items.push(other_it_el.deref().clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `dir_structs::DirItem` does not implement `Deref`, so calling `deref` on `&dir_structs::DirItem` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/commit_node.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 54 | Err(err) => panic!(String::from(err.description())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 54 | Err(err) => panic!("{}", String::from(err.description())) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/dir_structs.rs:164:39 [INFO] [stdout] | [INFO] [stdout] 164 | diff.added_items.push(other_it_el.deref().clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `dir_structs::DirItem` does not implement `Deref`, so calling `deref` on `&dir_structs::DirItem` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/dir_structs.rs:165:35 [INFO] [stdout] | [INFO] [stdout] 165 | diff.removed_items.push(it_el.deref().clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `dir_structs::DirItem` does not implement `Deref`, so calling `deref` on `&dir_structs::DirItem` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/commits_status.rs:28:23 [INFO] [stdout] | [INFO] [stdout] 28 | Err(err) => panic!(err) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 28 | Err(err) => panic!("{}", err) [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 28 | Err(err) => std::panic::panic_any(err) [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/commit_node.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 54 | Err(err) => panic!(String::from(err.description())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 54 | Err(err) => panic!("{}", String::from(err.description())) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/commits_status.rs:28:23 [INFO] [stdout] | [INFO] [stdout] 28 | Err(err) => panic!(err) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 28 | Err(err) => panic!("{}", err) [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 28 | Err(err) => std::panic::panic_any(err) [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: crate `MiniGit` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = help: convert the identifier to snake case: `mini_git` [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: crate `MiniGit` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = help: convert the identifier to snake case: `mini_git` [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.51s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: rustc-serialize v0.3.24 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "eca4be121270a4c8b460a5fbc32c4e87f15cb83f1c355daa63ccdd9660c69b43", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eca4be121270a4c8b460a5fbc32c4e87f15cb83f1c355daa63ccdd9660c69b43", kill_on_drop: false }` [INFO] [stdout] eca4be121270a4c8b460a5fbc32c4e87f15cb83f1c355daa63ccdd9660c69b43