[INFO] cloning repository https://github.com/dbalsom/marty [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dbalsom/marty" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdbalsom%2Fmarty", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdbalsom%2Fmarty'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f18b73e7a97824b31513dbb1668bc939996a8bde [INFO] testing dbalsom/marty against try#5a3d3b91048a0adf280e7a4e589c1dda6443f172 for pr-115235 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdbalsom%2Fmarty" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dbalsom/marty on toolchain 5a3d3b91048a0adf280e7a4e589c1dda6443f172 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5a3d3b91048a0adf280e7a4e589c1dda6443f172" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dbalsom/marty [INFO] finished tweaking git repo https://github.com/dbalsom/marty [INFO] tweaked toml for git repo https://github.com/dbalsom/marty written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dbalsom/marty already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5a3d3b91048a0adf280e7a4e589c1dda6443f172" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: profiles for the non root package will be ignored, specify profiles at the workspace root: [INFO] [stderr] package: /workspace/builds/worker-3-tc2/source/frontends/martypc_pixels_desktop/Cargo.toml [INFO] [stderr] workspace: /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] [stderr] warning: /workspace/builds/worker-3-tc2/source/frontends/martypc_pixels_wasm32/Cargo.toml: unused manifest key: target.wasm32-unknown-unknown.runner [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4f8da3c744d2da974e54ce020a79f4ad54313e914ebeaab8fc086f07e8d8b066" "/opt/rustwide/cargo-home/bin/cargo" "+5a3d3b91048a0adf280e7a4e589c1dda6443f172" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 09ee7d6869ac5bedb0c847aed9b5f8e8d4d08e21c83860e3b47ee7f22286905c [INFO] running `Command { std: "docker" "start" "-a" "09ee7d6869ac5bedb0c847aed9b5f8e8d4d08e21c83860e3b47ee7f22286905c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "09ee7d6869ac5bedb0c847aed9b5f8e8d4d08e21c83860e3b47ee7f22286905c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09ee7d6869ac5bedb0c847aed9b5f8e8d4d08e21c83860e3b47ee7f22286905c", kill_on_drop: false }` [INFO] [stdout] 09ee7d6869ac5bedb0c847aed9b5f8e8d4d08e21c83860e3b47ee7f22286905c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4f8da3c744d2da974e54ce020a79f4ad54313e914ebeaab8fc086f07e8d8b066" "/opt/rustwide/cargo-home/bin/cargo" "+5a3d3b91048a0adf280e7a4e589c1dda6443f172" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0d45c35584207963a8245642abd11b216112c5e32bb7869dd862077d433c585d [INFO] running `Command { std: "docker" "start" "-a" "0d45c35584207963a8245642abd11b216112c5e32bb7869dd862077d433c585d", kill_on_drop: false }` [INFO] [stderr] warning: profiles for the non root package will be ignored, specify profiles at the workspace root: [INFO] [stderr] package: /opt/rustwide/workdir/frontends/martypc_pixels_desktop/Cargo.toml [INFO] [stderr] workspace: /opt/rustwide/workdir/Cargo.toml [INFO] [stderr] warning: /opt/rustwide/workdir/frontends/martypc_pixels_wasm32/Cargo.toml: unused manifest key: target.wasm32-unknown-unknown.runner [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling unicode-ident v1.0.10 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling smallvec v1.11.0 [INFO] [stderr] Compiling log v0.4.19 [INFO] [stderr] Compiling once_cell v1.18.0 [INFO] [stderr] Compiling libloading v0.8.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling thiserror v1.0.41 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling dlib v0.5.2 [INFO] [stderr] Compiling static_assertions v1.1.0 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling scopeguard v1.1.0 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling downcast-rs v1.2.0 [INFO] [stderr] Compiling scoped-tls v1.0.1 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Compiling syn v2.0.23 [INFO] [stderr] Compiling wayland-sys v0.30.1 [INFO] [stderr] Compiling slotmap v1.0.6 [INFO] [stderr] Compiling ahash v0.7.6 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Compiling xml-rs v0.8.15 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling quick-xml v0.28.2 [INFO] [stderr] Compiling getrandom v0.2.10 [INFO] [stderr] Compiling nix v0.26.2 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Compiling nix v0.24.3 [INFO] [stderr] Compiling wayland-backend v0.1.2 [INFO] [stderr] Compiling parking_lot v0.12.1 [INFO] [stderr] Compiling nix v0.25.1 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Compiling ahash v0.8.3 [INFO] [stderr] Compiling bitflags v2.3.3 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling arrayvec v0.7.4 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling hashbrown v0.12.3 [INFO] [stderr] Compiling wayland-scanner v0.30.1 [INFO] [stderr] Compiling xcursor v0.3.4 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling ttf-parser v0.19.1 [INFO] [stderr] Compiling termcolor v1.2.0 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling libloading v0.7.4 [INFO] [stderr] Compiling ash v0.37.3+1.3.251 [INFO] [stderr] Compiling khronos-egl v4.1.0 [INFO] [stderr] Compiling ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Compiling raw-window-handle v0.5.2 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling darling_core v0.20.1 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Compiling codespan-reporting v0.11.1 [INFO] [stderr] Compiling memmap2 v0.5.10 [INFO] [stderr] Compiling owned_ttf_parser v0.19.0 [INFO] [stderr] Compiling wayland-commons v0.29.5 [INFO] [stderr] Compiling ab_glyph v0.2.21 [INFO] [stderr] Compiling spirv v0.2.0+1.5.4 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Compiling thiserror-impl v1.0.41 [INFO] [stderr] Compiling bytemuck_derive v1.4.1 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Compiling gpu-descriptor-types v0.1.1 [INFO] [stderr] Compiling gpu-alloc-types v0.2.0 [INFO] [stderr] Compiling instant v0.1.12 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling hexf-parse v0.2.1 [INFO] [stderr] Compiling serde v1.0.166 [INFO] [stderr] Compiling tinyvec_macros v0.1.1 [INFO] [stderr] Compiling simd-adler32 v0.3.5 [INFO] [stderr] Compiling tinyvec v1.6.0 [INFO] [stderr] Compiling gpu-alloc v0.5.4 [INFO] [stderr] Compiling gpu-descriptor v0.2.3 [INFO] [stderr] Compiling serde_derive v1.0.166 [INFO] [stderr] Compiling bytemuck v1.13.1 [INFO] [stderr] Compiling calloop v0.10.6 [INFO] [stderr] Compiling naga v0.12.2 [INFO] [stderr] Compiling darling_macro v0.20.1 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Compiling wgpu-types v0.16.0 [INFO] [stderr] Compiling wayland-client v0.30.2 [INFO] [stderr] Compiling aho-corasick v1.0.2 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling percent-encoding v2.3.0 [INFO] [stderr] Compiling glow v0.12.2 [INFO] [stderr] Compiling adler v1.0.2 [INFO] [stderr] Compiling regex-syntax v0.7.3 [INFO] [stderr] Compiling wayland-protocols v0.30.0 [INFO] [stderr] Compiling renderdoc-sys v1.0.0 [INFO] [stderr] Compiling profiling v1.0.8 [INFO] [stderr] Compiling strict-num v0.1.1 [INFO] [stderr] Compiling smithay-client-toolkit v0.17.0 [INFO] [stderr] Compiling arrayref v0.3.7 [INFO] [stderr] Compiling tiny-skia-path v0.8.4 [INFO] [stderr] Compiling regex-automata v0.3.0 [INFO] [stderr] Compiling wayland-cursor v0.30.0 [INFO] [stderr] Compiling miniz_oxide v0.7.1 [INFO] [stderr] Compiling darling v0.20.1 [INFO] [stderr] Compiling unicode-normalization v0.1.22 [INFO] [stderr] Compiling ecolor v0.22.0 (https://github.com/dbalsom/egui_martypc.git?branch=winit_0_29#783d3fe8) [INFO] [stderr] Compiling emath v0.22.0 (https://github.com/dbalsom/egui_martypc.git?branch=winit_0_29#783d3fe8) [INFO] [stderr] Compiling wayland-protocols-wlr v0.1.0 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling nix v0.23.2 [INFO] [stderr] Compiling smithay-client-toolkit v0.16.0 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling cpal v0.13.5 [INFO] [stderr] Compiling anyhow v1.0.71 [INFO] [stderr] Compiling nohash-hasher v0.2.0 [INFO] [stderr] Compiling unicode-bidi v0.3.13 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling arraydeque v0.4.5 [INFO] [stderr] Compiling wgpu-hal v0.16.1 [INFO] [stderr] Compiling idna v0.4.0 [INFO] [stderr] Compiling winit v0.29.0-beta.0 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling epaint v0.22.0 (https://github.com/dbalsom/egui_martypc.git?branch=winit_0_29#783d3fe8) [INFO] [stderr] Compiling flate2 v1.0.26 [INFO] [stderr] Compiling parking_lot v0.11.2 [INFO] [stderr] Compiling modular-bitfield-impl v0.11.2 [INFO] [stderr] Compiling libudev v0.3.0 [INFO] [stderr] Compiling regex v1.9.0 [INFO] [stderr] Compiling wgpu-core v0.16.1 [INFO] [stderr] Compiling alsa v0.6.0 [INFO] [stderr] Compiling serde_with_macros v2.3.3 [INFO] [stderr] Compiling tiny-skia v0.8.4 [INFO] [stderr] Compiling form_urlencoded v1.2.0 [INFO] [stderr] Compiling wayland-cursor v0.29.5 [INFO] [stderr] Compiling safe_arch v0.7.0 [INFO] [stderr] Compiling fdeflate v0.3.0 [INFO] [stderr] Compiling bpaf_derive v0.3.5 [INFO] [stderr] Compiling x11rb-protocol v0.10.0 [INFO] [stderr] Compiling gethostname v0.2.3 [INFO] [stderr] Compiling cgmath v0.18.0 [INFO] [stderr] Compiling xkeysym v0.2.0 [INFO] [stderr] Compiling cache-padded v1.3.0 [INFO] [stderr] Compiling bpaf v0.7.10 [INFO] [stderr] Compiling ringbuf v0.2.8 [INFO] [stderr] Compiling wgpu v0.16.1 [INFO] [stderr] Compiling xkbcommon-dl v0.4.0 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Compiling serde_with v2.3.3 [INFO] [stderr] Compiling sctk-adwaita v0.6.0 [INFO] [stderr] Compiling wide v0.7.10 [INFO] [stderr] Compiling png v0.17.9 [INFO] [stderr] Compiling url v2.4.0 [INFO] [stderr] Compiling modular-bitfield v0.11.2 [INFO] [stderr] Compiling serialport v4.2.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling x11rb v0.10.1 [INFO] [stderr] Compiling hashbrown v0.13.2 [INFO] [stderr] Compiling uuid v1.4.0 [INFO] [stderr] Compiling approx v0.4.0 [INFO] [stderr] Compiling byteorder v1.4.3 [INFO] [stderr] Compiling md5 v0.7.0 [INFO] [stderr] Compiling color_quant v1.1.0 [INFO] [stderr] Compiling cursor-icon v1.0.0 [INFO] [stderr] Compiling home v0.5.5 [INFO] [stderr] Compiling smol_str v0.2.0 [INFO] [stderr] Compiling webbrowser v0.8.10 [INFO] [stderr] Compiling image v0.24.6 [INFO] [stderr] Compiling fallible_collections v0.4.9 [INFO] [stderr] Compiling arboard v3.2.0 [INFO] [stderr] Compiling marty_core v0.1.3 (/opt/rustwide/workdir/core) [INFO] [stderr] Compiling smithay-clipboard v0.6.6 [INFO] [stdout] warning: unused import: `RawRomDescriptor` [INFO] [stdout] --> core/src/machine.rs:61:31 [INFO] [stdout] | [INFO] [stdout] 61 | rom_manager::{RomManager, RawRomDescriptor}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling ultraviolet v0.9.1 [INFO] [stdout] warning: unused import: `io::Write` [INFO] [stdout] --> core/src/cpu_808x/mod.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | io::Write, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `delta` [INFO] [stdout] --> core/src/devices/pit.rs:209:38 [INFO] [stdout] | [INFO] [stdout] 209 | fn read_u8(&mut self, port: u16, delta: DeviceRunTimeUnit) -> u8 { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_delta` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `warp_us` [INFO] [stdout] --> core/src/devices/pit.rs:929:83 [INFO] [stdout] | [INFO] [stdout] 929 | (DeviceRunTimeUnit::Microseconds(us), DeviceRunTimeUnit::Microseconds(warp_us)) => { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_warp_us` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling winres v0.1.12 [INFO] [stdout] warning: unused variable: `syswait` [INFO] [stdout] --> core/src/bus.rs:810:37 [INFO] [stdout] | [INFO] [stdout] 810 | ... let syswait = cga.mmio_write_u8(address, data, system_ticks); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_syswait` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> core/src/config.rs:414:9 [INFO] [stdout] | [INFO] [stdout] 414 | let mut toml_args: ConfigFileParams; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> core/src/cpu_808x/mod.rs:2413:16 [INFO] [stdout] | [INFO] [stdout] 2413 | if let HistoryEntry::Entry {cs, ip, cycles: _, i} = i { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> core/src/cpu_808x/mod.rs:2427:16 [INFO] [stdout] | [INFO] [stdout] 2427 | if let HistoryEntry::Entry {cs, ip, cycles, i} = i { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling egui v0.22.0 (https://github.com/dbalsom/egui_martypc.git?branch=winit_0_29#783d3fe8) [INFO] [stderr] Compiling fast_image_resize v2.7.3 [INFO] [stderr] Compiling rgb v0.8.36 [INFO] [stdout] warning: fields `crystal` and `sys_ticks_advance` are never read [INFO] [stdout] --> core/src/devices/pit.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 174 | pub struct ProgrammableIntervalTimer { [INFO] [stdout] | ------------------------- fields in this struct [INFO] [stdout] 175 | ptype: PitType, [INFO] [stdout] 176 | crystal: f64, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 180 | sys_ticks_advance: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling type-map v0.5.0 [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> core/src/rom_manager.rs:1756:41 [INFO] [stdout] | [INFO] [stdout] 1756 | rom_str_vec.push(rom_str.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> core/src/rom_manager.rs:1789:41 [INFO] [stdout] | [INFO] [stdout] 1789 | rom_str_vec.push(rom_str.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling humantime v2.1.0 [INFO] [stderr] Compiling glam v0.24.1 [INFO] [stderr] Compiling pollster v0.3.0 [INFO] [stderr] Compiling env_logger v0.9.3 [INFO] [stderr] Compiling pixels v0.13.0 [INFO] [stderr] Compiling egui-wgpu v0.22.0 (https://github.com/dbalsom/egui_martypc.git?branch=winit_0_29#783d3fe8) [INFO] [stderr] Compiling resize v0.7.4 [INFO] [stderr] Compiling martypc v0.1.3 (/opt/rustwide/workdir) [INFO] [stderr] Compiling emath v0.20.0 [INFO] [stderr] Compiling egui-winit v0.22.0 (https://github.com/dbalsom/egui_martypc.git?branch=winit_0_29#783d3fe8) [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling marty_render v0.1.3 (/opt/rustwide/workdir/frontend_libs/render) [INFO] [stdout] warning: unused import: `bytemuck::*` [INFO] [stdout] --> frontend_libs/render/src/lib.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | use bytemuck::*; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DynamicImageView` [INFO] [stdout] --> frontend_libs/render/src/resize.rs:36:42 [INFO] [stdout] | [INFO] [stdout] 36 | use fr::{Resizer, ResizeAlg, FilterType, DynamicImageView, Image, PixelType}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Vec3` [INFO] [stdout] --> frontend_libs/render/src/composite.rs:44:25 [INFO] [stdout] | [INFO] [stdout] 44 | use glam::{Mat3, Mat3A, Vec3, Vec3A}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> frontend_libs/render/src/resize.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | let mut resizer = Resizer::new(ResizeAlg::SuperSampling(FilterType::Bilinear, 4)); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dst_o` [INFO] [stdout] --> frontend_libs/render/src/composite.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let mut dst_o = 0; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_dst_o` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `attenuate` is assigned to, but never used [INFO] [stdout] --> frontend_libs/render/src/composite.rs:149:25 [INFO] [stdout] | [INFO] [stdout] 149 | let mut attenuate = false; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_attenuate` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `attenuate` is never read [INFO] [stdout] --> frontend_libs/render/src/composite.rs:166:25 [INFO] [stdout] | [INFO] [stdout] 166 | attenuate = true; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `attenuate` is never read [INFO] [stdout] --> frontend_libs/render/src/composite.rs:173:25 [INFO] [stdout] | [INFO] [stdout] 173 | attenuate = true; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> frontend_libs/render/src/composite.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | let mut dst_o = 0; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> frontend_libs/render/src/composite_new.rs:284:13 [INFO] [stdout] | [INFO] [stdout] 284 | let mut b = &self.composite_table[(border as usize) * 68..]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling martypc_pixels_desktop v0.1.3 (/opt/rustwide/workdir/frontends/martypc_pixels_desktop) [INFO] [stdout] warning: unused import: `ModifiersKeyState` [INFO] [stdout] --> frontends/martypc_pixels_desktop/src/input.rs:34:32 [INFO] [stdout] | [INFO] [stdout] 34 | use winit::keyboard::{KeyCode, ModifiersKeyState}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `CompositeParams` [INFO] [stdout] --> frontends/martypc_pixels_desktop/src/lib.rs:101:46 [INFO] [stdout] | [INFO] [stdout] 101 | use marty_render::{VideoData, VideoRenderer, CompositeParams, ResampleContext}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> frontends/martypc_pixels_desktop/src/input.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | KeyCode::ShiftRight => Some(0x36), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `l_button_id` and `r_button_id` are never read [INFO] [stdout] --> frontends/martypc_pixels_desktop/src/lib.rs:197:5 [INFO] [stdout] | [INFO] [stdout] 195 | struct MouseData { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 196 | reverse_buttons: bool, [INFO] [stdout] 197 | l_button_id: u32, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 198 | r_button_id: u32, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `video_data`, `exec_control`, and `composite` are never read [INFO] [stdout] --> frontends/martypc_pixels_desktop/src/egui/mod.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 224 | pub(crate) struct GuiState { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 238 | video_data: VideoData, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 262 | exec_control: Rc>, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 291 | composite: bool [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 39s [INFO] running `Command { std: "docker" "inspect" "0d45c35584207963a8245642abd11b216112c5e32bb7869dd862077d433c585d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d45c35584207963a8245642abd11b216112c5e32bb7869dd862077d433c585d", kill_on_drop: false }` [INFO] [stdout] 0d45c35584207963a8245642abd11b216112c5e32bb7869dd862077d433c585d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4f8da3c744d2da974e54ce020a79f4ad54313e914ebeaab8fc086f07e8d8b066" "/opt/rustwide/cargo-home/bin/cargo" "+5a3d3b91048a0adf280e7a4e589c1dda6443f172" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 14e988c0c929de3893444cfa5e2fc49e1c55cea17e7503ca39fea50848a8b3ab [INFO] running `Command { std: "docker" "start" "-a" "14e988c0c929de3893444cfa5e2fc49e1c55cea17e7503ca39fea50848a8b3ab", kill_on_drop: false }` [INFO] [stderr] warning: profiles for the non root package will be ignored, specify profiles at the workspace root: [INFO] [stderr] package: /opt/rustwide/workdir/frontends/martypc_pixels_desktop/Cargo.toml [INFO] [stderr] workspace: /opt/rustwide/workdir/Cargo.toml [INFO] [stderr] warning: /opt/rustwide/workdir/frontends/martypc_pixels_wasm32/Cargo.toml: unused manifest key: target.wasm32-unknown-unknown.runner [INFO] [stdout] warning: unused import: `RawRomDescriptor` [INFO] [stdout] --> core/src/machine.rs:61:31 [INFO] [stdout] | [INFO] [stdout] 61 | rom_manager::{RomManager, RawRomDescriptor}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `io::Write` [INFO] [stdout] --> core/src/cpu_808x/mod.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | io::Write, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `delta` [INFO] [stdout] --> core/src/devices/pit.rs:209:38 [INFO] [stdout] | [INFO] [stdout] 209 | fn read_u8(&mut self, port: u16, delta: DeviceRunTimeUnit) -> u8 { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_delta` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `warp_us` [INFO] [stdout] --> core/src/devices/pit.rs:929:83 [INFO] [stdout] | [INFO] [stdout] 929 | (DeviceRunTimeUnit::Microseconds(us), DeviceRunTimeUnit::Microseconds(warp_us)) => { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_warp_us` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `syswait` [INFO] [stdout] --> core/src/bus.rs:810:37 [INFO] [stdout] | [INFO] [stdout] 810 | ... let syswait = cga.mmio_write_u8(address, data, system_ticks); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_syswait` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> core/src/config.rs:414:9 [INFO] [stdout] | [INFO] [stdout] 414 | let mut toml_args: ConfigFileParams; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> core/src/cpu_808x/mod.rs:2413:16 [INFO] [stdout] | [INFO] [stdout] 2413 | if let HistoryEntry::Entry {cs, ip, cycles: _, i} = i { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> core/src/cpu_808x/mod.rs:2427:16 [INFO] [stdout] | [INFO] [stdout] 2427 | if let HistoryEntry::Entry {cs, ip, cycles, i} = i { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `crystal` and `sys_ticks_advance` are never read [INFO] [stdout] --> core/src/devices/pit.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 174 | pub struct ProgrammableIntervalTimer { [INFO] [stdout] | ------------------------- fields in this struct [INFO] [stdout] 175 | ptype: PitType, [INFO] [stdout] 176 | crystal: f64, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 180 | sys_ticks_advance: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> core/src/rom_manager.rs:1756:41 [INFO] [stdout] | [INFO] [stdout] 1756 | rom_str_vec.push(rom_str.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> core/src/rom_manager.rs:1789:41 [INFO] [stdout] | [INFO] [stdout] 1789 | rom_str_vec.push(rom_str.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bytemuck::*` [INFO] [stdout] --> frontend_libs/render/src/lib.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | use bytemuck::*; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DynamicImageView` [INFO] [stdout] --> frontend_libs/render/src/resize.rs:36:42 [INFO] [stdout] | [INFO] [stdout] 36 | use fr::{Resizer, ResizeAlg, FilterType, DynamicImageView, Image, PixelType}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Vec3` [INFO] [stdout] --> frontend_libs/render/src/composite.rs:44:25 [INFO] [stdout] | [INFO] [stdout] 44 | use glam::{Mat3, Mat3A, Vec3, Vec3A}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> frontend_libs/render/src/resize.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | let mut resizer = Resizer::new(ResizeAlg::SuperSampling(FilterType::Bilinear, 4)); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dst_o` [INFO] [stdout] --> frontend_libs/render/src/composite.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let mut dst_o = 0; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_dst_o` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `attenuate` is assigned to, but never used [INFO] [stdout] --> frontend_libs/render/src/composite.rs:149:25 [INFO] [stdout] | [INFO] [stdout] 149 | let mut attenuate = false; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_attenuate` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `attenuate` is never read [INFO] [stdout] --> frontend_libs/render/src/composite.rs:166:25 [INFO] [stdout] | [INFO] [stdout] 166 | attenuate = true; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `attenuate` is never read [INFO] [stdout] --> frontend_libs/render/src/composite.rs:173:25 [INFO] [stdout] | [INFO] [stdout] 173 | attenuate = true; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> frontend_libs/render/src/composite.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | let mut dst_o = 0; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> frontend_libs/render/src/composite_new.rs:284:13 [INFO] [stdout] | [INFO] [stdout] 284 | let mut b = &self.composite_table[(border as usize) * 68..]; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ModifiersKeyState` [INFO] [stdout] --> frontends/martypc_pixels_desktop/src/input.rs:34:32 [INFO] [stdout] | [INFO] [stdout] 34 | use winit::keyboard::{KeyCode, ModifiersKeyState}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling martypc v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `CompositeParams` [INFO] [stdout] --> frontends/martypc_pixels_desktop/src/lib.rs:101:46 [INFO] [stdout] | [INFO] [stdout] 101 | use marty_render::{VideoData, VideoRenderer, CompositeParams, ResampleContext}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> frontends/martypc_pixels_desktop/src/input.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | KeyCode::ShiftRight => Some(0x36), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `l_button_id` and `r_button_id` are never read [INFO] [stdout] --> frontends/martypc_pixels_desktop/src/lib.rs:197:5 [INFO] [stdout] | [INFO] [stdout] 195 | struct MouseData { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 196 | reverse_buttons: bool, [INFO] [stdout] 197 | l_button_id: u32, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 198 | r_button_id: u32, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `video_data`, `exec_control`, and `composite` are never read [INFO] [stdout] --> frontends/martypc_pixels_desktop/src/egui/mod.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 224 | pub(crate) struct GuiState { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 238 | video_data: VideoData, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 262 | exec_control: Rc>, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 291 | composite: bool [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 4.19s [INFO] running `Command { std: "docker" "inspect" "14e988c0c929de3893444cfa5e2fc49e1c55cea17e7503ca39fea50848a8b3ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14e988c0c929de3893444cfa5e2fc49e1c55cea17e7503ca39fea50848a8b3ab", kill_on_drop: false }` [INFO] [stdout] 14e988c0c929de3893444cfa5e2fc49e1c55cea17e7503ca39fea50848a8b3ab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4f8da3c744d2da974e54ce020a79f4ad54313e914ebeaab8fc086f07e8d8b066" "/opt/rustwide/cargo-home/bin/cargo" "+5a3d3b91048a0adf280e7a4e589c1dda6443f172" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] 326b09dc1ebd9b33abbe866e432e6b566be30b36a0a17367053afd0f686383b0 [INFO] running `Command { std: "docker" "start" "-a" "326b09dc1ebd9b33abbe866e432e6b566be30b36a0a17367053afd0f686383b0", kill_on_drop: false }` [INFO] [stderr] warning: profiles for the non root package will be ignored, specify profiles at the workspace root: [INFO] [stderr] package: /opt/rustwide/workdir/frontends/martypc_pixels_desktop/Cargo.toml [INFO] [stderr] workspace: /opt/rustwide/workdir/Cargo.toml [INFO] [stderr] warning: /opt/rustwide/workdir/frontends/martypc_pixels_wasm32/Cargo.toml: unused manifest key: target.wasm32-unknown-unknown.runner [INFO] [stderr] warning: unused import: `RawRomDescriptor` [INFO] [stderr] --> core/src/machine.rs:61:31 [INFO] [stderr] | [INFO] [stderr] 61 | rom_manager::{RomManager, RawRomDescriptor}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `io::Write` [INFO] [stderr] --> core/src/cpu_808x/mod.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | io::Write, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `delta` [INFO] [stderr] --> core/src/devices/pit.rs:209:38 [INFO] [stderr] | [INFO] [stderr] 209 | fn read_u8(&mut self, port: u16, delta: DeviceRunTimeUnit) -> u8 { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_delta` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `warp_us` [INFO] [stderr] --> core/src/devices/pit.rs:929:83 [INFO] [stderr] | [INFO] [stderr] 929 | (DeviceRunTimeUnit::Microseconds(us), DeviceRunTimeUnit::Microseconds(warp_us)) => { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_warp_us` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `syswait` [INFO] [stderr] --> core/src/bus.rs:810:37 [INFO] [stderr] | [INFO] [stderr] 810 | ... let syswait = cga.mmio_write_u8(address, data, system_ticks); [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_syswait` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> core/src/config.rs:414:9 [INFO] [stderr] | [INFO] [stderr] 414 | let mut toml_args: ConfigFileParams; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: irrefutable `if let` pattern [INFO] [stderr] --> core/src/cpu_808x/mod.rs:2413:16 [INFO] [stderr] | [INFO] [stderr] 2413 | if let HistoryEntry::Entry {cs, ip, cycles: _, i} = i { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this pattern will always match, so the `if let` is useless [INFO] [stderr] = help: consider replacing the `if let` with a `let` [INFO] [stderr] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: irrefutable `if let` pattern [INFO] [stderr] --> core/src/cpu_808x/mod.rs:2427:16 [INFO] [stderr] | [INFO] [stderr] 2427 | if let HistoryEntry::Entry {cs, ip, cycles, i} = i { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this pattern will always match, so the `if let` is useless [INFO] [stderr] = help: consider replacing the `if let` with a `let` [INFO] [stderr] [INFO] [stderr] warning: fields `crystal` and `sys_ticks_advance` are never read [INFO] [stderr] --> core/src/devices/pit.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 174 | pub struct ProgrammableIntervalTimer { [INFO] [stderr] | ------------------------- fields in this struct [INFO] [stderr] 175 | ptype: PitType, [INFO] [stderr] 176 | crystal: f64, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 180 | sys_ticks_advance: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stderr] --> core/src/rom_manager.rs:1756:41 [INFO] [stderr] | [INFO] [stderr] 1756 | rom_str_vec.push(rom_str.clone()); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stderr] [INFO] [stderr] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stderr] --> core/src/rom_manager.rs:1789:41 [INFO] [stderr] | [INFO] [stderr] 1789 | rom_str_vec.push(rom_str.clone()); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `marty_core` (lib) generated 11 warnings (run `cargo fix --lib -p marty_core` to apply 5 suggestions) [INFO] [stderr] warning: unused import: `bytemuck::*` [INFO] [stderr] --> frontend_libs/render/src/lib.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | use bytemuck::*; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `DynamicImageView` [INFO] [stderr] --> frontend_libs/render/src/resize.rs:36:42 [INFO] [stderr] | [INFO] [stderr] 36 | use fr::{Resizer, ResizeAlg, FilterType, DynamicImageView, Image, PixelType}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Vec3` [INFO] [stderr] --> frontend_libs/render/src/composite.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | use glam::{Mat3, Mat3A, Vec3, Vec3A}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> frontend_libs/render/src/resize.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let mut resizer = Resizer::new(ResizeAlg::SuperSampling(FilterType::Bilinear, 4)); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dst_o` [INFO] [stderr] --> frontend_libs/render/src/composite.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | let mut dst_o = 0; [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_dst_o` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable `attenuate` is assigned to, but never used [INFO] [stderr] --> frontend_libs/render/src/composite.rs:149:25 [INFO] [stderr] | [INFO] [stderr] 149 | let mut attenuate = false; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_attenuate` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `attenuate` is never read [INFO] [stderr] --> frontend_libs/render/src/composite.rs:166:25 [INFO] [stderr] | [INFO] [stderr] 166 | attenuate = true; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] = note: `#[warn(unused_assignments)]` on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `attenuate` is never read [INFO] [stderr] --> frontend_libs/render/src/composite.rs:173:25 [INFO] [stderr] | [INFO] [stderr] 173 | attenuate = true; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> frontend_libs/render/src/composite.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | let mut dst_o = 0; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> frontend_libs/render/src/composite_new.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | let mut b = &self.composite_table[(border as usize) * 68..]; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: `marty_render` (lib) generated 10 warnings (run `cargo fix --lib -p marty_render` to apply 7 suggestions) [INFO] [stderr] warning: unused import: `ModifiersKeyState` [INFO] [stderr] --> frontends/martypc_pixels_desktop/src/input.rs:34:32 [INFO] [stderr] | [INFO] [stderr] 34 | use winit::keyboard::{KeyCode, ModifiersKeyState}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `CompositeParams` [INFO] [stderr] --> frontends/martypc_pixels_desktop/src/lib.rs:101:46 [INFO] [stderr] | [INFO] [stderr] 101 | use marty_render::{VideoData, VideoRenderer, CompositeParams, ResampleContext}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> frontends/martypc_pixels_desktop/src/input.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | KeyCode::ShiftRight => Some(0x36), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: fields `l_button_id` and `r_button_id` are never read [INFO] [stderr] --> frontends/martypc_pixels_desktop/src/lib.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 195 | struct MouseData { [INFO] [stderr] | --------- fields in this struct [INFO] [stderr] 196 | reverse_buttons: bool, [INFO] [stderr] 197 | l_button_id: u32, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] 198 | r_button_id: u32, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: fields `video_data`, `exec_control`, and `composite` are never read [INFO] [stderr] --> frontends/martypc_pixels_desktop/src/egui/mod.rs:238:5 [INFO] [stderr] | [INFO] [stderr] 224 | pub(crate) struct GuiState { [INFO] [stderr] | -------- fields in this struct [INFO] [stderr] ... [INFO] [stderr] 238 | video_data: VideoData, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 262 | exec_control: Rc>, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 291 | composite: bool [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `martypc_pixels_desktop` (lib) generated 5 warnings (run `cargo fix --lib -p martypc_pixels_desktop` to apply 2 suggestions) [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.16s [INFO] [stderr] Running unittests frontends/martypc_pixels_desktop/src/main.rs (/opt/rustwide/target/debug/deps/martypc-8dfc30cd04185276) [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "326b09dc1ebd9b33abbe866e432e6b566be30b36a0a17367053afd0f686383b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "326b09dc1ebd9b33abbe866e432e6b566be30b36a0a17367053afd0f686383b0", kill_on_drop: false }` [INFO] [stdout] 326b09dc1ebd9b33abbe866e432e6b566be30b36a0a17367053afd0f686383b0