[INFO] fetching crate lightning 0.0.115... [INFO] checking lightning-0.0.115 against try#024378d9203a4009ed73d6db2681b88a8d74ce7a for pr-112160 [INFO] extracting crate lightning 0.0.115 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate lightning 0.0.115 on toolchain 024378d9203a4009ed73d6db2681b88a8d74ce7a [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+024378d9203a4009ed73d6db2681b88a8d74ce7a" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lightning 0.0.115 [INFO] finished tweaking crates.io crate lightning 0.0.115 [INFO] tweaked toml for crates.io crate lightning 0.0.115 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+024378d9203a4009ed73d6db2681b88a8d74ce7a" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+024378d9203a4009ed73d6db2681b88a8d74ce7a" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:19e73879b68f455e41552ea35293514db52ea292d993f571636dbffedb77a1ee" "/opt/rustwide/cargo-home/bin/cargo" "+024378d9203a4009ed73d6db2681b88a8d74ce7a" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 15b3a5a9e875fba5778465769a8e2367147f0b57d15b2d9600fdf182435736b7 [INFO] running `Command { std: "docker" "start" "-a" "15b3a5a9e875fba5778465769a8e2367147f0b57d15b2d9600fdf182435736b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "15b3a5a9e875fba5778465769a8e2367147f0b57d15b2d9600fdf182435736b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "15b3a5a9e875fba5778465769a8e2367147f0b57d15b2d9600fdf182435736b7", kill_on_drop: false }` [INFO] [stdout] 15b3a5a9e875fba5778465769a8e2367147f0b57d15b2d9600fdf182435736b7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:19e73879b68f455e41552ea35293514db52ea292d993f571636dbffedb77a1ee" "/opt/rustwide/cargo-home/bin/cargo" "+024378d9203a4009ed73d6db2681b88a8d74ce7a" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 341154505fd6adbb93494aa7643020a9045879659c9aa3f956e0d41891ff6552 [INFO] running `Command { std: "docker" "start" "-a" "341154505fd6adbb93494aa7643020a9045879659c9aa3f956e0d41891ff6552", kill_on_drop: false }` [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Compiling bitcoinconsensus v0.20.2-0.5.0 [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking secp256k1 v0.24.3 [INFO] [stderr] Checking bitcoin v0.29.2 [INFO] [stderr] Checking lightning v0.0.115 (/opt/rustwide/workdir) [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> src/ln/channelmanager.rs:1065:8 [INFO] [stdout] | [INFO] [stdout] 1065 | #[deny(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> src/ln/channelmanager.rs:1071:8 [INFO] [stdout] | [INFO] [stdout] 1071 | #[deny(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> src/ln/peer_handler.rs:2119:9 [INFO] [stdout] | [INFO] [stdout] 2119 | #[deny(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> src/ln/channelmanager.rs:1065:8 [INFO] [stdout] | [INFO] [stdout] 1065 | #[deny(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> src/ln/channelmanager.rs:1071:8 [INFO] [stdout] | [INFO] [stdout] 1071 | #[deny(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `const_err` has been removed: converted into hard error, see issue #71800 for more information [INFO] [stdout] --> src/ln/peer_handler.rs:2119:9 [INFO] [stdout] | [INFO] [stdout] 2119 | #[deny(const_err)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/routing/router.rs:415:9 [INFO] [stdout] | [INFO] [stdout] 415 | for (mut path, blinded_tail_opt) in paths.iter_mut().zip(blinded_tails.into_iter()) { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/routing/router.rs:994:8 [INFO] [stdout] | [INFO] [stdout] 994 | let mut cur_hop = &mut self.hops.get_mut(i).unwrap().0; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/routing/router.rs:415:9 [INFO] [stdout] | [INFO] [stdout] 415 | for (mut path, blinded_tail_opt) in paths.iter_mut().zip(blinded_tails.into_iter()) { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/routing/router.rs:994:8 [INFO] [stdout] | [INFO] [stdout] 994 | let mut cur_hop = &mut self.hops.get_mut(i).unwrap().0; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/ln/channelmanager.rs:8418:45 [INFO] [stdout] | [INFO] [stdout] 8418 | let network_graph = nodes[0].network_graph.clone(); [INFO] [stdout] | ^^^^^^^^ unnecessary method call [INFO] [stdout] | [INFO] [stdout] = note: the type `gossip::NetworkGraph<&TestLogger>` does not implement `Clone`, so calling `clone` on `&gossip::NetworkGraph<&TestLogger>` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[deny(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/ln/channelmanager.rs:8462:45 [INFO] [stdout] | [INFO] [stdout] 8462 | let network_graph = nodes[0].network_graph.clone(); [INFO] [stdout] | ^^^^^^^^ unnecessary method call [INFO] [stdout] | [INFO] [stdout] = note: the type `gossip::NetworkGraph<&TestLogger>` does not implement `Clone`, so calling `clone` on `&gossip::NetworkGraph<&TestLogger>` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/ln/functional_tests.rs:9514:44 [INFO] [stdout] | [INFO] [stdout] 9514 | let network_graph = nodes[0].network_graph.clone(); [INFO] [stdout] | ^^^^^^^^ unnecessary method call [INFO] [stdout] | [INFO] [stdout] = note: the type `gossip::NetworkGraph<&TestLogger>` does not implement `Clone`, so calling `clone` on `&gossip::NetworkGraph<&TestLogger>` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/ln/functional_tests.rs:9552:44 [INFO] [stdout] | [INFO] [stdout] 9552 | let network_graph = nodes[0].network_graph.clone(); [INFO] [stdout] | ^^^^^^^^ unnecessary method call [INFO] [stdout] | [INFO] [stdout] = note: the type `gossip::NetworkGraph<&TestLogger>` does not implement `Clone`, so calling `clone` on `&gossip::NetworkGraph<&TestLogger>` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&dyn BroadcasterInterface` instead of cloning the inner type [INFO] [stdout] --> src/ln/reload_tests.rs:375:108 [INFO] [stdout] | [INFO] [stdout] 375 | new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), &logger, &fee_est... [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/ln/reload_tests.rs:405:42 [INFO] [stdout] | [INFO] [stdout] 405 | tx_broadcaster: nodes[0].tx_broadcaster.clone(), [INFO] [stdout] | ^^^^^^^^ unnecessary method call [INFO] [stdout] | [INFO] [stdout] = note: the type `TestBroadcaster` does not implement `Clone`, so calling `clone` on `&TestBroadcaster` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/ln/reload_tests.rs:422:42 [INFO] [stdout] | [INFO] [stdout] 422 | tx_broadcaster: nodes[0].tx_broadcaster.clone(), [INFO] [stdout] | ^^^^^^^^ unnecessary method call [INFO] [stdout] | [INFO] [stdout] = note: the type `TestBroadcaster` does not implement `Clone`, so calling `clone` on `&TestBroadcaster` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lightning` (lib test) due to 7 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "341154505fd6adbb93494aa7643020a9045879659c9aa3f956e0d41891ff6552", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "341154505fd6adbb93494aa7643020a9045879659c9aa3f956e0d41891ff6552", kill_on_drop: false }` [INFO] [stdout] 341154505fd6adbb93494aa7643020a9045879659c9aa3f956e0d41891ff6552