[INFO] fetching crate hal 0.9.0... [INFO] checking hal-0.9.0 against try#024378d9203a4009ed73d6db2681b88a8d74ce7a for pr-112160 [INFO] extracting crate hal 0.9.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate hal 0.9.0 on toolchain 024378d9203a4009ed73d6db2681b88a8d74ce7a [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+024378d9203a4009ed73d6db2681b88a8d74ce7a" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hal 0.9.0 [INFO] finished tweaking crates.io crate hal 0.9.0 [INFO] tweaked toml for crates.io crate hal 0.9.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate hal 0.9.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+024378d9203a4009ed73d6db2681b88a8d74ce7a" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:19e73879b68f455e41552ea35293514db52ea292d993f571636dbffedb77a1ee" "/opt/rustwide/cargo-home/bin/cargo" "+024378d9203a4009ed73d6db2681b88a8d74ce7a" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 18183b9cadbffb9cf11e5c68515be6fc94d8c29837af29207a4570a15709a7eb [INFO] running `Command { std: "docker" "start" "-a" "18183b9cadbffb9cf11e5c68515be6fc94d8c29837af29207a4570a15709a7eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "18183b9cadbffb9cf11e5c68515be6fc94d8c29837af29207a4570a15709a7eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18183b9cadbffb9cf11e5c68515be6fc94d8c29837af29207a4570a15709a7eb", kill_on_drop: false }` [INFO] [stdout] 18183b9cadbffb9cf11e5c68515be6fc94d8c29837af29207a4570a15709a7eb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:19e73879b68f455e41552ea35293514db52ea292d993f571636dbffedb77a1ee" "/opt/rustwide/cargo-home/bin/cargo" "+024378d9203a4009ed73d6db2681b88a8d74ce7a" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6c553fdb6008907caf0acc913ff57c16d0bb38741079badbc1ea2b446dd9ff20 [INFO] running `Command { std: "docker" "start" "-a" "6c553fdb6008907caf0acc913ff57c16d0bb38741079badbc1ea2b446dd9ff20", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling syn v1.0.68 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Compiling cc v1.0.41 [INFO] [stderr] Compiling libc v0.2.92 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking bitcoin_hashes v0.9.4 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking unicode-normalization v0.1.9 [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Compiling secp256k1-sys v0.4.0 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking bech32 v0.7.3 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking jobserver v0.1.11 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking base64-compat v1.0.0 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Checking secp256k1 v0.20.3 [INFO] [stderr] Checking lightning-invoice v0.4.0 [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking bip39 v1.0.1 [INFO] [stderr] Checking serde_yaml v0.8.17 [INFO] [stderr] Checking secp256k1 v0.24.3 [INFO] [stderr] Checking fern v0.5.9 [INFO] [stderr] Checking bitcoin v0.29.2 [INFO] [stderr] Checking miniscript v9.0.1 [INFO] [stderr] Checking hal v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] error: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/psbt.rs:104:32 [INFO] [stdout] | [INFO] [stdout] 104 | .map(|w| w.iter().map(|p| p.clone().into()).collect()), [INFO] [stdout] | ^^^^^^^^ unnecessary method call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[deny(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/tx.rs:43:39 [INFO] [stdout] | [INFO] [stdout] 43 | Some(self.witness.iter().map(|h| h.clone().into()).collect()) [INFO] [stdout] | ^^^^^^^^ unnecessary method call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hal` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/psbt.rs:104:32 [INFO] [stdout] | [INFO] [stdout] 104 | .map(|w| w.iter().map(|p| p.clone().into()).collect()), [INFO] [stdout] | ^^^^^^^^ unnecessary method call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[deny(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/tx.rs:43:39 [INFO] [stdout] | [INFO] [stdout] 43 | Some(self.witness.iter().map(|h| h.clone().into()).collect()) [INFO] [stdout] | ^^^^^^^^ unnecessary method call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hal` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "6c553fdb6008907caf0acc913ff57c16d0bb38741079badbc1ea2b446dd9ff20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c553fdb6008907caf0acc913ff57c16d0bb38741079badbc1ea2b446dd9ff20", kill_on_drop: false }` [INFO] [stdout] 6c553fdb6008907caf0acc913ff57c16d0bb38741079badbc1ea2b446dd9ff20