[INFO] fetching crate a2kit 2.0.8... [INFO] checking a2kit-2.0.8 against try#024378d9203a4009ed73d6db2681b88a8d74ce7a for pr-112160 [INFO] extracting crate a2kit 2.0.8 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate a2kit 2.0.8 on toolchain 024378d9203a4009ed73d6db2681b88a8d74ce7a [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+024378d9203a4009ed73d6db2681b88a8d74ce7a" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate a2kit 2.0.8 [INFO] finished tweaking crates.io crate a2kit 2.0.8 [INFO] tweaked toml for crates.io crate a2kit 2.0.8 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate a2kit 2.0.8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+024378d9203a4009ed73d6db2681b88a8d74ce7a" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:19e73879b68f455e41552ea35293514db52ea292d993f571636dbffedb77a1ee" "/opt/rustwide/cargo-home/bin/cargo" "+024378d9203a4009ed73d6db2681b88a8d74ce7a" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e4fff41f14614415e254aaada7c1ceafa811026d24a3a11c5c0a0350f37f01ea [INFO] running `Command { std: "docker" "start" "-a" "e4fff41f14614415e254aaada7c1ceafa811026d24a3a11c5c0a0350f37f01ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e4fff41f14614415e254aaada7c1ceafa811026d24a3a11c5c0a0350f37f01ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4fff41f14614415e254aaada7c1ceafa811026d24a3a11c5c0a0350f37f01ea", kill_on_drop: false }` [INFO] [stdout] e4fff41f14614415e254aaada7c1ceafa811026d24a3a11c5c0a0350f37f01ea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:19e73879b68f455e41552ea35293514db52ea292d993f571636dbffedb77a1ee" "/opt/rustwide/cargo-home/bin/cargo" "+024378d9203a4009ed73d6db2681b88a8d74ce7a" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 17a3de5487e592505c8979295c2262ccc45f69b8c2db3185e5eefe9155b27b2f [INFO] running `Command { std: "docker" "start" "-a" "17a3de5487e592505c8979295c2262ccc45f69b8c2db3185e5eefe9155b27b2f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling cc v1.0.74 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.47 [INFO] [stderr] Compiling unicode-ident v1.0.5 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Compiling io-lifetimes v1.0.10 [INFO] [stderr] Compiling syn v1.0.103 [INFO] [stderr] Compiling rustix v0.37.3 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking linux-raw-sys v0.3.7 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking anstyle-parse v0.2.0 [INFO] [stderr] Checking predicates-core v1.0.4 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle v1.0.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking termtree v0.4.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking clap_lex v0.4.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking once_cell v1.16.0 [INFO] [stderr] Compiling thiserror v1.0.37 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking predicates-tree v1.0.6 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking iana-time-zone v0.1.53 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Compiling tree-sitter v0.20.9 [INFO] [stderr] Compiling tree-sitter-integerbasic v1.0.2 [INFO] [stderr] Compiling tree-sitter-applesoft v3.1.1 [INFO] [stderr] Compiling tree-sitter-merlin6502 v2.0.0 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking chrono v0.4.22 [INFO] [stderr] Checking predicates v2.1.1 [INFO] [stderr] Checking env_logger v0.9.1 [INFO] [stderr] Checking assert_cmd v2.0.5 [INFO] [stderr] Checking is-terminal v0.4.7 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.2.7 [INFO] [stderr] Compiling a2kit_macro_derive v0.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.37 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking a2kit_macro v0.1.0 [INFO] [stderr] Checking clap v4.2.7 [INFO] [stderr] Checking a2kit v2.0.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/fs/pascal/mod.rs:499:17 [INFO] [stdout] | [INFO] [stdout] 499 | let mut entry = &mut dir.entries[idx]; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/fs/pascal/mod.rs:499:17 [INFO] [stdout] | [INFO] [stdout] 499 | let mut entry = &mut dir.entries[idx]; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `pack_date` is never used [INFO] [stdout] --> src/fs/cpm/mod.rs:42:4 [INFO] [stdout] | [INFO] [stdout] 42 | fn pack_date(time: Option) -> [u8;4] { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `unpack_date` is never used [INFO] [stdout] --> src/fs/cpm/mod.rs:54:4 [INFO] [stdout] | [INFO] [stdout] 54 | fn unpack_date(cpm_date: [u8;4]) -> chrono::NaiveDateTime { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `lx_to_string` is never used [INFO] [stdout] --> src/fs/cpm/mod.rs:108:4 [INFO] [stdout] | [INFO] [stdout] 108 | fn lx_to_string(lx: &Label) -> String { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_password` and `get_timestamp` are never used [INFO] [stdout] --> src/fs/cpm/directory.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 263 | impl Directory { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 303 | pub fn get_password(&self,ptr: &Ptr) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 321 | pub fn get_timestamp(&self,ptr: &Ptr) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Enc44` is never constructed [INFO] [stdout] --> src/img/disk525.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 35 | enum NibbleType { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] 36 | Enc44, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NibbleType` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `epilog_mask` is never read [INFO] [stdout] --> src/img/disk525.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 80 | pub struct SectorDataFormat { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 87 | epilog_mask: [u8;3] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SectorDataFormat` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lang/applesoft/renumber.rs:50:27 [INFO] [stdout] | [INFO] [stdout] 50 | for line in source.clone().lines() { [INFO] [stdout] | ^^^^^^^^ unnecessary method call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[deny(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `a2kit` (lib) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `pack_date` is never used [INFO] [stdout] --> src/fs/cpm/mod.rs:42:4 [INFO] [stdout] | [INFO] [stdout] 42 | fn pack_date(time: Option) -> [u8;4] { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `unpack_date` is never used [INFO] [stdout] --> src/fs/cpm/mod.rs:54:4 [INFO] [stdout] | [INFO] [stdout] 54 | fn unpack_date(cpm_date: [u8;4]) -> chrono::NaiveDateTime { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `lx_to_string` is never used [INFO] [stdout] --> src/fs/cpm/mod.rs:108:4 [INFO] [stdout] | [INFO] [stdout] 108 | fn lx_to_string(lx: &Label) -> String { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_password` and `get_timestamp` are never used [INFO] [stdout] --> src/fs/cpm/directory.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 263 | impl Directory { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 303 | pub fn get_password(&self,ptr: &Ptr) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 321 | pub fn get_timestamp(&self,ptr: &Ptr) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Enc44` is never constructed [INFO] [stdout] --> src/img/disk525.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 35 | enum NibbleType { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] 36 | Enc44, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NibbleType` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `epilog_mask` is never read [INFO] [stdout] --> src/img/disk525.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 80 | pub struct SectorDataFormat { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 87 | epilog_mask: [u8;3] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SectorDataFormat` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lang/applesoft/renumber.rs:50:27 [INFO] [stdout] | [INFO] [stdout] 50 | for line in source.clone().lines() { [INFO] [stdout] | ^^^^^^^^ unnecessary method call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[deny(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `a2kit` (lib test) due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "17a3de5487e592505c8979295c2262ccc45f69b8c2db3185e5eefe9155b27b2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "17a3de5487e592505c8979295c2262ccc45f69b8c2db3185e5eefe9155b27b2f", kill_on_drop: false }` [INFO] [stdout] 17a3de5487e592505c8979295c2262ccc45f69b8c2db3185e5eefe9155b27b2f