[INFO] fetching crate rs_pbrt 0.9.8... [INFO] checking rs_pbrt-0.9.8 against master#e4106065bf1bb515935d5d024e8d9c86454e2b22 for pr-112160 [INFO] extracting crate rs_pbrt 0.9.8 into /workspace/builds/worker-4-tc1/source [INFO] validating manifest of crates.io crate rs_pbrt 0.9.8 on toolchain e4106065bf1bb515935d5d024e8d9c86454e2b22 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+e4106065bf1bb515935d5d024e8d9c86454e2b22" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rs_pbrt 0.9.8 [INFO] finished tweaking crates.io crate rs_pbrt 0.9.8 [INFO] tweaked toml for crates.io crate rs_pbrt 0.9.8 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate crates.io crate rs_pbrt 0.9.8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+e4106065bf1bb515935d5d024e8d9c86454e2b22" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded peg-macros v0.6.3 [INFO] [stderr] Downloaded camino v1.0.9 [INFO] [stderr] Downloaded peg-runtime v0.6.3 [INFO] [stderr] Downloaded pest_meta v2.3.0 [INFO] [stderr] Downloaded pest_generator v2.3.0 [INFO] [stderr] Downloaded peg v0.6.3 [INFO] [stderr] Downloaded pest_derive v2.3.0 [INFO] [stderr] Downloaded ply-rs v0.1.3 [INFO] [stderr] Downloaded crossbeam-queue v0.3.5 [INFO] [stderr] Downloaded atom v0.4.0 [INFO] [stderr] Downloaded blend_info v0.2.9 [INFO] [stderr] Downloaded impl_ops v0.1.1 [INFO] [stderr] Downloaded hexf v0.2.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:19e73879b68f455e41552ea35293514db52ea292d993f571636dbffedb77a1ee" "/opt/rustwide/cargo-home/bin/cargo" "+e4106065bf1bb515935d5d024e8d9c86454e2b22" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3b1089fe868307e61f36d6720b7622809e4e32b7efc6794592a4118a680c4040 [INFO] running `Command { std: "docker" "start" "-a" "3b1089fe868307e61f36d6720b7622809e4e32b7efc6794592a4118a680c4040", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3b1089fe868307e61f36d6720b7622809e4e32b7efc6794592a4118a680c4040", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b1089fe868307e61f36d6720b7622809e4e32b7efc6794592a4118a680c4040", kill_on_drop: false }` [INFO] [stdout] 3b1089fe868307e61f36d6720b7622809e4e32b7efc6794592a4118a680c4040 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:19e73879b68f455e41552ea35293514db52ea292d993f571636dbffedb77a1ee" "/opt/rustwide/cargo-home/bin/cargo" "+e4106065bf1bb515935d5d024e8d9c86454e2b22" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4c5116d0436e95dc7b947b00495ade0f6775855e4be111d93359759ffef6271b [INFO] running `Command { std: "docker" "start" "-a" "4c5116d0436e95dc7b947b00495ade0f6775855e4be111d93359759ffef6271b", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling crossbeam-utils v0.8.10 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Compiling serde_derive v1.0.139 [INFO] [stderr] Compiling serde v1.0.139 [INFO] [stderr] Compiling crossbeam-epoch v0.9.9 [INFO] [stderr] Compiling serde_json v1.0.82 [INFO] [stderr] Compiling semver v1.0.12 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Compiling camino v1.0.9 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Compiling ryu v1.0.10 [INFO] [stderr] Compiling itoa v1.0.2 [INFO] [stderr] Compiling pulldown-cmark v0.9.1 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling fastrand v1.7.0 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling remove_dir_all v0.5.3 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling walkdir v2.3.2 [INFO] [stderr] Compiling tempfile v3.3.0 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking either v1.7.0 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Compiling ucd-trie v0.1.4 [INFO] [stderr] Compiling bytecount v0.6.3 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking spin v0.9.4 [INFO] [stderr] Checking deflate v1.0.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling rustversion v1.0.7 [INFO] [stderr] Compiling crossbeam-queue v0.3.5 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling peg-runtime v0.6.3 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Compiling peg-macros v0.6.3 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Compiling atomic v0.5.1 [INFO] [stderr] Checking bit_field v0.10.1 [INFO] [stderr] Checking lebe v0.5.1 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Checking png v0.17.5 [INFO] [stderr] Checking jpeg-decoder v0.2.6 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking num-complex v0.4.2 [INFO] [stderr] Compiling hexf-parse v0.2.1 [INFO] [stderr] Checking tiff v0.7.2 [INFO] [stderr] Checking bytemuck v1.10.0 [INFO] [stderr] Checking pbr v1.0.4 [INFO] [stderr] Checking num v0.4.0 [INFO] [stderr] Checking crossbeam v0.8.2 [INFO] [stderr] Checking atom v0.4.0 [INFO] [stderr] Checking impl_ops v0.1.1 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking typed-arena v2.0.1 [INFO] [stderr] Checking peg v0.6.3 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling thiserror-impl v1.0.32 [INFO] [stderr] Compiling pin-project-internal v1.0.11 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Compiling hexf v0.2.1 [INFO] [stderr] Checking pin-project v1.0.11 [INFO] [stderr] Checking flume v0.10.13 [INFO] [stderr] Compiling thiserror v1.0.32 [INFO] [stderr] Compiling pest v2.3.0 [INFO] [stderr] Checking exr v1.4.2 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking blend_info v0.2.9 [INFO] [stderr] Compiling pest_meta v2.3.0 [INFO] [stderr] Compiling pest_generator v2.3.0 [INFO] [stderr] Compiling pest_derive v2.3.0 [INFO] [stderr] Checking image v0.24.3 [INFO] [stderr] Compiling cargo-platform v0.1.2 [INFO] [stderr] Compiling cargo_metadata v0.14.2 [INFO] [stderr] Compiling skeptic v0.13.7 [INFO] [stderr] Compiling ply-rs v0.1.3 [INFO] [stderr] Checking rs_pbrt v0.9.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/film.rs:360:17 [INFO] [stdout] | [INFO] [stdout] 360 | let mut merge_pixel = &mut pixels_write[offset as usize]; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/film.rs:376:17 [INFO] [stdout] | [INFO] [stdout] 376 | let mut merge_pixel = &mut pixels_write[i]; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/film.rs:360:17 [INFO] [stdout] | [INFO] [stdout] 360 | let mut merge_pixel = &mut pixels_write[offset as usize]; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/film.rs:376:17 [INFO] [stdout] | [INFO] [stdout] 376 | let mut merge_pixel = &mut pixels_write[i]; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `count` is never read [INFO] [stdout] --> src/core/reflection.rs:327:17 [INFO] [stdout] | [INFO] [stdout] 327 | count -= 1_i8; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `count` is never read [INFO] [stdout] --> src/core/reflection.rs:327:17 [INFO] [stdout] | [INFO] [stdout] 327 | count -= 1_i8; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/integrators/sppm.rs:306:45 [INFO] [stdout] | [INFO] [stdout] 306 | ... let mut pixel = &mut pixels[pixel_offset as usize]; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/integrators/sppm.rs:306:45 [INFO] [stdout] | [INFO] [stdout] 306 | ... let mut pixel = &mut pixels[pixel_offset as usize]; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.borrow()` on a double reference, which returns `&SurfaceInteraction<'_>` instead of borrowing the inner type [INFO] [stdout] --> src/core/bssrdf.rs:295:43 [INFO] [stdout] | [INFO] [stdout] 295 | *pdf = self.pdf_sp(chain[selected].borrow()) / n_found as Float; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.borrow()` on a double reference, which returns `&SurfaceInteraction<'_>` instead of borrowing the inner type [INFO] [stdout] --> src/core/bssrdf.rs:296:32 [INFO] [stdout] | [INFO] [stdout] 296 | self.sp(chain[selected].borrow()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&InteractionCommon` instead of cloning the inner type [INFO] [stdout] --> src/integrators/bdpt.rs:2282:45 [INFO] [stdout] | [INFO] [stdout] 2282 | vis.p1.as_ref().unwrap().clone(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&InteractionCommon` instead of cloning the inner type [INFO] [stdout] --> src/integrators/bdpt.rs:2358:45 [INFO] [stdout] | [INFO] [stdout] 2358 | vis.p1.as_ref().unwrap().clone(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.borrow()` on a double reference, which returns `&SurfaceInteraction<'_>` instead of borrowing the inner type [INFO] [stdout] --> src/integrators/path.rs:126:64 [INFO] [stdout] | [INFO] [stdout] 126 | ... let it: &SurfaceInteraction = isect.borrow(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.borrow()` on a double reference, which returns `&SurfaceInteraction<'_>` instead of borrowing the inner type [INFO] [stdout] --> src/integrators/sppm.rs:207:66 [INFO] [stdout] | [INFO] [stdout] 207 | ... isect.borrow(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.borrow()` on a double reference, which returns `&SurfaceInteraction<'_>` instead of borrowing the inner type [INFO] [stdout] --> src/integrators/volpath.rs:160:60 [INFO] [stdout] | [INFO] [stdout] 160 | let it: &SurfaceInteraction = isect.borrow(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.borrow()` on a double reference, which returns `&SurfaceInteraction<'_>` instead of borrowing the inner type [INFO] [stdout] --> src/core/bssrdf.rs:295:43 [INFO] [stdout] | [INFO] [stdout] 295 | *pdf = self.pdf_sp(chain[selected].borrow()) / n_found as Float; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.borrow()` on a double reference, which returns `&SurfaceInteraction<'_>` instead of borrowing the inner type [INFO] [stdout] --> src/core/bssrdf.rs:296:32 [INFO] [stdout] | [INFO] [stdout] 296 | self.sp(chain[selected].borrow()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&InteractionCommon` instead of cloning the inner type [INFO] [stdout] --> src/integrators/bdpt.rs:2282:45 [INFO] [stdout] | [INFO] [stdout] 2282 | vis.p1.as_ref().unwrap().clone(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&InteractionCommon` instead of cloning the inner type [INFO] [stdout] --> src/integrators/bdpt.rs:2358:45 [INFO] [stdout] | [INFO] [stdout] 2358 | vis.p1.as_ref().unwrap().clone(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.borrow()` on a double reference, which returns `&SurfaceInteraction<'_>` instead of borrowing the inner type [INFO] [stdout] --> src/integrators/path.rs:126:64 [INFO] [stdout] | [INFO] [stdout] 126 | ... let it: &SurfaceInteraction = isect.borrow(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.borrow()` on a double reference, which returns `&SurfaceInteraction<'_>` instead of borrowing the inner type [INFO] [stdout] --> src/integrators/sppm.rs:207:66 [INFO] [stdout] | [INFO] [stdout] 207 | ... isect.borrow(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.borrow()` on a double reference, which returns `&SurfaceInteraction<'_>` instead of borrowing the inner type [INFO] [stdout] --> src/integrators/volpath.rs:160:60 [INFO] [stdout] | [INFO] [stdout] 160 | let it: &SurfaceInteraction = isect.borrow(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.49s [INFO] running `Command { std: "docker" "inspect" "4c5116d0436e95dc7b947b00495ade0f6775855e4be111d93359759ffef6271b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c5116d0436e95dc7b947b00495ade0f6775855e4be111d93359759ffef6271b", kill_on_drop: false }` [INFO] [stdout] 4c5116d0436e95dc7b947b00495ade0f6775855e4be111d93359759ffef6271b