[INFO] fetching crate rckit 0.1.0... [INFO] checking rckit-0.1.0 against master#e29821ff85a2a3000d226f99f62f89464028d5d6 for pr-111505 [INFO] extracting crate rckit 0.1.0 into /workspace/builds/worker-2-tc1/source [INFO] validating manifest of crates.io crate rckit 0.1.0 on toolchain e29821ff85a2a3000d226f99f62f89464028d5d6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+e29821ff85a2a3000d226f99f62f89464028d5d6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rckit 0.1.0 [INFO] finished tweaking crates.io crate rckit 0.1.0 [INFO] tweaked toml for crates.io crate rckit 0.1.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" __CARGO_TEST_CHANNEL_OVERRIDE_DO_NOT_USE_THIS="nightly" "/workspace/cargo-home/bin/cargo" "+e29821ff85a2a3000d226f99f62f89464028d5d6" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+e29821ff85a2a3000d226f99f62f89464028d5d6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded redis v0.9.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:19e73879b68f455e41552ea35293514db52ea292d993f571636dbffedb77a1ee" "/opt/rustwide/cargo-home/bin/cargo" "+e29821ff85a2a3000d226f99f62f89464028d5d6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 780b408f021261b2d323450b4c08c556bc05f1b3ea528cb70cb36a1f77922b3b [INFO] running `Command { std: "docker" "start" "-a" "780b408f021261b2d323450b4c08c556bc05f1b3ea528cb70cb36a1f77922b3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "780b408f021261b2d323450b4c08c556bc05f1b3ea528cb70cb36a1f77922b3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "780b408f021261b2d323450b4c08c556bc05f1b3ea528cb70cb36a1f77922b3b", kill_on_drop: false }` [INFO] [stdout] 780b408f021261b2d323450b4c08c556bc05f1b3ea528cb70cb36a1f77922b3b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:19e73879b68f455e41552ea35293514db52ea292d993f571636dbffedb77a1ee" "/opt/rustwide/cargo-home/bin/cargo" "+e29821ff85a2a3000d226f99f62f89464028d5d6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 442af9516dfa3e2ca35060971a4987eab981bb2b4df1849b47f1725c7888c25c [INFO] running `Command { std: "docker" "start" "-a" "442af9516dfa3e2ca35060971a4987eab981bb2b4df1849b47f1725c7888c25c", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Compiling libc v0.2.144 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling log v0.4.18 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Compiling redis v0.9.1 [INFO] [stderr] Checking ascii v0.9.3 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking net2 v0.2.38 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking sha1_smol v1.0.0 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking sha1 v0.6.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking combine v3.8.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking rckit v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variant `master` should have an upper camel case name [INFO] [stdout] --> src/cluster.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | master, [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Master` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `slave` should have an upper camel case name [INFO] [stdout] --> src/cluster.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | slave, [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Slave` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/cluster.rs:97:29 [INFO] [stdout] | [INFO] [stdout] 97 | let mut nodes = try!(conn.nodes()); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `redis::Commands` [INFO] [stdout] --> src/conn.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use redis::Commands; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Role` [INFO] [stdout] --> src/create.rs:1:37 [INFO] [stdout] | [INFO] [stdout] 1 | use cluster::{Cluster, Error, Node, Role}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `master` should have an upper camel case name [INFO] [stdout] --> src/cluster.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | master, [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Master` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `slave` should have an upper camel case name [INFO] [stdout] --> src/cluster.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | slave, [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Slave` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/cluster.rs:97:29 [INFO] [stdout] | [INFO] [stdout] 97 | let mut nodes = try!(conn.nodes()); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `redis::Commands` [INFO] [stdout] --> src/conn.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use redis::Commands; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Role` [INFO] [stdout] --> src/create.rs:1:37 [INFO] [stdout] | [INFO] [stdout] 1 | use cluster::{Cluster, Error, Node, Role}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | for mut node in self.nodes.iter_mut() { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `node` [INFO] [stdout] --> src/cluster.rs:116:17 [INFO] [stdout] | [INFO] [stdout] 116 | for node in nodes { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_node` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `migrate` [INFO] [stdout] --> src/cluster.rs:118:21 [INFO] [stdout] | [INFO] [stdout] 118 | let migrate = &slots[start..start + count]; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_migrate` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/conn.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | for mut info in infos.into_iter() { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | for mut node in self.nodes.iter_mut() { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `node` [INFO] [stdout] --> src/cluster.rs:116:17 [INFO] [stdout] | [INFO] [stdout] 116 | for node in nodes { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_node` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `migrate` [INFO] [stdout] --> src/cluster.rs:118:21 [INFO] [stdout] | [INFO] [stdout] 118 | let migrate = &slots[start..start + count]; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_migrate` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/conn.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | for mut info in info.lines() { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/conn.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 92 | let mut scope: Vec<&str> = content.split("-").collect(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/create.rs:148:25 [INFO] [stdout] | [INFO] [stdout] 148 | let mut key = String::from(slave.ip.clone() + ":" + &slave.port); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/conn.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | for mut info in infos.into_iter() { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/conn.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | for mut info in info.lines() { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/conn.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 92 | let mut scope: Vec<&str> = content.split("-").collect(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | let mut master_count = clap::value_t!(sub_m.value_of("master"), usize).unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `origin` is never read [INFO] [stdout] --> src/add.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Add { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 6 | origin: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Add` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `None` is never constructed [INFO] [stdout] --> src/cluster.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 184 | pub enum Error { [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] 185 | None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `port` is never read [INFO] [stdout] --> src/conn.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Conn { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 6 | ip: String, [INFO] [stdout] 7 | port: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Conn` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/create.rs:148:25 [INFO] [stdout] | [INFO] [stdout] 148 | let mut key = String::from(slave.ip.clone() + ":" + &slave.port); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | let mut master_count = clap::value_t!(sub_m.value_of("master"), usize).unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `origin` is never read [INFO] [stdout] --> src/add.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Add { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 6 | origin: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Add` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `None` is never constructed [INFO] [stdout] --> src/cluster.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 184 | pub enum Error { [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] 185 | None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `port` is never read [INFO] [stdout] --> src/conn.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Conn { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 6 | ip: String, [INFO] [stdout] 7 | port: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Conn` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.03s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: redis v0.9.1 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "442af9516dfa3e2ca35060971a4987eab981bb2b4df1849b47f1725c7888c25c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "442af9516dfa3e2ca35060971a4987eab981bb2b4df1849b47f1725c7888c25c", kill_on_drop: false }` [INFO] [stdout] 442af9516dfa3e2ca35060971a4987eab981bb2b4df1849b47f1725c7888c25c