[INFO] fetching crate rsbx 2.0.0... [INFO] checking rsbx-2.0.0 against master#11ebe6512b4c77633c59f8dcdd421df3b79d1a9f for pr-103872 [INFO] extracting crate rsbx 2.0.0 into /workspace/builds/worker-4/source [INFO] validating manifest of crates.io crate rsbx 2.0.0 on toolchain 11ebe6512b4c77633c59f8dcdd421df3b79d1a9f [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+11ebe6512b4c77633c59f8dcdd421df3b79d1a9f" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rsbx 2.0.0 [INFO] finished tweaking crates.io crate rsbx 2.0.0 [INFO] tweaked toml for crates.io crate rsbx 2.0.0 written to /workspace/builds/worker-4/source/Cargo.toml [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+11ebe6512b4c77633c59f8dcdd421df3b79d1a9f" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+11ebe6512b4c77633c59f8dcdd421df3b79d1a9f" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded quickcheck v0.7.2 [INFO] [stderr] Downloaded rand_core v0.2.2 [INFO] [stderr] Downloaded blake2_c v0.3.3 [INFO] [stderr] Downloaded reed-solomon-erasure v3.1.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:83125433e4fff17b1ac56874832f668d9df75ee638575aca552b68e127bedee9" "/opt/rustwide/cargo-home/bin/cargo" "+11ebe6512b4c77633c59f8dcdd421df3b79d1a9f" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e0791254574262e1eba322c1ce39553cef1e7f1772d014d753bfb16a7f9ab2f0 [INFO] running `Command { std: "docker" "start" "-a" "e0791254574262e1eba322c1ce39553cef1e7f1772d014d753bfb16a7f9ab2f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e0791254574262e1eba322c1ce39553cef1e7f1772d014d753bfb16a7f9ab2f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e0791254574262e1eba322c1ce39553cef1e7f1772d014d753bfb16a7f9ab2f0", kill_on_drop: false }` [INFO] [stdout] e0791254574262e1eba322c1ce39553cef1e7f1772d014d753bfb16a7f9ab2f0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:83125433e4fff17b1ac56874832f668d9df75ee638575aca552b68e127bedee9" "/opt/rustwide/cargo-home/bin/cargo" "+11ebe6512b4c77633c59f8dcdd421df3b79d1a9f" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2d6d75d8b0ec1397bf9e2291320013418dc3da47b8691d76b4d7b6a54e57bda6 [INFO] running `Command { std: "docker" "start" "-a" "2d6d75d8b0ec1397bf9e2291320013418dc3da47b8691d76b4d7b6a54e57bda6", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.12 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling cc v1.0.74 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking block-padding v0.1.5 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.11 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Checking crossbeam-deque v0.8.2 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Compiling nom v4.2.3 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling reed-solomon-erasure v3.1.1 [INFO] [stderr] Compiling blake2_c v0.3.3 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking nix v0.25.0 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Compiling rsbx v2.0.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking cty v0.1.5 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking iana-time-zone v0.1.53 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking chrono v0.4.22 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking sha2 v0.8.2 [INFO] [stderr] Checking sha-1 v0.8.2 [INFO] [stderr] Checking ctrlc v3.2.3 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/file_utils.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | ((size + (block_size - 1)) / block_size) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 74 - ((size + (block_size - 1)) / block_size) [INFO] [stdout] 74 + (size + (block_size - 1)) / block_size [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/file_utils.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | ((size + (data_size - 1)) / data_size) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 85 - ((size + (data_size - 1)) / data_size) [INFO] [stdout] 85 + (size + (data_size - 1)) / data_size [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:3:31 [INFO] [stdout] | [INFO] [stdout] 3 | fn round_down_to_multiple(Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:3:43 [INFO] [stdout] | [INFO] [stdout] 3 | fn round_down_to_multiple(Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:4:31 [INFO] [stdout] | [INFO] [stdout] 4 | fn round_up_to_multiple (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:4:43 [INFO] [stdout] | [INFO] [stdout] 4 | fn round_up_to_multiple (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:5:31 [INFO] [stdout] | [INFO] [stdout] 5 | fn ensure_at_least (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:5:43 [INFO] [stdout] | [INFO] [stdout] 5 | fn ensure_at_least (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:6:31 [INFO] [stdout] | [INFO] [stdout] 6 | fn ensure_at_most (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:6:43 [INFO] [stdout] | [INFO] [stdout] 6 | fn ensure_at_most (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Error` is imported redundantly [INFO] [stdout] --> src/sbx_block/header.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 11 | use super::Error; [INFO] [stdout] | ------------ the item `Error` is already imported here [INFO] [stdout] ... [INFO] [stdout] 56 | use super::Error; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/sbx_block/mod.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | (data_shards as u32 <= index_in_set) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 209 - (data_shards as u32 <= index_in_set) [INFO] [stdout] 209 + data_shards as u32 <= index_in_set [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Error` is imported redundantly [INFO] [stdout] --> src/log.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 5 | use general_error::Error; [INFO] [stdout] | -------------------- the item `Error` is already imported here [INFO] [stdout] ... [INFO] [stdout] 58 | use super::{Error, ErrorKind}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/log.rs:65:31 [INFO] [stdout] | [INFO] [stdout] 65 | fn deserialize(&mut self, &[u8]) -> Result<(), ()>; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &[u8]` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/misc_macros.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 345 | $($expr;)*; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] ::: src/repair_core.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | / print_if!(verbose => param, reporter => [INFO] [stdout] 211 | | "{}", repair_stats;); [INFO] [stdout] | |______________________________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] = note: this warning originates in the macro `pause_reporter` which comes from the expansion of the macro `print_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/misc_macros.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 345 | $($expr;)*; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] ::: src/repair_core.rs:329:25 [INFO] [stdout] | [INFO] [stdout] 329 | / print_if!(verbose => param, reporter => [INFO] [stdout] 330 | | "Replaced invalid metadata block at {} (0x{:X}) with reference block", p, p;); [INFO] [stdout] | |_______________________________________________________________________________________________________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `pause_reporter` which comes from the expansion of the macro `print_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/misc_macros.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 345 | $($expr;)*; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] ::: src/check_core.rs:207:25 [INFO] [stdout] | [INFO] [stdout] 207 | / print_if!(verbose => param, reporter => [INFO] [stdout] 208 | | "Block failed check, version : {}, block size : {}, at byte {} (0x{:X})", [INFO] [stdout] 209 | | ver_usize, [INFO] [stdout] 210 | | block_size, [INFO] [stdout] 211 | | block_pos, [INFO] [stdout] 212 | | block_pos;); [INFO] [stdout] | |_____________________________________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `pause_reporter` which comes from the expansion of the macro `print_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/misc_macros.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 345 | $($expr;)*; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] ::: src/check_core.rs:226:9 [INFO] [stdout] | [INFO] [stdout] 226 | print_if!(verbose not_json => param, reporter, json_printer => "";); [INFO] [stdout] | ------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `pause_reporter` which comes from the expansion of the macro `print_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/sbx_block/mod.rs:743:46 [INFO] [stdout] | [INFO] [stdout] 743 | ... pred : Option<&Fn(&Block) -> bool>) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 743 | pred : Option<&dyn Fn(&Block) -> bool>) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/repair_core.rs:159:45 [INFO] [stdout] | [INFO] [stdout] 159 | ... pred : &Fn(&Block) -> bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 159 | pred : &dyn Fn(&Block) -> bool, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking quickcheck v0.7.2 [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/file_utils.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | ((size + (block_size - 1)) / block_size) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 74 - ((size + (block_size - 1)) / block_size) [INFO] [stdout] 74 + (size + (block_size - 1)) / block_size [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/file_utils.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | ((size + (data_size - 1)) / data_size) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 85 - ((size + (data_size - 1)) / data_size) [INFO] [stdout] 85 + (size + (data_size - 1)) / data_size [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/file_utils_tests.rs:484:13 [INFO] [stdout] | [INFO] [stdout] 484 | ({ [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 496 | }) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 484 ~ { [INFO] [stdout] 485 | let version = Version::V17; [INFO] [stdout] ... [INFO] [stdout] 495 | && container_size <= container_size_upper_bound [INFO] [stdout] 496 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:3:31 [INFO] [stdout] | [INFO] [stdout] 3 | fn round_down_to_multiple(Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:3:43 [INFO] [stdout] | [INFO] [stdout] 3 | fn round_down_to_multiple(Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:4:31 [INFO] [stdout] | [INFO] [stdout] 4 | fn round_up_to_multiple (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:4:43 [INFO] [stdout] | [INFO] [stdout] 4 | fn round_up_to_multiple (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:5:31 [INFO] [stdout] | [INFO] [stdout] 5 | fn ensure_at_least (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:5:43 [INFO] [stdout] | [INFO] [stdout] 5 | fn ensure_at_least (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:6:31 [INFO] [stdout] | [INFO] [stdout] 6 | fn ensure_at_most (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:6:43 [INFO] [stdout] | [INFO] [stdout] 6 | fn ensure_at_most (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Error` is imported redundantly [INFO] [stdout] --> src/sbx_block/header.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 11 | use super::Error; [INFO] [stdout] | ------------ the item `Error` is already imported here [INFO] [stdout] ... [INFO] [stdout] 56 | use super::Error; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/sbx_block/mod.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | (data_shards as u32 <= index_in_set) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 209 - (data_shards as u32 <= index_in_set) [INFO] [stdout] 209 + data_shards as u32 <= index_in_set [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the item `Error` is imported redundantly [INFO] [stdout] --> src/log.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 5 | use general_error::Error; [INFO] [stdout] | -------------------- the item `Error` is already imported here [INFO] [stdout] ... [INFO] [stdout] 58 | use super::{Error, ErrorKind}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/log.rs:65:31 [INFO] [stdout] | [INFO] [stdout] 65 | fn deserialize(&mut self, &[u8]) -> Result<(), ()>; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &[u8]` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/misc_macros.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 345 | $($expr;)*; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] ::: src/repair_core.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | / print_if!(verbose => param, reporter => [INFO] [stdout] 211 | | "{}", repair_stats;); [INFO] [stdout] | |______________________________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] = note: this warning originates in the macro `pause_reporter` which comes from the expansion of the macro `print_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/misc_macros.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 345 | $($expr;)*; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] ::: src/repair_core.rs:329:25 [INFO] [stdout] | [INFO] [stdout] 329 | / print_if!(verbose => param, reporter => [INFO] [stdout] 330 | | "Replaced invalid metadata block at {} (0x{:X}) with reference block", p, p;); [INFO] [stdout] | |_______________________________________________________________________________________________________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `pause_reporter` which comes from the expansion of the macro `print_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/misc_macros.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 345 | $($expr;)*; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] ::: src/check_core.rs:207:25 [INFO] [stdout] | [INFO] [stdout] 207 | / print_if!(verbose => param, reporter => [INFO] [stdout] 208 | | "Block failed check, version : {}, block size : {}, at byte {} (0x{:X})", [INFO] [stdout] 209 | | ver_usize, [INFO] [stdout] 210 | | block_size, [INFO] [stdout] 211 | | block_pos, [INFO] [stdout] 212 | | block_pos;); [INFO] [stdout] | |_____________________________________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `pause_reporter` which comes from the expansion of the macro `print_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/misc_macros.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 345 | $($expr;)*; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] ::: src/check_core.rs:226:9 [INFO] [stdout] | [INFO] [stdout] 226 | print_if!(verbose not_json => param, reporter, json_printer => "";); [INFO] [stdout] | ------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `pause_reporter` which comes from the expansion of the macro `print_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/sbx_block/mod.rs:743:46 [INFO] [stdout] | [INFO] [stdout] 743 | ... pred : Option<&Fn(&Block) -> bool>) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 743 | pred : Option<&dyn Fn(&Block) -> bool>) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/repair_core.rs:159:45 [INFO] [stdout] | [INFO] [stdout] 159 | ... pred : &Fn(&Block) -> bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 159 | pred : &dyn Fn(&Block) -> bool, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 21 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 34.72s [INFO] running `Command { std: "docker" "inspect" "2d6d75d8b0ec1397bf9e2291320013418dc3da47b8691d76b4d7b6a54e57bda6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2d6d75d8b0ec1397bf9e2291320013418dc3da47b8691d76b4d7b6a54e57bda6", kill_on_drop: false }` [INFO] [stdout] 2d6d75d8b0ec1397bf9e2291320013418dc3da47b8691d76b4d7b6a54e57bda6