[INFO] cloning repository https://github.com/RobbingDaHood/my_little_universe [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RobbingDaHood/my_little_universe" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRobbingDaHood%2Fmy_little_universe", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRobbingDaHood%2Fmy_little_universe'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] daca28dc9a83d3ffc4d308650929e07489a8366e [INFO] checking RobbingDaHood/my_little_universe against master#385fa9d845dd326c6bbfd58c22244215e431948a for never-type-fallback-to-never [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRobbingDaHood%2Fmy_little_universe" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/RobbingDaHood/my_little_universe on toolchain 385fa9d845dd326c6bbfd58c22244215e431948a [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+385fa9d845dd326c6bbfd58c22244215e431948a" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/RobbingDaHood/my_little_universe [INFO] finished tweaking git repo https://github.com/RobbingDaHood/my_little_universe [INFO] tweaked toml for git repo https://github.com/RobbingDaHood/my_little_universe written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/RobbingDaHood/my_little_universe already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+385fa9d845dd326c6bbfd58c22244215e431948a" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+385fa9d845dd326c6bbfd58c22244215e431948a" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ca0f21e7cde874f7389d0e6f0866d14acf2c10156b310294ba142e0f436c408e [INFO] running `Command { std: "docker" "start" "-a" "ca0f21e7cde874f7389d0e6f0866d14acf2c10156b310294ba142e0f436c408e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ca0f21e7cde874f7389d0e6f0866d14acf2c10156b310294ba142e0f436c408e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca0f21e7cde874f7389d0e6f0866d14acf2c10156b310294ba142e0f436c408e", kill_on_drop: false }` [INFO] [stdout] ca0f21e7cde874f7389d0e6f0866d14acf2c10156b310294ba142e0f436c408e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+385fa9d845dd326c6bbfd58c22244215e431948a" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eef7ae1548ae51ef72fdd6e0cc1f8331bfb38e248cfe749f76afe72372305d71 [INFO] running `Command { std: "docker" "start" "-a" "eef7ae1548ae51ef72fdd6e0cc1f8331bfb38e248cfe749f76afe72372305d71", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking my_little_universe v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `uninstall` is never used [INFO] [stdout] --> src/construct/construct.rs:147:8 [INFO] [stdout] | [INFO] [stdout] 52 | impl Construct { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 147 | fn uninstall(&mut self, module_name: &String) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `groups` is never used [INFO] [stdout] --> src/sector.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 50 | impl Sector { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 54 | pub fn groups(&self) -> &Vec> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/gameloop.rs:18:28 [INFO] [stdout] | [INFO] [stdout] 18 | for channel in channel_getter.try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 18 | while let Ok(channel) = channel_getter.try_recv() { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 18 | if let Ok(channel) = channel_getter.try_recv() { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/gameloop.rs:23:30 [INFO] [stdout] | [INFO] [stdout] 23 | for event in channel.getter.try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 23 | while let Ok(event) = channel.getter.try_recv() { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 23 | if let Ok(event) = channel.getter.try_recv() { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/gameloop.rs:18:28 [INFO] [stdout] | [INFO] [stdout] 18 | for channel in channel_getter.try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 18 | while let Ok(channel) = channel_getter.try_recv() { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 18 | if let Ok(channel) = channel_getter.try_recv() { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/gameloop.rs:23:30 [INFO] [stdout] | [INFO] [stdout] 23 | for event in channel.getter.try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 23 | while let Ok(event) = channel.getter.try_recv() { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 23 | if let Ok(event) = channel.getter.try_recv() { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/my_little_universe.rs:351:64 [INFO] [stdout] | [INFO] [stdout] 351 | ... universe.constructs.get_mut(construct_name.as_str().clone()).unwrap().push_event(&ConstructEventType::Internal(InternalConstructEve... [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/my_little_universe.rs:355:64 [INFO] [stdout] | [INFO] [stdout] 355 | ... universe.constructs.get_mut(construct_name.as_str().clone()).unwrap().push_event(&ConstructEventType::Internal(InternalConstructEve... [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/my_little_universe.rs:374:64 [INFO] [stdout] | [INFO] [stdout] 374 | ... universe.constructs.get_mut(construct_name.as_str().clone()).unwrap().push_event(&ConstructEventType::Internal(InternalConstructEve... [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.85s [INFO] running `Command { std: "docker" "inspect" "eef7ae1548ae51ef72fdd6e0cc1f8331bfb38e248cfe749f76afe72372305d71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eef7ae1548ae51ef72fdd6e0cc1f8331bfb38e248cfe749f76afe72372305d71", kill_on_drop: false }` [INFO] [stdout] eef7ae1548ae51ef72fdd6e0cc1f8331bfb38e248cfe749f76afe72372305d71 [INFO] checking RobbingDaHood/my_little_universe against try#2d84f2737f3bd9ebfcb07f75aa198d6cf7c715d2 for never-type-fallback-to-never [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRobbingDaHood%2Fmy_little_universe" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/RobbingDaHood/my_little_universe on toolchain 2d84f2737f3bd9ebfcb07f75aa198d6cf7c715d2 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+2d84f2737f3bd9ebfcb07f75aa198d6cf7c715d2" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/RobbingDaHood/my_little_universe [INFO] finished tweaking git repo https://github.com/RobbingDaHood/my_little_universe [INFO] tweaked toml for git repo https://github.com/RobbingDaHood/my_little_universe written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/RobbingDaHood/my_little_universe already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+2d84f2737f3bd9ebfcb07f75aa198d6cf7c715d2" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+2d84f2737f3bd9ebfcb07f75aa198d6cf7c715d2" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e0fa404da49d4918af38e93b3da184f832389d78753d8e00b12ef85a993b541 [INFO] running `Command { std: "docker" "start" "-a" "5e0fa404da49d4918af38e93b3da184f832389d78753d8e00b12ef85a993b541", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e0fa404da49d4918af38e93b3da184f832389d78753d8e00b12ef85a993b541", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e0fa404da49d4918af38e93b3da184f832389d78753d8e00b12ef85a993b541", kill_on_drop: false }` [INFO] [stdout] 5e0fa404da49d4918af38e93b3da184f832389d78753d8e00b12ef85a993b541 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:2788e3201cd34a07e3172128adcd8b3090168a8e3bcc40d7c032b9dda1df7d1c" "/opt/rustwide/cargo-home/bin/cargo" "+2d84f2737f3bd9ebfcb07f75aa198d6cf7c715d2" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0df6808fa79e0e7a3ef34b0b363e0e98447f762ef7b9b7fe09d60ad434b60380 [INFO] running `Command { std: "docker" "start" "-a" "0df6808fa79e0e7a3ef34b0b363e0e98447f762ef7b9b7fe09d60ad434b60380", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking my_little_universe v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `uninstall` is never used [INFO] [stdout] --> src/construct/construct.rs:147:8 [INFO] [stdout] | [INFO] [stdout] 52 | impl Construct { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 147 | fn uninstall(&mut self, module_name: &String) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `groups` is never used [INFO] [stdout] --> src/sector.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 50 | impl Sector { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 54 | pub fn groups(&self) -> &Vec> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/gameloop.rs:18:28 [INFO] [stdout] | [INFO] [stdout] 18 | for channel in channel_getter.try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 18 | while let Ok(channel) = channel_getter.try_recv() { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 18 | if let Ok(channel) = channel_getter.try_recv() { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/gameloop.rs:23:30 [INFO] [stdout] | [INFO] [stdout] 23 | for event in channel.getter.try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 23 | while let Ok(event) = channel.getter.try_recv() { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 23 | if let Ok(event) = channel.getter.try_recv() { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/gameloop.rs:18:28 [INFO] [stdout] | [INFO] [stdout] 18 | for channel in channel_getter.try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 18 | while let Ok(channel) = channel_getter.try_recv() { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 18 | if let Ok(channel) = channel_getter.try_recv() { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/gameloop.rs:23:30 [INFO] [stdout] | [INFO] [stdout] 23 | for event in channel.getter.try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 23 | while let Ok(event) = channel.getter.try_recv() { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 23 | if let Ok(event) = channel.getter.try_recv() { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/my_little_universe.rs:351:64 [INFO] [stdout] | [INFO] [stdout] 351 | ... universe.constructs.get_mut(construct_name.as_str().clone()).unwrap().push_event(&ConstructEventType::Internal(InternalConstructEve... [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/my_little_universe.rs:355:64 [INFO] [stdout] | [INFO] [stdout] 355 | ... universe.constructs.get_mut(construct_name.as_str().clone()).unwrap().push_event(&ConstructEventType::Internal(InternalConstructEve... [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/my_little_universe.rs:374:64 [INFO] [stdout] | [INFO] [stdout] 374 | ... universe.constructs.get_mut(construct_name.as_str().clone()).unwrap().push_event(&ConstructEventType::Internal(InternalConstructEve... [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.12s [INFO] running `Command { std: "docker" "inspect" "0df6808fa79e0e7a3ef34b0b363e0e98447f762ef7b9b7fe09d60ad434b60380", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0df6808fa79e0e7a3ef34b0b363e0e98447f762ef7b9b7fe09d60ad434b60380", kill_on_drop: false }` [INFO] [stdout] 0df6808fa79e0e7a3ef34b0b363e0e98447f762ef7b9b7fe09d60ad434b60380