[INFO] fetching crate kumitateru 0.4.0... [INFO] testing kumitateru-0.4.0 against try#8de4c7234dd9b97c9d76b58671343fdbbc9a433e+target=x86_64-unknown-linux-musl for musl_upgrade_1_2_5_with_libc_patch_0 [INFO] extracting crate kumitateru 0.4.0 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate kumitateru 0.4.0 [INFO] finished tweaking crates.io crate kumitateru 0.4.0 [INFO] tweaked toml for crates.io crate kumitateru 0.4.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate kumitateru 0.4.0 on toolchain 8de4c7234dd9b97c9d76b58671343fdbbc9a433e [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+8de4c7234dd9b97c9d76b58671343fdbbc9a433e" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate kumitateru 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+8de4c7234dd9b97c9d76b58671343fdbbc9a433e" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded yaserde v0.6.0 [INFO] [stderr] Downloaded yaserde_derive v0.5.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+8de4c7234dd9b97c9d76b58671343fdbbc9a433e" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 177070091d8ee9d7cceaf7311117d74cd1603db726035778c76ea4c43017d4ee [INFO] running `Command { std: "docker" "start" "-a" "177070091d8ee9d7cceaf7311117d74cd1603db726035778c76ea4c43017d4ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "177070091d8ee9d7cceaf7311117d74cd1603db726035778c76ea4c43017d4ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "177070091d8ee9d7cceaf7311117d74cd1603db726035778c76ea4c43017d4ee", kill_on_drop: false }` [INFO] [stdout] 177070091d8ee9d7cceaf7311117d74cd1603db726035778c76ea4c43017d4ee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+8de4c7234dd9b97c9d76b58671343fdbbc9a433e" "build" "--frozen" "--message-format=json" "--target" "x86_64-unknown-linux-musl", kill_on_drop: false }` [INFO] [stdout] c78d16e325c7c224fd21cd73e1272269f16932665a1e38b9c8d3bf7f97159b2c [INFO] running `Command { std: "docker" "start" "-a" "c78d16e325c7c224fd21cd73e1272269f16932665a1e38b9c8d3bf7f97159b2c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.107 [INFO] [stderr] Compiling proc-macro2 v1.0.32 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling syn v1.0.81 [INFO] [stderr] Compiling signal-hook v0.3.10 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling smallvec v1.7.0 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Compiling unicode-width v0.1.9 [INFO] [stderr] Compiling lock_api v0.4.5 [INFO] [stderr] Compiling anyhow v1.0.45 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling regex-syntax v0.6.25 [INFO] [stderr] Compiling quick-xml v0.20.0 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Compiling xml-rs v0.8.4 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling home v0.5.3 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling minidom v0.13.0 [INFO] [stderr] Compiling yaserde v0.6.0 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Compiling signal-hook-registry v1.4.0 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Compiling mio v0.7.14 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling getrandom v0.2.3 [INFO] [stderr] Compiling clap v2.33.3 [INFO] [stderr] Compiling colored v2.0.0 [INFO] [stderr] Compiling uuid v0.8.2 [INFO] [stderr] Compiling parking_lot v0.11.2 [INFO] [stderr] Compiling signal-hook-mio v0.2.1 [INFO] [stderr] Compiling crossterm v0.20.0 [INFO] [stderr] Compiling regex v1.5.4 [INFO] [stderr] Compiling yaserde_derive v0.5.1 [INFO] [stderr] Compiling toml v0.5.8 [INFO] [stderr] Compiling kumitateru v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `construct_selection` is never used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:8:4 [INFO] [stdout] | [INFO] [stdout] 8 | fn construct_selection(header: &str, items: Vec<&str>, highlighted: i64, selected: bool) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `display_cli_multiple_selection` is never used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn display_cli_multiple_selection(header: &str, items: Vec<&str>) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `reset_selection` is never used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:105:4 [INFO] [stdout] | [INFO] [stdout] 105 | fn reset_selection(len: i64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `package`, `package_meta`, and `build` are never read [INFO] [stdout] --> src/ser_de/config/barrel_config.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct BarrelConfig { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 6 | pub package: BarrelConfigPackage, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 7 | pub package_meta: BarrelConfigPackageMeta, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 8 | pub build: BarrelConfigBuild, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BarrelConfig` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `icon_resource`, `name_res`, `main_class`, `app_type`, and `min_sdk` are never read [INFO] [stdout] --> src/ser_de/config/barrel_config.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct BarrelConfigPackage { [INFO] [stdout] | ------------------- fields in this struct [INFO] [stdout] 14 | pub icon_resource: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 15 | pub name_res: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 16 | pub main_class: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 17 | pub app_type: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 18 | pub min_sdk: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BarrelConfigPackage` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/ser_de/config/barrel_config.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct BarrelConfigPackageMeta { [INFO] [stdout] | ----------------------- fields in this struct [INFO] [stdout] 24 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 25 | pub id: String, [INFO] [stdout] | ^^ [INFO] [stdout] 26 | pub version: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 27 | pub devices: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 28 | pub permissions: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 29 | pub annotations: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 30 | pub languages: Option>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BarrelConfigPackageMeta` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `signing_key`, `enable_code_analysis_on_build`, `connect_iq_version`, and `compiler_args` are never read [INFO] [stdout] --> src/ser_de/config/barrel_config.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct BarrelConfigBuild { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] 36 | pub signing_key: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 37 | pub enable_code_analysis_on_build: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 38 | pub connect_iq_version: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 39 | pub compiler_args: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BarrelConfigBuild` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:161:21 [INFO] [stdout] | [INFO] [stdout] 161 | io::stdin().read_line(&mut proj_name); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 161 | let _ = io::stdin().read_line(&mut proj_name); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:260:5 [INFO] [stdout] | [INFO] [stdout] 260 | io::stdin().read_line(&mut version); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 260 | let _ = io::stdin().read_line(&mut version); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | fs::create_dir("build"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 16 | let _ = fs::create_dir("build"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | fs::create_dir("build/tmp"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 17 | let _ = fs::create_dir("build/tmp"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | fs::create_dir("build/tmp/source"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 18 | let _ = fs::create_dir("build/tmp/source"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | fs::create_dir("build/tmp/resources"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 19 | let _ = fs::create_dir("build/tmp/resources"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/prepare_build.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 32 | for entry in fs::read_dir(PathBuf::from(resource)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 32 - for entry in fs::read_dir(PathBuf::from(resource)) { [INFO] [stdout] 32 + while let Ok(entry) = fs::read_dir(PathBuf::from(resource)) { [INFO] [stdout] | [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 32 | for entry in fs::read_dir(PathBuf::from(resource))? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 32 - for entry in fs::read_dir(PathBuf::from(resource)) { [INFO] [stdout] 32 + if let Ok(entry) = fs::read_dir(PathBuf::from(resource)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 119 | fs::copy(entry.path(), end_dir.clone()).with_context(|| format!("Failed to copy {:?} to {:?}", entry.path(), end_dir)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 119 | let _ = fs::copy(entry.path(), end_dir.clone()).with_context(|| format!("Failed to copy {:?} to {:?}", entry.path(), end_dir)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/tui/item_selection.rs:20:78 [INFO] [stdout] | [INFO] [stdout] 20 | result.push_str(&*format!("{}", format!("{}) {}", i + 1, items[i].clone()).bold())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/tui/item_selection.rs:22:64 [INFO] [stdout] | [INFO] [stdout] 22 | result.push_str(&*format!("{}) {}", i + 1, items[i].clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/utils/tui/item_selection.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 107 | let _ = io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/utils/tui/item_selection.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | io::stdout().execute(cursor::MoveUp(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 108 | let _ = io::stdout().execute(cursor::MoveUp(1)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:20:78 [INFO] [stdout] | [INFO] [stdout] 20 | result.push_str(&*format!("{}", format!("{}) {}", i + 1, items[i].clone()).bold())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:22:64 [INFO] [stdout] | [INFO] [stdout] 22 | result.push_str(&*format!("{}) {}", i + 1, items[i].clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 107 | let _ = io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | io::stdout().execute(cursor::MoveUp(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 108 | let _ = io::stdout().execute(cursor::MoveUp(1)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/verify_project.rs:90:18 [INFO] [stdout] | [INFO] [stdout] 90 | for entry in fs::read_dir("resources") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 90 - for entry in fs::read_dir("resources") { [INFO] [stdout] 90 + while let Ok(entry) = fs::read_dir("resources") { [INFO] [stdout] | [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 90 | for entry in fs::read_dir("resources")? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 90 - for entry in fs::read_dir("resources") { [INFO] [stdout] 90 + if let Ok(entry) = fs::read_dir("resources") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/verify_project.rs:100:26 [INFO] [stdout] | [INFO] [stdout] 100 | for entry in fs::read_dir(entry.path()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 100 - for entry in fs::read_dir(entry.path()) { [INFO] [stdout] 100 + while let Ok(entry) = fs::read_dir(entry.path()) { [INFO] [stdout] | [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 100 | for entry in fs::read_dir(entry.path())? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 100 - for entry in fs::read_dir(entry.path()) { [INFO] [stdout] 100 + if let Ok(entry) = fs::read_dir(entry.path()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/verify_project.rs:117:19 [INFO] [stdout] | [INFO] [stdout] 117 | fn basename(path: &str, sep: char) -> Cow { [INFO] [stdout] | ^^^^ -------- the lifetime gets resolved as `'_` [INFO] [stdout] | | [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 117 | fn basename(path: &str, sep: char) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:76:37 [INFO] [stdout] | [INFO] [stdout] 76 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQManifest` [INFO] [stdout] 77 | #[yaserde(rename = "manifest")] [INFO] [stdout] 78 | struct CIQManifest { [INFO] [stdout] | ----------- `CIQManifest` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:87:37 [INFO] [stdout] | [INFO] [stdout] 87 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQApplication` [INFO] [stdout] 88 | struct CIQApplication { [INFO] [stdout] | -------------- `CIQApplication` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:113:37 [INFO] [stdout] | [INFO] [stdout] 113 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQProducts` [INFO] [stdout] 114 | struct CIQProducts { [INFO] [stdout] | ----------- `CIQProducts` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:119:37 [INFO] [stdout] | [INFO] [stdout] 119 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQProduct` [INFO] [stdout] 120 | struct CIQProduct { [INFO] [stdout] | ---------- `CIQProduct` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:125:37 [INFO] [stdout] | [INFO] [stdout] 125 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQPermissions` [INFO] [stdout] 126 | struct CIQPermissions { [INFO] [stdout] | -------------- `CIQPermissions` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:132:37 [INFO] [stdout] | [INFO] [stdout] 132 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQPermission` [INFO] [stdout] 133 | struct CIQPermission { [INFO] [stdout] | ------------- `CIQPermission` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:138:37 [INFO] [stdout] | [INFO] [stdout] 138 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQLanguages` [INFO] [stdout] 139 | struct CIQLanguages { [INFO] [stdout] | ------------ `CIQLanguages` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:144:37 [INFO] [stdout] | [INFO] [stdout] 144 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQDependencies` [INFO] [stdout] 145 | struct CIQDependencies { [INFO] [stdout] | --------------- `CIQDependencies` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:149:37 [INFO] [stdout] | [INFO] [stdout] 149 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQDependency` [INFO] [stdout] 150 | struct CIQDependency { [INFO] [stdout] | ------------- `CIQDependency` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.91s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: quick-xml v0.20.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "c78d16e325c7c224fd21cd73e1272269f16932665a1e38b9c8d3bf7f97159b2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c78d16e325c7c224fd21cd73e1272269f16932665a1e38b9c8d3bf7f97159b2c", kill_on_drop: false }` [INFO] [stdout] c78d16e325c7c224fd21cd73e1272269f16932665a1e38b9c8d3bf7f97159b2c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+8de4c7234dd9b97c9d76b58671343fdbbc9a433e" "test" "--frozen" "--no-run" "--message-format=json" "--target" "x86_64-unknown-linux-musl", kill_on_drop: false }` [INFO] [stdout] 9acf4a623cc58ef9b3083031185e717f62edce2c7cb50b93c9cae41dc9c0d10f [INFO] running `Command { std: "docker" "start" "-a" "9acf4a623cc58ef9b3083031185e717f62edce2c7cb50b93c9cae41dc9c0d10f", kill_on_drop: false }` [INFO] [stderr] Compiling kumitateru v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `construct_selection` is never used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:8:4 [INFO] [stdout] | [INFO] [stdout] 8 | fn construct_selection(header: &str, items: Vec<&str>, highlighted: i64, selected: bool) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `display_cli_multiple_selection` is never used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn display_cli_multiple_selection(header: &str, items: Vec<&str>) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `reset_selection` is never used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:105:4 [INFO] [stdout] | [INFO] [stdout] 105 | fn reset_selection(len: i64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `package`, `package_meta`, and `build` are never read [INFO] [stdout] --> src/ser_de/config/barrel_config.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct BarrelConfig { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 6 | pub package: BarrelConfigPackage, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 7 | pub package_meta: BarrelConfigPackageMeta, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 8 | pub build: BarrelConfigBuild, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BarrelConfig` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `icon_resource`, `name_res`, `main_class`, `app_type`, and `min_sdk` are never read [INFO] [stdout] --> src/ser_de/config/barrel_config.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct BarrelConfigPackage { [INFO] [stdout] | ------------------- fields in this struct [INFO] [stdout] 14 | pub icon_resource: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 15 | pub name_res: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 16 | pub main_class: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 17 | pub app_type: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 18 | pub min_sdk: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BarrelConfigPackage` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/ser_de/config/barrel_config.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct BarrelConfigPackageMeta { [INFO] [stdout] | ----------------------- fields in this struct [INFO] [stdout] 24 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 25 | pub id: String, [INFO] [stdout] | ^^ [INFO] [stdout] 26 | pub version: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 27 | pub devices: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 28 | pub permissions: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 29 | pub annotations: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 30 | pub languages: Option>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BarrelConfigPackageMeta` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `signing_key`, `enable_code_analysis_on_build`, `connect_iq_version`, and `compiler_args` are never read [INFO] [stdout] --> src/ser_de/config/barrel_config.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct BarrelConfigBuild { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] 36 | pub signing_key: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 37 | pub enable_code_analysis_on_build: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 38 | pub connect_iq_version: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 39 | pub compiler_args: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BarrelConfigBuild` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:161:21 [INFO] [stdout] | [INFO] [stdout] 161 | io::stdin().read_line(&mut proj_name); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 161 | let _ = io::stdin().read_line(&mut proj_name); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:260:5 [INFO] [stdout] | [INFO] [stdout] 260 | io::stdin().read_line(&mut version); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 260 | let _ = io::stdin().read_line(&mut version); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | fs::create_dir("build"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 16 | let _ = fs::create_dir("build"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | fs::create_dir("build/tmp"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 17 | let _ = fs::create_dir("build/tmp"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | fs::create_dir("build/tmp/source"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 18 | let _ = fs::create_dir("build/tmp/source"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | fs::create_dir("build/tmp/resources"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 19 | let _ = fs::create_dir("build/tmp/resources"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/prepare_build.rs:32:22 [INFO] [stdout] | [INFO] [stdout] 32 | for entry in fs::read_dir(PathBuf::from(resource)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 32 - for entry in fs::read_dir(PathBuf::from(resource)) { [INFO] [stdout] 32 + while let Ok(entry) = fs::read_dir(PathBuf::from(resource)) { [INFO] [stdout] | [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 32 | for entry in fs::read_dir(PathBuf::from(resource))? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 32 - for entry in fs::read_dir(PathBuf::from(resource)) { [INFO] [stdout] 32 + if let Ok(entry) = fs::read_dir(PathBuf::from(resource)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/prepare_build.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 119 | fs::copy(entry.path(), end_dir.clone()).with_context(|| format!("Failed to copy {:?} to {:?}", entry.path(), end_dir)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 119 | let _ = fs::copy(entry.path(), end_dir.clone()).with_context(|| format!("Failed to copy {:?} to {:?}", entry.path(), end_dir)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/tui/item_selection.rs:20:78 [INFO] [stdout] | [INFO] [stdout] 20 | result.push_str(&*format!("{}", format!("{}) {}", i + 1, items[i].clone()).bold())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/tui/item_selection.rs:22:64 [INFO] [stdout] | [INFO] [stdout] 22 | result.push_str(&*format!("{}) {}", i + 1, items[i].clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/utils/tui/item_selection.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 107 | let _ = io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/utils/tui/item_selection.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | io::stdout().execute(cursor::MoveUp(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 108 | let _ = io::stdout().execute(cursor::MoveUp(1)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:20:78 [INFO] [stdout] | [INFO] [stdout] 20 | result.push_str(&*format!("{}", format!("{}) {}", i + 1, items[i].clone()).bold())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:22:64 [INFO] [stdout] | [INFO] [stdout] 22 | result.push_str(&*format!("{}) {}", i + 1, items[i].clone())); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 107 | let _ = io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/utils/tui/multiple_selection.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | io::stdout().execute(cursor::MoveUp(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 108 | let _ = io::stdout().execute(cursor::MoveUp(1)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/verify_project.rs:90:18 [INFO] [stdout] | [INFO] [stdout] 90 | for entry in fs::read_dir("resources") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 90 - for entry in fs::read_dir("resources") { [INFO] [stdout] 90 + while let Ok(entry) = fs::read_dir("resources") { [INFO] [stdout] | [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 90 | for entry in fs::read_dir("resources")? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 90 - for entry in fs::read_dir("resources") { [INFO] [stdout] 90 + if let Ok(entry) = fs::read_dir("resources") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/verify_project.rs:100:26 [INFO] [stdout] | [INFO] [stdout] 100 | for entry in fs::read_dir(entry.path()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 100 - for entry in fs::read_dir(entry.path()) { [INFO] [stdout] 100 + while let Ok(entry) = fs::read_dir(entry.path()) { [INFO] [stdout] | [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 100 | for entry in fs::read_dir(entry.path())? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 100 - for entry in fs::read_dir(entry.path()) { [INFO] [stdout] 100 + if let Ok(entry) = fs::read_dir(entry.path()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stdout] --> src/verify_project.rs:117:19 [INFO] [stdout] | [INFO] [stdout] 117 | fn basename(path: &str, sep: char) -> Cow { [INFO] [stdout] | ^^^^ -------- the lifetime gets resolved as `'_` [INFO] [stdout] | | [INFO] [stdout] | this lifetime flows to the output [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stdout] | [INFO] [stdout] 117 | fn basename(path: &str, sep: char) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:76:37 [INFO] [stdout] | [INFO] [stdout] 76 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQManifest` [INFO] [stdout] 77 | #[yaserde(rename = "manifest")] [INFO] [stdout] 78 | struct CIQManifest { [INFO] [stdout] | ----------- `CIQManifest` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:87:37 [INFO] [stdout] | [INFO] [stdout] 87 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQApplication` [INFO] [stdout] 88 | struct CIQApplication { [INFO] [stdout] | -------------- `CIQApplication` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:113:37 [INFO] [stdout] | [INFO] [stdout] 113 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQProducts` [INFO] [stdout] 114 | struct CIQProducts { [INFO] [stdout] | ----------- `CIQProducts` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:119:37 [INFO] [stdout] | [INFO] [stdout] 119 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQProduct` [INFO] [stdout] 120 | struct CIQProduct { [INFO] [stdout] | ---------- `CIQProduct` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:125:37 [INFO] [stdout] | [INFO] [stdout] 125 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQPermissions` [INFO] [stdout] 126 | struct CIQPermissions { [INFO] [stdout] | -------------- `CIQPermissions` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:132:37 [INFO] [stdout] | [INFO] [stdout] 132 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQPermission` [INFO] [stdout] 133 | struct CIQPermission { [INFO] [stdout] | ------------- `CIQPermission` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:138:37 [INFO] [stdout] | [INFO] [stdout] 138 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQLanguages` [INFO] [stdout] 139 | struct CIQLanguages { [INFO] [stdout] | ------------ `CIQLanguages` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:144:37 [INFO] [stdout] | [INFO] [stdout] 144 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQDependencies` [INFO] [stdout] 145 | struct CIQDependencies { [INFO] [stdout] | --------------- `CIQDependencies` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/ser_de/manifest/manifest_utils.rs:149:37 [INFO] [stdout] | [INFO] [stdout] 149 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `YaSerialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQDependency` [INFO] [stdout] 150 | struct CIQDependency { [INFO] [stdout] | ------------- `CIQDependency` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 1.28s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: quick-xml v0.20.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "9acf4a623cc58ef9b3083031185e717f62edce2c7cb50b93c9cae41dc9c0d10f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9acf4a623cc58ef9b3083031185e717f62edce2c7cb50b93c9cae41dc9c0d10f", kill_on_drop: false }` [INFO] [stdout] 9acf4a623cc58ef9b3083031185e717f62edce2c7cb50b93c9cae41dc9c0d10f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:90999bfc7ae267e83380e433d8e61a7c072ca6729e92edbae886d3423b3a6f4c" "/opt/rustwide/cargo-home/bin/cargo" "+8de4c7234dd9b97c9d76b58671343fdbbc9a433e" "test" "--frozen" "--target" "x86_64-unknown-linux-musl", kill_on_drop: false }` [INFO] [stdout] 5bd95ea09d2baff4e3c0636107785794f192e835355a6a2415dd0a14faa96bc6 [INFO] running `Command { std: "docker" "start" "-a" "5bd95ea09d2baff4e3c0636107785794f192e835355a6a2415dd0a14faa96bc6", kill_on_drop: false }` [INFO] [stderr] warning: function `construct_selection` is never used [INFO] [stderr] --> src/utils/tui/multiple_selection.rs:8:4 [INFO] [stderr] | [INFO] [stderr] 8 | fn construct_selection(header: &str, items: Vec<&str>, highlighted: i64, selected: bool) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: function `display_cli_multiple_selection` is never used [INFO] [stderr] --> src/utils/tui/multiple_selection.rs:41:8 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn display_cli_multiple_selection(header: &str, items: Vec<&str>) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function `reset_selection` is never used [INFO] [stderr] --> src/utils/tui/multiple_selection.rs:105:4 [INFO] [stderr] | [INFO] [stderr] 105 | fn reset_selection(len: i64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: fields `package`, `package_meta`, and `build` are never read [INFO] [stderr] --> src/ser_de/config/barrel_config.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 5 | pub struct BarrelConfig { [INFO] [stderr] | ------------ fields in this struct [INFO] [stderr] 6 | pub package: BarrelConfigPackage, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] 7 | pub package_meta: BarrelConfigPackageMeta, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] 8 | pub build: BarrelConfigBuild, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `BarrelConfig` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stderr] [INFO] [stderr] warning: fields `icon_resource`, `name_res`, `main_class`, `app_type`, and `min_sdk` are never read [INFO] [stderr] --> src/ser_de/config/barrel_config.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 13 | pub struct BarrelConfigPackage { [INFO] [stderr] | ------------------- fields in this struct [INFO] [stderr] 14 | pub icon_resource: String, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] 15 | pub name_res: String, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] 16 | pub main_class: String, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] 17 | pub app_type: String, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] 18 | pub min_sdk: String, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `BarrelConfigPackage` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stderr] [INFO] [stderr] warning: multiple fields are never read [INFO] [stderr] --> src/ser_de/config/barrel_config.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 23 | pub struct BarrelConfigPackageMeta { [INFO] [stderr] | ----------------------- fields in this struct [INFO] [stderr] 24 | pub name: String, [INFO] [stderr] | ^^^^ [INFO] [stderr] 25 | pub id: String, [INFO] [stderr] | ^^ [INFO] [stderr] 26 | pub version: String, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] 27 | pub devices: Vec, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] 28 | pub permissions: Vec, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] 29 | pub annotations: Vec, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] 30 | pub languages: Option>, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `BarrelConfigPackageMeta` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stderr] [INFO] [stderr] warning: fields `signing_key`, `enable_code_analysis_on_build`, `connect_iq_version`, and `compiler_args` are never read [INFO] [stderr] --> src/ser_de/config/barrel_config.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 35 | pub struct BarrelConfigBuild { [INFO] [stderr] | ----------------- fields in this struct [INFO] [stderr] 36 | pub signing_key: String, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] 37 | pub enable_code_analysis_on_build: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 38 | pub connect_iq_version: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 39 | pub compiler_args: String, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `BarrelConfigBuild` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/main.rs:161:21 [INFO] [stderr] | [INFO] [stderr] 161 | io::stdin().read_line(&mut proj_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] help: use `let _ = ...` to ignore the resulting value [INFO] [stderr] | [INFO] [stderr] 161 | let _ = io::stdin().read_line(&mut proj_name); [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/main.rs:260:5 [INFO] [stderr] | [INFO] [stderr] 260 | io::stdin().read_line(&mut version); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] help: use `let _ = ...` to ignore the resulting value [INFO] [stderr] | [INFO] [stderr] 260 | let _ = io::stdin().read_line(&mut version); [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/prepare_build.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | fs::create_dir("build"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] help: use `let _ = ...` to ignore the resulting value [INFO] [stderr] | [INFO] [stderr] 16 | let _ = fs::create_dir("build"); [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/prepare_build.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | fs::create_dir("build/tmp"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] help: use `let _ = ...` to ignore the resulting value [INFO] [stderr] | [INFO] [stderr] 17 | let _ = fs::create_dir("build/tmp"); [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/prepare_build.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | fs::create_dir("build/tmp/source"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] help: use `let _ = ...` to ignore the resulting value [INFO] [stderr] | [INFO] [stderr] 18 | let _ = fs::create_dir("build/tmp/source"); [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/prepare_build.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | fs::create_dir("build/tmp/resources"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] help: use `let _ = ...` to ignore the resulting value [INFO] [stderr] | [INFO] [stderr] 19 | let _ = fs::create_dir("build/tmp/resources"); [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stderr] --> src/prepare_build.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | for entry in fs::read_dir(PathBuf::from(resource)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stderr] help: to check pattern in a loop use `while let` [INFO] [stderr] | [INFO] [stderr] 32 - for entry in fs::read_dir(PathBuf::from(resource)) { [INFO] [stderr] 32 + while let Ok(entry) = fs::read_dir(PathBuf::from(resource)) { [INFO] [stderr] | [INFO] [stderr] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stderr] | [INFO] [stderr] 32 | for entry in fs::read_dir(PathBuf::from(resource))? { [INFO] [stderr] | + [INFO] [stderr] help: consider using `if let` to clear intent [INFO] [stderr] | [INFO] [stderr] 32 - for entry in fs::read_dir(PathBuf::from(resource)) { [INFO] [stderr] 32 + if let Ok(entry) = fs::read_dir(PathBuf::from(resource)) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/prepare_build.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | fs::copy(entry.path(), end_dir.clone()).with_context(|| format!("Failed to copy {:?} to {:?}", entry.path(), end_dir)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] help: use `let _ = ...` to ignore the resulting value [INFO] [stderr] | [INFO] [stderr] 119 | let _ = fs::copy(entry.path(), end_dir.clone()).with_context(|| format!("Failed to copy {:?} to {:?}", entry.path(), end_dir)); [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stderr] --> src/utils/tui/item_selection.rs:20:78 [INFO] [stderr] | [INFO] [stderr] 20 | result.push_str(&*format!("{}", format!("{}) {}", i + 1, items[i].clone()).bold())); [INFO] [stderr] | ^^^^^^^^ help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stderr] = note: `#[warn(noop_method_call)]` on by default [INFO] [stderr] [INFO] [stderr] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stderr] --> src/utils/tui/item_selection.rs:22:64 [INFO] [stderr] | [INFO] [stderr] 22 | result.push_str(&*format!("{}) {}", i + 1, items[i].clone())); [INFO] [stderr] | ^^^^^^^^ help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/utils/tui/item_selection.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] help: use `let _ = ...` to ignore the resulting value [INFO] [stderr] | [INFO] [stderr] 107 | let _ = io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/utils/tui/item_selection.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | io::stdout().execute(cursor::MoveUp(1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] help: use `let _ = ...` to ignore the resulting value [INFO] [stderr] | [INFO] [stderr] 108 | let _ = io::stdout().execute(cursor::MoveUp(1)); [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stderr] --> src/utils/tui/multiple_selection.rs:20:78 [INFO] [stderr] | [INFO] [stderr] 20 | result.push_str(&*format!("{}", format!("{}) {}", i + 1, items[i].clone()).bold())); [INFO] [stderr] | ^^^^^^^^ help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stderr] [INFO] [stderr] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stderr] --> src/utils/tui/multiple_selection.rs:22:64 [INFO] [stderr] | [INFO] [stderr] 22 | result.push_str(&*format!("{}) {}", i + 1, items[i].clone())); [INFO] [stderr] | ^^^^^^^^ help: remove this redundant call [INFO] [stderr] | [INFO] [stderr] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/utils/tui/multiple_selection.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] help: use `let _ = ...` to ignore the resulting value [INFO] [stderr] | [INFO] [stderr] 107 | let _ = io::stdout().execute(terminal::Clear(terminal::ClearType::CurrentLine)); [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/utils/tui/multiple_selection.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | io::stdout().execute(cursor::MoveUp(1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] help: use `let _ = ...` to ignore the resulting value [INFO] [stderr] | [INFO] [stderr] 108 | let _ = io::stdout().execute(cursor::MoveUp(1)); [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stderr] --> src/verify_project.rs:90:18 [INFO] [stderr] | [INFO] [stderr] 90 | for entry in fs::read_dir("resources") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: to check pattern in a loop use `while let` [INFO] [stderr] | [INFO] [stderr] 90 - for entry in fs::read_dir("resources") { [INFO] [stderr] 90 + while let Ok(entry) = fs::read_dir("resources") { [INFO] [stderr] | [INFO] [stderr] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stderr] | [INFO] [stderr] 90 | for entry in fs::read_dir("resources")? { [INFO] [stderr] | + [INFO] [stderr] help: consider using `if let` to clear intent [INFO] [stderr] | [INFO] [stderr] 90 - for entry in fs::read_dir("resources") { [INFO] [stderr] 90 + if let Ok(entry) = fs::read_dir("resources") { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stderr] --> src/verify_project.rs:100:26 [INFO] [stderr] | [INFO] [stderr] 100 | for entry in fs::read_dir(entry.path()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: to check pattern in a loop use `while let` [INFO] [stderr] | [INFO] [stderr] 100 - for entry in fs::read_dir(entry.path()) { [INFO] [stderr] 100 + while let Ok(entry) = fs::read_dir(entry.path()) { [INFO] [stderr] | [INFO] [stderr] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stderr] | [INFO] [stderr] 100 | for entry in fs::read_dir(entry.path())? { [INFO] [stderr] | + [INFO] [stderr] help: consider using `if let` to clear intent [INFO] [stderr] | [INFO] [stderr] 100 - for entry in fs::read_dir(entry.path()) { [INFO] [stderr] 100 + if let Ok(entry) = fs::read_dir(entry.path()) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: lifetime flowing from input to output with different syntax can be confusing [INFO] [stderr] --> src/verify_project.rs:117:19 [INFO] [stderr] | [INFO] [stderr] 117 | fn basename(path: &str, sep: char) -> Cow { [INFO] [stderr] | ^^^^ -------- the lifetime gets resolved as `'_` [INFO] [stderr] | | [INFO] [stderr] | this lifetime flows to the output [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stderr] help: one option is to remove the lifetime for references and use the anonymous lifetime for paths [INFO] [stderr] | [INFO] [stderr] 117 | fn basename(path: &str, sep: char) -> Cow<'_, str> { [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stderr] --> src/ser_de/manifest/manifest_utils.rs:76:37 [INFO] [stderr] | [INFO] [stderr] 76 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stderr] | ^---------- [INFO] [stderr] | | [INFO] [stderr] | `YaSerialize` is not local [INFO] [stderr] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQManifest` [INFO] [stderr] 77 | #[yaserde(rename = "manifest")] [INFO] [stderr] 78 | struct CIQManifest { [INFO] [stderr] | ----------- `CIQManifest` is not local [INFO] [stderr] | [INFO] [stderr] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stderr] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stderr] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stderr] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stderr] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stderr] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stderr] --> src/ser_de/manifest/manifest_utils.rs:87:37 [INFO] [stderr] | [INFO] [stderr] 87 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stderr] | ^---------- [INFO] [stderr] | | [INFO] [stderr] | `YaSerialize` is not local [INFO] [stderr] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQApplication` [INFO] [stderr] 88 | struct CIQApplication { [INFO] [stderr] | -------------- `CIQApplication` is not local [INFO] [stderr] | [INFO] [stderr] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stderr] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stderr] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stderr] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stderr] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stderr] --> src/ser_de/manifest/manifest_utils.rs:113:37 [INFO] [stderr] | [INFO] [stderr] 113 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stderr] | ^---------- [INFO] [stderr] | | [INFO] [stderr] | `YaSerialize` is not local [INFO] [stderr] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQProducts` [INFO] [stderr] 114 | struct CIQProducts { [INFO] [stderr] | ----------- `CIQProducts` is not local [INFO] [stderr] | [INFO] [stderr] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stderr] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stderr] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stderr] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stderr] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stderr] --> src/ser_de/manifest/manifest_utils.rs:119:37 [INFO] [stderr] | [INFO] [stderr] 119 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stderr] | ^---------- [INFO] [stderr] | | [INFO] [stderr] | `YaSerialize` is not local [INFO] [stderr] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQProduct` [INFO] [stderr] 120 | struct CIQProduct { [INFO] [stderr] | ---------- `CIQProduct` is not local [INFO] [stderr] | [INFO] [stderr] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stderr] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stderr] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stderr] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stderr] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stderr] --> src/ser_de/manifest/manifest_utils.rs:125:37 [INFO] [stderr] | [INFO] [stderr] 125 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stderr] | ^---------- [INFO] [stderr] | | [INFO] [stderr] | `YaSerialize` is not local [INFO] [stderr] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQPermissions` [INFO] [stderr] 126 | struct CIQPermissions { [INFO] [stderr] | -------------- `CIQPermissions` is not local [INFO] [stderr] | [INFO] [stderr] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stderr] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stderr] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stderr] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stderr] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stderr] --> src/ser_de/manifest/manifest_utils.rs:132:37 [INFO] [stderr] | [INFO] [stderr] 132 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stderr] | ^---------- [INFO] [stderr] | | [INFO] [stderr] | `YaSerialize` is not local [INFO] [stderr] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQPermission` [INFO] [stderr] 133 | struct CIQPermission { [INFO] [stderr] | ------------- `CIQPermission` is not local [INFO] [stderr] | [INFO] [stderr] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stderr] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stderr] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stderr] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stderr] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stderr] --> src/ser_de/manifest/manifest_utils.rs:138:37 [INFO] [stderr] | [INFO] [stderr] 138 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stderr] | ^---------- [INFO] [stderr] | | [INFO] [stderr] | `YaSerialize` is not local [INFO] [stderr] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQLanguages` [INFO] [stderr] 139 | struct CIQLanguages { [INFO] [stderr] | ------------ `CIQLanguages` is not local [INFO] [stderr] | [INFO] [stderr] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stderr] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stderr] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stderr] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stderr] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stderr] --> src/ser_de/manifest/manifest_utils.rs:144:37 [INFO] [stderr] | [INFO] [stderr] 144 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stderr] | ^---------- [INFO] [stderr] | | [INFO] [stderr] | `YaSerialize` is not local [INFO] [stderr] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQDependencies` [INFO] [stderr] 145 | struct CIQDependencies { [INFO] [stderr] | --------------- `CIQDependencies` is not local [INFO] [stderr] | [INFO] [stderr] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stderr] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stderr] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stderr] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stderr] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stderr] --> src/ser_de/manifest/manifest_utils.rs:149:37 [INFO] [stderr] | [INFO] [stderr] 149 | #[derive(Default, PartialEq, Debug, YaSerialize)] [INFO] [stderr] | ^---------- [INFO] [stderr] | | [INFO] [stderr] | `YaSerialize` is not local [INFO] [stderr] | move the `impl` block outside of this constant `_IMPL_YA_SERIALIZE_FOR_CIQDependency` [INFO] [stderr] 150 | struct CIQDependency { [INFO] [stderr] | ------------- `CIQDependency` is not local [INFO] [stderr] | [INFO] [stderr] = note: the derive macro `YaSerialize` defines the non-local `impl`, and may need to be changed [INFO] [stderr] = note: the derive macro `YaSerialize` may come from an old version of the `yaserde_derive` crate, try updating your dependency with `cargo update -p yaserde_derive` [INFO] [stderr] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stderr] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stderr] = note: this warning originates in the derive macro `YaSerialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `kumitateru` (bin "kumitateru" test) generated 35 warnings (run `cargo fix --bin "kumitateru" --tests` to apply 5 suggestions) [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.20s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: quick-xml v0.20.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] [stderr] Running unittests src/main.rs (/opt/rustwide/target/x86_64-unknown-linux-musl/debug/deps/kumitateru-923ea9177bf3c014) [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "5bd95ea09d2baff4e3c0636107785794f192e835355a6a2415dd0a14faa96bc6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5bd95ea09d2baff4e3c0636107785794f192e835355a6a2415dd0a14faa96bc6", kill_on_drop: false }` [INFO] [stdout] 5bd95ea09d2baff4e3c0636107785794f192e835355a6a2415dd0a14faa96bc6