[INFO] fetching crate same-file 1.0.6... [INFO] checking same-file-1.0.6 against master#1f12b9b0fdbe735968ac002792a720f0ba4faca6 for crater-rollup-uwu [INFO] extracting crate same-file 1.0.6 into /workspace/builds/worker-6-tc1/source [INFO] validating manifest of crates.io crate same-file 1.0.6 on toolchain 1f12b9b0fdbe735968ac002792a720f0ba4faca6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate same-file 1.0.6 [INFO] finished tweaking crates.io crate same-file 1.0.6 [INFO] tweaked toml for crates.io crate same-file 1.0.6 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate crates.io crate same-file 1.0.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded doc-comment v0.3.1 [INFO] [stderr] Downloaded winapi-util v0.1.1 [INFO] [stderr] Downloaded winapi-x86_64-pc-windows-gnu v0.3.2 [INFO] [stderr] Downloaded winapi v0.3.2 [INFO] [stderr] Downloaded winapi-i686-pc-windows-gnu v0.3.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b15b34bb665e1704dfd255748463d8774c5035f35ef8ade4b117870e52b9e3ba [INFO] running `Command { std: "docker" "start" "-a" "b15b34bb665e1704dfd255748463d8774c5035f35ef8ade4b117870e52b9e3ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b15b34bb665e1704dfd255748463d8774c5035f35ef8ade4b117870e52b9e3ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b15b34bb665e1704dfd255748463d8774c5035f35ef8ade4b117870e52b9e3ba", kill_on_drop: false }` [INFO] [stdout] b15b34bb665e1704dfd255748463d8774c5035f35ef8ade4b117870e52b9e3ba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+1f12b9b0fdbe735968ac002792a720f0ba4faca6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eae63c54f09d183b2f64a303ca97a4dec1fe7a50759a3270b8c5238705733da9 [INFO] running `Command { std: "docker" "start" "-a" "eae63c54f09d183b2f64a303ca97a4dec1fe7a50759a3270b8c5238705733da9", kill_on_drop: false }` [INFO] [stderr] Compiling doc-comment v0.3.1 [INFO] [stderr] Checking same-file v1.0.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> src/unix.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | self.file.take().unwrap().into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 23 | let _ = self.file.take().unwrap().into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> src/unix.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | self.file.take().unwrap().into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 23 | let _ = self.file.take().unwrap().into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.25s [INFO] running `Command { std: "docker" "inspect" "eae63c54f09d183b2f64a303ca97a4dec1fe7a50759a3270b8c5238705733da9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eae63c54f09d183b2f64a303ca97a4dec1fe7a50759a3270b8c5238705733da9", kill_on_drop: false }` [INFO] [stdout] eae63c54f09d183b2f64a303ca97a4dec1fe7a50759a3270b8c5238705733da9 [INFO] checking same-file-1.0.6 against try#f9935d29d867449445ee008640ccca1bf1ae0889+rustflags=-Dtail_expr_drop_order for crater-rollup-uwu [INFO] extracting crate same-file 1.0.6 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate same-file 1.0.6 on toolchain f9935d29d867449445ee008640ccca1bf1ae0889 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate same-file 1.0.6 [INFO] finished tweaking crates.io crate same-file 1.0.6 [INFO] tweaked toml for crates.io crate same-file 1.0.6 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate same-file 1.0.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e111830b1ef77296bb66d0f5cb4581681e475673a33d87b3d91df53f68a20098 [INFO] running `Command { std: "docker" "start" "-a" "e111830b1ef77296bb66d0f5cb4581681e475673a33d87b3d91df53f68a20098", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e111830b1ef77296bb66d0f5cb4581681e475673a33d87b3d91df53f68a20098", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e111830b1ef77296bb66d0f5cb4581681e475673a33d87b3d91df53f68a20098", kill_on_drop: false }` [INFO] [stdout] e111830b1ef77296bb66d0f5cb4581681e475673a33d87b3d91df53f68a20098 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f9935d29d867449445ee008640ccca1bf1ae0889" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b747d75a6acfdf038732dabe9cb75058fccd1186bcd1c0582cb544d0115e2b4a [INFO] running `Command { std: "docker" "start" "-a" "b747d75a6acfdf038732dabe9cb75058fccd1186bcd1c0582cb544d0115e2b4a", kill_on_drop: false }` [INFO] [stderr] Compiling doc-comment v0.3.1 [INFO] [stderr] Checking same-file v1.0.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn from_path>(p: P) -> io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | imp::Handle::from_path(p).map(Handle) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:183:9 [INFO] [stdout] | [INFO] [stdout] 182 | pub fn from_file(file: File) -> io::Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | imp::Handle::from_file(file).map(Handle) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:375:8 [INFO] [stdout] | [INFO] [stdout] 370 | pub fn is_same_file(path1: P, path2: Q) -> io::Result [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 375 | Ok(Handle::from_path(path1)? == Handle::from_path(path2)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:375:37 [INFO] [stdout] | [INFO] [stdout] 370 | pub fn is_same_file(path1: P, path2: Q) -> io::Result [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 375 | Ok(Handle::from_path(path1)? == Handle::from_path(path2)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> src/unix.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | self.file.take().unwrap().into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 23 | let _ = self.file.take().unwrap().into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 45 | fn into_raw_fd(mut self) -> RawFd { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | self.0.file.take().unwrap().into_raw_fd() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix.rs:61:27 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn from_path>(p: P) -> io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Handle::from_file(OpenOptions::new().read(true).open(p)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn from_file(file: File) -> io::Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let md = file.metadata()?; [INFO] [stdout] 66 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | file: Some(file), [INFO] [stdout] 68 | | is_std: false, [INFO] [stdout] 69 | | dev: md.dev(), [INFO] [stdout] 70 | | ino: md.ino(), [INFO] [stdout] 71 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn from_std(file: File) -> io::Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | Handle::from_file(file).map(|mut h| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `same-file` (lib) due to 9 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "b747d75a6acfdf038732dabe9cb75058fccd1186bcd1c0582cb544d0115e2b4a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b747d75a6acfdf038732dabe9cb75058fccd1186bcd1c0582cb544d0115e2b4a", kill_on_drop: false }` [INFO] [stdout] b747d75a6acfdf038732dabe9cb75058fccd1186bcd1c0582cb544d0115e2b4a